@kud/gh-ink 0.23.2 → 0.24.0

package/dist/index.d.ts

@@ -199,8 +199,8 @@ declare const sortItems: (items: GHItem[]) => GHItem[];
 declare const sortByRecency: (items: GHItem[]) => GHItem[];
 declare const insertRepoHeaders: (items: GHItem[]) => AnyItem[];
 type Standing = "authored" | "queued" | "spoken";
-declare const whoseMove: (health: Health, sectionId: string, standing?: Standing) => "you" | "them";
-declare const layoutGHItems: (items: GHItem[], sectionId: string) => AnyItem[];
+declare const whoseMove: (health: Health, sectionId: string, standing?: Standing, theySpokeLast?: boolean) => "you" | "them";
+declare const layoutGHItems: (items: GHItem[], sectionId: string, login?: string) => AnyItem[];
 /**
  * A two-way repo split, when a host has one. `undefined` — the ordinary case —
  * means no split at all: every row stands.
@@ -238,6 +238,20 @@ declare const filterByRepos: (sections: Section[], repos: Set<string>) => Sectio
 declare const withoutItem: (sections: Section[], target: GHItem) => Section[];
 declare const reposInSections: (sections: Section[]) => string[];
 declare const moveCursor: (items: AnyItem[], current: number, dir: 1 | -1) => number;
+/**
+ * Whether this row draws a blank line above it.
+ *
+ * ONE definition, because two readers need the same answer: the renderer draws
+ * the gap, and fitCount pays for it out of the window budget. They disagreed
+ * until 2026-08-27 — fitCount priced only headers at two lines while the
+ * renderer ALSO gapped a task row following a header — so a tab with that shape
+ * drew one line more than the window had bought. The frame is sized to fill the
+ * terminal exactly, so the overflow scrolls the whole panel instead of clipping.
+ *
+ * Index-based rather than item-based: whether a row gaps depends on what sits
+ * above it, which an item alone cannot answer.
+ */
+declare const gapsAbove: (items: readonly AnyItem[], i: number) => boolean;
 declare const fitCount: (items: AnyItem[], start: number, budget: number) => number;
 declare const windowCount: (items: AnyItem[], start: number, budget: number) => number;
 declare const maxViewStart: (items: AnyItem[], budget: number) => number;
@@ -282,21 +296,6 @@ declare const CiStatusLine: ({ state, job, }: {
     state: CiStatusState;
     job?: string;
 }) => React.JSX.Element;
-/**
- * Indexes of task rows whose row has already appeared higher up the same list.
- *
- * A ticket with one PR needing you and another in review lands in two bands,
- * which is right — the band reads each PR, not the ticket. What was wrong was
- * drawing the second occurrence identically to the first, so one ticket read as
- * two. The repeat keeps its key and drops its summary.
- *
- * Identity is the URL, never `key`. `key` is a LABEL, and on a task surface that
- * is not a tracker (`life`, whose keys are categories like "Flat") one label
- * legitimately heads several unrelated rows — keying on it hid the summary of
- * every row but the first. A row with no url is never a repeat, because nothing
- * identifies it.
- */
-declare const repeatedTaskRows: (items: readonly AnyItem[]) => Set<number>;
 declare const useActionMenu: () => {
     actions: Action[] | null;
     cursor: number;
@@ -444,4 +443,4 @@ declare const matchesFilter: (repo: string, filter: RepoFilter) => boolean;
  */
 declare const parsePatterns: (value: string) => string[];
 
-export { type Action, ActionMenu, type AnyItem, App, COLS, type CiStatus, CiStatusLine, type CiStatusState, CommentsPanel, type CommentsPanelProps, type DetailContext, type ExplainSection, type ExtensionTarget, type GHDetail, type GHItem, HealthPanel, type HealthPanelProps, type InboxConfig, type InboxExtension, type JiraTransition, type OriginSplit, type RepoFilter, type RepoHeader, type RepoProfile, type Section, type ShowLess, type ShowMore, type Standing, type SubgroupHeader, type TaskRow, buildActions, buildCheckoutCmd, checkoutDirs, clipboard, configureInbox, drillCmd, explainItem, filterByOrigin, filterByRepos, filterBySearch, fitCount, healthColor, healthDisplay, healthGlyph, healthLegend, inboxConfig, insertRepoHeaders, itermRun, jumpToRepo, jumpToRepoPane, layoutGHItems, matchesFilter, maxViewStart, moveCursor, openInTab, parsePatterns, profileOf, readCache, relativeTime, renderMarkdown, repeatedTaskRows, repoPriority, reposInSections, resetInboxConfig, resolveRepoPath, runHere, runInPane, runInPaneHorizontal, sameCiStatusState, signatureOf, sortByRecency, sortItems, toCiStatusState, topLevelCount, truncate, useActionMenu, whoseMove, windowCount, withHeaders, withoutItem, writeCache };
+export { type Action, ActionMenu, type AnyItem, App, COLS, type CiStatus, CiStatusLine, type CiStatusState, CommentsPanel, type CommentsPanelProps, type DetailContext, type ExplainSection, type ExtensionTarget, type GHDetail, type GHItem, HealthPanel, type HealthPanelProps, type InboxConfig, type InboxExtension, type JiraTransition, type OriginSplit, type RepoFilter, type RepoHeader, type RepoProfile, type Section, type ShowLess, type ShowMore, type Standing, type SubgroupHeader, type TaskRow, buildActions, buildCheckoutCmd, checkoutDirs, clipboard, configureInbox, drillCmd, explainItem, filterByOrigin, filterByRepos, filterBySearch, fitCount, gapsAbove, healthColor, healthDisplay, healthGlyph, healthLegend, inboxConfig, insertRepoHeaders, itermRun, jumpToRepo, jumpToRepoPane, layoutGHItems, matchesFilter, maxViewStart, moveCursor, openInTab, parsePatterns, profileOf, readCache, relativeTime, renderMarkdown, repoPriority, reposInSections, resetInboxConfig, resolveRepoPath, runHere, runInPane, runInPaneHorizontal, sameCiStatusState, signatureOf, sortByRecency, sortItems, toCiStatusState, topLevelCount, truncate, useActionMenu, whoseMove, windowCount, withHeaders, withoutItem, writeCache };

package/dist/index.js

@@ -919,18 +919,38 @@ var YOURS = {
   queued: ["waiting", "pending", "threads", "approved"],
   spoken: ["threads"]
 };
-var whoseMove = (health, sectionId, standing) => YOURS[standing ?? STANDING[sectionId] ?? "queued"].includes(health) ? "you" : "them";
+var whoseMove = (health, sectionId, standing, theySpokeLast) => (
+  // Somebody else having the last word outranks every review state below. It is
+  // the plainest claim on you there is — a question asked, an objection raised,
+  // a "can you rebase" — and none of it shows up as a health, because a bare
+  // comment approves nothing, fails nothing and opens no thread.
+  //
+  // The row already SAID this and the band disagreed with it: the turn arrow
+  // reads lastActor and drew `←`, and the explain panel spelled out "X spoke
+  // last, your reply is owed", while the band filed it under Their move. Two
+  // signals on one row, pointing opposite ways, until 2026-08-27.
+  //
+  // Only in that direction. YOU having spoken last does not hand the row over —
+  // red CI on your own PR is yours whether or not you commented after it — so
+  // that case falls through to the table.
+  theySpokeLast ? "you" : YOURS[standing ?? STANDING[sectionId] ?? "queued"].includes(health) ? "you" : "them"
+);
 var BAND_LABEL = {
   you: "Your move",
   them: "Their move"
 };
-var layoutGHItems = (items, sectionId) => {
+var layoutGHItems = (items, sectionId, login) => {
   if (sectionId === "done") return insertRepoHeaders(sortByRecency(items));
   const sorted = sortItems(items);
   const bands = ["you", "them"].map((side) => ({
     side,
     rows: sorted.filter(
-      (i) => whoseMove(i.health, sectionId, i.standing) === side
+      (i) => whoseMove(
+        i.health,
+        sectionId,
+        i.standing,
+        !!login && !!i.lastActor && i.lastActor !== login
+      ) === side
     )
   }));
   const filled = bands.filter((b) => b.rows.length > 0);
@@ -1028,12 +1048,17 @@ var moveCursor = (items, current2, dir) => {
   if (next < 0 || next >= items.length) return current2;
   return next;
 };
-var itemLines = (item, isFirst) => (item.kind === "repo-header" || item.kind === "subgroup-header") && !isFirst ? 2 : 1;
+var gapsAbove = (items, i) => {
+  const item = items[i];
+  if (!item || i === 0) return false;
+  if (item.kind === "repo-header" || item.kind === "subgroup-header") return true;
+  return item.kind === "task";
+};
 var fitCount = (items, start, budget) => {
   let lines = 0;
   let count = 0;
   for (let i = start; i < items.length; i++) {
-    const cost = itemLines(items[i], i === start);
+    const cost = i !== start && gapsAbove(items, i) ? 2 : 1;
     if (lines + cost > budget) break;
     lines += cost;
     count++;
@@ -1685,16 +1710,6 @@ var TRANSIT_LABEL = {
 };
 var TAB_MARK = "\u25CF";
 var tabLabel = (label, marked, id) => marked.size === 0 ? label : `${marked.has(id) ? TAB_MARK : " "} ${label}`;
-var repeatedTaskRows = (items) => {
-  const seen = /* @__PURE__ */ new Set();
-  const repeats = /* @__PURE__ */ new Set();
-  items.forEach((row, i) => {
-    if (row.kind !== "task" || !row.url) return;
-    if (seen.has(row.url)) repeats.add(i);
-    else seen.add(row.url);
-  });
-  return repeats;
-};
 var isChildRow = (item) => !!item && (item.kind === "show-more" || item.kind === "show-less" || "indent" in item && item.indent === true);
 var ItemRow = ({
   item,
@@ -1705,7 +1720,6 @@ var ItemRow = ({
   transient,
   lastChild,
   parent,
-  repeat,
   sparkFrame = 0
 }) => {
   if (item.kind === "repo-header")
@@ -1741,8 +1755,8 @@ var ItemRow = ({
       /* @__PURE__ */ jsx(Text2, { color: "cyan", children: active ? "\u276F " : "  " }),
       /* @__PURE__ */ jsx(Text2, { dimColor: true, children: parent ? "\u252C " : "  " }),
       /* @__PURE__ */ jsx(Text2, { bold: true, color: transient ? TRANSIT_COLOUR[transient] : void 0, children: transitIcon + " " }),
-      /* @__PURE__ */ jsx(Text2, { color: repeat ? void 0 : "#FF8700", dimColor: repeat, bold: active, children: item.key + "  " }),
-      repeat ? null : /* @__PURE__ */ jsx(
+      /* @__PURE__ */ jsx(Text2, { color: "#FF8700", bold: active, children: item.key + "  " }),
+      /* @__PURE__ */ jsx(
         Text2,
         {
           bold: active || transient === "in",
@@ -1751,7 +1765,7 @@ var ItemRow = ({
           children: truncate(item.summary, titleMax2)
         }
       ),
-      note && !repeat ? /* @__PURE__ */ jsx(Text2, { dimColor: true, children: ` ${note}` }) : null,
+      note ? /* @__PURE__ */ jsx(Text2, { dimColor: true, children: ` ${note}` }) : null,
       transitLabel2 ? /* @__PURE__ */ jsx(Text2, { bold: true, color: TRANSIT_COLOUR[transient], children: "  " + transitLabel2 }) : null
     ] });
   }
@@ -2209,10 +2223,6 @@ var BrowseScreen = ({
     { vimKeys: false, isActive: repoPicker }
   );
   const cursor = cursors[activeId] ?? 0;
-  const repeatedTasks = useMemo(
-    () => repeatedTaskRows(section.items),
-    [section.items]
-  );
   const viewStart = viewStarts[activeId] ?? 0;
   const visibleCount = windowCount(section.items, viewStart, listHeight);
   const visibleItems = section.items.slice(viewStart, viewStart + visibleCount);
@@ -2624,24 +2634,8 @@ var BrowseScreen = ({
                 transient: transientOf(transients, item),
                 lastChild: "indent" in item && item.indent ? !isChildRow(section.items[viewStart + i + 1]) : void 0,
                 parent: item.kind === "task" && isChildRow(section.items[viewStart + i + 1]),
-                repeat: repeatedTasks.has(viewStart + i),
                 sparkFrame,
-                gap: (
-                  // Window-relative, never `viewStart + i`. fitCount prices the
-                  // window's FIRST row at one line (isFirst), so gapping it when
-                  // scrolled draws a row the budget never bought — and the frame
-                  // is sized to fill the terminal exactly, so the overflow scrolls
-                  // the whole panel up a line instead of clipping.
-                  i > 0 && (item.kind === "repo-header" || item.kind === "subgroup-header" || // A header is always followed by a blank line before its
-                  // first child — in Other PRs that's "free" because the
-                  // child is itself a repo-header (gap above). A task row
-                  // has no such stand-in, so it needs this explicitly. Never
-                  // applies between two tickets/PRs — only right after a
-                  // header.
-                  item.kind === "task" && ["repo-header", "subgroup-header"].includes(
-                    section.items[viewStart + i - 1]?.kind
-                  ))
-                )
+                gap: i > 0 && gapsAbove(section.items, viewStart + i)
               },
               `${viewStart + i}:${item.kind === "task" ? item.instanceKey ?? item.key : item.kind === "repo-header" ? `header:${item.repo}` : item.kind === "subgroup-header" ? `subgroup:${item.label}` : item.kind === "show-more" ? `show-more:${item.hidden[0]?.repo ?? i}` : item.kind === "show-less" ? `show-less:${item.toHide[0]?.repo ?? i}` : `${item.repo}/${item.number}`}`
             )) }),
@@ -3035,4 +3029,4 @@ var matchesFilter = (repo, filter) => {
 };
 var parsePatterns = (value) => value.split(",").map((p) => p.trim()).filter(Boolean);
 
-export { ActionMenu, App, COLS, CiStatusLine, CommentsPanel, HealthPanel, buildActions, buildCheckoutCmd, checkoutDirs, clipboard, configureInbox, drillCmd, explainItem, filterByOrigin, filterByRepos, filterBySearch, fitCount, healthColor, healthDisplay, healthGlyph, healthLegend, inboxConfig, insertRepoHeaders, itermRun, jumpToRepo, jumpToRepoPane, layoutGHItems, matchesFilter, maxViewStart, moveCursor, openInTab, parsePatterns, profileOf, readCache, relativeTime, renderMarkdown, repeatedTaskRows, repoPriority, reposInSections, resetInboxConfig, resolveRepoPath, runHere, runInPane, runInPaneHorizontal, sameCiStatusState, signatureOf, sortByRecency, sortItems, toCiStatusState, topLevelCount, truncate, useActionMenu, whoseMove, windowCount, withHeaders, withoutItem, writeCache };
+export { ActionMenu, App, COLS, CiStatusLine, CommentsPanel, HealthPanel, buildActions, buildCheckoutCmd, checkoutDirs, clipboard, configureInbox, drillCmd, explainItem, filterByOrigin, filterByRepos, filterBySearch, fitCount, gapsAbove, healthColor, healthDisplay, healthGlyph, healthLegend, inboxConfig, insertRepoHeaders, itermRun, jumpToRepo, jumpToRepoPane, layoutGHItems, matchesFilter, maxViewStart, moveCursor, openInTab, parsePatterns, profileOf, readCache, relativeTime, renderMarkdown, repoPriority, reposInSections, resetInboxConfig, resolveRepoPath, runHere, runInPane, runInPaneHorizontal, sameCiStatusState, signatureOf, sortByRecency, sortItems, toCiStatusState, topLevelCount, truncate, useActionMenu, whoseMove, windowCount, withHeaders, withoutItem, writeCache };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kud/gh-ink",
-  "version": "0.23.2",
+  "version": "0.24.0",
   "description": "Ink components for rendering GitHub PR review comments and health — controlled, presentation-only, built on @kud/ink-ui and fed by @kud/gh.",
   "type": "module",
   "main": "dist/index.js",