@kubohiroya/turbowarp-title-menu 0.2.0 → 0.2.1

package/README.ja.md

@@ -33,7 +33,7 @@ IndexedDBはoriginごとに分かれます。TurboWarp Web、TurboWarp Desktop
 ## インストール
 
 ```bash
-pnpm add --save-exact @kubohiroya/turbowarp-title-menu@0.2.0
+pnpm add --save-exact @kubohiroya/turbowarp-title-menu@0.2.1
 ```
 
 TurboWarpでは `dist/turbowarp-title-menu.js` をCustom Extensionとして読み込み、sandboxなしの実行を許可します。
@@ -203,6 +203,7 @@ IndexedDBに保管しているDSLファイルの件数を返します。
 |---|---|
 | 組み込みのメニュー項目 | `files`／`reload`／`about`／`close` は最初から登録されており、それぞれの動作を保ちます。同時にhatも発火します。`clear app menu actions` で外せます。 |
 | メニューの変更 | 項目の追加や消去でメニューを作り直します。表示中だった場合は消えずに再表示します。 |
+| 項目が0件のとき | 1件も登録されていない状態では `show application menu` は何もせず、すべて消すと表示中のメニューは閉じます。土台のprimitiveが0件のメニューを作れないため、自分の項目を入れる前に全消しするプロジェクトが途中で止まらないようにしています。 |
 | ファイルの追加 | 「ファイルを追加」はファイル選択ダイアログを開き、選ばれた内容を保管します。開きはしません。使うときは「開く」を押します。 |
 | 名前の変更 | 名前は一意です。他のファイルと同じ名前にしようとすると失敗し、どちらのファイルも変わりません。 |
 | 削除 | 削除には確認のためもう一度クリックが必要です。開いているファイルを削除すると、開いている内容も解除されます。 |

package/README.md

@@ -48,7 +48,7 @@ The reviewed JavaScript build is committed to this repository, so users do not n
 Install an exact version that you have reviewed:
 
 ```bash
-pnpm add --save-exact @kubohiroya/turbowarp-title-menu@0.2.0
+pnpm add --save-exact @kubohiroya/turbowarp-title-menu@0.2.1
 ```
 
 Load the standalone bundle from:
@@ -60,7 +60,7 @@ node_modules/@kubohiroya/turbowarp-title-menu/dist/turbowarp-title-menu.js
 A version-pinned CDN URL is:
 
 ```text
-https://cdn.jsdelivr.net/npm/@kubohiroya/turbowarp-title-menu@0.2.0/dist/turbowarp-title-menu.js
+https://cdn.jsdelivr.net/npm/@kubohiroya/turbowarp-title-menu@0.2.1/dist/turbowarp-title-menu.js
 ```
 
 ## Quick start
@@ -235,6 +235,7 @@ Returns the most recent DSL storage failure in the interface language, or an emp
 | Official website | The title dialog opens the configured website URL in a new browser tab. |
 | Built-in menu actions | `files`, `reload`, `about`, and `close` are pre-registered and keep their own behavior. They also start the hat, and `clear app menu actions` removes them. |
 | Changing the menu | Adding or clearing an action rebuilds the menu. A menu that was on screen is shown again rather than disappearing. |
+| An empty menu | `show application menu` does nothing while no action is registered, and clearing every action closes an open menu. The underlying primitive refuses to build a menu with no actions, so a project that clears the set before installing its own is not interrupted. |
 | Adding a DSL file | `Add file` opens a browser file picker and stores the chosen source. It does not open the file; the operator presses `Open` when the project should use it. |
 | Renaming | Names are unique. Renaming a file to a name another file already uses fails and leaves both files unchanged. |
 | Deleting | Deleting asks for a second confirming click, and deleting the open file clears the opened source. |

package/dist/turbowarp-title-menu.js

@@ -1307,7 +1307,15 @@
     showTitle() {
       this.ensureTitleDialog().show(this.locale());
     }
+    /**
+     * Shows the application menu.
+     *
+     * An empty registry does nothing: the underlying primitive requires at least one action, and a
+     * project that cleared the actions to install its own should not be interrupted by an error
+     * between the two steps.
+     */
     showMenu() {
+      if (this.menuActions.length === 0) return;
       this.ensureApplicationMenu().show(this.locale());
       this.menuVisible = true;
     }
@@ -1396,12 +1404,18 @@
      *
      * The app-shell primitive fixes its actions at construction, so a changed list means a new menu.
      * A menu that was on screen is shown again, because a project that adds an action while the menu
-     * is open should not have it silently disappear.
+     * is open should not have it silently disappear. Clearing every action closes the menu instead,
+     * because the primitive refuses to build one with no actions.
      */
     rebuildMenu() {
       this.applicationMenu?.dispose();
       this.applicationMenu = null;
-      if (this.menuVisible) this.showMenu();
+      if (!this.menuVisible) return;
+      if (this.menuActions.length === 0) {
+        this.menuVisible = false;
+        return;
+      }
+      this.showMenu();
     }
     selectMenuAction(id) {
       Scratch.vm?.runtime?.startHats?.(`${extensionConfig.id}_whenAppMenuActionSelected`, { ACTION: id });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kubohiroya/turbowarp-title-menu",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Reusable title, application menu, and DSL source storage controls for TurboWarp.",
   "author": "Hiroya Kubo <hiroya@cuc.ac.jp>",
   "license": "MPL-2.0",

package/src/extension.ts

@@ -81,7 +81,15 @@ export class TurboWarpTitleMenuExtension implements TurboWarpExtension {
     this.ensureTitleDialog().show(this.locale());
   }
 
+  /**
+   * Shows the application menu.
+   *
+   * An empty registry does nothing: the underlying primitive requires at least one action, and a
+   * project that cleared the actions to install its own should not be interrupted by an error
+   * between the two steps.
+   */
   public showMenu(): void {
+    if (this.menuActions.length === 0) return;
     this.ensureApplicationMenu().show(this.locale());
     this.menuVisible = true;
   }
@@ -187,12 +195,18 @@ export class TurboWarpTitleMenuExtension implements TurboWarpExtension {
    *
    * The app-shell primitive fixes its actions at construction, so a changed list means a new menu.
    * A menu that was on screen is shown again, because a project that adds an action while the menu
-   * is open should not have it silently disappear.
+   * is open should not have it silently disappear. Clearing every action closes the menu instead,
+   * because the primitive refuses to build one with no actions.
    */
   private rebuildMenu(): void {
     this.applicationMenu?.dispose();
     this.applicationMenu = null;
-    if (this.menuVisible) this.showMenu();
+    if (!this.menuVisible) return;
+    if (this.menuActions.length === 0) {
+      this.menuVisible = false;
+      return;
+    }
+    this.showMenu();
   }
 
   private selectMenuAction(id: string): void {