@kubex/zinc 1.1.146 → 1.1.148

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kubex/zinc",
-  "version": "1.1.146",
+  "version": "1.1.148",
   "description": "A collection of web components for building web applications based off of @shoelace-style/Shoelace",
   "keywords": [
     "web components",

package/src/components/confirm/confirm.component.ts

@@ -70,6 +70,8 @@ export default class ZnConfirm extends ZincElement {
 
   @property() cancelText: string = "Cancel";
 
+  @property() closeText: string = "Close";
+
   @property({type: Boolean, attribute: 'hide-icon'}) hideIcon: boolean = false;
 
   /**
@@ -228,12 +230,16 @@ export default class ZnConfirm extends ZincElement {
             <slot></slot>`}
         </div>
 
-        <zn-button outline color="${this.type}" slot="footer" dialog-closer disabled=${this.loading || nothing}>
-          ${this.cancelText}
-        </zn-button>
-        <zn-button color="${this.type}" slot="footer" @click="${this.submitDialog}" disabled=${this.loading || nothing}>
-          ${this.confirmText}
-        </zn-button>
+        ${this.failed ? html`
+          <zn-button color="${this.type}" slot="footer" dialog-closer>
+            ${this.closeText}
+          </zn-button>` : html`
+          <zn-button outline color="${this.type}" slot="footer" dialog-closer disabled=${this.loading || nothing}>
+            ${this.cancelText}
+          </zn-button>
+          <zn-button color="${this.type}" slot="footer" @click="${this.submitDialog}" disabled=${this.loading || nothing}>
+            ${this.confirmText}
+          </zn-button>`}
 
         <slot name="footer-text" slot="footer-text">${this.footerText}</slot>
       </zn-dialog>`;

package/src/components/confirm/confirm.test.ts

@@ -28,7 +28,7 @@ async function submittedConfirm() {
   click(buttons[1]);
   await (confirm as never as {updateComplete: Promise<void>}).updateComplete;
 
-  return {confirm, form, dialog, cancel: buttons[0] as HTMLElement & {disabled: boolean}};
+  return {confirm, form, dialog};
 }
 
 const closer = (dialog: Element) => dialog.shadowRoot!.querySelector('.dialog__close')!;
@@ -62,7 +62,7 @@ describe('<zn-confirm-modal>', () => {
   });
 
   it('reports failure when the response carries a danger alert', async () => {
-    const {confirm, form, dialog, cancel} = await submittedConfirm();
+    const {confirm, form, dialog} = await submittedConfirm();
 
     settle(form, 'complete', {
       response: {status: 200, actions: [{action: 'alert', style: 'error', title: 'Deployment stopped'}]}
@@ -72,10 +72,21 @@ describe('<zn-confirm-modal>', () => {
     expect(confirm.shadowRoot!.textContent).to.contain('Failed');
     expect(confirm.shadowRoot!.textContent).to.contain('Deployment stopped');
     expect(confirm.shadowRoot!.textContent).to.not.contain('Loading');
-    expect(cancel.disabled).to.be.false;
     expect(closer(dialog).disabled).to.be.false;
   });
 
+  it('offers only a close button once the request has failed', async () => {
+    const {confirm, form} = await submittedConfirm();
+
+    settle(form, 'error', {});
+    await (confirm as never as {updateComplete: Promise<void>}).updateComplete;
+
+    const buttons = confirm.shadowRoot!.querySelectorAll('zn-button[slot="footer"]');
+    expect(buttons.length).to.equal(1);
+    expect(buttons[0].textContent!.trim()).to.equal('Close');
+    expect(buttons[0].hasAttribute('dialog-closer')).to.be.true;
+  });
+
   it('reports failure when the request errors', async () => {
     const {confirm, form, dialog} = await submittedConfirm();
 

package/src/components/remarkd-editor/remarkd-editor.component.ts

@@ -342,6 +342,7 @@ function renderInlineConditional(block: string): TemplateResult | null {
  * @csspart include-picker - The inline Include picker opened from the toolbar or "/include".
  *
  * @cssproperty --remarkd-editor-max-height - The tallest the editor grows before its body scrolls. Defaults to `100dvh`.
+ * @cssproperty --remarkd-editor-min-height - The shortest the body renders while empty. Defaults to `10rem`.
  */
 export default class ZnRemarkdEditor extends ZincElement implements ZincFormControl {
   static styles: CSSResultGroup = unsafeCSS(styles);

package/src/components/remarkd-editor/remarkd-editor.scss

@@ -54,7 +54,7 @@
 
 .remarkd-editor__body {
   padding: var(--zn-spacing-large) var(--zn-spacing-large) var(--zn-spacing-large) 52px;
-  min-height: 10rem;
+  min-height: var(--remarkd-editor-min-height, 10rem);
   overflow-y: auto;
 }
 
@@ -70,7 +70,7 @@
 
 .remarkd-editor__raw {
   flex: 1;
-  min-height: 10rem;
+  min-height: var(--remarkd-editor-min-height, 10rem);
   resize: vertical;
   border: 0;
   background: transparent;