@ktpartners/dgs-platform 2.8.0 → 3.0.4

package/deliver-great-systems/bin/lib/ideas.test.cjs

@@ -10,7 +10,7 @@ const path = require('path');
 const { execSync } = require('child_process');
 const { createTempDir, cleanupDir, createTempProject, initGitRepo } = require('./test-helpers.cjs');
 const { resetPaths } = require('./paths.cjs');
-const { findIdeaFile, parseIdeaFrontmatter, ensureIdeasDirs, cmdIdeasCreate, loadManifest, IDEA_STATES, buildIdeaContent, cmdIdeasConsolidate, cmdIdeasFindRelated, cmdIdeasUndoConsolidation } = require('./ideas.cjs');
+const { findIdeaFile, parseIdeaFrontmatter, ensureIdeasDirs, cmdIdeasCreate, cmdIdeasList, loadManifest, IDEA_STATES, IDEA_STATUSES, setIdeaStatus, buildIdeaContent, cmdIdeasConsolidate, cmdIdeasFindRelated, cmdIdeasUndoConsolidation } = require('./ideas.cjs');
 
 // ─── Helpers ──────────────────────────────────────────────────────────────────
 
@@ -1416,3 +1416,246 @@ describe('cmdIdeasUndoConsolidation', () => {
     assert.strictEqual(json.undone_idea_id, 4);
   });
 });
+
+// ─── IDEA_STATUSES constant ─────────────────────────────────────────────────
+
+describe('IDEA_STATUSES constant', () => {
+  it('exports correct values', () => {
+    assert.deepStrictEqual(IDEA_STATUSES, ['pending', 'done', 'rejected', 'consolidated']);
+  });
+
+  it('IDEA_STATES aliases IDEA_STATUSES', () => {
+    assert.strictEqual(IDEA_STATES, IDEA_STATUSES);
+  });
+});
+
+// ─── buildIdeaContent round-trip ─────────────────────────────────────────────
+
+describe('buildIdeaContent round-trip', () => {
+  it('preserves status and unknown fields', () => {
+    const original = '---\nid: 42\ntitle: "Round Trip Test"\nstatus: pending\ntags: ["test"]\ncreated: 2026-01-01\nupdated: 2026-01-02\nauthor: "Test"\ncustom_field: preserved_value\n---\n\nBody content here.\n';
+    const parsed = parseIdeaFrontmatter(original);
+    const rebuilt = buildIdeaContent(parsed.frontmatter, parsed.body, parsed.notes, parsed.discussionLog, parsed.researchLog);
+    const reparsed = parseIdeaFrontmatter(rebuilt);
+
+    assert.strictEqual(reparsed.frontmatter.id, 42);
+    assert.strictEqual(reparsed.frontmatter.title, 'Round Trip Test');
+    assert.strictEqual(reparsed.frontmatter.status, 'pending');
+    assert.deepStrictEqual(reparsed.frontmatter.tags, ['test']);
+    assert.strictEqual(reparsed.frontmatter.custom_field, 'preserved_value');
+    assert.ok(reparsed.body.includes('Body content here.'));
+  });
+});
+
+// ─── setIdeaStatus ───────────────────────────────────────────────────────────
+
+describe('setIdeaStatus', () => {
+  it('throws on invalid status', () => {
+    assert.throws(() => {
+      setIdeaStatus('/nonexistent', '001', 'invalid-status');
+    }, (err) => {
+      assert.ok(err.message.includes('Invalid status'));
+      assert.ok(err.message.includes('pending'));
+      assert.ok(err.message.includes('done'));
+      assert.ok(err.message.includes('rejected'));
+      assert.ok(err.message.includes('consolidated'));
+      return true;
+    });
+  });
+
+  it('throws when idea not found', () => {
+    const os = require('os');
+    const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'dgs-test-'));
+    assert.throws(() => {
+      setIdeaStatus(tmpDir, '999', 'done');
+    }, (err) => {
+      assert.ok(err.message.includes('not found'));
+      return true;
+    });
+    fs.rmSync(tmpDir, { recursive: true });
+  });
+});
+
+// ─── findIdeaFile flat-first scanning ───────────────────────────────────────
+
+/**
+ * Creates an idea file in the flat ideas/ directory (not a subdirectory).
+ */
+function createFlatIdea(cwd, id, title, status) {
+  const paddedId = String(id).padStart(3, '0');
+  const slug = title.toLowerCase().replace(/\s+/g, '-');
+  const filename = `${paddedId}-${slug}.md`;
+  const content = `---\nid: ${id}\ntitle: "${title}"\nstatus: ${status}\n---\n\nIdea body.\n`;
+  const dir = path.join(cwd, 'ideas');
+  fs.mkdirSync(dir, { recursive: true });
+  fs.writeFileSync(path.join(dir, filename), content, 'utf-8');
+  return filename;
+}
+
+describe('findIdeaFile flat-first scanning', () => {
+  let tmpDir;
+
+  beforeEach(() => {
+    tmpDir = createTempDir('ideas-flat-test-');
+    tmpDir = fs.realpathSync(tmpDir);
+    initGitRepo(tmpDir);
+  });
+
+  afterEach(() => { resetPaths(); cleanupDir(tmpDir); });
+
+  it('finds idea in flat ideas/ directory', () => {
+    createFlatIdea(tmpDir, 1, 'Test Flat', 'done');
+    const idea = findIdeaFile(tmpDir, '1');
+    assert.ok(idea, 'findIdeaFile should return a result');
+    assert.strictEqual(idea.status, 'done');
+    assert.strictEqual(idea.state, 'done');
+    assert.ok(idea.path.endsWith('ideas/001-test-flat.md'), 'Should be in flat ideas/ directory');
+    assert.ok(!idea.path.includes('ideas/done/'), 'Should NOT be in a subdirectory');
+  });
+
+  it('falls back to legacy subdirectory with warning', () => {
+    createIdeaInState(tmpDir, 'pending', 2, 'Legacy Idea');
+    // Capture stderr
+    const origWrite = process.stderr.write;
+    let stderrOutput = '';
+    process.stderr.write = (msg) => { stderrOutput += msg; };
+    try {
+      const idea = findIdeaFile(tmpDir, '2');
+      assert.ok(idea, 'findIdeaFile should return a result');
+      assert.ok(stderrOutput.includes('[DGS] Warning:'), 'Should emit legacy warning');
+      assert.ok(stderrOutput.includes('legacy'), 'Warning should mention legacy');
+    } finally {
+      process.stderr.write = origWrite;
+    }
+  });
+
+  it('warns when frontmatter status disagrees with directory', () => {
+    // Create idea in done/ directory but with frontmatter status: pending
+    const dir = path.join(tmpDir, 'ideas', 'done');
+    fs.mkdirSync(dir, { recursive: true });
+    fs.writeFileSync(path.join(dir, '003-mismatch.md'), '---\nid: 3\ntitle: "Mismatch"\nstatus: pending\n---\n\nBody.\n', 'utf-8');
+    const origWrite = process.stderr.write;
+    let stderrOutput = '';
+    process.stderr.write = (msg) => { stderrOutput += msg; };
+    try {
+      const idea = findIdeaFile(tmpDir, '3');
+      assert.ok(idea, 'findIdeaFile should return a result');
+      assert.strictEqual(idea.status, 'pending', 'Frontmatter should win');
+      assert.ok(stderrOutput.includes('disagrees with directory'), 'Should warn about disagreement');
+    } finally {
+      process.stderr.write = origWrite;
+    }
+  });
+
+  it('prefers flat directory over legacy subdirectory', () => {
+    // Create in BOTH flat and legacy
+    createFlatIdea(tmpDir, 4, 'Both Locations', 'done');
+    createIdeaInState(tmpDir, 'pending', 4, 'Both Locations');
+    const idea = findIdeaFile(tmpDir, '4');
+    assert.ok(idea, 'findIdeaFile should return a result');
+    assert.ok(idea.path.endsWith('ideas/004-both-locations.md'), 'Flat should win');
+    assert.strictEqual(idea.status, 'done');
+  });
+
+  it('returns status and state fields', () => {
+    createFlatIdea(tmpDir, 5, 'Both Fields', 'rejected');
+    const idea = findIdeaFile(tmpDir, '5');
+    assert.ok(idea, 'findIdeaFile should return a result');
+    assert.strictEqual(idea.status, 'rejected');
+    assert.strictEqual(idea.state, 'rejected');
+  });
+});
+
+// ─── cmdIdeasList frontmatter status grouping ───────────────────────────────
+
+/**
+ * Capture JSON output from cmdIdeasList.
+ */
+function captureListOutput(fn) {
+  const logs = [];
+  const origLog = console.log;
+  console.log = (...args) => logs.push(args.join(' '));
+  try {
+    fn();
+  } finally {
+    console.log = origLog;
+  }
+  return logs.length ? JSON.parse(logs[0]) : null;
+}
+
+describe('cmdIdeasList frontmatter status grouping', () => {
+  let tmpDir;
+
+  beforeEach(() => {
+    tmpDir = createTempDir('ideas-list-flat-test-');
+    tmpDir = fs.realpathSync(tmpDir);
+    initGitRepo(tmpDir);
+  });
+
+  afterEach(() => { resetPaths(); cleanupDir(tmpDir); });
+
+  it('groups flat ideas by frontmatter status', () => {
+    createFlatIdea(tmpDir, 1, 'Pending Idea', 'pending');
+    createFlatIdea(tmpDir, 2, 'Done Idea', 'done');
+    const result = captureListOutput(() => {
+      cmdIdeasList(tmpDir, { state: null, tag: null, include_orphan_check: false, include_consolidated: false, show_all: true }, true);
+    });
+    assert.ok(result, 'Should return output');
+    assert.strictEqual(result.ideas.length, 2);
+    const pendingIdea = result.ideas.find(i => i.id === 1);
+    const doneIdea = result.ideas.find(i => i.id === 2);
+    assert.strictEqual(pendingIdea.status, 'pending');
+    assert.strictEqual(pendingIdea.state, 'pending');
+    assert.strictEqual(doneIdea.status, 'done');
+    assert.strictEqual(doneIdea.state, 'done');
+  });
+
+  it('handles mixed layout without duplicates', () => {
+    createFlatIdea(tmpDir, 1, 'Flat One', 'pending');
+    createIdeaInState(tmpDir, 'done', 2, 'Legacy Two');
+    // Suppress stderr warnings
+    const origWrite = process.stderr.write;
+    process.stderr.write = () => {};
+    try {
+      const result = captureListOutput(() => {
+        cmdIdeasList(tmpDir, { state: null, tag: null, include_orphan_check: false, include_consolidated: false, show_all: true }, true);
+      });
+      assert.ok(result, 'Should return output');
+      assert.strictEqual(result.ideas.length, 2, 'No duplicates');
+      assert.strictEqual(result.counts.total, 2);
+    } finally {
+      process.stderr.write = origWrite;
+    }
+  });
+
+  it('filters by --state option using frontmatter status', () => {
+    createFlatIdea(tmpDir, 1, 'Done One', 'done');
+    createFlatIdea(tmpDir, 2, 'Pending One', 'pending');
+    const doneResult = captureListOutput(() => {
+      cmdIdeasList(tmpDir, { state: 'done', tag: null, include_orphan_check: false, include_consolidated: false, show_all: false }, true);
+    });
+    assert.strictEqual(doneResult.ideas.length, 1);
+    assert.strictEqual(doneResult.ideas[0].status, 'done');
+
+    const pendingResult = captureListOutput(() => {
+      cmdIdeasList(tmpDir, { state: 'pending', tag: null, include_orphan_check: false, include_consolidated: false, show_all: false }, true);
+    });
+    assert.strictEqual(pendingResult.ideas.length, 1);
+    assert.strictEqual(pendingResult.ideas[0].status, 'pending');
+  });
+
+  it('emits warning for legacy ideas in list', () => {
+    createIdeaInState(tmpDir, 'pending', 1, 'Legacy Listed');
+    const origWrite = process.stderr.write;
+    let stderrOutput = '';
+    process.stderr.write = (msg) => { stderrOutput += msg; };
+    try {
+      captureListOutput(() => {
+        cmdIdeasList(tmpDir, { state: null, tag: null, include_orphan_check: false, include_consolidated: false, show_all: false }, true);
+      });
+      assert.ok(stderrOutput.includes('[DGS] Warning:'), 'Should emit legacy warning in list');
+    } finally {
+      process.stderr.write = origWrite;
+    }
+  });
+});