npm - @krmxd/onegpt - Versions diffs - 0.2.2-beta → 0.2.4-beta - Mend

@krmxd/onegpt 0.2.2-beta → 0.2.4-beta

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@krmxd/onegpt",
-  "version": "0.2.2-beta",
+  "version": "0.2.4-beta",
   "description": "OGPT - AI coding assistant for the terminal with a built-in local engine",
   "main": "src/index.js",
   "bin": {

package/src/agent.js CHANGED Viewed

@@ -10,6 +10,41 @@ const path = require("path");
 const { getConfig } = require("./config");
 const { getSharedProvider } = require("./ollama");
 const { ToolRegistry } = require("./tools");
+const { spawnSync } = require("child_process");
+// --- auto syntax check for AI-written code -------------------------------
+const CHECKABLE_EXT = new Set([".py", ".js", ".mjs", ".cjs"]);
+function _pick(binaries, args, timeoutMs) {
+  for (const bin of binaries) {
+    try {
+      const r = spawnSync(bin, args, { timeout: timeoutMs });
+      if (r.status === 0) return null;
+      if (r.error && r.error.code === "ENOENT") continue;
+      const err = (r.stderr ? r.stderr.toString() : "")
+        || (r.stdout ? r.stdout.toString() : "") || `exit ${r.status}`;
+      return err.split("\n").filter((l) => l.trim()).slice(0, 4).join("\n").slice(0, 500);
+    } catch { /* try next */ }
+  }
+  return null; // no interpreter available - skip silently
+}
+function syntaxCheckError(filePath) {
+  const ext = path.extname(filePath).toLowerCase();
+  if (!CHECKABLE_EXT.has(ext)) return null;
+  if (!fs.existsSync(filePath)) return null;
+  if (ext === ".py") {
+    return _pick(["python3", "python"], ["-m", "py_compile", filePath], 15000);
+  }
+  return _pick([process.execPath || "node", "node"], ["--check", filePath], 15000);
+}
+function autoCheckMsg(p, err) {
+  // Loop-break redirect style: tiny models need the exact shape again.
+  return "[auto-check] The file you just wrote FAILED its syntax check:\n" +
+    `${p}\n${err}\n` +
+    "Rewrite the ENTIRE file correctly NOW with write_file (bare JSON tool call), fixing every reported error. Do not explain.";
+}
 const TOOL_RE = /\x00TOOL:([^:]*):([^:]*):(.*?)\x00/g;
 const USAGE_RE = /\x00USAGE:(.*?)\x00/;
@@ -74,6 +109,9 @@ const TOOL_GUIDANCE = (
   "'/home/user/...' or '/Users/...' - they do not exist on this machine.\n" +
   "- Tool arguments are REAL values: 'path': 'my_folder/app.py'. Never send the " +
   "parameter schema ({'type': 'string'}) as a value, and never leave arguments empty.\n" +
+  "- Call tools ONLY as exact JSON: {\"name\": \"write_file\", \"arguments\": {...}}. " +
+  "NEVER invent formats like 'name_file:path' or bare '<html>' dumps - those are NOT " +
+  "tool calls, they will be ignored, and you must redo them properly.\n" +
   "- To act, output plain JSON tool calls (never shell commands in code fences):\n" +
   '{"name": "write_file", "arguments": {"path": "widgets/gadget.py", ' +
   '"content": "print(\'hi\')"}}\n' +
@@ -160,6 +198,21 @@ function repliedWithoutActing(reply) {
   return SLOTH_RE.test(reply) || reply.includes("```");
 }
+// Tiny models degenerate into printing the same chunk over and over
+// ("name_file:web <html>..." x20). Detect any meaningful line repeated
+// too many times so the agent can cut the run instead of spamming chat.
+function degenerateRepeat(text, minLen = 12, maxHits = 4) {
+  const counts = new Map();
+  for (const rawLine of String(text || "").split("\n")) {
+    const line = rawLine.trim();
+    if (line.length < minLen) continue;
+    const n = (counts.get(line) || 0) + 1;
+    counts.set(line, n);
+    if (n >= maxHits) return line;
+  }
+  return null;
+}
 // "Created the folder." style announcements. Harmless on their own, but a
 // red flag when the request named files that were never actually created
 // (e.g. 'a folder AND an index.html' - folder done, file skipped).
@@ -570,7 +623,9 @@ class Agent {
     let full = "";
     let rounds = 0;
     let nudges = 0;
+    this._autoChecks = 0;
     let lastSig = null;
+    let collectedText = "";
     let loopBreaks = 0;
     const doneBits = [];
@@ -633,6 +688,15 @@ class Agent {
             doneBits.push(result.output.split("\n")[0].slice(0, 90));
             const ev = codeEvent(tc, pre);
             if (ev) full += (full.trim() ? "\n\n" : "") + codeMarkdown(ev);
+            // Auto syntax check: broken AI-written code gets one bounce-back.
+            if (ev && (tc.name === "write_file" || tc.name === "edit_file")
+                && this._autoChecks < 2) {
+              const err = syntaxCheckError(ev.path);
+              if (err) {
+                this._autoChecks++;
+                this.history.push({ role: "user", content: autoCheckMsg(ev.path, err), ts: Date.now() / 1000 });
+              }
+            }
           }
         }
       } else {
@@ -682,11 +746,13 @@ class Agent {
     this.history.push({ role: "user", content: userInput, ts: Date.now() / 1000 });
     let rounds = 0;
     let nudges = 0;
+    this._autoChecks = 0;
     const tStart = Date.now();
     let ttft = 0;
     let nTokens = 0;
     this.lastRun = {};
     let lastSig = null;
+    let collectedText = "";
     let loopBreaks = 0;
     const doneBits = [];
     let sawText = false;
@@ -735,6 +801,20 @@ class Agent {
       }
       const full = contentParts.join("");
+      // Degeneration breaker: same meaningful line 4+ times in ONE round
+      // (or across the whole reply) -> stop instead of spamming chat.
+      const rep = degenerateRepeat(full)
+        || (full.trim().length < 40 && degenerateRepeat(collectedText, 8, 6));
+      if (rep) {
+        this.history.push({ role: "assistant", content: full, ts: Date.now() / 1000 });
+        yield "\n· repeated output detected - cutting it off\n";
+        if (wantsAction(userInput)) {
+          this.history.push({ role: "user", content: redirectMsg(userInput), ts: Date.now() / 1000 });
+          if (loopBreaks < 2) { loopBreaks++; continue; }
+        }
+        break;
+      }
+      collectedText = (collectedText ? collectedText + "\n" : "") + full;
       this.usage.prompt += usage.prompt;
       this.usage.completion += usage.completion;
       this.usage.total += usage.total;
@@ -790,6 +870,16 @@ class Agent {
             }
             const ev = codeEvent(tc, pre);
             if (ev) yield "\n" + codeMarkdown(ev) + "\n";
+            // Auto syntax check: broken AI-written code gets one bounce-back.
+            if (ev && (tc.name === "write_file" || tc.name === "edit_file")
+                && this._autoChecks < 2) {
+              const err = syntaxCheckError(ev.path);
+              if (err) {
+                this._autoChecks++;
+                yield `\n[auto-check] ${path.basename(ev.path)} has a syntax error - fixing...\n`;
+                this.history.push({ role: "user", content: autoCheckMsg(ev.path, err), ts: Date.now() / 1000 });
+              }
+            }
           }
         }
       } else {
@@ -909,4 +999,6 @@ class Agent {
   }
 }
-module.exports = { Agent, extractJsonTools, repairToolJson, wantsAction, repliedWithoutActing, stalledHalfway };
+module.exports = { Agent, extractJsonTools, repairToolJson, wantsAction,
+  repliedWithoutActing, stalledHalfway, syntaxCheckError, autoCheckMsg,
+  degenerateRepeat };

package/src/render.js CHANGED Viewed

@@ -257,30 +257,29 @@ class SmoothPrinter {
     let preview = this.buf;
     if (preview.length > MAX_PREVIEW_CHARS) preview = preview.slice(-MAX_PREVIEW_CHARS);
     const rendered = renderMarkdown(preview, width);
-    const lines = rendered.split("\n");
-    const rows = Math.max(0, lines.length - 1);
-    const maxRows = (this.out.rows || 2000) - 1;
-    if (rows > maxRows) {
-      // Taller than the screen: scrolling would already have eaten the top
-      // rows - repainting can't reach them. Degrade instead of duplicating.
-      this._degrade(true);
-      return;
-    }
+    let lines = rendered.split("\n");
+    const target = Math.max(0, lines.length - 1);
+    const maxRows = Math.max(3, (this.out.rows || 2000) - 2);
+    // Viewport with INCREMENTAL REVEAL: grow by one row per tick so the
+    // painted block never pushes past the screen edge (which would scroll
+    // ghosts in and desync the next erase). Once at maxRows it repaints a
+    // stable window; finish() prints the complete styled message.
+    let take = Math.min(target, maxRows, this.drawn + 1);
+    if (target < take) take = target;
+    lines = lines.slice(-(take + 1));
     this._erase();
-    this.out.write(rendered);
-    this.drawn = rows;
+    this.out.write(lines.join("\n"));
+    this.drawn = Math.max(0, lines.length - 1);
     this.paintWidth = cols || width;
     this.lastPaint = now;
   }
   _degrade(skipFlush) {
     this.degraded = true;
-    if (!skipFlush && this.buf) {
-      // Hand back the un-styled tail so nothing is lost visually.
-      this.out.write("\n" + this.buf.slice(-4000) + "\n");
-    } else {
-      this.out.write("\n");
-    }
+    // Do NOT reprint the buffer here - part of it is already on screen
+    // and repainting would duplicate it. Just mark the seam and let the
+    // remaining chunks stream raw.
+    this.out.write("\n");
     this.buf = "";
   }
@@ -288,7 +287,9 @@ class SmoothPrinter {
     if (this.closed) return;
     this.closed = true;
     if (this.timer) { clearTimeout(this.timer); this.timer = null; }
-    if (!this.tty || this.degraded) return;
+    if (!this.tty) return;
+    // Always un-hide the cursor, degraded or not.
+    if (this.degraded) { this.out.write(`${ESC}[?25h`); return; }
     this._erase();
     const width = this.widthOf();
     this.out.write(renderMarkdown(this.buf, width) + "\n");