@kravc/dos 1.8.2 → 1.8.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kravc/dos",
-  "version": "1.8.2",
+  "version": "1.8.4",
   "description": "Convention-based, easy-to-use library for building API-driven serverless services.",
   "keywords": [
     "Service",
@@ -20,7 +20,7 @@
     "src": "src"
   },
   "scripts": {
-    "test": "eslint src/ examples/ && NODE_APP_INSTANCE=test NODE_PATH=./ nyc mocha \"./src/**/*.spec.js\""
+    "test": "eslint src/ examples/ && NODE_APP_INSTANCE=test NODE_PATH=./ nyc --skip-full mocha \"./src/**/*.spec.js\""
   },
   "author": "Alexander Kravets <a@kra.vc>",
   "license": "ISC",

package/src/Document.js

@@ -265,7 +265,7 @@ class Document extends Component {
 
   get originalDocument() {
     if (!this._originalDocument) {
-      throw new Error('Orginal document is undefined')
+      throw new Error('Original document is undefined')
     }
 
     return this._originalDocument

package/src/Document.spec.js

@@ -290,7 +290,7 @@ describe('Document', () => {
         profile.hasAttributeChanged('name')
 
       } catch (error) {
-        expect(error.message).to.eql('Orginal document is undefined')
+        expect(error.message).to.eql('Original document is undefined')
 
         return
       }

package/src/Service.spec.js

@@ -259,7 +259,9 @@ describe('Service', () => {
       expect(response.statusCode).to.eql(200)
     })
 
-    it('supports spec middleware', async () => {
+    it('supports spec middleware in dev environment', async () => {
+      process.env.NODE_APP_INSTANCE = 'dev'
+
       const lambdaFunction = request => service.handler(request)
 
       let request
@@ -272,6 +274,7 @@ describe('Service', () => {
 
       response = await lambdaFunction(request)
       expect(response.statusCode).to.eql(200)
+      expect(response.body.startsWith('<!DOCTYPE')).to.be.true
 
       request = {
         path:       '/Spec',
@@ -280,6 +283,56 @@ describe('Service', () => {
 
       response = await lambdaFunction(request)
       expect(response.statusCode).to.eql(200)
+
+      const body = JSON.parse(response.body)
+      expect(body.swagger).to.exist
+
+      process.env.NODE_APP_INSTANCE = undefined
+    })
+
+    it('does not expose spec middleware in non-dev environment', async () => {
+      const lambdaFunction = request => service.handler(request)
+
+      let request
+      let response
+
+      request = {
+        url:        'http://localhost:3000/',
+        httpMethod: 'GET'
+      }
+
+      response = await lambdaFunction(request)
+      expect(response.statusCode).to.eql(200)
+      expect(response.body).to.eql('healthy')
+
+      request = {
+        path:       '/Spec',
+        httpMethod: 'GET'
+      }
+
+      response = await lambdaFunction(request)
+      expect(response.statusCode).to.eql(200)
+
+      const body = JSON.parse(response.body)
+      expect(body.swagger).to.not.exist
+    })
+
+    it('logs operation input in non-test environment', async () => {
+      process.env.NODE_APP_INSTANCE = 'dev'
+
+      const lambdaFunction = request => service.handler(request)
+
+      await lambdaFunction({
+        url: 'http://localhost:3000/api/Health',
+        httpMethod: 'GET'
+      })
+
+      const id = 'HELLO_WORLD'
+      await exec('CreateProfile', {
+        mutation: { id, name: 'Hello, world!' }
+      }, { authorization })
+
+      process.env.NODE_APP_INSTANCE = undefined
     })
   })
 })

package/src/helpers/logRequest.js

@@ -1,9 +1,9 @@
 'use strict'
 
-const isTestEnvironment = process.env.NODE_APP_INSTANCE === 'test'
+const isTestEnvironment = () => process.env.NODE_APP_INSTANCE === 'test'
 
 const logRequest = context => {
-  if (isTestEnvironment) {
+  if (isTestEnvironment()) {
     return
   }
 

package/src/helpers/specMiddleware.js

@@ -11,7 +11,11 @@ const { name: title, version } = require(`${ROOT_PATH}/package.json`)
 
 const SWAGGER_UI_HTML = SWAGGER_UI_TEMPLATE.replace('$TITLE', title)
 
-const isProduction = process.env.NODE_APP_INSTANCE === 'prd'
+const isDevelopment = () => process.env.NODE_APP_INSTANCE === 'dev' || !process.env.NODE_APP_INSTANCE
+
+const _getHomeBody = () => isDevelopment() ? SWAGGER_UI_HTML : 'healthy'
+
+const _getSpecBody = (service) => isDevelopment() ? service.spec : { info: { title, version } }
 
 const specMiddleware = (service, context) => {
   const { httpPath, httpMethod } = context
@@ -19,22 +23,26 @@ const specMiddleware = (service, context) => {
   if (httpMethod !== 'get') { return null }
 
   if (httpPath === '/') {
+    const bodyText = _getHomeBody()
+
     return {
       headers: {
         'Content-Type': 'text/html; charset=UTF-8'
       },
       statusCode: 200,
-      body: isProduction ? 'healthy' : SWAGGER_UI_HTML
+      body: bodyText,
     }
   }
 
   if (httpPath === '/Spec') {
+    const bodyJson = JSON.stringify(_getSpecBody(service), null, 2)
+
     return {
       headers: {
         'Content-Type': 'application/json; charset=utf-8'
       },
       statusCode: 200,
-      body: JSON.stringify(isProduction ? { info: { title, version } } : service.spec, null, 2)
+      body: bodyJson,
     }
   }