@kravc/dos 1.5.0 → 1.6.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kravc/dos",
-  "version": "1.5.0",
+  "version": "1.6.0",
   "description": "Convention-based, easy-to-use library for building API-driven serverless services.",
   "keywords": [
     "Service",

package/src/Component.js

@@ -1,5 +1,7 @@
 'use strict'
 
+const asSafeClass = require('./helpers/asSafeClass')
+
 class Component {
   static get id() {
     return this.name
@@ -21,6 +23,8 @@ class Component {
     if (!this._validator) {
       throw new Error(`Validator is undefined for "${this.componentId}:${this.id}"`)
     }
+
+    return asSafeClass(this)
   }
 
   get context() {

package/src/Component.spec.js

@@ -52,4 +52,14 @@ describe('Component', () => {
       ).to.throw('"Profile" validation failed')
     })
   })
+
+  describe('.undefined', () => {
+    it('throw error if attributes or method is not defined by a class', () => {
+      const profile = new Profile({ validator }, { ...attributes, id: null })
+
+      expect(
+        () => profile.sex
+      ).to.throw('Undefined property or method: sex')
+    })
+  })
 })

package/src/Operation.js

@@ -1,10 +1,12 @@
 'use strict'
 
-const isEmpty        = require('lodash.isempty')
-const cloneDeep      = require('lodash.clonedeep')
-const defaultId      = require('./helpers/defaultId')
-const { Schema }     = require('@kravc/schema')
-const defaultTags    = require('./helpers/defaultTags')
+const isEmpty = require('lodash.isempty')
+const cloneDeep = require('lodash.clonedeep')
+const { Schema } = require('@kravc/schema')
+
+const defaultId = require('./helpers/defaultId')
+const defaultTags = require('./helpers/defaultTags')
+const asSafeClass = require('./helpers/asSafeClass')
 const defaultSummary = require('./helpers/defaultSummary')
 
 class Operation {
@@ -180,17 +182,20 @@ class Operation {
 
   constructor(context) {
     this._context = context
+
+    this._headers = {}
+    this._multiValueHeaders = {}
+
+    return asSafeClass(this)
   }
 
   setHeader(name, value, isMultiValue = false) {
     if (isMultiValue) {
-      this._multiValueHeaders = this._headers || {}
       this._multiValueHeaders[name.toLowerCase()] = value
 
       return
     }
 
-    this._headers = this._headers || {}
     this._headers[name.toLowerCase()] = value
   }
 
@@ -198,40 +203,56 @@ class Operation {
     return this._context
   }
 
+  before() {
+    return
+  }
+
   async action(parameters) {
     const { Component } = this.constructor
 
-    if (!Component) { return }
+    if (!Component) {
+      return {}
+    }
 
     const { componentActionMethod } = this.constructor
 
     const { mutation, ...query } = parameters
 
-    const data = await (mutation ?
-      componentActionMethod(this.context, query, mutation) :
-      componentActionMethod(this.context, query)
+    const data = await (mutation
+      ? componentActionMethod(this.context, query, mutation)
+      : componentActionMethod(this.context, query)
     )
 
     return { data }
   }
 
+  after() {
+    return
+  }
+
   async exec(_parameters) {
     let parameters = cloneDeep(_parameters)
     let result
 
-    if (this.before) {
-      const _ = await this.before(parameters)
-      parameters = _ ? _ : parameters
-    }
+    const beforeResult = await this.before(parameters)
+
+    parameters = beforeResult
+      ? beforeResult
+      : parameters
 
     result = await this.action(parameters)
 
-    if (this.after) {
-      const _ = await this.after(parameters, result.data || result)
-      result = _ ? ( result.data ? { ...result, data: _ } : _ ) : result
-    }
+    const afterResult = await this.after(parameters, result.data || result)
 
-    return { result, headers: this._headers, multiValueHeaders: this._multiValueHeaders }
+    result = afterResult
+      ? ( result.data ? { ...result, data: afterResult } : afterResult )
+      : result
+
+    return {
+      result,
+      headers: this._headers,
+      multiValueHeaders: this._multiValueHeaders
+    }
   }
 }
 

package/src/Operation.spec.js

@@ -468,7 +468,7 @@ describe('Operation', () => {
     it('supports dummy mode without defined "Component"', async () => {
       const { result } = await new Operation().exec()
 
-      expect(result).to.not.exist
+      expect(result).to.be.empty
     })
   })
 })

package/src/helpers/asSafeClass.js

@@ -0,0 +1,23 @@
+'use strict'
+
+const asSafeClass = classTarget => {
+  // eslint-disable-next-line no-undef
+  return new Proxy(classTarget, {
+    get(target, prop) {
+      const isPropertyDefined = (prop in target)
+      const isThen = prop === 'then'
+
+      if (isThen) {
+        return undefined
+      }
+
+      if (!isPropertyDefined) {
+        throw new Error(`Undefined property or method: ${prop}`)
+      }
+
+      return target[prop]
+    }
+  })
+}
+
+module.exports = asSafeClass