@koobiq/components 20.4.2 → 21.0.0

package/schematics/migrations/progress-spinner-signals/index.js

@@ -0,0 +1,694 @@
+'use strict';
+
+Object.defineProperty(exports, '__esModule', { value: true });
+
+var ts = require('typescript');
+var utils_ast = require('../../utils/ast.js');
+var utils_messages = require('../../utils/messages.js');
+var utils_packageConfig = require('../../package-config-BhU2TfC8.js');
+var utils_typescript = require('../../utils/typescript.js');
+var migrations_progressSpinnerSignals_data = require('./data.js');
+require('@angular-devkit/schematics');
+require('@schematics/angular/utility');
+
+const LABEL = '[progress-spinner-signals]';
+const TS_EXT = '.ts';
+const HTML_EXT = '.html';
+/** Signal-API methods reachable on a signal; a read followed by one is already migrated. */
+const SIGNAL_API_METHODS = new Set(['set', 'update', 'asReadonly', 'subscribe']);
+/** Factories whose single argument gives the type of the declaration they set up. */
+const TYPING_FACTORIES = new Set(['inject', 'viewChild', 'contentChild']);
+function escapeRegExp(value) {
+    return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+}
+/** Applies text-span edits to `content`, right-to-left, so earlier edits don't shift later offsets. */
+function applyEdits(content, edits) {
+    const sorted = [...edits].sort((a, b) => b.start - a.start || b.end - a.end);
+    let result = content;
+    for (const { start, end, text } of sorted) {
+        result = result.slice(0, start) + text + result.slice(end);
+    }
+    return result;
+}
+/** Walks up from `node` to the nearest ancestor matching `predicate`. */
+function findAncestor(node, predicate) {
+    let current = node.parent;
+    while (current) {
+        if (predicate(current))
+            return current;
+        current = current.parent;
+    }
+    return undefined;
+}
+/**
+ * Nodes that open a new binding scope. `ts.isFunctionLike` rather than a hand-rolled list of declarations,
+ * so a parameter of a `FunctionTypeNode` or a `MethodSignature` is bounded by its type instead of falling
+ * back to the whole file. Blocks and loops are included because `let`/`const` are block-scoped.
+ */
+const opensScope = (node) => ts.isFunctionLike(node) ||
+    ts.isBlock(node) ||
+    ts.isCaseBlock(node) ||
+    ts.isModuleBlock(node) ||
+    ts.isForStatement(node) ||
+    ts.isForInStatement(node) ||
+    ts.isForOfStatement(node) ||
+    ts.isCatchClause(node) ||
+    ts.isClassLike(node) ||
+    ts.isSourceFile(node);
+/** Nodes that rebind `this`, so `this.spinner` inside them is a different object. Arrows don't. */
+const rebindsThis = (node) => ts.isFunctionDeclaration(node) || ts.isFunctionExpression(node) || ts.isClassLike(node);
+/** Whether `node` sits inside `scope` without crossing a `barrier` node on the way up. */
+function reachesScope(node, scope, barrier) {
+    let current = node.parent;
+    while (current && current !== scope) {
+        if (barrier(current))
+            return false;
+        current = current.parent;
+    }
+    return current === scope;
+}
+/** Whether a type annotation names `typeName` directly (not through a union, array or type argument). */
+function isTypeReference(type, typeNames) {
+    return (!!type &&
+        ts.isTypeReferenceNode(type) &&
+        ts.isIdentifier(type.typeName) &&
+        typeNames.includes(type.typeName.text));
+}
+const FIELD_MODIFIERS = new Set([
+    ts.SyntaxKind.PrivateKeyword,
+    ts.SyntaxKind.PublicKeyword,
+    ts.SyntaxKind.ProtectedKeyword,
+    ts.SyntaxKind.ReadonlyKeyword
+]);
+/** Every value declaration that introduces a plain identifier, with the scope it is visible in. */
+function collectBindings(sourceFile) {
+    const bindings = [];
+    const add = (name, declaration, scope) => bindings.push({ name, declaration, scope: scope ?? sourceFile });
+    const visit = (node) => {
+        if (ts.isParameter(node) && ts.isIdentifier(node.name)) {
+            add(node.name.text, node, findAncestor(node, ts.isFunctionLike));
+        }
+        else if ((ts.isVariableDeclaration(node) || ts.isBindingElement(node)) && ts.isIdentifier(node.name)) {
+            add(node.name.text, node, findAncestor(node, opensScope));
+        }
+        else if ((ts.isFunctionDeclaration(node) || ts.isClassDeclaration(node)) && node.name) {
+            add(node.name.text, node, findAncestor(node, opensScope));
+        }
+        else if ((ts.isImportSpecifier(node) || ts.isImportClause(node)) && node.name) {
+            add(node.name.text, node, sourceFile);
+        }
+        node.forEachChild(visit);
+    };
+    visit(sourceFile);
+    return bindings;
+}
+/** The declaration `name` binds to at `pos`: the innermost enclosing scope that declares it. */
+function resolveBinding(bindings, name, pos) {
+    let best;
+    let bestWidth = Number.POSITIVE_INFINITY;
+    for (const binding of bindings) {
+        if (binding.name !== name)
+            continue;
+        const start = binding.scope.getStart();
+        const end = binding.scope.getEnd();
+        if (pos < start || pos > end)
+            continue;
+        const width = end - start;
+        if (width < bestWidth) {
+            best = binding;
+            bestWidth = width;
+        }
+    }
+    return best?.declaration;
+}
+/** Local names `SPINNER_TYPE` is bound to in this file, including aliased imports. */
+function localTypeNames(sourceFile) {
+    const names = new Set([migrations_progressSpinnerSignals_data.SPINNER_TYPE]);
+    const visit = (node) => {
+        if (ts.isImportSpecifier(node) && (node.propertyName?.text ?? node.name.text) === migrations_progressSpinnerSignals_data.SPINNER_TYPE) {
+            names.add(node.name.text);
+        }
+        node.forEachChild(visit);
+    };
+    visit(sourceFile);
+    return [...names];
+}
+/**
+ * The spinner-ness of an initializer, for the shapes a modern Angular consumer writes:
+ * `inject(KbqProgressSpinner)`, `viewChild(KbqProgressSpinner)`, `viewChild.required(…)`,
+ * `contentChild(…)`. Returns whether the declaration is a spinner and whether it is a signal query.
+ */
+function initializerTypeOf(initializer, typeNames) {
+    const none = { spinner: false, signalQuery: false };
+    if (!initializer || !ts.isCallExpression(initializer))
+        return none;
+    const callee = initializer.expression;
+    const name = ts.isIdentifier(callee)
+        ? callee.text
+        : ts.isPropertyAccessExpression(callee) && ts.isIdentifier(callee.expression)
+            ? callee.expression.text
+            : undefined;
+    if (!name || !TYPING_FACTORIES.has(name))
+        return none;
+    const [arg] = initializer.arguments;
+    if (!arg || !ts.isIdentifier(arg) || !typeNames.includes(arg.text))
+        return none;
+    return { spinner: true, signalQuery: name !== 'inject' };
+}
+/**
+ * Collects the spinner receivers: method/function params, class fields (incl.
+ * `@ViewChild(KbqProgressSpinner) x: KbqProgressSpinner`, constructor parameter-properties and the
+ * `inject()` / `viewChild()` initializer forms) and typed locals. Annotations that resolve are recorded in
+ * `resolved`, so the caller can report the mentions this pass could not turn into a receiver.
+ */
+function collectReceivers(sourceFile, typeNames, resolved) {
+    const receivers = [];
+    const add = (text, declaration, scope, signalQuery = false) => receivers.push({ text, declaration, scope: scope ?? sourceFile, signalQuery });
+    const visit = (node) => {
+        if (ts.isParameter(node) && ts.isIdentifier(node.name) && isTypeReference(node.type, typeNames)) {
+            resolved?.add(node.type);
+            add(node.name.text, node, findAncestor(node, ts.isFunctionLike));
+            // A constructor parameter-property is also a class field, reachable as `this.<name>`.
+            if (node.modifiers?.some((modifier) => FIELD_MODIFIERS.has(modifier.kind))) {
+                const owner = findAncestor(node, ts.isClassDeclaration);
+                if (owner)
+                    add(`this.${node.name.text}`, node, owner);
+            }
+        }
+        else if (ts.isPropertyDeclaration(node) && ts.isIdentifier(node.name)) {
+            const owner = findAncestor(node, ts.isClassDeclaration);
+            const annotated = isTypeReference(node.type, typeNames);
+            const { spinner, signalQuery } = initializerTypeOf(node.initializer, typeNames);
+            if (owner && (annotated || spinner)) {
+                if (annotated)
+                    resolved?.add(node.type);
+                add(`this.${node.name.text}`, node, owner, signalQuery);
+            }
+        }
+        else if (ts.isVariableDeclaration(node) && ts.isIdentifier(node.name)) {
+            const annotated = isTypeReference(node.type, typeNames);
+            const { spinner, signalQuery } = initializerTypeOf(node.initializer, typeNames);
+            if (annotated || spinner) {
+                if (annotated)
+                    resolved?.add(node.type);
+                add(node.name.text, node, findAncestor(node, opensScope), signalQuery);
+            }
+        }
+        node.forEachChild(visit);
+    };
+    visit(sourceFile);
+    return receivers;
+}
+/** Strips the wrappers that do not change which object an access reads from. */
+function unwrapReceiver(node) {
+    let current = node;
+    while (ts.isNonNullExpression(current) || ts.isParenthesizedExpression(current)) {
+        current = current.expression;
+    }
+    return current;
+}
+/** The receiver a property access resolves to at this exact position, if any. */
+function resolveReceiver(expression, at, sourceFile, receivers, bindings) {
+    const inner = unwrapReceiver(expression);
+    // `this . spinner` and `this /* x */ . spinner` spell the same receiver as `this.spinner`.
+    const text = ts.isPropertyAccessExpression(inner)
+        ? `${inner.expression.getText(sourceFile).replace(/\s+/g, '')}.${inner.name.text}`
+        : inner.getText(sourceFile);
+    return receivers.find((receiver) => {
+        if (receiver.text !== text)
+            return false;
+        // For `this.spinner`, a nested `function` or class changes what `this` is; an arrow does not.
+        // For a bare `spinner`, a nested redeclaration of the same name shadows the receiver.
+        if (receiver.text.startsWith('this.'))
+            return reachesScope(at, receiver.scope, rebindsThis);
+        return (reachesScope(at, receiver.scope, () => false) &&
+            resolveBinding(bindings, receiver.text, at.getStart(sourceFile)) === receiver.declaration);
+    });
+}
+/** Binary operators that make their left operand a write target rather than a read. */
+const ASSIGNMENT_OPERATORS = new Set([
+    ts.SyntaxKind.EqualsToken,
+    ts.SyntaxKind.PlusEqualsToken,
+    ts.SyntaxKind.MinusEqualsToken,
+    ts.SyntaxKind.AsteriskEqualsToken,
+    ts.SyntaxKind.AsteriskAsteriskEqualsToken,
+    ts.SyntaxKind.SlashEqualsToken,
+    ts.SyntaxKind.PercentEqualsToken,
+    ts.SyntaxKind.LessThanLessThanEqualsToken,
+    ts.SyntaxKind.GreaterThanGreaterThanEqualsToken,
+    ts.SyntaxKind.GreaterThanGreaterThanGreaterThanEqualsToken,
+    ts.SyntaxKind.AmpersandEqualsToken,
+    ts.SyntaxKind.BarEqualsToken,
+    ts.SyntaxKind.CaretEqualsToken,
+    ts.SyntaxKind.BarBarEqualsToken,
+    ts.SyntaxKind.AmpersandAmpersandEqualsToken,
+    ts.SyntaxKind.QuestionQuestionEqualsToken
+]);
+/** Unary operators that write their operand back. Every other prefix operator is a plain read. */
+const INCREMENT_OPERATORS = new Set([ts.SyntaxKind.PlusPlusToken, ts.SyntaxKind.MinusMinusToken]);
+/** Whether `node` sits on the left of a destructuring assignment, where it is written rather than read. */
+function isDestructuringTarget(node) {
+    let current = node;
+    while (ts.isPropertyAssignment(current.parent) ||
+        ts.isShorthandPropertyAssignment(current.parent) ||
+        ts.isSpreadAssignment(current.parent) ||
+        ts.isSpreadElement(current.parent) ||
+        ts.isObjectLiteralExpression(current.parent) ||
+        ts.isArrayLiteralExpression(current.parent)) {
+        current = current.parent;
+    }
+    return (ts.isBinaryExpression(current.parent) &&
+        current.parent.left === current &&
+        ASSIGNMENT_OPERATORS.has(current.parent.operatorToken.kind));
+}
+/** Classifies a matched property access and appends the resulting edit(s). */
+function classifyAccess(node, sourceFile, edits) {
+    const parent = node.parent;
+    // Already migrated: `x.size()` (call) or `x.size.set(...)` and the rest of the signal API.
+    if (ts.isCallExpression(parent) && parent.expression === node)
+        return;
+    if (ts.isPropertyAccessExpression(parent) && parent.expression === node && SIGNAL_API_METHODS.has(parent.name.text))
+        return;
+    // Write target: `x.size = RHS` and every compound form (`+=`, `||=`, …). Every spinner signal member is
+    // `input()` (read-only), so the write is left untouched and becomes a compile error the consumer fixes
+    // by hand. Appending `()` to any of them would produce unparseable TypeScript instead.
+    if (ts.isBinaryExpression(parent) && parent.left === node && ASSIGNMENT_OPERATORS.has(parent.operatorToken.kind)) {
+        if (parent.operatorToken.kind === ts.SyntaxKind.EqualsToken && migrations_progressSpinnerSignals_data.WRITABLE_MEMBERS.has(node.name.text)) {
+            const rhs = parent.right;
+            edits.push({ start: node.getEnd(), end: rhs.getStart(sourceFile), text: '.set(' });
+            edits.push({ start: rhs.getEnd(), end: rhs.getEnd(), text: ')' });
+        }
+        return;
+    }
+    // `x.size++` / `--x.size` and `delete x.size` are writes too. Only the increment operators
+    // count: a `PrefixUnaryExpression` is also how `!x.size` and `-x.value` are spelled, and those
+    // are reads.
+    if (ts.isPostfixUnaryExpression(parent) && parent.operand === node)
+        return;
+    if (ts.isPrefixUnaryExpression(parent) && parent.operand === node && INCREMENT_OPERATORS.has(parent.operator))
+        return;
+    if (ts.isDeleteExpression(parent))
+        return;
+    if (isDestructuringTarget(node))
+        return;
+    // Read (incl. optional chain `x?.size`): append `()`.
+    edits.push({ start: node.getEnd(), end: node.getEnd(), text: '()' });
+}
+/** Collects edits for every read of a signal member on a known spinner receiver. */
+function collectAccessEdits(sourceFile, receivers, bindings) {
+    const edits = [];
+    const visit = (node) => {
+        if (ts.isPropertyAccessExpression(node) &&
+            ts.isIdentifier(node.name) &&
+            migrations_progressSpinnerSignals_data.SIGNAL_MEMBERS.includes(node.name.text)) {
+            const receiver = resolveReceiver(node.expression, node, sourceFile, receivers, bindings);
+            // A signal query holds the instance behind a call of its own, so the read is `query().size()`.
+            // Appending one `()` to `this.query.size` would be wrong in both halves; leave it to the warning.
+            if (receiver && !receiver.signalQuery)
+                classifyAccess(node, sourceFile, edits);
+        }
+        node.forEachChild(visit);
+    };
+    visit(sourceFile);
+    return edits;
+}
+/**
+ * 1-based lines where the spinner is named in a position `collectReceivers` cannot resolve - a union, an
+ * array, a `QueryList<…>`, a cast, a return type - plus the reads the access pass structurally cannot
+ * reach: `spinner['size']` and `const { size } = spinner`.
+ */
+function collectUnresolvedMentions(sourceFile, resolved, typeNames, receivers, bindings) {
+    const lines = new Set();
+    const members = [...migrations_progressSpinnerSignals_data.SIGNAL_MEMBERS, ...migrations_progressSpinnerSignals_data.PROTECTED_MEMBERS];
+    const report = (node) => lines.add(sourceFile.getLineAndCharacterOfPosition(node.getStart(sourceFile)).line + 1);
+    const isReceiver = (expression, at) => !!resolveReceiver(expression, at, sourceFile, receivers, bindings);
+    const visit = (node) => {
+        if (ts.isTypeReferenceNode(node) && ts.isIdentifier(node.typeName) && typeNames.includes(node.typeName.text)) {
+            if (!resolved.has(node))
+                report(node);
+        }
+        else if (ts.isElementAccessExpression(node) &&
+            ts.isStringLiteralLike(node.argumentExpression) &&
+            members.includes(node.argumentExpression.text) &&
+            isReceiver(node.expression, node)) {
+            report(node);
+        }
+        else if (ts.isVariableDeclaration(node) &&
+            ts.isObjectBindingPattern(node.name) &&
+            node.initializer &&
+            isReceiver(node.initializer, node) &&
+            node.name.elements.some((element) => members.includes((element.propertyName ?? element.name).getText(sourceFile)))) {
+            report(node);
+        }
+        node.forEachChild(visit);
+    };
+    visit(sourceFile);
+    return [...lines].sort((a, b) => a - b);
+}
+/** Collects the members read on a spinner receiver that no consumer can keep reading as-is. */
+function collectReceiverWarnings(sourceFile) {
+    const protectedAccess = new Set();
+    const resolved = new Set();
+    const typeNames = localTypeNames(sourceFile);
+    const bindings = collectBindings(sourceFile);
+    const receivers = collectReceivers(sourceFile, typeNames, resolved);
+    const visit = (node) => {
+        if (ts.isPropertyAccessExpression(node) &&
+            ts.isIdentifier(node.name) &&
+            migrations_progressSpinnerSignals_data.PROTECTED_MEMBERS.includes(node.name.text) &&
+            resolveReceiver(node.expression, node, sourceFile, receivers, bindings)) {
+            protectedAccess.add(node.name.text);
+        }
+        node.forEachChild(visit);
+    };
+    visit(sourceFile);
+    return {
+        protectedAccess,
+        unresolved: collectUnresolvedMentions(sourceFile, resolved, typeNames, receivers, bindings)
+    };
+}
+/** Pass A — rewrite programmatic reads of spinner signal members in TypeScript code. */
+function migrateTsExpressions(content, fileName) {
+    const sourceFile = ts.createSourceFile(fileName, content, ts.ScriptTarget.Latest, true, ts.ScriptKind.TS);
+    const receivers = collectReceivers(sourceFile, localTypeNames(sourceFile));
+    if (receivers.length === 0)
+        return content;
+    const edits = collectAccessEdits(sourceFile, receivers, collectBindings(sourceFile));
+    return edits.length > 0 ? applyEdits(content, edits) : content;
+}
+const protectedMessage = (members) => `These KbqProgressSpinner members are \`protected\` now and can't be read from outside the component: ` +
+    `${[...members].join(', ')}. ${migrations_progressSpinnerSignals_data.PROTECTED_HINT}`;
+/** Emits precise, receiver-scoped warnings for the members that can't be auto-fixed. */
+function warnReceiverMembers(context, filePath, content) {
+    const sourceFile = ts.createSourceFile(filePath, content, ts.ScriptTarget.Latest, true, ts.ScriptKind.TS);
+    const { protectedAccess, unresolved } = collectReceiverWarnings(sourceFile);
+    if (protectedAccess.size > 0) {
+        utils_messages.logMessage(context.logger, [`${LABEL} ${filePath}`, `  ${protectedMessage(protectedAccess)}`]);
+    }
+    if (unresolved.length > 0) {
+        utils_messages.logMessage(context.logger, [
+            `${LABEL} ${filePath}`,
+            `  ${migrations_progressSpinnerSignals_data.UNRESOLVED_RECEIVER_MESSAGE} ${unresolved.join(', ')}.`
+        ]);
+    }
+}
+/** Attribute-name prefixes that mark the value as an Angular expression rather than a literal. */
+const BINDING_PREFIX = /^(?:\[|\(|\*|bind-|bind(?:on)?-|on-)/;
+/**
+ * Walks a template's HTML AST, collecting what the rewrite needs: the reference variables bound to a
+ * `<kbq-progress-spinner>`, the source ranges that actually hold Angular expressions, and every other name
+ * the template introduces (so a `@for` variable sharing a ref's name is not rewritten).
+ */
+class TemplateScanner {
+    constructor(template) {
+        this.template = template;
+        this.spinnerRefs = [];
+        this.otherNames = new Set();
+        this.expressions = [];
+        this.view = { start: 0, end: template.length };
+    }
+    visitElement(element) {
+        const isSpinner = element.name === migrations_progressSpinnerSignals_data.SPINNER_ELEMENT;
+        for (const attr of element.attrs ?? []) {
+            if (typeof attr.name !== 'string')
+                continue;
+            const reference = this.referenceName(attr.name);
+            if (reference !== undefined) {
+                // `#s="cdkOverlayOrigin"` names a directive on the element, not the spinner itself.
+                const exportsSpinner = !attr.value || attr.value === 'kbqProgressSpinner';
+                if (isSpinner && exportsSpinner)
+                    this.spinnerRefs.push({ name: reference, ...this.view });
+                else
+                    this.otherNames.add(reference);
+                continue;
+            }
+            // `let-item` on an <ng-template> introduces a name the refs must not collide with.
+            if (attr.name.startsWith('let-')) {
+                this.otherNames.add(attr.name.slice(4));
+                continue;
+            }
+            this.collectAttributeExpression(attr);
+        }
+        this.inView(element.name === 'ng-template' ? element.sourceSpan : undefined, () => this.visitChildren(element));
+    }
+    visitBlock(block) {
+        for (const parameter of block.parameters ?? []) {
+            const span = parameter.sourceSpan;
+            if (!span)
+                continue;
+            this.expressions.push({ start: span.start.offset, end: span.end.offset });
+            // `@for (spinner of rows; track spinner)` and `@if (x; as y)` introduce names of their own.
+            for (const match of String(parameter.expression ?? '').matchAll(/(?:^\s*|\b(?:as|let)\s+)([A-Za-z_$][\w$]*)\s*(?:\bof\b|\bin\b|=|$)/g)) {
+                this.otherNames.add(match[1]);
+            }
+        }
+        this.inView(block.sourceSpan, () => this.visitChildren(block));
+    }
+    visitText(text) {
+        const span = text.sourceSpan;
+        if (span)
+            this.collectInterpolations(span.start.offset, span.end.offset);
+    }
+    visitLetDeclaration(decl) {
+        if (decl.name)
+            this.otherNames.add(decl.name);
+        const span = decl.valueSpan ?? decl.sourceSpan;
+        if (span)
+            this.expressions.push({ start: span.start.offset, end: span.end.offset });
+    }
+    /** Runs `walk` with the embedded view narrowed to `span`, if the node opens one. */
+    inView(span, walk) {
+        if (!span) {
+            walk();
+            return;
+        }
+        const outer = this.view;
+        this.view = { start: span.start.offset, end: span.end.offset };
+        walk();
+        this.view = outer;
+    }
+    /** `#ref` / `ref-ref`, or `undefined` when the attribute is not a reference variable. */
+    referenceName(name) {
+        if (name.startsWith('#'))
+            return name.slice(1);
+        if (name.startsWith('ref-'))
+            return name.slice(4);
+        return undefined;
+    }
+    collectAttributeExpression(attr) {
+        const span = attr.valueSpan;
+        if (!span)
+            return;
+        const start = span.start.offset;
+        const end = span.end.offset;
+        // A binding's whole value is an expression; a plain attribute only holds interpolations.
+        if (BINDING_PREFIX.test(attr.name))
+            this.expressions.push({ start, end });
+        else
+            this.collectInterpolations(start, end);
+    }
+    collectInterpolations(start, end) {
+        for (const match of this.template.slice(start, end).matchAll(/\{\{([\s\S]*?)\}\}/g)) {
+            const from = start + match.index + 2;
+            this.expressions.push({ start: from, end: from + match[1].length });
+        }
+    }
+    visitChildren(node) {
+        for (const child of node.children ?? []) {
+            child.visit(this);
+        }
+    }
+    visitAttribute() { }
+    visitComment() { }
+    visitExpansion() { }
+    visitExpansionCase() { }
+    visitBlockParameter() { }
+}
+/**
+ * Matches `<ref>.<member>` inside a template expression. The lookbehind rejects `state.spinner.size`, where
+ * `\b` alone matches after the dot, and admits a `$`-prefixed ref that `\b` never could. Angular's grammar
+ * allows whitespace around the dot, so a binding wrapped over two lines is matched too. The three groups skip
+ * an already-migrated read, a signal-API call, and an assignment target that must not gain a `()`.
+ */
+function memberAccessPattern(ref, members) {
+    const methods = [...SIGNAL_API_METHODS].join('|');
+    const names = members.map(escapeRegExp).join('|');
+    return new RegExp(`(?<![\\w$.])(${escapeRegExp(ref)})\\s*\\??\\.\\s*(${names})\\b` +
+        `(?!\\s*\\()(?!\\s*\\.\\s*(?:${methods})\\b)(?!\\s*=(?!=))`, 'g');
+}
+/**
+ * Rewrites `ref.member` reads to `ref.member()`, only inside the given expression ranges. Restricting the
+ * rewrite to expressions is what keeps prose, comments and attribute names out of it.
+ */
+function rewriteRefReads(template, refs, expressions) {
+    const edits = [];
+    for (const { start, end } of expressions) {
+        const source = template.slice(start, end);
+        for (const ref of refs) {
+            if (start < ref.start || end > ref.end)
+                continue;
+            for (const match of source.matchAll(memberAccessPattern(ref.name, migrations_progressSpinnerSignals_data.SIGNAL_MEMBERS))) {
+                const at = start + match.index + match[0].length;
+                edits.push({ start: at, end: at, text: '()' });
+            }
+        }
+    }
+    return edits.length > 0
+        ? { content: applyEdits(template, edits), changed: true }
+        : { content: template, changed: false };
+}
+/** Protected members read through a spinner reference variable, which no template can keep reading. */
+function collectRefManualMembers(template, refs, expressions) {
+    const found = new Set();
+    for (const { start, end } of expressions) {
+        const source = template.slice(start, end);
+        for (const ref of refs) {
+            if (start < ref.start || end > ref.end)
+                continue;
+            const pattern = new RegExp(`(?<![\\w$.])${escapeRegExp(ref.name)}\\s*\\??\\.\\s*(${migrations_progressSpinnerSignals_data.PROTECTED_MEMBERS.map(escapeRegExp).join('|')})\\b`, 'g');
+            for (const match of source.matchAll(pattern)) {
+                found.add(match[1]);
+            }
+        }
+    }
+    return found;
+}
+const untouched = (template) => ({
+    content: template,
+    changed: false,
+    manual: new Set(),
+    unparseable: false
+});
+/** Pass B (core) — parse a template, discover spinner refs, rewrite their signal reads. */
+async function migrateTemplate(template) {
+    if (!template.includes(migrations_progressSpinnerSignals_data.SPINNER_ELEMENT))
+        return untouched(template);
+    const parsed = await utils_typescript.parseTemplate(template);
+    if (!parsed.tree)
+        return { ...untouched(template), unparseable: true };
+    const scanner = new TemplateScanner(template);
+    utils_ast.visitAll(scanner, parsed.tree.rootNodes);
+    // A ref whose name is also introduced by a `@for`, an `@let` or a foreign `#ref` is ambiguous: the
+    // reads could belong to either, so neither is rewritten.
+    const refs = scanner.spinnerRefs.filter((ref) => !scanner.otherNames.has(ref.name));
+    if (refs.length === 0)
+        return untouched(template);
+    return {
+        ...rewriteRefReads(template, refs, scanner.expressions),
+        manual: collectRefManualMembers(template, refs, scanner.expressions),
+        unparseable: false
+    };
+}
+/** Pass B (inline) — rewrite spinner ref reads inside inline component templates. */
+async function migrateInlineTemplates(content, fileName) {
+    const manual = new Set();
+    // Parsing the file to find inline templates is the expensive half, and most consumers have none.
+    if (!content.includes(migrations_progressSpinnerSignals_data.SPINNER_ELEMENT))
+        return { content, manual, unparseable: false };
+    const sourceFile = ts.createSourceFile(fileName, content, ts.ScriptTarget.Latest, true, ts.ScriptKind.TS);
+    const ranges = utils_typescript.collectInlineTemplateRanges(sourceFile).sort((a, b) => b.start - a.start);
+    let result = content;
+    let unparseable = false;
+    for (const { start, end } of ranges) {
+        const outcome = await migrateTemplate(result.slice(start, end));
+        for (const member of outcome.manual)
+            manual.add(member);
+        unparseable ||= outcome.unparseable;
+        if (outcome.changed) {
+            result = result.slice(0, start) + outcome.content + result.slice(end);
+        }
+    }
+    return { content: result, manual, unparseable };
+}
+function logWarnings(context, filePath, content) {
+    for (const { anchor, pattern, message } of migrations_progressSpinnerSignals_data.warnPatterns) {
+        if (!new RegExp(anchor).test(content) || !new RegExp(pattern).test(content))
+            continue;
+        utils_messages.logMessage(context.logger, [`${LABEL} ${filePath}`, `  ${message}`]);
+    }
+}
+/** Reports the protected members a template reads through a spinner ref. */
+function warnTemplateMembers(context, filePath, manual) {
+    if (manual.size === 0)
+        return;
+    utils_messages.logMessage(context.logger, [`${LABEL} ${filePath}`, `  ${protectedMessage(manual)}`]);
+}
+/**
+ * A `.ts` file is a spinner consumer if it names the exported symbol, imports the package, or renders the
+ * element in an inline template — a component that only imports `KbqProgressSpinnerModule` names no type.
+ */
+function referencesSpinner(content) {
+    return (/\bKbqProgressSpinner\w*\b/.test(content) ||
+        content.includes(migrations_progressSpinnerSignals_data.SPINNER_PACKAGE) ||
+        content.includes(`<${migrations_progressSpinnerSignals_data.SPINNER_ELEMENT}`));
+}
+function progressSpinnerSignals(options) {
+    return async (tree, context) => {
+        const { project } = options;
+        // `ng update` invokes migrations with no options at all, and migrations.json declares no schema,
+        // so the schema default never reaches us — applying the fix is the intended behaviour there.
+        const fix = options.fix ?? true;
+        const projectDefinition = await utils_packageConfig.setupOptions(project, tree);
+        const root = projectDefinition?.root ?? '';
+        const rootDir = root ? tree.getDir(root) : tree.root;
+        const tsPaths = [];
+        const htmlPaths = [];
+        utils_packageConfig.visitProjectFiles(rootDir, (filePath) => {
+            if (filePath.endsWith(TS_EXT))
+                tsPaths.push(filePath);
+            else if (filePath.endsWith(HTML_EXT))
+                htmlPaths.push(filePath);
+        });
+        let touched = 0;
+        let consumers = 0;
+        const commit = (filePath, original, updated) => {
+            if (updated === original)
+                return;
+            touched++;
+            if (fix) {
+                tree.overwrite(filePath, updated);
+            }
+            else {
+                utils_messages.logMessage(context.logger, [`${LABEL} would update ${filePath} (run with --fix to apply)`]);
+            }
+        };
+        const reportUnparseable = (filePath) => utils_messages.logMessage(context.logger, [`${LABEL} ${filePath}`, `  ${migrations_progressSpinnerSignals_data.UNPARSEABLE_TEMPLATE_MESSAGE}`]);
+        for (const filePath of tsPaths) {
+            const original = tree.read(filePath)?.toString();
+            if (!original || !referencesSpinner(original))
+                continue;
+            consumers++;
+            logWarnings(context, filePath, original);
+            warnReceiverMembers(context, filePath, original);
+            const content = migrateTsExpressions(original, filePath);
+            const inline = await migrateInlineTemplates(content, filePath);
+            warnTemplateMembers(context, filePath, inline.manual);
+            if (inline.unparseable)
+                reportUnparseable(filePath);
+            commit(filePath, original, inline.content);
+        }
+        for (const filePath of htmlPaths) {
+            const original = tree.read(filePath)?.toString();
+            // Counted on "renders the spinner", matching the `.ts` loop: a project whose only usage is a
+            // plain `[value]` binding in an external template still needs the summary.
+            if (!original || !original.includes(`<${migrations_progressSpinnerSignals_data.SPINNER_ELEMENT}`))
+                continue;
+            consumers++;
+            const outcome = await migrateTemplate(original);
+            warnTemplateMembers(context, filePath, outcome.manual);
+            if (outcome.unparseable)
+                reportUnparseable(filePath);
+            commit(filePath, original, outcome.content);
+        }
+        // Nothing here uses the spinner, so the summary would only be noise.
+        if (consumers === 0)
+            return;
+        utils_messages.logMessage(context.logger, [
+            `${LABEL} processed tree under "${root || '<workspace root>'}", ` +
+                `${fix ? 'updated' : 'would update'} ${touched} file(s).`,
+            ...migrations_progressSpinnerSignals_data.SUMMARY
+        ]);
+    };
+}
+
+exports.default = progressSpinnerSignals;