@kontourai/flow-agents 2.4.0 → 3.0.0

package/evals/integration/test_critique_supersession_roundtrip.sh

@@ -0,0 +1,182 @@
+#!/usr/bin/env bash
+# test_critique_supersession_roundtrip.sh — Regression evals for the trust-ledger defects
+# fixed under #267 (critique supersession), #268 (lossless, type-stable check/critique
+# round-trip), and #282 (first-class superseded_by affordance).
+#
+# Proves:
+#   (a) record-critique twice for the same id (fail → pass, SAME reviewer) supersedes the fail:
+#       the effective/live state is the pass, the historical fail is retained (status=superseded,
+#       metadata.superseded_by) but excluded from evaluation, no duplicate claim ids, and CI
+#       trust-reconcile exits 0.
+#   (b) HEADLINE: a --flow-id (builder.build/verify) session — ensure-session → record-evidence
+#       (mixed session-local kinds) → record-critique → trust-reconcile — exits 0. This exact flow
+#       could never converge before (critique claims were re-absorbed as command-less test_output
+#       checks → permanent [not-run] divergence; check kinds collapsed to the declared claimType).
+#   (c) record-evidence AFTER a critique preserves the critique history (previously hardcoded []).
+#   (d) ANTI-GAMING: a DIFFERENT reviewer cannot supersede a reviewer's fail — the disputed
+#       critique stays live and trust-reconcile still exits 1 (worker cannot bury a reviewer finding).
+#   (e) VALIDATOR (#282): a top-level pass tolerates a superseded historical fail member, but a
+#       LIVE (non-superseded) fail still triggers "required critique must pass".
+#
+# Deterministic, no model spend, self-cleaning.
+# Usage: bash evals/integration/test_critique_supersession_roundtrip.sh
+
+set -uo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+source "$ROOT/evals/lib/node.sh"
+RECON="$ROOT/scripts/ci/trust-reconcile.js"
+WRITER="workflow-sidecar"
+
+TMP="$(mktemp -d)"
+errors=0
+_pass() { echo "  PASS: $1"; }
+_fail() { echo "  FAIL: $1"; errors=$((errors + 1)); }
+cleanup() { rm -rf "$TMP"; }
+trap cleanup EXIT
+
+# seed <aroot> <slug> [flow-args...] — ensure-session + init-plan
+seed() {
+  local aroot="$1"; local slug="$2"; shift 2
+  mkdir -p "$aroot"
+  flow_agents_node "$WRITER" ensure-session --artifact-root "$aroot" --task-slug "$slug" \
+    --title "T" --summary "S" --timestamp "2026-07-01T00:00:00Z" "$@" >/dev/null 2>&1
+  flow_agents_node "$WRITER" init-plan "$aroot/$slug/$slug--deliver.md" \
+    --source-request "R" --summary "S" --timestamp "2026-07-01T00:00:00Z" >/dev/null 2>&1
+}
+
+# ─── (a) same-reviewer supersession: fail → pass ──────────────────────────────
+echo ""
+echo "=== (a) record-critique fail→pass (same reviewer) supersedes, history intact, reconcile 0 ==="
+A_AROOT="$TMP/a/aroot"; A_SLUG="supersede-same"; A_DIR="$A_AROOT/$A_SLUG"
+seed "$A_AROOT" "$A_SLUG"
+flow_agents_node "$WRITER" record-evidence "$A_DIR" --verdict pass \
+  --check-json '{"id":"c1","kind":"diff","status":"pass","summary":"diff check"}' \
+  --timestamp "2026-07-01T00:01:00Z" >/dev/null 2>&1
+flow_agents_node "$WRITER" record-critique "$A_DIR" --id rv --reviewer alice --verdict fail \
+  --summary "found a bug" --timestamp "2026-07-01T00:02:00Z" >/dev/null 2>&1
+flow_agents_node "$WRITER" record-critique "$A_DIR" --id rv --reviewer alice --verdict pass \
+  --summary "bug fixed" --timestamp "2026-07-01T00:03:00Z" >/dev/null 2>&1
+
+node - "$A_DIR/trust.bundle" << 'NODE'
+const fs = require('fs');
+const b = JSON.parse(fs.readFileSync(process.argv[2], 'utf8'));
+const crit = (b.claims||[]).filter(c => c.metadata && c.metadata.origin === 'critique');
+const live = crit.filter(c => !c.metadata.superseded_by);
+const hist = crit.filter(c => c.metadata.superseded_by);
+if (crit.length !== 2) throw new Error('expected 2 critique claims (1 live + 1 history), got ' + crit.length);
+if (live.length !== 1 || live[0].value !== 'pass') throw new Error('expected exactly 1 LIVE critique with value=pass, got ' + JSON.stringify(live.map(c=>c.value)));
+if (hist.length !== 1 || hist[0].value !== 'fail' || hist[0].status !== 'superseded') throw new Error('expected historical fail with status=superseded');
+if (!hist[0].metadata.superseded_by) throw new Error('history missing first-class metadata.superseded_by');
+const ids = (b.claims||[]).map(c=>c.id); const dup = ids.filter((x,i)=>ids.indexOf(x)!==i);
+if (dup.length) throw new Error('duplicate claim ids in bundle: ' + dup.join(','));
+console.log('live=pass, history=fail(superseded), no duplicate ids');
+NODE
+if [[ $? -eq 0 ]]; then _pass "(a) effective state=pass, historical fail retained+superseded, no dup ids"; else _fail "(a) supersession/history assertion failed"; fi
+
+TRUST_RECONCILE_COMMANDS="true" node "$RECON" --bundle "$A_DIR/trust.bundle" --repo-root "$TMP/a" >"$TMP/a-recon.log" 2>&1
+if [[ $? -eq 0 ]]; then _pass "(a) trust-reconcile exits 0 (resolved session converges)"; else _fail "(a) trust-reconcile did NOT converge: $(cat "$TMP/a-recon.log")"; fi
+
+# ─── (b) HEADLINE: --flow-id session converges ────────────────────────────────
+echo ""
+echo "=== (b) HEADLINE --flow-id builder.build/verify: mixed evidence + critique → reconcile 0 ==="
+B_AROOT="$TMP/b/aroot"; B_SLUG="flowid-converge"; B_DIR="$B_AROOT/$B_SLUG"
+seed "$B_AROOT" "$B_SLUG" --flow-id builder.build --step-id verify
+flow_agents_node "$WRITER" record-evidence "$B_DIR" --verdict pass \
+  --check-json '{"id":"k-diff","kind":"diff","status":"pass","summary":"diff excerpt"}' \
+  --check-json '{"id":"k-policy","kind":"policy","status":"pass","summary":"policy rule"}' \
+  --check-json '{"id":"k-ext","kind":"external","status":"pass","summary":"attested"}' \
+  --timestamp "2026-07-01T00:01:00Z" >/dev/null 2>&1
+flow_agents_node "$WRITER" record-critique "$B_DIR" --id code-review --reviewer alice --verdict pass \
+  --summary "looks good" --timestamp "2026-07-01T00:02:00Z" >/dev/null 2>&1
+
+node - "$B_DIR/trust.bundle" << 'NODE'
+const fs = require('fs');
+const b = JSON.parse(fs.readFileSync(process.argv[2], 'utf8'));
+// Type stability: no critique claim may be re-absorbed as a check, and check kinds/evidenceTypes
+// must survive the round-trip (a session-local kind must NOT flip to test_output).
+const checks = (b.claims||[]).filter(c => c.metadata && c.metadata.origin === 'check');
+const crit = (b.claims||[]).filter(c => c.metadata && c.metadata.origin === 'critique');
+if (crit.length !== 1) throw new Error('expected exactly 1 critique claim (no re-absorption/duplication), got ' + crit.length);
+const evByClaim = {}; for (const e of (b.evidence||[])) (evByClaim[e.claimId] ||= []).push(e);
+for (const c of checks) {
+  const ets = (evByClaim[c.id]||[]).map(e=>e.evidenceType);
+  if (ets.includes('test_output')) throw new Error('session-local check ' + c.id + ' flipped to test_output evidence (round-trip kind instability)');
+}
+console.log(checks.length + ' check claims, ' + crit.length + ' critique claim; no test_output flip');
+NODE
+if [[ $? -eq 0 ]]; then _pass "(b) round-trip type-stable under --flow-id (no critique→check absorption, no evidenceType flip)"; else _fail "(b) round-trip type instability under --flow-id"; fi
+
+TRUST_RECONCILE_COMMANDS="true" node "$RECON" --bundle "$B_DIR/trust.bundle" --repo-root "$TMP/b" >"$TMP/b-recon.log" 2>&1
+if [[ $? -eq 0 ]]; then _pass "(b) HEADLINE: --flow-id session trust-reconcile exits 0 (converges)"; else _fail "(b) HEADLINE --flow-id session did NOT converge: $(cat "$TMP/b-recon.log")"; fi
+
+# ─── (c) record-evidence after critiques preserves history ────────────────────
+echo ""
+echo "=== (c) record-evidence AFTER a critique preserves critique history (#268) ==="
+flow_agents_node "$WRITER" record-evidence "$B_DIR" --verdict pass \
+  --check-json '{"id":"k-diff2","kind":"diff","status":"pass","summary":"another diff"}' \
+  --timestamp "2026-07-01T00:04:00Z" >/dev/null 2>&1
+node - "$B_DIR/trust.bundle" << 'NODE'
+const fs = require('fs');
+const b = JSON.parse(fs.readFileSync(process.argv[2], 'utf8'));
+const crit = (b.claims||[]).filter(c => c.metadata && c.metadata.origin === 'critique');
+if (crit.length !== 1) throw new Error('critique history dropped by record-evidence — expected 1, got ' + crit.length);
+if (crit[0].value !== 'pass') throw new Error('critique value changed');
+console.log('critique survived record-evidence');
+NODE
+if [[ $? -eq 0 ]]; then _pass "(c) critique history survives a later record-evidence call"; else _fail "(c) record-evidence dropped critique history"; fi
+
+# ─── (d) ANTI-GAMING: cross-reviewer cannot supersede a reviewer fail ─────────
+echo ""
+echo "=== (d) ANTI-GAMING: a different reviewer cannot supersede a reviewer's fail ==="
+D_AROOT="$TMP/d/aroot"; D_SLUG="supersede-cross"; D_DIR="$D_AROOT/$D_SLUG"
+seed "$D_AROOT" "$D_SLUG"
+flow_agents_node "$WRITER" record-evidence "$D_DIR" --verdict pass \
+  --check-json '{"id":"c1","kind":"diff","status":"pass","summary":"diff check"}' \
+  --timestamp "2026-07-01T00:01:00Z" >/dev/null 2>&1
+flow_agents_node "$WRITER" record-critique "$D_DIR" --id rv --reviewer reviewer-bob --verdict fail \
+  --summary "reviewer found a real bug" --timestamp "2026-07-01T00:02:00Z" >/dev/null 2>&1
+flow_agents_node "$WRITER" record-critique "$D_DIR" --id rv --reviewer worker-mallory --verdict pass \
+  --summary "worker claims fixed" --timestamp "2026-07-01T00:03:00Z" >/dev/null 2>&1
+node - "$D_DIR/trust.bundle" << 'NODE'
+const fs = require('fs');
+const b = JSON.parse(fs.readFileSync(process.argv[2], 'utf8'));
+const crit = (b.claims||[]).filter(c => c.metadata && c.metadata.origin === 'critique');
+const live = crit.filter(c => !c.metadata.superseded_by);
+const liveFail = live.filter(c => c.value === 'fail' || c.status === 'disputed');
+if (!liveFail.length) throw new Error('ANTI-GAMING VIOLATION: reviewer fail was superseded by a different reviewer');
+if (crit.some(c => c.metadata.superseded_by)) throw new Error('unexpected supersession across reviewers');
+console.log('reviewer fail stays LIVE (' + liveFail.length + '); cross-reviewer supersession refused');
+NODE
+if [[ $? -eq 0 ]]; then _pass "(d) reviewer's fail is NOT superseded by a different reviewer (stays live)"; else _fail "(d) ANTI-GAMING regression: cross-reviewer supersession occurred"; fi
+TRUST_RECONCILE_COMMANDS="true" node "$RECON" --bundle "$D_DIR/trust.bundle" --repo-root "$TMP/d" >"$TMP/d-recon.log" 2>&1
+if [[ $? -ne 0 ]] && grep -q "session-local-failed" "$TMP/d-recon.log"; then _pass "(d) trust-reconcile still exits 1 (live disputed critique blocks)"; else _fail "(d) reconcile should have blocked on the live reviewer fail"; fi
+
+# ─── (e) VALIDATOR (#282): superseded fail tolerated, live fail blocks ────────
+echo ""
+echo "=== (e) VALIDATOR: superseded historical fail tolerated; live fail blocks (#282) ==="
+# Reuse (a)'s superseded bundle: pass top-level with a superseded fail member.
+va_out="$(flow_agents_node validate-workflow-artifacts "$A_AROOT" --require-sidecars --require-critique 2>&1)"
+if echo "$va_out" | grep -q "required critique must pass"; then
+  _fail "(e) validator wrongly rejected a superseded historical fail"
+else
+  _pass "(e) validator tolerates a superseded historical fail member (no 'required critique must pass')"
+fi
+# Live fail (d's cross-reviewer bundle has a live disputed critique) must still be rejected.
+vd_out="$(flow_agents_node validate-workflow-artifacts "$D_AROOT" --require-sidecars --require-critique 2>&1)"
+if echo "$vd_out" | grep -q "required critique must pass"; then
+  _pass "(e) validator still rejects a LIVE (non-superseded) fail critique"
+else
+  _fail "(e) validator failed to reject a live fail critique"
+fi
+
+# ─── Summary ──────────────────────────────────────────────────────────────────
+echo ""
+echo "────────────────────────────────────────────"
+if [[ $errors -eq 0 ]]; then
+  echo "test_critique_supersession_roundtrip: all checks passed."
+  exit 0
+else
+  echo "test_critique_supersession_roundtrip: $errors check(s) failed."
+  exit 1
+fi

package/evals/integration/test_fixture_retirement_audit.sh

@@ -21,9 +21,9 @@ json_query() {
   node -e 'const fs=require("fs"); let cur=JSON.parse(fs.readFileSync(process.argv[1],"utf8")); for (const part of process.argv[2].split(".")) cur=Array.isArray(cur) ? cur[Number(part)] : cur[part]; console.log(cur);' "$1" "$2"
 }
 
-[[ "$(json_query "$TMPDIR_EVAL/audit.json" "totals.scanned")" == "14" ]] && pass "audit scans all fixture groups" || fail "audit scans all fixture groups"
+[[ "$(json_query "$TMPDIR_EVAL/audit.json" "totals.scanned")" == "15" ]] && pass "audit scans all fixture groups" || fail "audit scans all fixture groups"
 [[ "$(json_query "$TMPDIR_EVAL/audit.json" "totals.retire_candidates")" == "0" ]] && pass "audit finds no unowned retire candidates" || fail "audit finds no unowned retire candidates"
-[[ "$(json_query "$TMPDIR_EVAL/audit.json" "totals.kept")" == "14" ]] && pass "audit keeps all owned fixture groups" || fail "audit keeps all owned fixture groups"
+[[ "$(json_query "$TMPDIR_EVAL/audit.json" "totals.kept")" == "15" ]] && pass "audit keeps all owned fixture groups" || fail "audit keeps all owned fixture groups"
 
 node - "$TMPDIR_EVAL/audit.json" <<'NODE'
 const fs = require("node:fs");

package/evals/integration/test_publish_delivery.sh

@@ -4,8 +4,10 @@
 # Proves that:
 #   1. END-TO-END-RECORD-RELEASE: record-release auto-publishes trust.bundle.
 #   2. SUBCOMMAND: publish-delivery subcommand copies bundle to delivery/.
-#   3. RECONCILE-DIVERGENCE: delivery trust.bundle + CI fail -> exit 1.
-#   4. RECONCILE-MATCHING: delivery trust.bundle + CI pass -> exit 0.
+#   3. RECONCILE-DIVERGENCE: delivery trust.bundle (+ matching-sha checkpoint sibling, ADR
+#      0022 addendum part 2 bundle-ownership binding) + CI fail -> exit 1.
+#   4. RECONCILE-MATCHING: delivery trust.bundle (+ matching-sha checkpoint sibling) + CI
+#      pass -> exit 0.
 #   5. FAIL-SOFT: no trust.bundle -> publishDelivery skips, record-release exits 0.
 #
 # Deterministic, no model spend, self-cleaning.
@@ -63,6 +65,19 @@ PY
   node "$helper" "$dest" "$label" "$passing"
 }
 
+# write_checkpoint_to <delivery_dir> <sha>
+# Writes a minimal, well-formed trust.checkpoint.json naming <sha> as commit_sha, so a
+# bare fixture trust.bundle written directly into delivery/ (TEST 3/4 below -- these do
+# NOT go through the real seal-checkpoint pipeline) still carries the commit-identity
+# binding trust-reconcile.js's bundle-ownership staleness check now requires (ADR 0022
+# addendum, part 2) for an auto-discovered bundle to be treated as owned by the change
+# under test, not stale.
+write_checkpoint_to() {
+  local delivery_dir="$1" sha="$2"
+  printf '{"schema_version":"1.0","slug":"publish-delivery-fixture","work_item":null,"status":"delivered","phase":"release","sealed_at":"2026-06-27T00:00:00Z","commit_sha":"%s","checkpoint":{"asOf":"2026-06-27T00:00:00.000Z","statusByClaimId":{}}}' \
+    "$sha" > "$delivery_dir/trust.checkpoint.json"
+}
+
 # Session setup helper
 setup_session() {
   local aroot="$1" slug="$2" bundle_src="$3"
@@ -181,8 +196,9 @@ mkdir -p "$REPO3/delivery"
 # -> claimed cmd not in canonical set -> not-run divergence, AND canonical fails
 DELIVERY3="$REPO3/delivery/trust.bundle"
 write_bundle_to "$DELIVERY3" "node --version" "true"
+write_checkpoint_to "$REPO3/delivery" "1111111111111111111111111111111111111111"
 
-recon3_out=$(TRUST_RECONCILE_COMMANDS="false" \
+recon3_out=$(TRUST_RECONCILE_SHA="1111111111111111111111111111111111111111" TRUST_RECONCILE_COMMANDS="false" \
   node "$RECONCILE" --repo-root "$REPO3" 2>&1)
 recon3_exit=$?
 
@@ -208,8 +224,9 @@ mkdir -p "$REPO4/delivery"
 # Bundle claims "node --version" passed; canonical verify is ALSO "node --version" (passes)
 DELIVERY4="$REPO4/delivery/trust.bundle"
 write_bundle_to "$DELIVERY4" "node --version" "true"
+write_checkpoint_to "$REPO4/delivery" "2222222222222222222222222222222222222222"
 
-recon4_out=$(TRUST_RECONCILE_COMMANDS="node --version" \
+recon4_out=$(TRUST_RECONCILE_SHA="2222222222222222222222222222222222222222" TRUST_RECONCILE_COMMANDS="node --version" \
   node "$RECONCILE" --repo-root "$REPO4" 2>&1)
 recon4_exit=$?
 

package/evals/integration/test_pull_work_assignment_join.sh

@@ -0,0 +1,132 @@
+#!/usr/bin/env bash
+# test_pull_work_assignment_join.sh — Two-session disjoint-selection simulation (#290).
+#
+# HONESTY NOTE (plan Design Decision / Stop-Short Risks): this eval simulates the assignment ⋈
+# liveness join's exclusion property with two actor structs evaluating the same candidate
+# subject id fixture in sequence, inside ONE process. It does NOT stand up two real concurrent
+# agent runtimes, and does not prove true concurrency (a real race between two simultaneous
+# writers). It is the closest *local* proof available for the issue's literal acceptance line
+# ("two sessions running pull-work against the same backlog select disjoint issues") without a
+# multi-runtime test harness this repo does not have — see the plan's Stop-Short Risks section.
+# What IS proven here, deterministically: once session A's assignment claim is recorded (local-
+# file or a rendered-then-status-confirmed GitHub fixture), session B's subsequent
+# `assignment-provider status` / join check for the SAME subject reports it `held` (excluded),
+# never `free` — so `pull-work`'s selection loop (kits/builder/skills/pull-work/SKILL.md,
+# "### 1. Read Board State") would skip it for session B.
+#
+# Supports AC12 (disjoint-selection-simulated), AC10 (docs pointer — see
+# docs/workflow-usage-guide.md's new Assignment Ownership subsection).
+set -uo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+CLI="$ROOT/build/src/cli.js"
+FIXTURES="$ROOT/evals/fixtures/assignment-provider"
+ACTOR_A="$FIXTURES/actor-a.json"
+ACTOR_B="$FIXTURES/actor-b.json"
+ISSUE_CLAIMED="$FIXTURES/github-issue-claimed.json"
+LIVENESS_FRESH="$FIXTURES/liveness-fresh.json"
+
+TMPDIR_EVAL="$(mktemp -d)"
+trap 'rm -rf "$TMPDIR_EVAL"' EXIT
+ARTIFACT_ROOT="$TMPDIR_EVAL/artifact-root"
+
+errors=0
+pass() { echo "  ✓ $1"; }
+fail() { echo "  ✗ $1"; errors=$((errors + 1)); }
+
+json_query() {
+  node -e 'const fs=require("fs"); let cur=JSON.parse(fs.readFileSync(process.argv[1],"utf8")); for (const part of process.argv[2].split(".")) cur=part==="length" ? cur.length : (Array.isArray(cur) ? cur[Number(part)] : cur[part]); console.log(cur);' "$1" "$2"
+}
+
+if [[ ! -f "$CLI" ]]; then
+  echo "build/src/cli.js not found — run 'npm run build' first" >&2
+  exit 1
+fi
+
+echo "=== Two-session disjoint-selection simulation (assignment ⋈ liveness join) ==="
+
+EMPTY_LIVENESS="$TMPDIR_EVAL/liveness-empty.json"
+echo '[]' > "$EMPTY_LIVENESS"
+
+# --- local-file leg: session A claims, session B's join check on the same subject is excluded ---
+
+SUBJECT_ID="kontourai/flow-agents#9301"
+
+# "Session A" (actor A) evaluates the candidate subject before anyone has claimed it: free.
+node "$CLI" assignment-provider status \
+  --provider local-file --artifact-root "$ARTIFACT_ROOT" --subject-id "$SUBJECT_ID" \
+  --self-actor "claude-code:eval-actor-a-session:eval-host" --liveness-events-json "$EMPTY_LIVENESS" \
+  > "$TMPDIR_EVAL/session-a-preclaim.json"
+[[ "$(json_query "$TMPDIR_EVAL/session-a-preclaim.json" "effective.effective_state")" == "free" ]] && pass "local-file: candidate subject is free before either session claims" || fail "local-file: candidate subject is free before either session claims"
+
+# Session A selects and claims it (pull-work's "Assignment Claim On Selection" step).
+node "$CLI" assignment-provider claim \
+  --provider local-file --artifact-root "$ARTIFACT_ROOT" --subject-id "$SUBJECT_ID" \
+  --actor-json "$ACTOR_A" --branch "agent/claude-code-eval-actor-a-session-eval-host/flow-agents-9301" \
+  --artifact-dir ".kontourai/flow-agents/flow-agents-9301" > /dev/null
+status=$?
+[[ "$status" -eq 0 ]] && pass "local-file: session A's claim on the candidate subject succeeds" || fail "local-file: session A's claim on the candidate subject succeeds"
+
+# "Session B" (actor B, a distinct actor struct — the second concurrent pull-work session)
+# evaluates the SAME candidate subject next. Its own liveness heartbeat is fresh (it is alive),
+# but that must not matter: the join is computed against the HOLDER's freshness, not the
+# reader's — session B must see the subject excluded.
+NOW_ISO="$(date -u +%Y-%m-%dT%H:%M:%SZ)"
+cat > "$TMPDIR_EVAL/liveness-actor-a-fresh.json" <<JSON
+[
+  {"type":"claim","subjectId":"$SUBJECT_ID","actor":"claude-code:eval-actor-a-session:eval-host","at":"$NOW_ISO","ttlSeconds":1800}
+]
+JSON
+node "$CLI" assignment-provider status \
+  --provider local-file --artifact-root "$ARTIFACT_ROOT" --subject-id "$SUBJECT_ID" \
+  --self-actor "claude-code:eval-actor-b-session:eval-host" \
+  --liveness-events-json "$TMPDIR_EVAL/liveness-actor-a-fresh.json" > "$TMPDIR_EVAL/session-b-postclaim.json"
+[[ "$(json_query "$TMPDIR_EVAL/session-b-postclaim.json" "assignment.assignee")" == "claude-code:eval-actor-a-session:eval-host" ]] && pass "local-file: session B's status read shows actor A as the holder" || fail "local-file: session B's status read shows actor A as the holder"
+[[ "$(json_query "$TMPDIR_EVAL/session-b-postclaim.json" "effective.effective_state")" == "held" ]] && pass "local-file: session B's join check reports held (excluded) for the same subject session A just claimed" || fail "local-file: session B's join check reports held (excluded) for the same subject session A just claimed"
+[[ "$(json_query "$TMPDIR_EVAL/session-b-postclaim.json" "effective.effective_state")" != "free" ]] && pass "local-file: subject is definitively NOT free for session B (disjoint selection holds)" || fail "local-file: subject is definitively NOT free for session B (disjoint selection holds)"
+
+# Session B, correctly excluding the held subject, selects a DIFFERENT subject instead — the
+# literal "select disjoint issues" property, one selection loop iteration at a time.
+SUBJECT_ID_2="kontourai/flow-agents#9302"
+node "$CLI" assignment-provider status \
+  --provider local-file --artifact-root "$ARTIFACT_ROOT" --subject-id "$SUBJECT_ID_2" \
+  --self-actor "claude-code:eval-actor-b-session:eval-host" --liveness-events-json "$EMPTY_LIVENESS" \
+  > "$TMPDIR_EVAL/session-b-alternate.json"
+[[ "$(json_query "$TMPDIR_EVAL/session-b-alternate.json" "effective.effective_state")" == "free" ]] && pass "local-file: session B's alternate candidate is free — it can select a disjoint subject" || fail "local-file: session B's alternate candidate is free — it can select a disjoint subject"
+node "$CLI" assignment-provider claim \
+  --provider local-file --artifact-root "$ARTIFACT_ROOT" --subject-id "$SUBJECT_ID_2" \
+  --actor-json "$ACTOR_B" --branch "agent/claude-code-eval-actor-b-session-eval-host/flow-agents-9302" \
+  --artifact-dir ".kontourai/flow-agents/flow-agents-9302" > /dev/null
+[[ $? -eq 0 ]] && pass "local-file: session B claims the disjoint subject successfully" || fail "local-file: session B claims the disjoint subject successfully"
+
+# Final proof: the two sessions' claimed subject sets are disjoint.
+node "$CLI" assignment-provider list --provider local-file --artifact-root "$ARTIFACT_ROOT" --actor-json "$ACTOR_A" > "$TMPDIR_EVAL/list-a.json"
+node "$CLI" assignment-provider list --provider local-file --artifact-root "$ARTIFACT_ROOT" --actor-json "$ACTOR_B" > "$TMPDIR_EVAL/list-b.json"
+DISJOINT="$(node -e '
+const fs = require("fs");
+const a = JSON.parse(fs.readFileSync(process.argv[1], "utf8")).subject_ids;
+const b = JSON.parse(fs.readFileSync(process.argv[2], "utf8")).subject_ids;
+const overlap = a.filter((id) => b.includes(id));
+console.log(overlap.length === 0 && a.length === 1 && b.length === 1 ? "yes" : "no");
+' "$TMPDIR_EVAL/list-a.json" "$TMPDIR_EVAL/list-b.json")"
+[[ "$DISJOINT" == "yes" ]] && pass "session A and session B's claimed subject sets are disjoint (one each, no overlap)" || fail "session A and session B's claimed subject sets are disjoint (one each, no overlap)"
+
+# --- GitHub leg: a rendered-and-status-confirmed claim on a fixture also excludes a second reader ---
+
+# The already-claimed GitHub fixture stands in for "session A already claimed and the render
+# was executed + status-confirmed" (SKILL.md's "Assignment Claim On Selection" round trip).
+# "Session B" reads the SAME fixture next with a fresh liveness fixture for the holder: held.
+node "$CLI" assignment-provider status --provider github --issue-json "$ISSUE_CLAIMED" \
+  --self-actor "claude-code:eval-actor-b-session:eval-host" \
+  --liveness-events-json "$LIVENESS_FRESH" --now "2026-06-01T12:20:00Z" \
+  > "$TMPDIR_EVAL/github-session-b.json"
+[[ "$(json_query "$TMPDIR_EVAL/github-session-b.json" "effective.effective_state")" == "held" ]] && pass "github: session B's join check on an already-claimed fixture issue reports held (excluded)" || fail "github: session B's join check on an already-claimed fixture issue reports held (excluded)"
+[[ "$(json_query "$TMPDIR_EVAL/github-session-b.json" "effective.effective_state")" != "free" ]] && pass "github: subject is definitively NOT free for session B" || fail "github: subject is definitively NOT free for session B"
+
+echo ""
+if [[ "$errors" -eq 0 ]]; then
+  echo "test_pull_work_assignment_join: all checks passed."
+else
+  echo "test_pull_work_assignment_join: $errors check(s) failed."
+fi
+exit "$errors"

package/evals/integration/test_pull_work_liveness_preflight.sh

@@ -329,7 +329,7 @@ require_text "$PULL" 'liveness claim <subjectId>' "pull-work references liveness
 require_text "$PULL" 'reading each row.s raw .status. field \(never .label.\)' "pull-work instructs consuming raw status, never label (AC1, AC8)"
 require_text "$PULL" 'a .verified. row for an actor other than self.*.held.' "pull-work documents held classification (AC1, AC2, AC8)"
 require_text "$PULL" 'excluded from the ready set by default' "pull-work excludes held candidates by default (AC2, AC8)"
-require_text "$PULL" 'a .stale. row \(any actor\).*.reclaimable.' "pull-work documents reclaimable classification (AC1, AC3, AC8)"
+require_text "$PULL" 'effective_state: .reclaimable.' "pull-work documents reclaimable classification via the assignment-provider join (AC1, AC3, AC8, #290)"
 require_text "$PULL" 'requires an explicit recorded opt-in' "pull-work requires an explicit recorded opt-in for reclaimable selection (AC3, AC8)"
 require_text "$PULL" 'never a silent normal pick' "pull-work states reclaimable is never a silent normal pick (AC3, AC8)"
 require_text "$PULL" 'a .verified. row for the resolved self actor.*.mine.' "pull-work documents mine classification (AC1, AC5, AC8)"
@@ -348,10 +348,15 @@ require_text "$PICKUP_PROBE" 'flags the selected item .reclaimable., treat the r
 # ─── F2-F6 (fix-plan iteration 1) static assertions ─────────────────────────
 require_text "$PULL" 'group all rows for that .subjectId. by subject' "pull-work classifies per-subject (grouped rows), not per-row (F2, AC1, AC8)"
 require_text "$PULL" 'classify in this precedence order' "pull-work states the classification is an ordered precedence rule (F2, AC8)"
-require_text "$PULL" '^1\. a .verified. row for an actor other than self' "pull-work's precedence rule step 1 (held) is numbered verbatim (F2, AC8)"
-require_text "$PULL" '^2\. else, a .verified. row for the resolved self actor' "pull-work's precedence rule step 2 (mine) is numbered verbatim (F2, AC8)"
-require_text "$PULL" '^3\. else, a .stale. row' "pull-work's precedence rule step 3 (reclaimable) is numbered verbatim (F2, AC8)"
-require_text "$PULL" '^4\. else \(a .revoked.-only row' "pull-work's precedence rule step 4 (free) is numbered verbatim (F2, AC8)"
+# F2's original numbered precedence list was liveness-only (#166); #290 (Wave 3) replaced it with
+# the full ADR 0021 §1 assignment ⋈ liveness join, computed via `assignment-provider status`'s
+# `effective_state`/`reason` fields. These assertions are updated to match the new five-row list
+# (mine/held/reclaimable/human-held/free) rather than the old four-row liveness-only list.
+require_text "$PULL" '^1\. .effective_state: .held.. with .reason: .self_is_holder..' "pull-work's precedence rule step 1 (mine, via self_is_holder) is numbered verbatim (F2, #290, AC8)"
+require_text "$PULL" '^2\. else .effective_state: .held..' "pull-work's precedence rule step 2 (held, excluded) is numbered verbatim (F2, #290, AC8)"
+require_text "$PULL" '^3\. else .effective_state: .reclaimable..' "pull-work's precedence rule step 3 (reclaimable) is numbered verbatim (F2, #290, AC8)"
+require_text "$PULL" '^4\. else .effective_state: .human-held..' "pull-work's precedence rule step 4 (human-held) is numbered verbatim (F2, #290, AC11, AC8)"
+require_text "$PULL" '^5\. else .effective_state: .free..' "pull-work's precedence rule step 5 (free) is numbered verbatim (F2, #290, AC8)"
 require_text "$PULL" 'double-hold' "pull-work names the own-actor + other-actor co-existing row combination a double-hold (F2, AC8)"
 require_text "$PULL" 'explicit conflict warning \(per ADR 0012 §4 detection' "pull-work cites ADR 0012 §4 detection for the double-hold conflict warning (F2, AC8)"
 require_text "$PULL" 'never silently resolve it to .mine.' "pull-work states a double-hold is never silently resolved to mine (F2, AC8)"
@@ -373,7 +378,10 @@ require_text "$PULL" '### Post-Claim Conflict Re-check' "pull-work documents the
 require_text "$PULL" 'coexists with this session.s own just-emitted claim on the same subject' "pull-work's post-claim re-check detects a double-hold against the just-emitted claim (F6, AC8)"
 require_text "$PULL" 'surface the conflict prominently in the user-facing output and instruct the user to coordinate before proceeding' "pull-work instructs surfacing the post-claim conflict prominently and coordinating before proceeding, not silently continuing (F6, AC8)"
 require_text "$PULL" 'does not provide true mutual exclusion across the read-then-write race window itself' "pull-work's honesty note states the exclusion guarantee still does not provide true mutual exclusion across the read-then-write race window (F6, AC8; updated #320 wording — see also test_liveness_verdict.sh)"
-require_text "$PULL" 'True mutual exclusion arrives with the provider assignment lease \(#290\) and the .verify-hold. publish gate \(#293\)' "pull-work names #290/#293 as where true mutual exclusion actually arrives (F6, AC8)"
+require_text "$PULL" '.#290.\x27s provider assignment lease closes this gap for the .{0,2}local-file.{0,2} provider only' "pull-work scopes true mutual exclusion to the local-file provider only, via #290's lock (fix-plan iteration 1, F5, AC8)"
+require_text "$PULL" 'two concurrent local-file .claim. calls on the same subject genuinely cannot both win' "pull-work states local-file claim/claim races genuinely cannot both win under #290's lock (fix-plan iteration 1, F5, AC8)"
+require_text "$PULL" 'The .{0,2}GitHub.{0,2} provider \(assignee/label/claim-comment\) remains advisory/last-writer' "pull-work does NOT overclaim true mutual exclusion for the GitHub provider — advisory/last-writer, detect not prevent (fix-plan iteration 1, F5, AC8)"
+require_text "$PULL" 'Do not read .provider assignment lease. as closing the GitHub race; only the .verify-hold. publish gate \(#293\)' "pull-work explicitly warns not to read #290 as closing the GitHub race — only #293's verify-hold gate would (fix-plan iteration 1, F5, AC8)"
 
 
 echo ""

package/evals/integration/test_reconcile_soundness.sh

@@ -9,8 +9,13 @@
 #  B. REAL-VERIFY-CLOSED:     build passes but a fake "real verify" (eval:static substitute)
 #     fails → trust-reconcile exits 1 (PRE-FIX this would exit 0 because only build ran).
 #
-#  C. REAL-VERIFY-PASSES:     the comprehensive verify resolves green → exits 0 (legit
-#     work is not false-blocked when package.json trust-reconcile-verify is present).
+#  C. REAL-VERIFY-PASSES:     the comprehensive verify resolves green, no bundle, but a
+#     well-formed in-scope delivery/DECLARED marker exempts Step 2 (ADR 0022 §1) → exits 0
+#     with the DECLARED (no-agent-delivery) line (legit work is not false-blocked; the
+#     bundle-absence branch is bundle-required by default post-ADR-0022, so this case is
+#     now anchored by a DECLARED marker rather than by bundle absence alone — see
+#     evals/integration/test_trust_reconcile_negatives.sh section 7 for the no-marker /
+#     out-of-scope-marker fail-closed cases this test does NOT re-cover).
 #
 #  D. CHECKPOINT-BYPASS-CLOSED: a checkpoint-only bundle (no evidence/claims, statusByClaimId
 #     all-passed) → exits 1 with checkpoint-bypass divergence (not a silent skip).
@@ -56,8 +61,14 @@ fs.writeFileSync('$PKG_NO_VERIFY/package.json', JSON.stringify(pkg, null, 2));
 "
 
 # ─── Minimal package.json WITH trust-reconcile-verify ─────────────────────────
+# ADR 0022 §1 (bundle-required by default): no bundle is written for this fixture, so a
+# well-formed, in-scope delivery/DECLARED marker (ADR 0022 §2) is seeded alongside it —
+# this is the new legitimate no-bundle path (a real human/bot PR author with no agent
+# delivery), preserving TEST C's original "no bundle" shape more faithfully than
+# switching it to a --bundle fixture would (a bundle would test Step 2 reconcile, which
+# TEST C was never about — it proves Step 1 fresh-verify success is honored).
 PKG_WITH_VERIFY="$TMP/pkg_with_verify"
-mkdir -p "$PKG_WITH_VERIFY"
+mkdir -p "$PKG_WITH_VERIFY/delivery"
 node -e "
 const fs = require('fs');
 const pkg = {
@@ -68,6 +79,13 @@ const pkg = {
   }
 };
 fs.writeFileSync('$PKG_WITH_VERIFY/package.json', JSON.stringify(pkg, null, 2));
+const declared = {
+  scope: 'ref:test-verify-passes',
+  reason: 'test fixture: real verify passes, no agent delivery bundle',
+  approved_by: 'test-harness',
+  declared_at: '2026-06-27T00:00:00Z'
+};
+fs.writeFileSync('$PKG_WITH_VERIFY/delivery/DECLARED', JSON.stringify(declared, null, 2));
 "
 
 # ─── Minimal package.json with failing verify ─────────────────────────────────
@@ -255,22 +273,28 @@ fi
 # package.json has passing trust-reconcile-verify → exits 0 (not false-blocked)
 # ═══════════════════════════════════════════════════════════════════════════════
 echo ""
-echo "=== TEST C: REAL-VERIFY-PASSES — passing verify + no bundle → exits 0 ==="
+echo "=== TEST C: REAL-VERIFY-PASSES — passing verify + in-scope delivery/DECLARED marker (no bundle) → exits 0 with DECLARED exemption ==="
 
-outC=$(node "$RECONCILE" \
+outC=$(TRUST_RECONCILE_REF="test-verify-passes" node "$RECONCILE" \
     --repo-root "$PKG_WITH_VERIFY" 2>&1)
 exitC=$?
 
 if [[ $exitC -eq 0 ]]; then
-  _pass "REAL-VERIFY-PASSES: exits 0 when real verify passes and no bundle (got $exitC)"
+  _pass "REAL-VERIFY-PASSES: exits 0 when real verify passes and a well-formed, in-scope delivery/DECLARED marker exempts Step 2 (got $exitC)"
 else
   _fail "REAL-VERIFY-PASSES: expected exit 0, got $exitC — output: $outC"
 fi
 
-if echo "$outC" | grep -q "fresh verify passed"; then
-  _pass "REAL-VERIFY-PASSES: 'fresh verify passed' message present"
+if echo "$outC" | grep -qF "DECLARED (no-agent-delivery): ref:test-verify-passes — test fixture: real verify passes, no agent delivery bundle (approved by test-harness, declared 2026-06-27T00:00:00Z)"; then
+  _pass "REAL-VERIFY-PASSES: exact DECLARED (no-agent-delivery) exemption line present"
+else
+  _fail "REAL-VERIFY-PASSES: expected the exact DECLARED (no-agent-delivery) line, got: $outC"
+fi
+
+if echo "$outC" | grep -q "running: npm run trust-reconcile-verify"; then
+  _pass "REAL-VERIFY-PASSES: Step 1 (fresh verify) still ran the real trust-reconcile-verify command (not skipped by the exemption)"
 else
-  _fail "REAL-VERIFY-PASSES: expected 'fresh verify passed' in output, got: $outC"
+  _fail "REAL-VERIFY-PASSES: expected Step 1 to have run 'npm run trust-reconcile-verify', got: $outC"
 fi
 
 # ═══════════════════════════════════════════════════════════════════════════════

package/evals/integration/test_trust_reconcile.sh

@@ -6,8 +6,9 @@
 #      Exit 1 with "trust divergence" message naming the command.
 #   2. MATCHING-PASSES:    bundle claims a command passed; CI re-runs it and it PASSES.
 #      Exit 0 (no divergence).
-#   3. NO-CHECKPOINT:      no bundle present; canonical verify passes.
-#      Exit 0 (fail-open on bundle absence, enforce fresh verify only).
+#   3. NO-CHECKPOINT:      no bundle present, no delivery/DECLARED marker; canonical
+#      verify passes. Exit 1 — bundle required by default (ADR 0022 §1); the
+#      'bundle-required-no-declared-marker' issue fires (no more fail-open on absence).
 #   4. LAUNDERING-CAUGHT:  bundle claims "something || true" passed.
 #      Exit 1 with laundering message (checked before "CI never ran" check).
 #   YAML-VALID:            .github/workflows/trust-reconcile.yml parses as valid YAML.
@@ -158,16 +159,16 @@ out3=$(TRUST_RECONCILE_COMMANDS="node -e 'process.exit(0)'" \
     --repo-root "$TMP" 2>&1)
 exit3=$?
 
-if [[ $exit3 -eq 0 ]]; then
-  _pass "NO-CHECKPOINT: exits 0 (fresh verify passes, no bundle)"
+if [[ $exit3 -ne 0 ]]; then
+  _pass "NO-CHECKPOINT: exits 1 (bundle required by default, no bundle, no marker) — got $exit3"
 else
-  _fail "NO-CHECKPOINT: expected exit 0, got $exit3 — output: $out3"
+  _fail "NO-CHECKPOINT: expected exit 1 (bundle-required by default, ADR 0022 §1), got 0 — output: $out3"
 fi
 
-if echo "$out3" | grep -q "fail-open"; then
-  _pass "NO-CHECKPOINT: output notes fail-open on bundle absence"
+if echo "$out3" | grep -q "bundle-required-no-declared-marker"; then
+  _pass "NO-CHECKPOINT: output contains 'bundle-required-no-declared-marker'"
 else
-  _fail "NO-CHECKPOINT: expected 'fail-open' in output, got: $out3"
+  _fail "NO-CHECKPOINT: expected 'bundle-required-no-declared-marker' in output, got: $out3"
 fi
 
 # Also verify: no-bundle + failing fresh verify still exits 1