@konfuzio/document-validation-ui 0.1.17-dev.1 → 0.1.17-dev.2

package/src/components/DocumentEdit/DocumentEdit.cy.js

@@ -137,7 +137,7 @@ describe("Document Edit", () => {
       const pages = $document.selectedDocument.pages;
       const pagesLength = pages.length;
 
-      if (!$document.selectedDocument.proposed_split) {
+      if (!$document.selectedDocument.proposed_split && $document.pages.length > 1) {
         cy.get("#document-edit")
           .find(".pages-section")
           .find(".image-section")
@@ -154,27 +154,29 @@ describe("Document Edit", () => {
 
   it("Clicking splitting lines creates new documents", () => {
     cy.getStore("document").then(($document) => {
-      if ($document.selectedDocument.proposed_split) {
+      if ($document.pages.length > 1) {
+        if ($document.selectedDocument.proposed_split) {
+          cy.get("#document-edit")
+            .find(".sidebar")
+            .find(".smart-split")
+            .find(".split-switch")
+            .click();
+
+          cy.wait(1000);
+        }
+
         cy.get("#document-edit")
-          .find(".sidebar")
-          .find(".smart-split")
-          .find(".split-switch")
+          .find(".pages-section")
+          .find(".image-section")
+          .find(".splitting-lines")
+          .find(".lines")
+          .first()
           .click();
 
-        cy.wait(1000);
+        cy.getStore("edit").then(($edit) => {
+          expect($edit.updatedDocument).to.have.lengthOf(2);
+        });
       }
-
-      cy.get("#document-edit")
-        .find(".pages-section")
-        .find(".image-section")
-        .find(".splitting-lines")
-        .find(".lines")
-        .first()
-        .click();
-
-      cy.getStore("edit").then(($edit) => {
-        expect($edit.updatedDocument).to.have.lengthOf(2);
-      });
     });
   });
 

package/src/components/DocumentPage/DocumentPage.vue

@@ -154,6 +154,7 @@ export default {
 
   computed: {
     ...mapState("display", ["currentPage", "showAnnSetTable"]),
+    ...mapGetters("document", ["isNegative"]),
 
     isBoxSelection() {
       return this.selection && !this.isSelecting && this.isElementSelected;
@@ -231,7 +232,7 @@ export default {
           if (
             annotation.span.find(
               (span) => span.page_index + 1 === this.page.number
-            )
+            ) && !this.isNegative(annotation)
           ) {
             annotations.push(annotation);
           }

package/src/locales/de.json

@@ -140,5 +140,8 @@
   "link_to_add_labels": "Sehen Sie <a href='https://help.konfuzio.com/modules/labels/index.html#add-a-label' target='_blank'>hier</a>, wie Sie sie hinzufügen.",
   "no_annotations_in_annotation_set": "Dieser Annotationssatz enthält keine extrahierten Annotationen für die jeweiligen Beschriftungen.",
   "wait_title": "Bitte warten...",
-  "redirecting_to_documents_list": "Wir führen Sie zur Dokumentenliste, sodass Sie Ihre Dokumente weiter überprüfen können, während wir die vorgenommenen Änderungen verarbeiten."
+  "redirecting_to_documents_list": "Wir führen Sie zur Dokumentenliste, sodass Sie Ihre Dokumente weiter überprüfen können, während wir die vorgenommenen Änderungen verarbeiten.",
+  "translated_string_title": "Übersetzter Text",
+  "no_translated_string": "Es existiert noch keine Übersetzung.",
+  "add_translation": "Eins hinzufügen"
 }

package/src/locales/en.json

@@ -140,5 +140,8 @@
   "link_to_add_labels": "See how to add them <a href='https://help.konfuzio.com/modules/labels/index.html#add-a-label' target='_blank'>here</a>.",
   "no_annotations_in_annotation_set": "This annotation set has no annotations extracted for its respective labels.",
   "wait_title": "Please wait...",
-  "redirecting_to_documents_list": "We are taking you to the documents list, so you can continue reviewing your documents while we process the changes made."
+  "redirecting_to_documents_list": "We are taking you to the documents list, so you can continue reviewing your documents while we process the changes made.",
+  "translated_string_title": "Translated text",
+  "no_translated_string": "No translation exists yet.",
+  "add_translation": "Add one"
 }

package/src/locales/es.json

@@ -140,5 +140,8 @@
   "link_to_add_labels": "Para ver cómo agregarlas haga clic <a href='https://help.konfuzio.com/modules/labels/index.html#add-a-label' target='_blank'>aquí</a>.",
   "no_annotations_in_annotation_set": "Este grupo de anotaciones no tiene anotaciones encontradas para sus respectivas etiquetas.",
   "wait_title": "Por favor espere...",
-  "redirecting_to_documents_list": "Lo estamos redirigiendo a la lista de documentos, para que pueda continuar la revisión de sus documentos mientras procesamos los cambios realizados."
+  "redirecting_to_documents_list": "Lo estamos redirigiendo a la lista de documentos, para que pueda continuar la revisión de sus documentos mientras procesamos los cambios realizados.",
+  "translated_string_title": "Texto traducido",
+  "no_translated_string": "Aún no existe traducción.",
+  "add_translation": "Agregar"
 }

package/src/store/document.js

@@ -248,6 +248,7 @@ const getters = {
     const labels = [];
     const processedAnnotationSets = annotationSets.map((annotationSet) => {
       const annotationSetLabels = annotationSet.labels.map((label) => {
+      
         // add annotations to the document array
         annotations.push(...label.annotations);
         labels.push(label);
@@ -367,27 +368,28 @@ const getters = {
   /**
    * Get number of empty labels per annotation set
    */
-  emptyLabelsLength: (state) => (annotationSet) => {
-    const labels = annotationSet.labels.filter(
-      (label) => label.annotations.length === 0
-    );
-
+  emptyLabels: (state, getters) => (annotationSet) => {
     const pendingEmpty = [];
 
-    labels.map((label) => {
-      const found = state.missingAnnotations.find(
+    annotationSet.labels.map((label) => {
+      const foundMissing = state.missingAnnotations.find(
         (l) =>
           l.label === label.id &&
           annotationSet.id === l.annotation_set &&
           annotationSet.label_set.id === l.label_set
       );
 
-      if (!found) {
+      const foundNegative = label.annotations.find(annotation => 
+        getters.isNegative(annotation)
+      );
+
+      if (!foundMissing && (label.annotations.length === 0 || foundNegative)) {
         pendingEmpty.push(label);
       }
+
     });
 
-    return pendingEmpty.length;
+    return pendingEmpty;
   },
 
   annotationIsNotFound: (state) => (annotationSet, label) => {
@@ -408,8 +410,8 @@ const getters = {
 
   // Check if document is ready to be finished
   isDocumentReadyToFinishReview: (state) => {
-    // check if all annotations have been revised
-    let notRevised;
+    // check if all annotations are correct
+    let notCorrect;
 
     const emptyAnnotations = [];
 
@@ -430,7 +432,7 @@ const getters = {
     }
 
     if (state.annotations) {
-      notRevised = state.annotations.filter((a) => !a.revised);
+      notCorrect = state.annotations.filter((a) => !a.is_correct);
     }
 
     // if all annotations have been revised
@@ -440,8 +442,8 @@ const getters = {
     if (
       !emptyAnnotations ||
       !state.missingAnnotations ||
-      !notRevised ||
-      (notRevised.length === 0 &&
+      !notCorrect ||
+      (notCorrect.length === 0 &&
         state.missingAnnotations.length === emptyAnnotations.length)
     ) {
       return true;
@@ -456,7 +458,7 @@ const getters = {
   /**
    * Get number of annotations pending review per annotation set
    */
-  annotationsWithPendingReviewLength: () => (annotationSet) => {
+  notCorrectAnnotations: () => (annotationSet) => {
     const labels = annotationSet.labels.filter(
       (label) => label.annotations.length > 0
     );
@@ -465,7 +467,7 @@ const getters = {
 
     labels.map((label) => {
       const foundPendingAnnotations = label.annotations.filter(
-        (ann) => !ann.revised
+        (ann) => !ann.is_correct && !ann.revised
       );
 
       if (foundPendingAnnotations && foundPendingAnnotations.length > 0) {
@@ -480,7 +482,7 @@ const getters = {
       }
     });
 
-    return annotationsWithPendingReview.length;
+    return annotationsWithPendingReview;
   },
 
   /**
@@ -577,6 +579,13 @@ const getters = {
       return null;
     }
   },
+  isNegative: () => (annotation) => {
+    if(annotation) {
+      return !annotation.is_correct && annotation.revised
+    } else {
+      return null;
+    }
+  },
 
   /**
    * Check for user who created or revised the annotation
@@ -722,11 +731,13 @@ const actions = {
           commit("SET_LABELS", labels);
           commit("SET_SELECTED_DOCUMENT", response.data);
 
-          if (rootState.project.projectId) {
-            projectId = rootState.project.projectId;
-          } else {
+          if(response.data.project) {
             projectId = response.data.project;
-            dispatch("project/setProjectId", response.data.project, {
+
+            dispatch("project/setProjectId", projectId, {
+              root: true,
+            });
+            dispatch("project/fetchProjectDetails", projectId, {
               root: true,
             });
           }
@@ -829,7 +840,7 @@ const actions = {
     commit("SET_DOCUMENT_ANNOTATION_SELECTED", null);
   },
 
-  createAnnotation: ({ commit, getters, dispatch }, annotation) => {
+  createAnnotation: ({ commit, getters, dispatch }, {annotation, negativeAnnotationId}) => {
     return new Promise((resolve, reject) => {
       HTTP.post(`/annotations/`, annotation)
         .then(async (response) => {
@@ -847,6 +858,9 @@ const actions = {
               }
             } else {
               commit("ADD_ANNOTATION", response.data);
+              if(negativeAnnotationId) {
+                commit("DELETE_ANNOTATION", negativeAnnotationId);
+              }
             }
 
             resolve(response);
@@ -1142,6 +1156,7 @@ const mutations = {
             const exists = label.annotations.find(
               (existingAnnotation) => existingAnnotation.id === annotation.id
             );
+            
             if (!exists) {
               label.annotations.push(annotation);
               return;

package/src/store/project.js

@@ -2,10 +2,11 @@ import myImports from "../api";
 const HTTP = myImports.HTTP;
 
 const state = {
-  projectId: process.env.VUE_APP_PROJECT_ID,
+  projectId: null,
   currentUser: null,
   documentsListPath: null,
   documentsInProject: null,
+  translationsEnabled: false,
 };
 
 const getters = {
@@ -99,6 +100,20 @@ const actions = {
         console.log(error, "Could not fetch document list from the backend");
       });
   },
+
+  fetchProjectDetails: ({commit}, projectId) => {
+    return HTTP.get(
+      `projects/${projectId}/`
+    )
+      .then((response) => {
+        if (response.data.enable_translated_strings) {
+          commit("SET_TRANSLATIONS_ENABLED", true);
+        }
+      })
+      .catch((error) => {
+        console.log(error, "Could not fetch project details from the backend");
+      });
+  }
 };
 
 const mutations = {
@@ -114,6 +129,9 @@ const mutations = {
   SET_DOCUMENTS_IN_PROJECT: (state, documents) => {
     state.documentsInProject = documents;
   },
+  SET_TRANSLATIONS_ENABLED: (state, value) => {
+    state.translationsEnabled = value;
+  }
 };
 
 export default {

package/src/assets/images/UserIcon.vue

@@ -1,8 +0,0 @@
-<template>
-  <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
-    <path
-      fill="#E1E1E1"
-      d="M15.71,12.71a6,6,0,1,0-7.42,0,10,10,0,0,0-6.22,8.18,1,1,0,0,0,2,.22,8,8,0,0,1,15.9,0,1,1,0,0,0,1,.89h.11a1,1,0,0,0,.88-1.1A10,10,0,0,0,15.71,12.71ZM12,12a4,4,0,1,1,4-4A4,4,0,0,1,12,12Z"
-    />
-  </svg>
-</template>