@komarspn/pi-permission-system 16.0.2

package/test/prompting-gateway.test.ts

@@ -0,0 +1,230 @@
+/**
+ * Unit tests for PromptingGateway.
+ *
+ * The gateway owns the stored ExtensionContext and is the sole implementation
+ * of the GatePrompter role. These tests exercise canConfirm() across all
+ * policy permutations and verify the prompt/reject contract for promptPermission().
+ */
+import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import type { ConfigReader } from "#src/config-store";
+import { DEFAULT_EXTENSION_CONFIG } from "#src/extension-config";
+import type { PermissionPromptDecision } from "#src/permission-dialog";
+import type {
+  PermissionPrompterApi,
+  PromptPermissionDetails,
+} from "#src/permission-prompter";
+import {
+  PromptingGateway,
+  type PromptingGatewayDeps,
+} from "#src/prompting-gateway";
+
+// ── Test helpers ──────────────────────────────────────────────────────────
+
+function makeCtx(overrides: Partial<ExtensionContext> = {}): ExtensionContext {
+  return {
+    cwd: "/test/project",
+    hasUI: true,
+    ui: {
+      setStatus: vi.fn(),
+      notify: vi.fn(),
+      select: vi.fn(),
+      input: vi.fn(),
+    },
+    sessionManager: {
+      getEntries: vi.fn().mockReturnValue([]),
+      getSessionDir: vi.fn().mockReturnValue("/sessions/test"),
+      getSessionId: vi.fn().mockReturnValue(null),
+      addEntry: vi.fn(),
+    },
+    ...overrides,
+  } as unknown as ExtensionContext;
+}
+
+function makeConfigReader(
+  overrides: Partial<typeof DEFAULT_EXTENSION_CONFIG> = {},
+): ConfigReader {
+  return {
+    current: vi
+      .fn<() => typeof DEFAULT_EXTENSION_CONFIG>()
+      .mockReturnValue({ ...DEFAULT_EXTENSION_CONFIG, ...overrides }),
+  };
+}
+
+function makePrompterApi(): PermissionPrompterApi & {
+  prompt: ReturnType<typeof vi.fn>;
+} {
+  return {
+    prompt: vi
+      .fn<PermissionPrompterApi["prompt"]>()
+      .mockResolvedValue({ approved: true, state: "approved" }),
+  };
+}
+
+function makeDetails(): PromptPermissionDetails {
+  return {
+    requestId: "req-1",
+    source: "tool_call",
+    agentName: null,
+    message: "Allow this?",
+  };
+}
+
+function makeDeps(
+  overrides: Partial<PromptingGatewayDeps> = {},
+): PromptingGatewayDeps {
+  return {
+    config: overrides.config ?? makeConfigReader(),
+    subagentSessionsDir:
+      overrides.subagentSessionsDir ?? "/test/agent/subagent-sessions",
+    registry: overrides.registry,
+    prompter: overrides.prompter ?? makePrompterApi(),
+  };
+}
+
+// ── Tests ─────────────────────────────────────────────────────────────────
+
+describe("PromptingGateway", () => {
+  describe("canConfirm", () => {
+    it("returns false before activate", () => {
+      const gateway = new PromptingGateway(makeDeps());
+      expect(gateway.canConfirm()).toBe(false);
+    });
+
+    it("returns true after activate when context has UI", () => {
+      const gateway = new PromptingGateway(makeDeps());
+      gateway.activate(makeCtx({ hasUI: true }));
+      expect(gateway.canConfirm()).toBe(true);
+    });
+
+    it("returns false when context has no UI, is not a subagent, and yolo mode is off", () => {
+      const gateway = new PromptingGateway(
+        makeDeps({ config: makeConfigReader({ yoloMode: false }) }),
+      );
+      gateway.activate(makeCtx({ hasUI: false }));
+      expect(gateway.canConfirm()).toBe(false);
+    });
+
+    it("returns true when yolo mode is enabled (no UI, not subagent)", () => {
+      const gateway = new PromptingGateway(
+        makeDeps({ config: makeConfigReader({ yoloMode: true }) }),
+      );
+      gateway.activate(makeCtx({ hasUI: false }));
+      expect(gateway.canConfirm()).toBe(true);
+    });
+
+    it("returns true when running as a subagent (env hint)", () => {
+      vi.stubEnv("PI_IS_SUBAGENT", "1");
+      const gateway = new PromptingGateway(
+        makeDeps({ config: makeConfigReader({ yoloMode: false }) }),
+      );
+      gateway.activate(makeCtx({ hasUI: false }));
+      expect(gateway.canConfirm()).toBe(true);
+      vi.unstubAllEnvs();
+    });
+
+    it("returns false after deactivate", () => {
+      const gateway = new PromptingGateway(makeDeps());
+      gateway.activate(makeCtx({ hasUI: true }));
+      gateway.deactivate();
+      expect(gateway.canConfirm()).toBe(false);
+    });
+
+    it("returns true after re-activate following deactivate", () => {
+      const gateway = new PromptingGateway(makeDeps());
+      gateway.activate(makeCtx({ hasUI: true }));
+      gateway.deactivate();
+      gateway.activate(makeCtx({ hasUI: true }));
+      expect(gateway.canConfirm()).toBe(true);
+    });
+  });
+
+  describe("prompt", () => {
+    it("rejects before activate", async () => {
+      const gateway = new PromptingGateway(makeDeps());
+      await expect(gateway.prompt(makeDetails())).rejects.toThrow(
+        "prompt called before the session was activated",
+      );
+    });
+
+    it("delegates to deps.prompter.prompt with the stored context", async () => {
+      const prompter = makePrompterApi();
+      const gateway = new PromptingGateway(makeDeps({ prompter }));
+      const ctx = makeCtx();
+      gateway.activate(ctx);
+      const details = makeDetails();
+
+      const result = await gateway.prompt(details);
+
+      expect(prompter.prompt).toHaveBeenCalledWith(ctx, details);
+      expect(result).toEqual({ approved: true, state: "approved" });
+    });
+
+    it("uses the most recently activated context", async () => {
+      const prompter = makePrompterApi();
+      const gateway = new PromptingGateway(makeDeps({ prompter }));
+      const firstCtx = makeCtx({ cwd: "/first" });
+      const secondCtx = makeCtx({ cwd: "/second" });
+
+      gateway.activate(firstCtx);
+      gateway.activate(secondCtx);
+
+      await gateway.prompt(makeDetails());
+
+      expect(prompter.prompt).toHaveBeenCalledWith(
+        secondCtx,
+        expect.anything(),
+      );
+    });
+
+    it("rejects after deactivate", async () => {
+      const gateway = new PromptingGateway(makeDeps());
+      gateway.activate(makeCtx());
+      gateway.deactivate();
+      await expect(gateway.prompt(makeDetails())).rejects.toThrow(
+        "prompt called before the session was activated",
+      );
+    });
+
+    it("returns the prompter decision", async () => {
+      const decision: PermissionPromptDecision = {
+        approved: false,
+        state: "denied",
+        denialReason: "user declined",
+      };
+      const prompter = makePrompterApi();
+      prompter.prompt.mockResolvedValue(decision);
+      const gateway = new PromptingGateway(makeDeps({ prompter }));
+      gateway.activate(makeCtx());
+
+      const result = await gateway.prompt(makeDetails());
+
+      expect(result).toEqual(decision);
+    });
+  });
+
+  describe("lifecycle", () => {
+    afterEach(() => {
+      vi.unstubAllEnvs();
+    });
+
+    it("activate then deactivate clears the stored context", () => {
+      const gateway = new PromptingGateway(makeDeps());
+      gateway.activate(makeCtx());
+      gateway.deactivate();
+      expect(gateway.canConfirm()).toBe(false);
+    });
+
+    it("multiple activate calls update the stored context", () => {
+      const prompter = makePrompterApi();
+      const gateway = new PromptingGateway(makeDeps({ prompter }));
+      const ctx2 = makeCtx({ cwd: "/new" });
+      gateway.activate(makeCtx({ cwd: "/old" }));
+      gateway.activate(ctx2);
+
+      // canConfirm still works (context set)
+      expect(gateway.canConfirm()).toBe(true);
+    });
+  });
+});