@komaci/static-analyzer 242.3.2 → 242.3.4

package/RULES.md

@@ -1251,3 +1251,105 @@ export default class Example extends LightningElement {
     }
 }
 ```
+
+## `komaci1039`: no-render-function-contains-more-than-return-statement
+
+| Code         | Description                                                   | Message                                                        | Severity |
+| ------------ | ------------------------------------------------------------- | -------------------------------------------------------------- | -------- |
+| `komaci1039` | Flags render functions that do more than just return a value. | Supported render functions can only contain a return statement | error    |
+
+### ❌ Incorrect
+
+```js
+import { LightningElement } from 'lwc';
+import template from './tesTemplate.html';
+export default class Example extends LightningElement {
+    render() {
+        const val = 'val';
+        return val ? template : undefined;
+    }
+}
+```
+
+### ✅ Correct
+
+```js
+import { LightningElement } from 'lwc';
+import template from './tesTemplate.html';
+export default class Example extends LightningElement {
+    render() {
+        return template;
+    }
+}
+```
+
+## `komaci1040`: no-render-function-return-statement
+
+| Code         | Description                                                  | Message                                                       | Severity |
+| ------------ | ------------------------------------------------------------ | ------------------------------------------------------------- | -------- |
+| `komaci1040` | Flags render functions that don't contain a return statement | Supported render functions need to contain a return statement | error    |
+
+### ❌ Incorrect
+
+```js
+import { LightningElement } from 'lwc';
+export default class Example extends LightningElement {
+    render() {
+        const val = 'val';
+    }
+}
+```
+
+### ✅ Correct
+
+```js
+import { LightningElement } from 'lwc';
+import template from './tesTemplate.html';
+export default class Example extends LightningElement {
+    render() {
+        return template;
+    }
+}
+```
+
+## `komaci1041`: no-render-function-return-statement-not-returning-imported-template
+
+| Code         | Description                                                                                   | Message                                                                 | Severity |
+| ------------ | --------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------- | -------- |
+| `komaci1041` | Flags render functions that attempt to return something that isn't an imported local template | Supported render functions can only return supported imported templates | error    |
+
+### ❌ Incorrect
+
+```js
+import { LightningElement, api } from 'lwc';
+import template from 'lightning/something';
+export default class Example extends LightningElement {
+    @api
+    firstOrSecondTemplate;
+
+    @api
+    passedInTemplate;
+
+    render() {
+        return this.firstOrSecondTemplate
+            ? this.passedInTemplate //not suported because it's passed through the prop
+            : template; // not supported because it's imported from another module
+    }
+}
+```
+
+### ✅ Correct
+
+```js
+import { LightningElement, api } from 'lwc';
+import firstTemplate from './firstTemplate.html';
+import secondTemplate from './secondTemplate.html';
+export default class Example extends LightningElement {
+    @api
+    firstOrSecondTemplate;
+
+    render() {
+        return this.firstOrSecondTemplate ? firstTemplate : secondTemplate;
+    }
+}
+```

package/build/rules.js

@@ -193,19 +193,19 @@ exports.diagnosticMessages = {
         source: SOURCE_PREFIX_OFFLINE_CODE_ANALYZER,
     },
     NO_RENDER_FUNCTION_CONTAINS_MORE_THAN_RETURN_STATEMENT: {
-        code: `${MESSAGE_CODE_PREFIX}1025`,
+        code: `${MESSAGE_CODE_PREFIX}1039`,
         severity: SEVERITY.ERROR,
         message: 'Supported render functions in custom components can only contain a return statement',
         source: SOURCE_PREFIX_OFFLINE_CODE_ANALYZER,
     },
     NO_RENDER_FUNCTION_RETURN_STATEMENT: {
-        code: `${MESSAGE_CODE_PREFIX}1025`,
+        code: `${MESSAGE_CODE_PREFIX}1040`,
         severity: SEVERITY.ERROR,
         message: 'Supported render functions need to contain a return statement',
         source: SOURCE_PREFIX_OFFLINE_CODE_ANALYZER,
     },
     NO_RENDER_FUNCTION_RETURN_STATEMENT_NOT_RETURNING_IMPORTED_TEMPLATE: {
-        code: `${MESSAGE_CODE_PREFIX}1025`,
+        code: `${MESSAGE_CODE_PREFIX}1041`,
         severity: SEVERITY.ERROR,
         message: 'Supported render functions can only return supported imported templates',
         source: SOURCE_PREFIX_OFFLINE_CODE_ANALYZER,

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@komaci/static-analyzer",
-    "version": "242.3.2",
+    "version": "242.3.4",
     "description": "Komaci Diagnostics API",
     "homepage": "https://komaci.dev/",
     "repository": {
@@ -29,10 +29,10 @@
     ],
     "dependencies": {
         "@babel/types": "^7.9.0",
-        "@komaci/common-shared": "242.3.2"
+        "@komaci/common-shared": "242.3.4"
     },
     "devDependencies": {
-        "@komaci/types": "242.3.2"
+        "@komaci/types": "242.3.4"
     },
     "peerDependencies": {
         "@lwc/metadata": "2.22.0-0",