@komaci/prefetch 262.21.0 → 264.4.0

package/build/__tests__/prefetchService.spec.js

@@ -876,5 +876,103 @@ describe('prefetchService', () => {
             }, 0);
         });
     });
+    describe('bug repro: stack growth when bulk resolvers complete synchronously', () => {
+        afterEach(() => {
+            jest.restoreAllMocks();
+        });
+        it('should not recurse synchronously through bulkResolveGuard between chunks', async () => {
+            const MAX_CONCURRENT = 10;
+            const NUM_ADDRESSES = 500;
+            const EXPECTED_CHUNKS = NUM_ADDRESSES / MAX_CONCURRENT;
+            const pageRefs = Array.from({ length: NUM_ADDRESSES }, (_, i) => createPageRef('action1', String(i)));
+            const { createRouter } = setupRouterMock();
+            let currentSyncDepth = 0;
+            let maxSyncDepth = 0;
+            let startCallCount = 0;
+            // Simulate a bulk resolver whose constituents all complete synchronously
+            // (e.g. an empty LWC with no wire adapters).
+            jest.spyOn(ResolverApi, 'getBulkAdgResolver').mockImplementation((_adg, inputs, callbacks) => {
+                let completed = 0;
+                const total = inputs.length;
+                return {
+                    start: () => {
+                        startCallCount++;
+                        currentSyncDepth++;
+                        // This finds the maximum sync depth reached by any chunk.
+                        if (currentSyncDepth > maxSyncDepth) {
+                            maxSyncDepth = currentSyncDepth;
+                        }
+                        for (let i = 0; i < total; i++) {
+                            completed++;
+                            // This is where would synchronously recurse into then next chunk's start() without the fix in place.
+                            callbacks.bulkResolutionStatusCb({
+                                index: i,
+                                status: {
+                                    getState: () => 'done',
+                                    getErrorMessages: () => [],
+                                },
+                            });
+                        }
+                        currentSyncDepth--;
+                    },
+                    areAllResolversDone: () => completed === total,
+                    stop: jest.fn(),
+                };
+            });
+            const setup = setupPrefetch(createRouter, pageRefs, {
+                ...mockPrefetchConfig,
+                maxConcurrent: MAX_CONCURRENT,
+            });
+            const service = setup.run();
+            await waitForExpect(() => {
+                expect(service.getState()).toBe('done');
+            });
+            // All chunks must have actually been started.
+            expect(startCallCount).toBe(EXPECTED_CHUNKS);
+            // Each chunk's bulk resolver should start on its own fresh call stack.
+            // Without that boundary, maxSyncDepth grows linearly with chunk count,
+            // which is the root cause of the stack overflow observed in production
+            expect(maxSyncDepth).toBe(1);
+        }, 10000);
+        it('completes successfully when enough chunks resolve synchronously (regression test for stack overflow)', async () => {
+            const MAX_CONCURRENT = 10;
+            // Previously enough chunks to blow past V8's default stack limit
+            // (~10-12k frames). Each chunk added ~15-25 JS frames on the
+            // synchronous cascade from bulkResolveGuard -> ... -> start().
+            // With the fix, the microtask boundary prevents the recursion and
+            // all 20k addresses should resolve without a RangeError.
+            const NUM_ADDRESSES = 20000;
+            const pageRefs = Array.from({ length: NUM_ADDRESSES }, (_, i) => createPageRef('action1', String(i)));
+            const { createRouter } = setupRouterMock();
+            jest.spyOn(ResolverApi, 'getBulkAdgResolver').mockImplementation((_adg, inputs, callbacks) => {
+                let completed = 0;
+                const total = inputs.length;
+                return {
+                    start: () => {
+                        for (let i = 0; i < total; i++) {
+                            completed++;
+                            callbacks.bulkResolutionStatusCb({
+                                index: i,
+                                status: {
+                                    getState: () => 'done',
+                                    getErrorMessages: () => [],
+                                },
+                            });
+                        }
+                    },
+                    areAllResolversDone: () => completed === total,
+                    stop: jest.fn(),
+                };
+            });
+            const setup = setupPrefetch(createRouter, pageRefs, {
+                ...mockPrefetchConfig,
+                maxConcurrent: MAX_CONCURRENT,
+            });
+            const service = setup.run();
+            await waitForExpect(() => {
+                expect(service.getState()).toBe('done');
+            });
+        }, 30000);
+    });
 });
 //# sourceMappingURL=prefetchService.spec.js.map

package/build/modules/komaci/prefetchService/prefetchService.js

@@ -390,8 +390,9 @@ export class PrefetchService {
         if (allDone) {
             if (this.adgMap.size > 0) {
                 // if all current runs are all done but with addresses left in the adgMap
-                // go process them
-                this.bulkResolveGuard();
+                // go process them. Schedule via microtask to avoid unbounded synchronous
+                // recursion when resolvers complete synchronously (W-22146685).
+                Promise.resolve().then(() => this.bulkResolveGuard());
             }
             else {
                 // prefetch is done when allIdel and nothing left in adgMap

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@komaci/prefetch",
-    "version": "262.21.0",
+    "version": "264.4.0",
     "description": "Komaci prefetch service.",
     "homepage": "https://komaci.dev/",
     "repository": {