@komaci/common-shared 244.1.8 → 244.2.0

package/build/internal-namespaces.json

@@ -1036,6 +1036,7 @@
     "setup_service_experience",
     "setup_service_fieldservice",
     "setup_service_flowobjectlinking",
+    "setup_service_folmessaging",
     "setup_service_folvoice",
     "setup_service_intents",
     "setup_service_livemessage",

package/build/komaciDocumentIntrospection.d.ts

@@ -117,10 +117,7 @@ export declare const doesAdgExist: (index: number, doc: KomaciDocument) => boole
  * @param composition the composition to look at
  * @param cb the function to run on every new composition. returning true here will end traversal for that subtree
  */
-export declare function traverseComposition(composition: Composition, callbacks: {
-    pretraversal?: (Composition: Composition, iterationContext: string[], parent?: Composition) => boolean;
-    posttraversal?: (Composition: Composition, iterationContext: string[], parent?: Composition) => void;
-}, iteratorContext?: string[], parent?: Composition): void;
+export declare function traverseComposition(composition: Composition, cb: (Composition: Composition, iterationContext: string[]) => boolean, iteratorContext?: string[]): void;
 /**
  * Recursively probe a composition and it's children for usages of properties.
  * @param composition Current composition

package/build/komaciDocumentIntrospection.js

@@ -357,24 +357,19 @@ function updatePropertyIfExists(value, properties, key) {
  * @param composition the composition to look at
  * @param cb the function to run on every new composition. returning true here will end traversal for that subtree
  */
-function traverseComposition(composition, callbacks, iteratorContext = [], parent) {
-    const found = callbacks.pretraversal
-        ? callbacks.pretraversal(composition, iteratorContext, parent)
-        : false;
+function traverseComposition(composition, cb, iteratorContext = []) {
+    const found = cb(composition, iteratorContext);
     if (!found && composition && composition.compositions) {
         for (const value of composition.compositions) {
             if (isCompositionAnIteration(composition)) {
                 iteratorContext.unshift(composition.iterator);
             }
-            traverseComposition(value, callbacks, iteratorContext, composition);
+            traverseComposition(value, cb, iteratorContext);
             if (isCompositionAnIteration(composition)) {
                 iteratorContext.shift();
             }
         }
     }
-    if (callbacks.posttraversal) {
-        callbacks.posttraversal(composition, iteratorContext, parent);
-    }
 }
 exports.traverseComposition = traverseComposition;
 /**

package/build/moduleMetadata.js

@@ -21,6 +21,7 @@ const initModuleMetadataObject = () => ({
     adgs: new Map(),
     exports: {},
     templateKomaciDocMap: {},
+    hasRenderFunction: false,
     staticMetadataId: '',
 });
 exports.initModuleMetadataObject = initModuleMetadataObject;
@@ -503,64 +504,43 @@ const addTemplateUsageForAdg = (doc, adgIndex, moduleMetadata) => {
             const composition = doc.compositions[doc.exports.default.value];
             adg.compositions = [composition];
             adg.compositionRootIndex = doc.exports.default.value;
-            (0, komaciDocumentIntrospection_1.traverseComposition)(composition, {
-                pretraversal: (comp, iterationContext, parent) => {
-                    (0, komaciDocumentIntrospection_1.updatePropertiesForComposition)(comp, adg.properties, adg.propertiesUsedInTemplate, iterationContext);
-                    if (comp && comp.isActive) {
-                        adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.CONDITION_FUNC);
-                    }
-                    if (parent &&
-                        (0, komaciDocumentIntrospection_1.isCompositionAComposedAdg)(parent) &&
-                        ((0, komaciDocumentIntrospection_1.isCompositionAComposedAdg)(comp) ||
-                            (0, komaciDocumentIntrospection_1.isCompositionAContainer)(comp) ||
-                            (0, komaciDocumentIntrospection_1.isCompositionASlot)(comp) ||
-                            (0, komaciDocumentIntrospection_1.isCompositionAnIteration)(comp)) &&
-                        !comp.slot) {
-                        comp.slot = '';
-                    }
-                    if ((0, komaciDocumentIntrospection_1.isCompositionAComposedAdg)(comp)) {
-                        adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.COMPOSED_GRAPH_FUNC);
-                        if (comp.input.type === 'ImportReference') {
-                            const visitedImportForTemplate = comp.input.value.startsWith(`t`);
-                            const importName = moduleMetadata.importIndexReference.get(visitedImportForTemplate
-                                ? comp.input.value
-                                : `t${adgIndex}-${comp.input.value}`);
-                            const importInfo = importName
-                                ? moduleMetadata.importsByName.get(importName)
-                                : undefined;
-                            if (importInfo) {
-                                importInfo.usedInPriming = true;
-                            }
-                            //changing the comp node to be what t is referencing
-                            if (!visitedImportForTemplate) {
-                                comp.input.value = `t${adgIndex}-${comp.input.value}`;
-                            }
+            (0, komaciDocumentIntrospection_1.traverseComposition)(composition, (comp, iterationContext) => {
+                (0, komaciDocumentIntrospection_1.updatePropertiesForComposition)(comp, adg.properties, adg.propertiesUsedInTemplate, iterationContext);
+                if (comp && comp.isActive) {
+                    adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.UNRESOLVED_FUNC);
+                }
+                if ((0, komaciDocumentIntrospection_1.isCompositionAComposedAdg)(comp)) {
+                    adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.COMPOSED_GRAPH_FUNC);
+                    if (comp.input.type === 'ImportReference') {
+                        const visitedImportForTemplate = comp.input.value.startsWith(`t`);
+                        const importName = moduleMetadata.importIndexReference.get(visitedImportForTemplate
+                            ? comp.input.value
+                            : `t${adgIndex}-${comp.input.value}`);
+                        const importInfo = importName
+                            ? moduleMetadata.importsByName.get(importName)
+                            : undefined;
+                        if (importInfo) {
+                            importInfo.usedInPriming = true;
+                        }
+                        //changing the comp node to be what t is referencing
+                        if (!visitedImportForTemplate) {
+                            comp.input.value = `t${adgIndex}-${comp.input.value}`;
                         }
                     }
-                    else if ((0, komaciDocumentIntrospection_1.isCompositionASlot)(comp)) {
-                        adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.SLOT_FUNC);
-                    }
-                    else if ((0, komaciDocumentIntrospection_1.isCompositionAnIteration)(comp)) {
-                        adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.ITERATION_FUNC);
-                    }
-                    else if ((0, komaciDocumentIntrospection_1.isCompositionAnImage)(comp)) {
-                        adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.IMG_FUNC);
-                    }
-                    else if ((0, komaciDocumentIntrospection_1.isCompositionAContainer)(comp) && (comp.key || comp.slot)) {
-                        adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.ELEMENT_FUNC);
-                    }
-                    return false;
-                },
-                posttraversal: (comp, iterationContext, parent) => {
-                    // if the current composition is supposed to be slotted but its a child of a "processing" node i.e. conditional or iteration, set the slot on the parent
-                    if (comp.slot &&
-                        parent &&
-                        (((0, komaciDocumentIntrospection_1.isCompositionAContainer)(parent) && parent.isActive) ||
-                            (0, komaciDocumentIntrospection_1.isCompositionAnIteration)(parent))) {
-                        parent.slot = comp.slot;
-                        comp.slot = undefined;
-                    }
-                },
+                }
+                else if ((0, komaciDocumentIntrospection_1.isCompositionASlot)(comp)) {
+                    adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.SLOT_FUNC);
+                }
+                else if ((0, komaciDocumentIntrospection_1.isCompositionAnIteration)(comp)) {
+                    adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.ITERATION_FUNC);
+                }
+                else if ((0, komaciDocumentIntrospection_1.isCompositionAnImage)(comp)) {
+                    adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.IMG_FUNC);
+                }
+                else if ((0, komaciDocumentIntrospection_1.isCompositionAContainer)(comp) && (comp.key || comp.slot)) {
+                    adg.requiredCompositionFactoryFunctions.add(types_1.IdKeys.ELEMENT_FUNC);
+                }
+                return false;
             });
         }
     }

package/build/types.d.ts

@@ -35,8 +35,7 @@ export declare enum IdKeys {
     REDUCER_FUNC_ID = "REDUCER_FUNC_ID",
     IMG_SRC = "IMG_SRC",
     IMG_FUNC = "IMG_FUNC",
-    HOISTED_RENDER_FUNC_ID = "HOISTED_RENDER_FUNC_ID",
-    CONDITION_FUNC = "CONDITION_FUNC"
+    HOISTED_RENDER_FUNC_ID = "HOISTED_RENDER_FUNC_ID"
 }
 /**
  * @typedef AstContext is an object that holds meta data information about the ast.
@@ -287,7 +286,7 @@ export declare type ModuleMetadata = {
     templateKomaciDocMap: {
         [fName: string]: KomaciDocument;
     };
-    renderFunction?: HoistedFunctionMetadata;
+    hasRenderFunction: boolean;
     staticMetadataId: string;
     includePropsMetadata?: boolean;
     moduleType?: ModuleTypes.BUNDLE_MODULE | ModuleTypes.SCRIPT_ONLY | ModuleTypes.TEMPLATE_ONLY;

package/build/types.js

@@ -37,7 +37,6 @@ var IdKeys;
     IdKeys["IMG_SRC"] = "IMG_SRC";
     IdKeys["IMG_FUNC"] = "IMG_FUNC";
     IdKeys["HOISTED_RENDER_FUNC_ID"] = "HOISTED_RENDER_FUNC_ID";
-    IdKeys["CONDITION_FUNC"] = "CONDITION_FUNC";
 })(IdKeys = exports.IdKeys || (exports.IdKeys = {}));
 /**
  * Possbile types of properties we can encounter in a LWC

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@komaci/common-shared",
-    "version": "244.1.8",
+    "version": "244.2.0",
     "description": "Assets that are shared across Komaci commonjs packages",
     "homepage": "https://komaci.dev/",
     "repository": {
@@ -29,7 +29,7 @@
         "build/komaci-mapping.json"
     ],
     "devDependencies": {
-        "@komaci/types": "244.1.8"
+        "@komaci/types": "244.2.0"
     },
     "dependencies": {
         "@babel/core": "^7.9.0",