@kolkrabbi/kol-shell 0.37.0 → 0.37.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +3 -3
- package/src/AppShell.jsx +14 -3
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@kolkrabbi/kol-shell",
|
|
3
|
-
"version": "0.37.
|
|
3
|
+
"version": "0.37.1",
|
|
4
4
|
"private": false,
|
|
5
5
|
"description": "KOL application shell — fixed 48px NavRail + AppShell layout root, PageShell/PageHeader scaffolds, ContentFilters catalog organism, GridCard, SettingsScaffold, WalkthroughPanel, ShortcutsOverlay. App chrome (kol-framework owns site chrome). Nav items, content, shortcuts and settings are consumer-injected. Sits above @kolkrabbi/kol-{theme,component,framework}.",
|
|
6
6
|
"license": "MIT",
|
|
@@ -20,9 +20,9 @@
|
|
|
20
20
|
"react-dom": "^18.3.0 || ^19.0.0"
|
|
21
21
|
},
|
|
22
22
|
"devDependencies": {
|
|
23
|
-
"@kolkrabbi/kol-component": "^0.154.1",
|
|
24
|
-
"@kolkrabbi/kol-icons": "^0.25.0",
|
|
25
23
|
"@kolkrabbi/kol-framework": "^0.36.0",
|
|
24
|
+
"@kolkrabbi/kol-component": "^0.156.0",
|
|
25
|
+
"@kolkrabbi/kol-icons": "^0.25.0",
|
|
26
26
|
"@kolkrabbi/kol-theme": "^0.122.0"
|
|
27
27
|
},
|
|
28
28
|
"files": [
|
package/src/AppShell.jsx
CHANGED
|
@@ -99,6 +99,13 @@ const CODE_FOR_KEY = {
|
|
|
99
99
|
'-': 'Minus', '=': 'Equal',
|
|
100
100
|
}
|
|
101
101
|
|
|
102
|
+
/* A STABLE DEFAULT (ShellDrawerOpenOnUnstableDep, kol-mirror 2026-09-01 —
|
|
103
|
+
* found by the user on his phone): `drawerOpenOn = []` in the signature was a
|
|
104
|
+
* fresh array every render, and it sat in an effect's deps, so the route effect
|
|
105
|
+
* re-ran on every render and closed the drawer straight after every tap. The
|
|
106
|
+
* trigger did nothing on every consumer taking the default. */
|
|
107
|
+
const NO_PATHS = []
|
|
108
|
+
|
|
102
109
|
export default function AppShell({
|
|
103
110
|
items,
|
|
104
111
|
bottomItems,
|
|
@@ -115,7 +122,7 @@ export default function AppShell({
|
|
|
115
122
|
settingsPath,
|
|
116
123
|
settingsKey,
|
|
117
124
|
drawerBelow = 768,
|
|
118
|
-
drawerOpenOn =
|
|
125
|
+
drawerOpenOn = NO_PATHS,
|
|
119
126
|
children,
|
|
120
127
|
}) {
|
|
121
128
|
const [navHidden, setNavHidden] = useState(false)
|
|
@@ -205,10 +212,14 @@ export default function AppShell({
|
|
|
205
212
|
/* …unless the destination is one where nav IS the page (`drawerOpenOn`):
|
|
206
213
|
* there the entry OPENS it. Runs on mount, on the fold and on navigation
|
|
207
214
|
* alike — `drawer` is a dep — so a phone arriving on home gets the rail. */
|
|
215
|
+
/* Keyed on the BOOLEAN, not the array: a consumer's inline `['/']` is a new
|
|
216
|
+
* identity every render too (the showcase set passes one), and the effect
|
|
217
|
+
* must fire on route entry only — never on a re-render, or it undoes the tap. */
|
|
218
|
+
const opensHere = drawerOpenOn.some((p) => (p === '/' ? currentPath === '/' : currentPath.startsWith(p)))
|
|
208
219
|
useEffect(() => {
|
|
209
|
-
if (drawer) setDrawerOpen(
|
|
220
|
+
if (drawer) setDrawerOpen(opensHere)
|
|
210
221
|
else setNavHidden(false)
|
|
211
|
-
}, [currentPath, drawer,
|
|
222
|
+
}, [currentPath, drawer, opensHere])
|
|
212
223
|
|
|
213
224
|
/* THE WASH ALSO GOES ON THE ROOT (2026-08-30). It is set on the content
|
|
214
225
|
* wrapper below, which every page inherits — but a PORTALLED surface does
|