@kolkrabbi/kol-shell 0.31.0 → 0.32.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (2) hide show
  1. package/package.json +4 -4
  2. package/src/Logomark.jsx +30 -1
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@kolkrabbi/kol-shell",
3
- "version": "0.31.0",
3
+ "version": "0.32.0",
4
4
  "private": false,
5
5
  "description": "KOL application shell — fixed 48px NavRail + AppShell layout root, PageShell/PageHeader scaffolds, ContentFilters catalog organism, GridCard, SettingsScaffold, WalkthroughPanel, ShortcutsOverlay. App chrome (kol-framework owns site chrome). Nav items, content, shortcuts and settings are consumer-injected. Sits above @kolkrabbi/kol-{theme,component,framework}.",
6
6
  "license": "MIT",
@@ -20,10 +20,10 @@
20
20
  "react-dom": "^18.3.0 || ^19.0.0"
21
21
  },
22
22
  "devDependencies": {
23
- "@kolkrabbi/kol-component": "^0.145.0",
23
+ "@kolkrabbi/kol-component": "^0.150.1",
24
24
  "@kolkrabbi/kol-icons": "^0.25.0",
25
- "@kolkrabbi/kol-theme": "^0.112.0",
26
- "@kolkrabbi/kol-framework": "^0.36.0"
25
+ "@kolkrabbi/kol-framework": "^0.36.0",
26
+ "@kolkrabbi/kol-theme": "^0.119.0"
27
27
  },
28
28
  "files": [
29
29
  "src",
package/src/Logomark.jsx CHANGED
@@ -5,10 +5,39 @@ import { useState, useEffect } from 'react'
5
5
  * <img> renders a currentColor mark black in dark mode (invisible). Ported
6
6
  * verbatim from the kol-mirror cut (module-level cache; async resolve even on
7
7
  * cache hit — sync setState in an effect cascades renders).
8
+ *
9
+ * The fetched markup is SANITIZED before injection — `<style>`/`<script>`
10
+ * stripped, `on*` attributes dropped (LogomarkInlineStyleLeak, kol-chess
11
+ * 2026-09-01). An SVG *document* may legitimately carry its own `<style>` — a
12
+ * theme-aware favicon does — but once inlined, that `<style>` is
13
+ * DOCUMENT-GLOBAL: kol-chess pointed `svgUrl` at its favicon and every <svg>
14
+ * in the app took OS-keyed ink and ignored `data-theme`, presenting two
15
+ * packages away as "the theme toggle is broken". A mark that needs its own
16
+ * styling inlines it as attributes, not a stylesheet.
8
17
  */
9
18
 
10
19
  const svgCache = new Map()
11
20
 
21
+ /* strip what must never escape into the host document: stylesheets (global
22
+ * once inlined), scripts and event handlers (this is a fetch → innerHTML
23
+ * boundary). DOMParser is the correct tool; the regex fallback only runs if
24
+ * the markup does not even parse as SVG. */
25
+ function sanitizeSvg(svg) {
26
+ try {
27
+ const doc = new DOMParser().parseFromString(svg, 'image/svg+xml')
28
+ if (doc.querySelector('parsererror')) throw new Error('unparseable')
29
+ doc.querySelectorAll('style, script').forEach((el) => el.remove())
30
+ doc.querySelectorAll('*').forEach((el) => {
31
+ for (const a of [...el.attributes]) if (/^on/i.test(a.name)) el.removeAttribute(a.name)
32
+ })
33
+ return new XMLSerializer().serializeToString(doc)
34
+ } catch {
35
+ return svg
36
+ .replace(/<(style|script)[\s\S]*?<\/\1\s*>/gi, '')
37
+ .replace(/\son[a-z]+\s*=\s*("[^"]*"|'[^']*')/gi, '')
38
+ }
39
+ }
40
+
12
41
  export default function Logomark({ svgUrl, size = 20, className = '', ...props }) {
13
42
  const [svgContent, setSvgContent] = useState(() => svgCache.get(svgUrl) || null)
14
43
 
@@ -16,7 +45,7 @@ export default function Logomark({ svgUrl, size = 20, className = '', ...props }
16
45
  if (!svgUrl) return
17
46
  let active = true
18
47
  Promise.resolve(
19
- svgCache.get(svgUrl) ?? fetch(svgUrl).then(res => res.text()).then(svg => { svgCache.set(svgUrl, svg); return svg })
48
+ svgCache.get(svgUrl) ?? fetch(svgUrl).then(res => res.text()).then(raw => { const svg = sanitizeSvg(raw); svgCache.set(svgUrl, svg); return svg })
20
49
  )
21
50
  .then(svg => { if (active) setSvgContent(svg) })
22
51
  .catch(() => {})