@kolkrabbi/kol-shell 0.17.1 → 0.19.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +4 -4
- package/src/AppShell.jsx +22 -6
- package/src/PageShell.jsx +26 -0
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@kolkrabbi/kol-shell",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.19.0",
|
|
4
4
|
"private": false,
|
|
5
5
|
"description": "KOL application shell — fixed 48px NavRail + AppShell layout root, PageShell/PageHeader scaffolds, ContentFilters catalog organism, GridCard, SettingsScaffold, WalkthroughPanel, ShortcutsOverlay. App chrome (kol-framework owns site chrome). Nav items, content, shortcuts and settings are consumer-injected. Sits above @kolkrabbi/kol-{theme,component,framework}.",
|
|
6
6
|
"license": "MIT",
|
|
@@ -20,10 +20,10 @@
|
|
|
20
20
|
"react-dom": "^18.3.0 || ^19.0.0"
|
|
21
21
|
},
|
|
22
22
|
"devDependencies": {
|
|
23
|
-
"@kolkrabbi/kol-framework": "^0.35.0",
|
|
24
|
-
"@kolkrabbi/kol-component": "^0.127.0",
|
|
25
23
|
"@kolkrabbi/kol-icons": "^0.24.0",
|
|
26
|
-
"@kolkrabbi/kol-
|
|
24
|
+
"@kolkrabbi/kol-component": "^0.128.0",
|
|
25
|
+
"@kolkrabbi/kol-framework": "^0.35.0",
|
|
26
|
+
"@kolkrabbi/kol-theme": "^0.89.0"
|
|
27
27
|
},
|
|
28
28
|
"files": [
|
|
29
29
|
"src",
|
package/src/AppShell.jsx
CHANGED
|
@@ -45,7 +45,9 @@ import TouchDeviceOverlay, { useTouchPrimary } from './TouchDeviceOverlay.jsx'
|
|
|
45
45
|
* localStorage `kol-desktop` is '1' (fxr's gate); `overlay` keeps the shell and
|
|
46
46
|
* mounts TouchDeviceOverlay once (monitor's)
|
|
47
47
|
* @param {string} props.appName TouchDeviceOverlay's subject
|
|
48
|
-
* @param {boolean} props.navKeys Option+1…9 navigates to
|
|
48
|
+
* @param {boolean} props.navKeys Option+1…9 navigates to the rail's nth ROW through `onNavigate` — with a
|
|
49
|
+
* `logomark` that is the mark ('/') then the items, which is the order on
|
|
50
|
+
* screen (AppShellNavKeysHomeFirst, 2026-08-28); without one, `items[n-1]`. The
|
|
49
51
|
* rail-order counterpart of `railToggleKey` (AppShellNavKeys, kol-monitor
|
|
50
52
|
* 2026-08-28 — user: "make command or alt 1234 go from home 1 2 3 4 in the
|
|
51
53
|
* sidenav without clicking"). Option, not Command: ⌘1–9 is the browser's
|
|
@@ -95,7 +97,21 @@ export default function AppShell({
|
|
|
95
97
|
return () => window.removeEventListener('keydown', onKey)
|
|
96
98
|
}, [railToggleKey])
|
|
97
99
|
|
|
98
|
-
/* Option+digit → the rail
|
|
100
|
+
/* Option+digit → the rail ROW in that position (never while typing).
|
|
101
|
+
*
|
|
102
|
+
* THE MARK IS ROW 1 (AppShellNavKeysHomeFirst, kol-monitor 2026-08-28 — user:
|
|
103
|
+
* "alt 1 skips home and goes straight to 2"). 0.12.0 navigated to
|
|
104
|
+
* `items[n - 1]`, but the rail's first row is the LOGOMARK, which `NavRail`
|
|
105
|
+
* renders above the items and wires to '/'. So ⌥1 landed on the second rung
|
|
106
|
+
* and every key after it was off by one, with Home having no key at all —
|
|
107
|
+
* against the sentence that asked for the feature, quoted in the prop's own
|
|
108
|
+
* docblock above: "make command or alt 1234 go from HOME 1 2 3 4". Home was
|
|
109
|
+
* position 1 in the ask; the implementation counted a list it was never in.
|
|
110
|
+
*
|
|
111
|
+
* With a `logomark`, the order is the order you see: the mark, then the items.
|
|
112
|
+
* Without one, `items[n - 1]` exactly as before, so an app that renders no
|
|
113
|
+
* mark is untouched. */
|
|
114
|
+
const navPaths = (logomark ? ['/'] : []).concat((items ?? []).map((i) => i?.path)).filter(Boolean)
|
|
99
115
|
useEffect(() => {
|
|
100
116
|
if (!navKeys) return undefined
|
|
101
117
|
const onKey = (e) => {
|
|
@@ -103,14 +119,14 @@ export default function AppShell({
|
|
|
103
119
|
if (!m || !e.altKey || e.metaKey || e.ctrlKey) return
|
|
104
120
|
const t = e.target
|
|
105
121
|
if (t?.isContentEditable || /^(INPUT|TEXTAREA|SELECT)$/.test(t?.tagName)) return
|
|
106
|
-
const
|
|
107
|
-
if (!
|
|
122
|
+
const path = navPaths[Number(m[1]) - 1]
|
|
123
|
+
if (!path) return
|
|
108
124
|
e.preventDefault()
|
|
109
|
-
onNavigate?.(
|
|
125
|
+
onNavigate?.(path)
|
|
110
126
|
}
|
|
111
127
|
window.addEventListener('keydown', onKey)
|
|
112
128
|
return () => window.removeEventListener('keydown', onKey)
|
|
113
|
-
}, [navKeys,
|
|
129
|
+
}, [navKeys, navPaths.join('\u0000'), onNavigate]) // eslint-disable-line react-hooks/exhaustive-deps
|
|
114
130
|
|
|
115
131
|
let wantsDesktop = false
|
|
116
132
|
try { wantsDesktop = typeof localStorage !== 'undefined' && localStorage.getItem('kol-desktop') === '1' } catch { /* storage blocked */ }
|
package/src/PageShell.jsx
CHANGED
|
@@ -9,6 +9,31 @@
|
|
|
9
9
|
* Gutter is `--kol-shell-page-pad` (kol-theme). `PageBleed` breaks it for
|
|
10
10
|
* full-width embeds (monitor's rack bleed).
|
|
11
11
|
*
|
|
12
|
+
* `scrollbar-gutter: stable` on both modes (PageShellScrollbarGutter,
|
|
13
|
+
* kol-monitor 2026-08-28 — user: "Create is the odd one out"). A page's content
|
|
14
|
+
* width used to depend on whether it scrolls: `scroll` mode scrolls the
|
|
15
|
+
* document, so the viewport's scrollbar takes its width out of the content box;
|
|
16
|
+
* `fixed` mode is `overflow: hidden` and keeps it. That would cost nothing if
|
|
17
|
+
* anything downstream were measured in absolute units — but `.kol-filters-first`
|
|
18
|
+
* is `calc((100cqw - 120px) / 6)` (ContentFiltersFirstGroupFixedWidth), so a
|
|
19
|
+
* scrollbar's width divides by six into the first filter group and every group
|
|
20
|
+
* after it shifts, along with the 6-column grid beneath. One catalog column has
|
|
21
|
+
* to mean one thing on every surface of an app.
|
|
22
|
+
*
|
|
23
|
+
* WHERE the declaration lands is not symmetric, and it is why this is on the
|
|
24
|
+
* component rather than in the theme: in `fixed` mode this element IS the scroll
|
|
25
|
+
* container (`overflow: hidden` qualifies), so it reserves the gutter and its
|
|
26
|
+
* content box matches a scrolling page's. In `scroll` mode it is not one
|
|
27
|
+
* (`overflow: visible`), the property does not apply, and the viewport keeps
|
|
28
|
+
* doing what it already did — so this is inert there rather than a second
|
|
29
|
+
* gutter. Equal widths, one declaration.
|
|
30
|
+
*
|
|
31
|
+
* Inert, too, wherever scrollbars overlay rather than take space (macOS with a
|
|
32
|
+
* trackpad): there was no delta to fix and there is none to introduce.
|
|
33
|
+
* The fuller fix — `html { scrollbar-gutter: stable }` — would also equalise a
|
|
34
|
+
* SHORT scrolling page against a long one; that is an estate-wide change to
|
|
35
|
+
* every consumer's root element and is not this ticket's.
|
|
36
|
+
*
|
|
12
37
|
* The background is `var(--kol-shell-page-wash, var(--kol-surface-primary))`
|
|
13
38
|
* (ShellPageWash, 2026-08-27): unset, today's primary pixel; set by
|
|
14
39
|
* `AppShell pageWash`, a transparent wash over the shell's primary back —
|
|
@@ -26,6 +51,7 @@ export default function PageShell({ mode = 'scroll', className = '', style, chil
|
|
|
26
51
|
style={{
|
|
27
52
|
background: 'var(--kol-shell-page-wash, var(--kol-surface-primary))',
|
|
28
53
|
padding: 'var(--kol-shell-page-pad)',
|
|
54
|
+
scrollbarGutter: 'stable',
|
|
29
55
|
display: 'flex',
|
|
30
56
|
flexDirection: 'column',
|
|
31
57
|
...modeStyle,
|