@kolatts/pncli 5.0.0 → 5.0.2

package/dist/cli.js

@@ -1,5 +1,6 @@
 #!/usr/bin/env node
 import {
+  assertValidCustomFields,
   getGlobalConfigPath,
   loadConfig,
   loadJsonFile,
@@ -9,13 +10,12 @@ import {
   setRepoConfigValue,
   writeGlobalConfig,
   writeRepoConfig
-} from "./chunk-3JICA4FZ.js";
+} from "./chunk-GRKPFSQD.js";
 import {
   createHttpClient
-} from "./chunk-EC6VSC6G.js";
+} from "./chunk-5Q4VM6GO.js";
 import {
   ExitCode,
-  PncliError,
   fail,
   log,
   setGlobalOptions,
@@ -23,7 +23,10 @@ import {
   success,
   warn,
   writeRawOutput
-} from "./chunk-HZF6WQPU.js";
+} from "./chunk-BOFSNQQ2.js";
+import {
+  PncliError
+} from "./chunk-HRNOAQDN.js";
 import {
   AdoCoreClient
 } from "./chunk-VDL32PSG.js";
@@ -604,7 +607,7 @@ var BitbucketClient = class {
               project: { key: opts.project }
             }
           },
-          reviewers: (opts.reviewers ?? []).map((slug) => ({ user: { slug } }))
+          reviewers: (opts.reviewers ?? []).map((name) => ({ user: { name } }))
         }
       }
     );
@@ -613,7 +616,7 @@ var BitbucketClient = class {
     const body = { version: opts.version };
     if (opts.title) body.title = opts.title;
     if (opts.description !== void 0) body.description = opts.description;
-    if (opts.reviewers) body.reviewers = opts.reviewers.map((slug) => ({ user: { slug } }));
+    if (opts.reviewers) body.reviewers = opts.reviewers.map((name) => ({ user: { name } }));
     return this.http.bitbucket(
       `${API}/projects/${opts.project}/repos/${opts.repo}/pull-requests/${opts.id}`,
       { method: "PUT", body }
@@ -1228,6 +1231,7 @@ function collectMetaFields(projects, issueType) {
 function buildFieldMap(fields) {
   const byName = /* @__PURE__ */ new Map();
   const byId = /* @__PURE__ */ new Map();
+  assertValidCustomFields(fields);
   for (const f of fields) {
     byName.set(f.name.toLowerCase(), f);
     byId.set(f.id, f);
@@ -6553,6 +6557,47 @@ function marketplaceLabel(m) {
 function scrubToken(msg) {
   return msg.replace(/x-(?:token-auth|access-token):[^@]+@/g, "x-token-auth:***@");
 }
+function isConfiguredGitHubHost(repoUrl, githubBaseUrl) {
+  try {
+    const host = new URL(repoUrl).hostname;
+    if (host === "github.com") return true;
+    if (!githubBaseUrl) return false;
+    return new URL(githubBaseUrl).hostname === host;
+  } catch {
+    return false;
+  }
+}
+function resolveMarketplaceToken(explicitToken, repoUrl) {
+  if (explicitToken) return explicitToken;
+  if (!repoUrl) return void 0;
+  const resolved = loadConfig();
+  if (!isConfiguredGitHubHost(repoUrl, resolved.github.baseUrl)) return void 0;
+  return resolved.github.token;
+}
+var GIT_AUTH_FAILURE_PATTERNS = [
+  /invalid username or (password|token)/i,
+  /authentication failed/i,
+  /could not read username/i,
+  /could not read password/i,
+  /support for password authentication was removed/i
+];
+var GIT_NOT_FOUND_PATTERNS = [/repository not found/i];
+function describeGitFailure(rawMessage, marketplaceName, tokenSource) {
+  const msg = scrubToken(rawMessage);
+  if (GIT_AUTH_FAILURE_PATTERNS.some((p) => p.test(msg))) {
+    const hint = tokenSource === "explicit" ? `The token configured for marketplace "${marketplaceName}" was rejected \u2014 it may be expired, revoked, or missing required scopes. Update it with: pncli skills marketplace add <url> --token <new-token>` : tokenSource === "fallback" ? `The GitHub token pncli is using (PNCLI_GITHUB_TOKEN / GITHUB_TOKEN / github.token) was rejected for marketplace "${marketplaceName}" \u2014 it may be expired, revoked, or missing required scopes for this repo. Rotate that token, or set one specifically for this marketplace: pncli skills marketplace add <url> --token <new-token>` : `Marketplace "${marketplaceName}" requires authentication but no token is configured. Add one with: pncli skills marketplace add <url> --token <token>`;
+    return new Error(`${hint}
+
+Git reported: ${msg}`);
+  }
+  if (GIT_NOT_FOUND_PATTERNS.some((p) => p.test(msg))) {
+    const hint = tokenSource === "explicit" ? `Repository for marketplace "${marketplaceName}" was not found \u2014 check the URL and that the configured token has access to it.` : tokenSource === "fallback" ? `Repository for marketplace "${marketplaceName}" was not found \u2014 check the URL and that pncli's configured GitHub token has access to it.` : `Repository for marketplace "${marketplaceName}" was not found \u2014 if it's private, add a token: pncli skills marketplace add <url> --token <token>`;
+    return new Error(`${hint}
+
+Git reported: ${msg}`);
+  }
+  return new Error(msg);
+}
 function assertInteractive(hint) {
   if (!process.stdin.isTTY) {
     throw new Error(`This selection requires an interactive terminal. ${hint}`);
@@ -7019,7 +7064,7 @@ function upsertMarketplace(all, entry) {
     all.push(entry);
   }
 }
-function cloneOrReuseMarketplace(url, resolvedPath, opts) {
+function cloneOrReuseMarketplace(url, resolvedPath, opts, marketplaceName) {
   const hasGit = fs2.existsSync(path7.join(resolvedPath, ".git"));
   if (fs2.existsSync(resolvedPath) && !hasGit && fs2.readdirSync(resolvedPath).length > 0) {
     throw new Error(`Directory already exists and is not a git repo: ${resolvedPath}`);
@@ -7028,9 +7073,10 @@ function cloneOrReuseMarketplace(url, resolvedPath, opts) {
     warn(`Directory already contains a git repo at ${resolvedPath} \u2014 skipping clone, updating config and re-installing plugins.`);
     return;
   }
+  const resolvedToken = resolveMarketplaceToken(opts.token, url);
   const branchLabel = opts.branch ?? "remote default";
   warn(`Cloning ${url} (branch: ${branchLabel}) \u2192 ${resolvedPath}...`);
-  const cloneUrl = opts.token ? injectTokenIntoUrl(url, opts.token) : url;
+  const cloneUrl = resolvedToken ? injectTokenIntoUrl(url, resolvedToken) : url;
   const cloneArgs = ["clone"];
   if (opts.branch) cloneArgs.push("--branch", opts.branch);
   cloneArgs.push(cloneUrl, resolvedPath);
@@ -7045,15 +7091,17 @@ function cloneOrReuseMarketplace(url, resolvedPath, opts) {
     }
     if (!cloneActuallySucceeded) {
       const msg = e instanceof Error ? e.message : String(e);
-      throw new Error(scrubToken(msg));
+      const tokenSource = opts.token ? "explicit" : resolvedToken ? "fallback" : "none";
+      throw describeGitFailure(msg, marketplaceName, tokenSource);
     }
   }
 }
 function pullMarketplace(marketplacePath, repoUrl, token, marketplaceName) {
+  const resolvedToken = resolveMarketplaceToken(token, repoUrl);
   warn(`Pulling latest content for "${marketplaceName}"...`);
   const gitArgs = ["-C", marketplacePath];
-  if (repoUrl && token) {
-    gitArgs.push("-c", `remote.origin.url=${injectTokenIntoUrl(repoUrl, token)}`);
+  if (repoUrl && resolvedToken) {
+    gitArgs.push("-c", `remote.origin.url=${injectTokenIntoUrl(repoUrl, resolvedToken)}`);
   }
   gitArgs.push("pull");
   let pullOutput;
@@ -7061,7 +7109,8 @@ function pullMarketplace(marketplacePath, repoUrl, token, marketplaceName) {
     pullOutput = execFileSync3("git", gitArgs, { encoding: "utf8", stdio: ["inherit", "pipe", "pipe"], env: { ...process.env, LANG: "C", LC_ALL: "C" } });
   } catch (e) {
     const msg = e instanceof Error ? e.message : String(e);
-    throw new Error(scrubToken(msg));
+    const tokenSource = token ? "explicit" : resolvedToken ? "fallback" : "none";
+    throw describeGitFailure(msg, marketplaceName, tokenSource);
   }
   const updated = !pullOutput.includes("Already up to date");
   if (pullOutput.trim() && updated) warn(pullOutput.trim());
@@ -7152,7 +7201,7 @@ function syncMarketplacePlugins(m, targetDir, force, pluginFilter, installedOnly
 function performMarketplaceAdd(url, localPath, opts) {
   const resolvedPath = path7.resolve(localPath ?? defaultMarketplacePath(url));
   const marketplaceName = opts.name ?? repoNameFromUrl(url);
-  cloneOrReuseMarketplace(url, resolvedPath, opts);
+  cloneOrReuseMarketplace(url, resolvedPath, opts, marketplaceName);
   const configPath = getGlobalConfigPath();
   const { existing, all } = loadMarketplacesConfig(configPath);
   const entry = {
@@ -10342,11 +10391,11 @@ function registerAdoRepoCommands(ado) {
       const start = Date.now();
       try {
         const globalOpts = ado.optsWithGlobals();
-        const { loadConfig: lc } = await import("./config-7FK4MAQC.js");
+        const { loadConfig: lc } = await import("./config-ZVQMQ6B2.js");
         const config = lc({ configPath: globalOpts.config });
         const { collection, project, repo: repo2, gitClient } = getAdoContext(ado, true);
         const { AdoCoreClient: AdoCoreClient2 } = await import("./core-SWYVXOQ4.js");
-        const { createHttpClient: createHttpClient2 } = await import("./http-M5GQGXVF.js");
+        const { createHttpClient: createHttpClient2 } = await import("./http-RX7E2V5C.js");
         const http = createHttpClient2(config, Boolean(globalOpts.dryRun));
         const coreClient = new AdoCoreClient2(http);
         const me = await coreClient.getConnectionData(collection);
@@ -12356,7 +12405,7 @@ function registerFigmaCommands(program2) {
   const figma = program2.command("figma").description("Figma design operations (files, comments, versions)");
   figma.command("file").description("Get a Figma file \u2014 metadata, structure, and component/style inventory").argument("<file-key-or-url>", "Figma file key or full Figma URL (https://www.figma.com/design/<key>/...)").option("--document", "Include the full document node tree (can be large; omitted by default)").action(async (fileKeyOrUrl, opts) => {
     const start = Date.now();
-    const { success: success2, fail: fail2 } = await import("./output-XT3WT5L5.js");
+    const { success: success2, fail: fail2 } = await import("./output-HDUIIXUI.js");
     try {
       const fileKey = parseFileKey(fileKeyOrUrl);
       const params = {};
@@ -12388,7 +12437,7 @@ function registerFigmaCommands(program2) {
   });
   figma.command("comments").description("Get comments on a Figma file").argument("<file-key-or-url>", "Figma file key or full Figma URL").option("--as-of <date>", "ISO 8601 timestamp \u2014 return only comments created before this time").action(async (fileKeyOrUrl, opts) => {
     const start = Date.now();
-    const { success: success2, fail: fail2 } = await import("./output-XT3WT5L5.js");
+    const { success: success2, fail: fail2 } = await import("./output-HDUIIXUI.js");
     try {
       const fileKey = parseFileKey(fileKeyOrUrl);
       const params = {};
@@ -12406,7 +12455,7 @@ function registerFigmaCommands(program2) {
   });
   figma.command("versions").description("Get the version history of a Figma file").argument("<file-key-or-url>", "Figma file key or full Figma URL").action(async (fileKeyOrUrl) => {
     const start = Date.now();
-    const { success: success2, fail: fail2 } = await import("./output-XT3WT5L5.js");
+    const { success: success2, fail: fail2 } = await import("./output-HDUIIXUI.js");
     try {
       const fileKey = parseFileKey(fileKeyOrUrl);
       const data = await getHttp5(program2).figma(`/v1/files/${encodeURIComponent(fileKey)}/versions`);
@@ -12422,7 +12471,7 @@ function registerFigmaCommands(program2) {
   });
   figma.command("project-files").description("List files in a Figma project").argument("<project-id>", "Figma project ID (visible in the project URL)").action(async (projectId) => {
     const start = Date.now();
-    const { success: success2, fail: fail2 } = await import("./output-XT3WT5L5.js");
+    const { success: success2, fail: fail2 } = await import("./output-HDUIIXUI.js");
     try {
       const data = await getHttp5(program2).figma(`/v1/projects/${encodeURIComponent(projectId)}/files`);
       success2(
@@ -12437,7 +12486,7 @@ function registerFigmaCommands(program2) {
   });
   figma.command("me").description("Get the current Figma user (useful for verifying credentials)").action(async () => {
     const start = Date.now();
-    const { success: success2, fail: fail2 } = await import("./output-XT3WT5L5.js");
+    const { success: success2, fail: fail2 } = await import("./output-HDUIIXUI.js");
     try {
       const data = await getHttp5(program2).figma("/v1/me");
       success2(data, "figma", "me", start);