@kohala/devkit 0.1.5 → 0.1.7

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @kohala/devkit
 
+## 0.1.7
+
+- **BUG-006 fixed: `kohala deploy --run` no longer misreports every 409 as
+  "agent not enabled".** The platform returns two distinct 409s for a manual
+  run: agent disabled, and `nothing_to_run` (no script bound to an active
+  cron schedule — the case a fresh schedule-less scaffold always hits, even
+  after enabling the agent). The CLI now tells them apart and gives the
+  right fix for each: enable the agent in the dashboard, or add a
+  `schedule` to kohala.json so deploy binds the scripts. Verified live that
+  enabling an agent survives redeploys (the upsert does not reset it).
+  DEPLOY.md documents both cases.
+
+## 0.1.6
+
+- **BUG-077 fixed: a deployed agent with a manifest schedule can now actually
+  run.** Setting `agentScheduleCron` (0.1.5 / BUG-069) enabled the schedule
+  but bound no script to it — `agentScheduleEntries` stayed null and every
+  run 409'd with `nothing_to_run`. Deploy now sets the schedule *after*
+  uploading the skills and binds every skill script to the cron via
+  `agentScheduleEntries` (`{scriptFilename, schedule}` per skill), then
+  verifies the cron, the enabled flag, and every binding round-tripped —
+  failing loudly if any script would be left unbound.
+
 ## 0.1.5
 
 - **BUG-069 fixed: the manifest `schedule` now actually lands on the

package/dist/cli/index.js

@@ -2258,6 +2258,11 @@ function buildDeployPlan(manifest, agentDir) {
       code: fs12.readFileSync(scriptPath, "utf8")
     };
   });
+  if (manifest.schedule && skills.length === 0) {
+    throw new Error(
+      `Manifest has a schedule ("${manifest.schedule}") but no skills \u2014 the platform would have nothing to run on that schedule (every run fails with nothing_to_run). Add at least one skill or remove the schedule.`
+    );
+  }
   return {
     agent: {
       name: manifest.name,
@@ -2283,6 +2288,12 @@ var DeployError = class extends Error {
   }
   status;
 };
+function classifyManualRun409(error) {
+  if (error.status !== 409) return "other";
+  if (/nothing_to_run|would execute nothing/i.test(error.message)) return "nothing_to_run";
+  if (/not enabled/i.test(error.message)) return "disabled";
+  return "other";
+}
 var KohalaClient = class {
   constructor(apiKey, baseUrl = DEFAULT_BASE_URL) {
     this.apiKey = apiKey;
@@ -2348,15 +2359,24 @@ var KohalaClient = class {
    * schedule explicitly and verifies it round-tripped. Never called without
    * a schedule — deploy is additive and must not disable existing schedules.
    */
-  async setSchedule(agentId, cron) {
+  async setSchedule(agentId, cron, scriptFilenames) {
+    const entries = scriptFilenames.map((scriptFilename) => ({
+      scriptFilename,
+      schedule: cron
+    }));
     const data = await this.request("PATCH", `/api/v1/agents/${agentId}`, {
       agentScheduleCron: cron,
-      agentScheduleEnabled: true
+      agentScheduleEnabled: true,
+      agentScheduleEntries: entries
     });
-    if (data?.agentScheduleCron !== cron || data?.agentScheduleEnabled !== true) {
+    const boundFilenames = new Set(
+      (data?.agentScheduleEntries ?? []).filter((entry) => entry.schedule === cron).map((entry) => entry.scriptFilename)
+    );
+    const allBound = scriptFilenames.length > 0 && scriptFilenames.every((filename) => boundFilenames.has(filename));
+    if (data?.agentScheduleCron !== cron || data?.agentScheduleEnabled !== true || !allBound) {
       throw new DeployError(
         500,
-        `Platform did not persist the schedule "${cron}" (got agentScheduleCron=${JSON.stringify(data?.agentScheduleCron)}, agentScheduleEnabled=${JSON.stringify(data?.agentScheduleEnabled)}) \u2014 aborting.`
+        `Platform did not persist the schedule "${cron}" (got agentScheduleCron=${JSON.stringify(data?.agentScheduleCron)}, agentScheduleEnabled=${JSON.stringify(data?.agentScheduleEnabled)}, agentScheduleEntries=${JSON.stringify(data?.agentScheduleEntries ?? null)}) \u2014 the deployed agent's scripts would not be bound to the schedule. Aborting.`
       );
     }
   }
@@ -2383,26 +2403,34 @@ function registerDeployCommand(program2) {
         console.log("");
         console.log(pc8.bold("1. POST /api/v1/agents (idempotent on name)"));
         console.log(JSON.stringify(plan.agent, null, 2));
-        if (plan.agent.agentScheduleCron) {
+        for (const skill of plan.skills) {
           console.log("");
-          console.log(pc8.bold("1b. PATCH /api/v1/agents/:id (persist schedule on updates)"));
+          console.log(pc8.bold(`2. POST /api/v1/agents/:id/skills \u2014 "${skill.name}"`));
           console.log(
             JSON.stringify(
-              {
-                agentScheduleCron: plan.agent.agentScheduleCron,
-                agentScheduleEnabled: true
-              },
+              { ...skill, code: `<${Buffer.byteLength(skill.code)} bytes of ${skill.scriptFilename}>` },
               null,
               2
             )
           );
         }
-        for (const skill of plan.skills) {
+        if (plan.agent.agentScheduleCron) {
           console.log("");
-          console.log(pc8.bold(`2. POST /api/v1/agents/:id/skills \u2014 "${skill.name}"`));
+          console.log(
+            pc8.bold(
+              "2b. PATCH /api/v1/agents/:id (persist schedule + bind scripts, after skills upload)"
+            )
+          );
           console.log(
             JSON.stringify(
-              { ...skill, code: `<${Buffer.byteLength(skill.code)} bytes of ${skill.scriptFilename}>` },
+              {
+                agentScheduleCron: plan.agent.agentScheduleCron,
+                agentScheduleEnabled: true,
+                agentScheduleEntries: plan.skills.map((skill) => ({
+                  scriptFilename: skill.scriptFilename,
+                  schedule: plan.agent.agentScheduleCron
+                }))
+              },
               null,
               2
             )
@@ -2429,14 +2457,19 @@ function registerDeployCommand(program2) {
       console.log(
         pc8.green(`  \u2714 agent ${upserted.created ? "created" : "updated"} (id ${upserted.id})`)
       );
-      if (plan.agent.agentScheduleCron) {
-        await client.setSchedule(upserted.id, plan.agent.agentScheduleCron);
-        console.log(pc8.green(`  \u2714 schedule set (${plan.agent.agentScheduleCron})`));
-      }
       for (const skill of plan.skills) {
         await client.upsertSkill(upserted.id, skill);
         console.log(pc8.green(`  \u2714 skill "${skill.name}" uploaded (${skill.scriptFilename})`));
       }
+      if (plan.agent.agentScheduleCron) {
+        const filenames = plan.skills.map((skill) => skill.scriptFilename);
+        await client.setSchedule(upserted.id, plan.agent.agentScheduleCron, filenames);
+        console.log(
+          pc8.green(
+            `  \u2714 schedule set (${plan.agent.agentScheduleCron}, bound: ${filenames.join(", ")})`
+          )
+        );
+      }
       await client.setQuota(upserted.id, plan.quota);
       console.log(
         pc8.green(
@@ -2449,16 +2482,33 @@ function registerDeployCommand(program2) {
           console.log(pc8.green(`  \u2714 manual run triggered: ${runUrl}`));
         } catch (error) {
           if (error instanceof DeployError && error.status === 409) {
-            console.error(
-              pc8.yellow(
-                `  \u2716 manual run not started: the agent is not enabled on the platform yet.`
-              )
-            );
-            console.error(
-              pc8.dim(
-                `    Deploy itself succeeded. Enable "${manifest.name}" in your kohala.ai dashboard, then re-run \`kohala deploy ${agent} --run\` (or trigger a run from the dashboard).`
-              )
-            );
+            const reason = classifyManualRun409(error);
+            if (reason === "nothing_to_run") {
+              console.error(
+                pc8.yellow(
+                  `  \u2716 manual run not started: no script is bound to an active schedule, so a run would execute nothing.`
+                )
+              );
+              console.error(
+                pc8.dim(
+                  `    Deploy itself succeeded. The platform only runs scripts bound to a cron schedule: add e.g. "schedule": "0 9 * * *" to kohala.json, then re-run \`kohala deploy ${agent} --run\` \u2014 deploy binds every skill script to it.`
+                )
+              );
+            } else if (reason === "disabled") {
+              console.error(
+                pc8.yellow(
+                  `  \u2716 manual run not started: the agent is not enabled on the platform yet.`
+                )
+              );
+              console.error(
+                pc8.dim(
+                  `    Deploy itself succeeded. Enable "${manifest.name}" in your kohala.ai dashboard, then re-run \`kohala deploy ${agent} --run\` (or trigger a run from the dashboard). Enabling survives redeploys.`
+                )
+              );
+            } else {
+              console.error(pc8.yellow(`  \u2716 manual run not started (409).`));
+              console.error(pc8.dim(`    ${error.message}`));
+            }
             process.exitCode = 1;
             return;
           }