@kodelyth/nextcloud-talk 2026.5.42 → 2026.6.1

package/src/room-info.test.ts

@@ -1,160 +0,0 @@
-import { afterEach, describe, expect, it, vi } from "vitest";
-import { resolveNextcloudTalkRoomKind, testing } from "./room-info.js";
-
-const fetchWithSsrFGuard = vi.hoisted(() => vi.fn());
-const readFileSync = vi.hoisted(() => vi.fn());
-
-vi.mock("../runtime-api.js", () => {
-  return vi
-    .importActual<typeof import("../runtime-api.js")>("../runtime-api.js")
-    .then((actual) => ({
-      ...actual,
-      fetchWithSsrFGuard,
-    }));
-});
-
-vi.mock("node:fs", () => {
-  return vi.importActual<typeof import("node:fs")>("node:fs").then((actual) => ({
-    ...actual,
-    readFileSync,
-  }));
-});
-
-afterEach(() => {
-  fetchWithSsrFGuard.mockReset();
-  readFileSync.mockReset();
-  testing.resetRoomCache();
-});
-
-function requireFirstFetchParams(): { auditContext?: string; url?: string } {
-  const [call] = fetchWithSsrFGuard.mock.calls;
-  if (!call) {
-    throw new Error("expected Nextcloud Talk room info fetch call");
-  }
-  const [fetchParams] = call;
-  if (!fetchParams || typeof fetchParams !== "object" || Array.isArray(fetchParams)) {
-    throw new Error("expected Nextcloud Talk room info fetch call");
-  }
-  return fetchParams as { auditContext?: string; url?: string };
-}
-
-describe("nextcloud talk room info", () => {
-  it("resolves direct rooms from the room info endpoint", async () => {
-    const release = vi.fn(async () => {});
-    fetchWithSsrFGuard.mockResolvedValue({
-      response: {
-        ok: true,
-        json: async () => ({
-          ocs: {
-            data: {
-              type: 1,
-            },
-          },
-        }),
-      },
-      release,
-    });
-
-    const kind = await resolveNextcloudTalkRoomKind({
-      account: {
-        accountId: "acct-direct",
-        baseUrl: "https://nc.example.com",
-        config: {
-          apiUser: "bot",
-          apiPassword: "secret",
-        },
-      } as never,
-      roomToken: "room-direct",
-    });
-
-    expect(kind).toBe("direct");
-    const fetchParams = requireFirstFetchParams();
-    expect(fetchParams.url).toBe(
-      "https://nc.example.com/ocs/v2.php/apps/spreed/api/v4/room/room-direct",
-    );
-    expect(fetchParams.auditContext).toBe("nextcloud-talk.room-info");
-    expect(release).toHaveBeenCalledTimes(1);
-  });
-
-  it("reads the api password from a file and logs non-ok room info responses", async () => {
-    const release = vi.fn(async () => {});
-    const log = vi.fn();
-    const error = vi.fn();
-    const exit = vi.fn();
-    readFileSync.mockReturnValue("file-secret\n");
-    fetchWithSsrFGuard.mockResolvedValue({
-      response: {
-        ok: false,
-        status: 403,
-        json: async () => ({}),
-      },
-      release,
-    });
-
-    const kind = await resolveNextcloudTalkRoomKind({
-      account: {
-        accountId: "acct-group",
-        baseUrl: "https://nc.example.com",
-        config: {
-          apiUser: "bot",
-          apiPasswordFile: "/tmp/nextcloud-secret",
-        },
-      } as never,
-      roomToken: "room-group",
-      runtime: { log, error, exit },
-    });
-
-    expect(kind).toBeUndefined();
-    expect(readFileSync).toHaveBeenCalledWith("/tmp/nextcloud-secret", "utf-8");
-    expect(log).toHaveBeenCalledWith("nextcloud-talk: room lookup failed (403) token=room-group");
-    expect(release).toHaveBeenCalledTimes(1);
-  });
-
-  it("reports malformed room info JSON with a stable channel error", async () => {
-    const release = vi.fn(async () => {});
-    const log = vi.fn();
-    const error = vi.fn();
-    const exit = vi.fn();
-    fetchWithSsrFGuard.mockResolvedValue({
-      response: new Response("{ nope", {
-        status: 200,
-        headers: { "content-type": "application/json" },
-      }),
-      release,
-    });
-
-    const kind = await resolveNextcloudTalkRoomKind({
-      account: {
-        accountId: "acct-malformed",
-        baseUrl: "https://nc.example.com",
-        config: {
-          apiUser: "bot",
-          apiPassword: "secret",
-        },
-      } as never,
-      roomToken: "room-malformed",
-      runtime: { log, error, exit },
-    });
-
-    expect(kind).toBeUndefined();
-    expect(error).toHaveBeenCalledWith(
-      "nextcloud-talk: room lookup error: Error: Nextcloud Talk room info failed: malformed JSON response",
-    );
-    expect(release).toHaveBeenCalledTimes(1);
-  });
-
-  it("returns undefined from room info without credentials or base url", async () => {
-    await expect(
-      resolveNextcloudTalkRoomKind({
-        account: {
-          accountId: "acct-missing",
-          baseUrl: "",
-          config: {},
-        } as never,
-        roomToken: "room-missing",
-      }),
-    ).resolves.toBeUndefined();
-
-    expect(fetchWithSsrFGuard).not.toHaveBeenCalled();
-  });
-});

package/src/room-info.ts

@@ -1,130 +0,0 @@
-import { formatErrorMessage } from "klaw/plugin-sdk/error-runtime";
-import { readProviderJsonResponse } from "klaw/plugin-sdk/provider-http";
-import { ssrfPolicyFromPrivateNetworkOptIn } from "klaw/plugin-sdk/ssrf-runtime";
-import { fetchWithSsrFGuard, type RuntimeEnv } from "../runtime-api.js";
-import type { ResolvedNextcloudTalkAccount } from "./accounts.js";
-import { resolveNextcloudTalkApiCredentials } from "./api-credentials.js";
-
-const ROOM_CACHE_TTL_MS = 5 * 60 * 1000;
-const ROOM_CACHE_ERROR_TTL_MS = 30 * 1000;
-
-const roomCache = new Map<
-  string,
-  { kind?: "direct" | "group"; fetchedAt: number; error?: string }
->();
-
-export const testing = {
-  resetRoomCache() {
-    roomCache.clear();
-  },
-};
-
-function resolveRoomCacheKey(params: { accountId: string; roomToken: string }) {
-  return `${params.accountId}:${params.roomToken}`;
-}
-
-function coerceRoomType(value: unknown): number | undefined {
-  if (typeof value === "number" && Number.isFinite(value)) {
-    return value;
-  }
-  if (typeof value === "string" && value.trim()) {
-    const parsed = Number.parseInt(value, 10);
-    return Number.isFinite(parsed) ? parsed : undefined;
-  }
-  return undefined;
-}
-
-function resolveRoomKindFromType(type: number | undefined): "direct" | "group" | undefined {
-  if (!type) {
-    return undefined;
-  }
-  if (type === 1 || type === 5 || type === 6) {
-    return "direct";
-  }
-  return "group";
-}
-
-export async function resolveNextcloudTalkRoomKind(params: {
-  account: ResolvedNextcloudTalkAccount;
-  roomToken: string;
-  runtime?: RuntimeEnv;
-}): Promise<"direct" | "group" | undefined> {
-  const { account, roomToken, runtime } = params;
-  const key = resolveRoomCacheKey({ accountId: account.accountId, roomToken });
-  const cached = roomCache.get(key);
-  if (cached) {
-    const age = Date.now() - cached.fetchedAt;
-    if (cached.kind && age < ROOM_CACHE_TTL_MS) {
-      return cached.kind;
-    }
-    if (cached.error && age < ROOM_CACHE_ERROR_TTL_MS) {
-      return undefined;
-    }
-  }
-
-  const apiCredentials = resolveNextcloudTalkApiCredentials({
-    apiUser: account.config.apiUser,
-    apiPassword: account.config.apiPassword,
-    apiPasswordFile: account.config.apiPasswordFile,
-  });
-  if (!apiCredentials) {
-    return undefined;
-  }
-
-  const baseUrl = account.baseUrl?.trim();
-  if (!baseUrl) {
-    return undefined;
-  }
-
-  const url = `${baseUrl}/ocs/v2.php/apps/spreed/api/v4/room/${roomToken}`;
-  const auth = Buffer.from(
-    `${apiCredentials.apiUser}:${apiCredentials.apiPassword}`,
-    "utf-8",
-  ).toString("base64");
-
-  try {
-    const { response, release } = await fetchWithSsrFGuard({
-      url,
-      init: {
-        method: "GET",
-        headers: {
-          Authorization: `Basic ${auth}`,
-          "OCS-APIRequest": "true",
-          Accept: "application/json",
-        },
-      },
-      auditContext: "nextcloud-talk.room-info",
-      policy: ssrfPolicyFromPrivateNetworkOptIn(account.config),
-    });
-    try {
-      if (!response.ok) {
-        roomCache.set(key, {
-          fetchedAt: Date.now(),
-          error: `status:${response.status}`,
-        });
-        runtime?.log?.(
-          `nextcloud-talk: room lookup failed (${response.status}) token=${roomToken}`,
-        );
-        return undefined;
-      }
-
-      const payload = await readProviderJsonResponse<{
-        ocs?: { data?: { type?: number | string } };
-      }>(response, "Nextcloud Talk room info failed");
-      const type = coerceRoomType(payload.ocs?.data?.type);
-      const kind = resolveRoomKindFromType(type);
-      roomCache.set(key, { fetchedAt: Date.now(), kind });
-      return kind;
-    } finally {
-      await release();
-    }
-  } catch (err) {
-    roomCache.set(key, {
-      fetchedAt: Date.now(),
-      error: formatErrorMessage(err),
-    });
-    runtime?.error?.(`nextcloud-talk: room lookup error: ${String(err)}`);
-    return undefined;
-  }
-}
-export { testing as __testing };

package/src/runtime.ts

@@ -1,9 +0,0 @@
-import { createPluginRuntimeStore } from "klaw/plugin-sdk/runtime-store";
-import type { PluginRuntime } from "klaw/plugin-sdk/runtime-store";
-
-const { setRuntime: setNextcloudTalkRuntime, getRuntime: getNextcloudTalkRuntime } =
-  createPluginRuntimeStore<PluginRuntime>({
-    pluginId: "nextcloud-talk",
-    errorMessage: "Nextcloud Talk runtime not initialized",
-  });
-export { getNextcloudTalkRuntime, setNextcloudTalkRuntime };

package/src/secret-contract.ts

@@ -1,103 +0,0 @@
-import {
-  collectConditionalChannelFieldAssignments,
-  getChannelSurface,
-  hasOwnProperty,
-  type ChannelAccountEntry,
-  type ResolverContext,
-  type SecretDefaults,
-} from "klaw/plugin-sdk/channel-secret-basic-runtime";
-
-export const secretTargetRegistryEntries: import("klaw/plugin-sdk/channel-secret-basic-runtime").SecretTargetRegistryEntry[] =
-  [
-    {
-      id: "channels.nextcloud-talk.accounts.*.apiPassword",
-      targetType: "channels.nextcloud-talk.accounts.*.apiPassword",
-      configFile: "klaw.json",
-      pathPattern: "channels.nextcloud-talk.accounts.*.apiPassword",
-      secretShape: "secret_input",
-      expectedResolvedValue: "string",
-      includeInPlan: true,
-      includeInConfigure: true,
-      includeInAudit: true,
-    },
-    {
-      id: "channels.nextcloud-talk.accounts.*.botSecret",
-      targetType: "channels.nextcloud-talk.accounts.*.botSecret",
-      configFile: "klaw.json",
-      pathPattern: "channels.nextcloud-talk.accounts.*.botSecret",
-      secretShape: "secret_input",
-      expectedResolvedValue: "string",
-      includeInPlan: true,
-      includeInConfigure: true,
-      includeInAudit: true,
-    },
-    {
-      id: "channels.nextcloud-talk.apiPassword",
-      targetType: "channels.nextcloud-talk.apiPassword",
-      configFile: "klaw.json",
-      pathPattern: "channels.nextcloud-talk.apiPassword",
-      secretShape: "secret_input",
-      expectedResolvedValue: "string",
-      includeInPlan: true,
-      includeInConfigure: true,
-      includeInAudit: true,
-    },
-    {
-      id: "channels.nextcloud-talk.botSecret",
-      targetType: "channels.nextcloud-talk.botSecret",
-      configFile: "klaw.json",
-      pathPattern: "channels.nextcloud-talk.botSecret",
-      secretShape: "secret_input",
-      expectedResolvedValue: "string",
-      includeInPlan: true,
-      includeInConfigure: true,
-      includeInAudit: true,
-    },
-  ];
-
-export function collectRuntimeConfigAssignments(params: {
-  config: { channels?: Record<string, unknown> };
-  defaults?: SecretDefaults;
-  context: ResolverContext;
-}): void {
-  const resolved = getChannelSurface(params.config, "nextcloud-talk");
-  if (!resolved) {
-    return;
-  }
-  const { channel: nextcloudTalk, surface } = resolved;
-  const inheritsField =
-    (field: string) =>
-    ({ account, enabled }: ChannelAccountEntry) =>
-      enabled && !hasOwnProperty(account, field);
-  collectConditionalChannelFieldAssignments({
-    channelKey: "nextcloud-talk",
-    field: "botSecret",
-    channel: nextcloudTalk,
-    surface,
-    defaults: params.defaults,
-    context: params.context,
-    topLevelActiveWithoutAccounts: true,
-    topLevelInheritedAccountActive: inheritsField("botSecret"),
-    accountActive: ({ enabled }) => enabled,
-    topInactiveReason: "no enabled Nextcloud Talk surface inherits this top-level botSecret.",
-    accountInactiveReason: "Nextcloud Talk account is disabled.",
-  });
-  collectConditionalChannelFieldAssignments({
-    channelKey: "nextcloud-talk",
-    field: "apiPassword",
-    channel: nextcloudTalk,
-    surface,
-    defaults: params.defaults,
-    context: params.context,
-    topLevelActiveWithoutAccounts: true,
-    topLevelInheritedAccountActive: inheritsField("apiPassword"),
-    accountActive: ({ enabled }) => enabled,
-    topInactiveReason: "no enabled Nextcloud Talk surface inherits this top-level apiPassword.",
-    accountInactiveReason: "Nextcloud Talk account is disabled.",
-  });
-}
-
-export const channelSecrets = {
-  secretTargetRegistryEntries,
-  collectRuntimeConfigAssignments,
-};

package/src/secret-input.ts

@@ -1,4 +0,0 @@
-export {
-  buildSecretInputSchema,
-  normalizeResolvedSecretInputString,
-} from "klaw/plugin-sdk/secret-input";