@kodelyth/codex 2026.5.42 → 2026.6.1

package/src/app-server/computer-use.test.ts

@@ -1,788 +0,0 @@
-import fs from "node:fs";
-import os from "node:os";
-import path from "node:path";
-import { afterEach, describe, expect, it, vi } from "vitest";
-import {
-  ensureCodexComputerUse,
-  installCodexComputerUse,
-  readCodexComputerUseStatus,
-  type CodexComputerUseStatus,
-  type CodexComputerUseRequest,
-} from "./computer-use.js";
-
-function expectStatusFields(
-  status: CodexComputerUseStatus,
-  fields: Partial<CodexComputerUseStatus>,
-): void {
-  for (const key of Object.keys(fields) as Array<keyof CodexComputerUseStatus>) {
-    expect(status[key]).toEqual(fields[key]);
-  }
-}
-
-async function expectSetupErrorStatus(
-  promise: Promise<CodexComputerUseStatus>,
-  fields: Partial<CodexComputerUseStatus>,
-): Promise<void> {
-  let caught: unknown;
-  try {
-    await promise;
-  } catch (error) {
-    caught = error;
-  }
-  const error = requireRecord(caught, "setup error");
-  const status = requireRecord(error.status, "setup error status") as CodexComputerUseStatus;
-  expectStatusFields(status, fields);
-}
-
-function requireRecord(value: unknown, label: string): Record<string, unknown> {
-  if (typeof value !== "object" || value === null) {
-    throw new Error(`${label} was not an object`);
-  }
-  return value as Record<string, unknown>;
-}
-
-function requestCalls(
-  request: CodexComputerUseRequest,
-): ReadonlyArray<readonly [method: string, params?: unknown]> {
-  return vi.mocked(request).mock.calls as ReadonlyArray<readonly [string, unknown?]>;
-}
-
-function expectRequestMethodNotCalled(request: CodexComputerUseRequest, method: string): void {
-  expect(requestCalls(request).map(([calledMethod]) => calledMethod)).not.toContain(method);
-}
-
-describe("Codex Computer Use setup", () => {
-  const cleanupPaths: string[] = [];
-
-  afterEach(() => {
-    vi.useRealTimers();
-    for (const cleanupPath of cleanupPaths.splice(0)) {
-      fs.rmSync(cleanupPath, { recursive: true, force: true });
-    }
-  });
-
-  it("stays disabled until configured", async () => {
-    const status = await readCodexComputerUseStatus({ pluginConfig: {}, request: vi.fn() });
-    expectStatusFields(status, {
-      enabled: false,
-      ready: false,
-      reason: "disabled",
-      message: "Computer Use is disabled.",
-    });
-  });
-
-  it("reports an installed Computer Use MCP server from a registered marketplace", async () => {
-    const request = createComputerUseRequest({ installed: true });
-
-    const status = await readCodexComputerUseStatus({
-      pluginConfig: { computerUse: { enabled: true, marketplaceName: "desktop-tools" } },
-      request,
-    });
-
-    expectStatusFields(status, {
-      enabled: true,
-      ready: true,
-      reason: "ready",
-      installed: true,
-      pluginEnabled: true,
-      mcpServerAvailable: true,
-      marketplaceName: "desktop-tools",
-      tools: ["list_apps"],
-      message: "Computer Use is ready.",
-    });
-    expectRequestMethodNotCalled(request, "marketplace/add");
-    expectRequestMethodNotCalled(request, "experimentalFeature/enablement/set");
-    expectRequestMethodNotCalled(request, "plugin/install");
-  });
-
-  it("reports an installed but disabled Computer Use plugin separately", async () => {
-    const request = createComputerUseRequest({ installed: true, enabled: false });
-
-    const status = await readCodexComputerUseStatus({
-      pluginConfig: { computerUse: { enabled: true, marketplaceName: "desktop-tools" } },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: false,
-      reason: "plugin_disabled",
-      installed: true,
-      pluginEnabled: false,
-      mcpServerAvailable: false,
-      message:
-        "Computer Use is installed, but the computer-use plugin is disabled. Run /codex computer-use install or enable computerUse.autoInstall to re-enable it.",
-    });
-    expectRequestMethodNotCalled(request, "plugin/install");
-  });
-
-  it("does not register marketplace sources during status checks", async () => {
-    const request = createComputerUseRequest({ installed: true });
-
-    const status = await readCodexComputerUseStatus({
-      pluginConfig: {
-        computerUse: {
-          enabled: true,
-          marketplaceSource: "github:example/desktop-tools",
-        },
-      },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      message: "Computer Use is ready.",
-    });
-    expectRequestMethodNotCalled(request, "marketplace/add");
-    expectRequestMethodNotCalled(request, "experimentalFeature/enablement/set");
-  });
-
-  it("fails closed when multiple marketplaces contain Computer Use", async () => {
-    const request = createAmbiguousComputerUseRequest();
-
-    const status = await readCodexComputerUseStatus({
-      pluginConfig: { computerUse: { enabled: true } },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: false,
-      reason: "marketplace_missing",
-      message:
-        "Multiple Codex marketplaces contain computer-use. Configure computerUse.marketplaceName or computerUse.marketplacePath to choose one.",
-    });
-    expectRequestMethodNotCalled(request, "plugin/read");
-  });
-
-  it("installs Computer Use from a configured marketplace source", async () => {
-    const request = createComputerUseRequest({ installed: false });
-
-    const status = await installCodexComputerUse({
-      pluginConfig: {
-        computerUse: {
-          marketplaceSource: "github:example/desktop-tools",
-        },
-      },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      installed: true,
-      pluginEnabled: true,
-      tools: ["list_apps"],
-    });
-    expect(request).toHaveBeenCalledWith("experimentalFeature/enablement/set", {
-      enablement: { plugins: true },
-    });
-    expect(request).toHaveBeenCalledWith("marketplace/add", {
-      source: "github:example/desktop-tools",
-    });
-    expect(request).toHaveBeenCalledWith("plugin/install", {
-      marketplacePath: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-      pluginName: "computer-use",
-    });
-    expect(request).toHaveBeenCalledWith("config/mcpServer/reload", undefined);
-  });
-
-  it("re-enables an installed but disabled Computer Use plugin during install", async () => {
-    const request = createComputerUseRequest({ installed: true, enabled: false });
-
-    const status = await installCodexComputerUse({
-      pluginConfig: { computerUse: { marketplaceName: "desktop-tools" } },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      installed: true,
-      pluginEnabled: true,
-      message: "Computer Use is ready.",
-    });
-    expect(request).toHaveBeenCalledWith("plugin/install", {
-      marketplacePath: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-      pluginName: "computer-use",
-    });
-  });
-
-  it("fails closed when Computer Use is required but not installed", async () => {
-    const request = createComputerUseRequest({ installed: false });
-
-    await expectSetupErrorStatus(
-      ensureCodexComputerUse({
-        pluginConfig: { computerUse: { enabled: true, marketplaceName: "desktop-tools" } },
-        request,
-      }),
-      {
-        reason: "plugin_not_installed",
-      },
-    );
-    expectRequestMethodNotCalled(request, "plugin/install");
-  });
-
-  it("skips setup writes when auto-install is already ready", async () => {
-    const request = createComputerUseRequest({ installed: true });
-
-    const status = await ensureCodexComputerUse({
-      pluginConfig: {
-        computerUse: {
-          enabled: true,
-          autoInstall: true,
-          marketplaceName: "desktop-tools",
-        },
-      },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      message: "Computer Use is ready.",
-    });
-    expectRequestMethodNotCalled(request, "marketplace/add");
-    expectRequestMethodNotCalled(request, "experimentalFeature/enablement/set");
-    expectRequestMethodNotCalled(request, "plugin/install");
-  });
-
-  it("uses setup writes when auto-install needs to install", async () => {
-    const request = createComputerUseRequest({ installed: false });
-
-    const status = await ensureCodexComputerUse({
-      pluginConfig: {
-        computerUse: {
-          enabled: true,
-          autoInstall: true,
-        },
-      },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      message: "Computer Use is ready.",
-    });
-    expect(request).toHaveBeenCalledWith("experimentalFeature/enablement/set", {
-      enablement: { plugins: true },
-    });
-    expectRequestMethodNotCalled(request, "marketplace/add");
-    expect(request).toHaveBeenCalledWith("plugin/install", {
-      marketplacePath: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-      pluginName: "computer-use",
-    });
-  });
-
-  it("auto-registers the bundled Codex app marketplace during auto-install", async () => {
-    const bundledMarketplacePath = fs.mkdtempSync(
-      path.join(os.tmpdir(), "klaw-codex-bundled-marketplace-"),
-    );
-    cleanupPaths.push(bundledMarketplacePath);
-    const request = createBundledMarketplaceComputerUseRequest(bundledMarketplacePath);
-
-    const status = await ensureCodexComputerUse({
-      pluginConfig: {
-        computerUse: {
-          enabled: true,
-          autoInstall: true,
-        },
-      },
-      request,
-      defaultBundledMarketplacePath: bundledMarketplacePath,
-    });
-
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      marketplaceName: "openai-bundled",
-      message: "Computer Use is ready.",
-    });
-    expect(request).toHaveBeenCalledWith("marketplace/add", {
-      source: bundledMarketplacePath,
-    });
-    expect(request).toHaveBeenCalledWith("plugin/install", {
-      marketplacePath: `${bundledMarketplacePath}/.agents/plugins/marketplace.json`,
-      pluginName: "computer-use",
-    });
-  });
-
-  it("allows auto-install from a configured local marketplace path", async () => {
-    const request = createComputerUseRequest({ installed: false });
-
-    const status = await ensureCodexComputerUse({
-      pluginConfig: {
-        computerUse: {
-          enabled: true,
-          autoInstall: true,
-          marketplacePath: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-        },
-      },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      message: "Computer Use is ready.",
-    });
-    expectRequestMethodNotCalled(request, "marketplace/add");
-    expect(request).toHaveBeenCalledWith("plugin/install", {
-      marketplacePath: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-      pluginName: "computer-use",
-    });
-  });
-
-  it("requires an explicit install command for configured marketplace sources", async () => {
-    const request = createComputerUseRequest({ installed: false });
-
-    await expectSetupErrorStatus(
-      ensureCodexComputerUse({
-        pluginConfig: {
-          computerUse: {
-            enabled: true,
-            autoInstall: true,
-            marketplaceSource: "github:example/desktop-tools",
-          },
-        },
-        request,
-      }),
-      {
-        reason: "auto_install_blocked",
-      },
-    );
-    expectRequestMethodNotCalled(request, "marketplace/add");
-    expectRequestMethodNotCalled(request, "plugin/install");
-  });
-
-  it("fails closed when a configured marketplace name is not discovered", async () => {
-    const request = createEmptyMarketplaceComputerUseRequest();
-
-    const status = await readCodexComputerUseStatus({
-      pluginConfig: {
-        computerUse: {
-          enabled: true,
-          marketplaceName: "missing-marketplace",
-        },
-      },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: false,
-      reason: "marketplace_missing",
-      message:
-        "Configured Codex marketplace missing-marketplace was not found or does not contain computer-use. Run /codex computer-use install with a source or path to install from a new marketplace.",
-    });
-    expectRequestMethodNotCalled(request, "plugin/read");
-  });
-
-  it("fails closed instead of installing from a remote-only Codex marketplace", async () => {
-    const request = createRemoteOnlyComputerUseRequest();
-
-    await expectSetupErrorStatus(
-      installCodexComputerUse({
-        pluginConfig: { computerUse: { marketplaceName: "openai-curated" } },
-        request,
-      }),
-      {
-        ready: false,
-        reason: "remote_install_unsupported",
-        installed: false,
-        pluginEnabled: false,
-        marketplaceName: "openai-curated",
-        message:
-          "Computer Use is available in remote Codex marketplace openai-curated, but Codex app-server does not support remote plugin install yet. Configure computerUse.marketplaceSource or computerUse.marketplacePath for a local marketplace, then run /codex computer-use install.",
-      },
-    );
-    expectRequestMethodNotCalled(request, "plugin/install");
-  });
-
-  it("waits for the default Codex marketplace during install", async () => {
-    vi.useFakeTimers();
-    const request = createComputerUseRequest({
-      installed: false,
-      marketplaceAvailableAfterListCalls: 3,
-    });
-    const installed = installCodexComputerUse({
-      pluginConfig: { computerUse: {} },
-      request,
-    });
-
-    await vi.advanceTimersByTimeAsync(4_000);
-
-    const status = await installed;
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      message: "Computer Use is ready.",
-    });
-    expect(request).toHaveBeenCalledWith("plugin/install", {
-      marketplacePath: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-      pluginName: "computer-use",
-    });
-    expect(
-      vi.mocked(request).mock.calls.filter(([method]) => method === "plugin/list"),
-    ).toHaveLength(3);
-  });
-
-  it("prefers the official Computer Use marketplace when multiple matches are present", async () => {
-    const request = createMultiMarketplaceComputerUseRequest();
-
-    const status = await installCodexComputerUse({
-      pluginConfig: { computerUse: {} },
-      request,
-    });
-
-    expectStatusFields(status, {
-      ready: true,
-      reason: "ready",
-      marketplaceName: "openai-curated",
-    });
-    expect(request).toHaveBeenCalledWith("plugin/install", {
-      marketplacePath: "/marketplaces/openai-curated/.agents/plugins/marketplace.json",
-      pluginName: "computer-use",
-    });
-  });
-});
-
-function createComputerUseRequest(params: {
-  installed: boolean;
-  enabled?: boolean;
-  marketplaceAvailableAfterListCalls?: number;
-}): CodexComputerUseRequest {
-  let installed = params.installed;
-  let enabled = params.enabled ?? installed;
-  let pluginListCalls = 0;
-  return vi.fn(async (method: string, requestParams?: unknown) => {
-    if (method === "experimentalFeature/enablement/set") {
-      return { enablement: { plugins: true } };
-    }
-    if (method === "marketplace/add") {
-      return {
-        marketplaceName: "desktop-tools",
-        installedRoot: "/marketplaces/desktop-tools",
-        alreadyAdded: false,
-      };
-    }
-    if (method === "plugin/list") {
-      pluginListCalls += 1;
-      const marketplaceAvailable =
-        pluginListCalls >= (params.marketplaceAvailableAfterListCalls ?? 1);
-      return {
-        marketplaces: marketplaceAvailable
-          ? [
-              {
-                name: "desktop-tools",
-                path: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-                interface: null,
-                plugins: [pluginSummary(installed, "desktop-tools", enabled)],
-              },
-            ]
-          : [],
-        marketplaceLoadErrors: [],
-        featuredPluginIds: [],
-      };
-    }
-    if (method === "plugin/read") {
-      expect(requireRecord(requestParams, "plugin read params").pluginName).toBe("computer-use");
-      return {
-        plugin: {
-          marketplaceName: "desktop-tools",
-          marketplacePath: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-          summary: pluginSummary(installed, "desktop-tools", enabled),
-          description: "Control desktop apps.",
-          skills: [],
-          apps: [],
-          mcpServers: ["computer-use"],
-        },
-      };
-    }
-    if (method === "plugin/install") {
-      installed = true;
-      enabled = true;
-      return { authPolicy: "ON_INSTALL", appsNeedingAuth: [] };
-    }
-    if (method === "config/mcpServer/reload") {
-      return undefined;
-    }
-    if (method === "mcpServerStatus/list") {
-      return {
-        data:
-          installed && enabled
-            ? [
-                {
-                  name: "computer-use",
-                  tools: {
-                    list_apps: {
-                      name: "list_apps",
-                      inputSchema: { type: "object" },
-                    },
-                  },
-                  resources: [],
-                  resourceTemplates: [],
-                  authStatus: "unsupported",
-                },
-              ]
-            : [],
-        nextCursor: null,
-      };
-    }
-    throw new Error(`unexpected request ${method}`);
-  }) as CodexComputerUseRequest;
-}
-
-function createRemoteOnlyComputerUseRequest(): CodexComputerUseRequest {
-  return vi.fn(async (method: string, requestParams?: unknown) => {
-    if (method === "experimentalFeature/enablement/set") {
-      return { enablement: { plugins: true } };
-    }
-    if (method === "plugin/list") {
-      return {
-        marketplaces: [
-          {
-            name: "openai-curated",
-            path: null,
-            interface: null,
-            plugins: [pluginSummary(false, "openai-curated", false, "remote")],
-          },
-        ],
-        marketplaceLoadErrors: [],
-        featuredPluginIds: [],
-      };
-    }
-    if (method === "plugin/read") {
-      expect(requestParams).toEqual({
-        remoteMarketplaceName: "openai-curated",
-        pluginName: "computer-use",
-      });
-      return {
-        plugin: {
-          marketplaceName: "openai-curated",
-          marketplacePath: null,
-          summary: pluginSummary(false, "openai-curated", false, "remote"),
-          description: "Control desktop apps.",
-          skills: [],
-          apps: [],
-          mcpServers: ["computer-use"],
-        },
-      };
-    }
-    throw new Error(`unexpected request ${method}`);
-  }) as CodexComputerUseRequest;
-}
-
-function createAmbiguousComputerUseRequest(): CodexComputerUseRequest {
-  return vi.fn(async (method: string) => {
-    if (method === "plugin/list") {
-      return {
-        marketplaces: [
-          {
-            name: "desktop-tools",
-            path: "/marketplaces/desktop-tools/.agents/plugins/marketplace.json",
-            interface: null,
-            plugins: [pluginSummary(true, "desktop-tools")],
-          },
-          {
-            name: "other-tools",
-            path: "/marketplaces/other-tools/.agents/plugins/marketplace.json",
-            interface: null,
-            plugins: [pluginSummary(true, "other-tools")],
-          },
-        ],
-        marketplaceLoadErrors: [],
-        featuredPluginIds: [],
-      };
-    }
-    throw new Error(`unexpected request ${method}`);
-  }) as CodexComputerUseRequest;
-}
-
-function createEmptyMarketplaceComputerUseRequest(): CodexComputerUseRequest {
-  return vi.fn(async (method: string) => {
-    if (method === "plugin/list") {
-      return {
-        marketplaces: [],
-        marketplaceLoadErrors: [],
-        featuredPluginIds: [],
-      };
-    }
-    throw new Error(`unexpected request ${method}`);
-  }) as CodexComputerUseRequest;
-}
-
-function createMultiMarketplaceComputerUseRequest(): CodexComputerUseRequest {
-  let installed = false;
-  return vi.fn(async (method: string, requestParams?: unknown) => {
-    if (method === "experimentalFeature/enablement/set") {
-      return { enablement: { plugins: true } };
-    }
-    if (method === "plugin/list") {
-      return {
-        marketplaces: [
-          marketplaceEntry("workspace-tools", false),
-          marketplaceEntry("openai-curated", installed),
-        ],
-        marketplaceLoadErrors: [],
-        featuredPluginIds: [],
-      };
-    }
-    if (method === "plugin/read") {
-      return {
-        plugin: {
-          marketplaceName: "openai-curated",
-          marketplacePath: "/marketplaces/openai-curated/.agents/plugins/marketplace.json",
-          summary: pluginSummary(installed, "openai-curated"),
-          description: "Control desktop apps.",
-          skills: [],
-          apps: [],
-          mcpServers: ["computer-use"],
-        },
-      };
-    }
-    if (method === "plugin/install") {
-      expect(requestParams).toEqual({
-        marketplacePath: "/marketplaces/openai-curated/.agents/plugins/marketplace.json",
-        pluginName: "computer-use",
-      });
-      installed = true;
-      return { authPolicy: "ON_INSTALL", appsNeedingAuth: [] };
-    }
-    if (method === "config/mcpServer/reload") {
-      return undefined;
-    }
-    if (method === "mcpServerStatus/list") {
-      return {
-        data: installed
-          ? [
-              {
-                name: "computer-use",
-                tools: {
-                  list_apps: {
-                    name: "list_apps",
-                    inputSchema: { type: "object" },
-                  },
-                },
-                resources: [],
-                resourceTemplates: [],
-                authStatus: "unsupported",
-              },
-            ]
-          : [],
-        nextCursor: null,
-      };
-    }
-    throw new Error(`unexpected request ${method}`);
-  }) as CodexComputerUseRequest;
-}
-
-function createBundledMarketplaceComputerUseRequest(
-  bundledMarketplacePath: string,
-): CodexComputerUseRequest {
-  let registered = false;
-  let installed = false;
-  return vi.fn(async (method: string, requestParams?: unknown) => {
-    if (method === "experimentalFeature/enablement/set") {
-      return { enablement: { plugins: true } };
-    }
-    if (method === "marketplace/add") {
-      expect(requestParams).toEqual({
-        source: bundledMarketplacePath,
-      });
-      registered = true;
-      return {
-        marketplaceName: "openai-bundled",
-        installedRoot: bundledMarketplacePath,
-        alreadyAdded: false,
-      };
-    }
-    if (method === "plugin/list") {
-      return {
-        marketplaces: registered
-          ? [
-              {
-                name: "openai-bundled",
-                path: `${bundledMarketplacePath}/.agents/plugins/marketplace.json`,
-                interface: null,
-                plugins: [pluginSummary(installed, "openai-bundled")],
-              },
-            ]
-          : [],
-        marketplaceLoadErrors: [],
-        featuredPluginIds: [],
-      };
-    }
-    if (method === "plugin/read") {
-      return {
-        plugin: {
-          marketplaceName: "openai-bundled",
-          marketplacePath: `${bundledMarketplacePath}/.agents/plugins/marketplace.json`,
-          summary: pluginSummary(installed, "openai-bundled"),
-          description: "Control desktop apps.",
-          skills: [],
-          apps: [],
-          mcpServers: ["computer-use"],
-        },
-      };
-    }
-    if (method === "plugin/install") {
-      installed = true;
-      return { authPolicy: "ON_INSTALL", appsNeedingAuth: [] };
-    }
-    if (method === "config/mcpServer/reload") {
-      return undefined;
-    }
-    if (method === "mcpServerStatus/list") {
-      return {
-        data: installed
-          ? [
-              {
-                name: "computer-use",
-                tools: {
-                  list_apps: {
-                    name: "list_apps",
-                    inputSchema: { type: "object" },
-                  },
-                },
-                resources: [],
-                resourceTemplates: [],
-                authStatus: "unsupported",
-              },
-            ]
-          : [],
-        nextCursor: null,
-      };
-    }
-    throw new Error(`unexpected request ${method}`);
-  }) as CodexComputerUseRequest;
-}
-
-function marketplaceEntry(marketplaceName: string, installed: boolean) {
-  return {
-    name: marketplaceName,
-    path: `/marketplaces/${marketplaceName}/.agents/plugins/marketplace.json`,
-    interface: null,
-    plugins: [pluginSummary(installed, marketplaceName)],
-  };
-}
-
-function pluginSummary(
-  installed: boolean,
-  marketplaceName = "desktop-tools",
-  enabled = installed,
-  source: "local" | "remote" = "local",
-) {
-  return {
-    id: `computer-use@${marketplaceName}`,
-    name: "computer-use",
-    source:
-      source === "local"
-        ? { type: "local", path: `/marketplaces/${marketplaceName}/plugins/computer-use` }
-        : { type: "remote" },
-    installed,
-    enabled,
-    installPolicy: "AVAILABLE",
-    authPolicy: "ON_INSTALL",
-    interface: null,
-  };
-}