@koda-sl/baker-cli 0.379.0-dev.fe3d33fa3 → 0.380.0-dev.59908a419

package/README.md

@@ -3737,7 +3737,7 @@ baker shopify stock-holds --product <id>           # ads Baker paused because th
 
 **`promotions`:** positional `<ref>` like `product`. Reads the product, scans this workspace's `src/pages/*` (import graph, ≤ 300 pages, files ≤ 256 KB) for its buy link, `/products/<handle>` or an option id, then `POST /api/shopify/promotions` with the linked landings. `data.ads[]` (`platform`, `level` ad|asset_group, `name`, `campaign`, `status` active|paused, `via` product_page|buy_link|landing), `data.landings[]` (`published`, `via` links_to_product|visitors_went_on), `data.shopping[]`, `data.catalog_ads`, `data.checked` (`not_checked` names a platform it could not read), `data.remembered` (the read carried a Session and named an ad — only then can “Restart ads when a product is back” later stage turning a pause from it back on, for review). `--full` adds ids, accounts, campaign / ad group / ad set ids, the Google `resource` and the URL.
 
-**`stock-holds`:** `--product <ref>`, `--all` (resolved holds too). `data.holds[]` — one per paused entity and product, with `verdict` (`resumable` · `still_out_of_stock` · `changed_since` · `already_active` · `still_promotes_out_of_stock` · `cannot_confirm`) read live from the ad platform; `data.pending_sessions[]` — out-of-stock work still waiting for review that would pause this product's ads; `data.recently_closed[]` — with `--product`, its pauses turned back on or let go in the last 30 days.
+**`stock-holds`:** `--product <ref>`, `--all` (resolved holds too). `data.holds[]` — one per paused entity and product, with `verdict` (`resumable` · `still_out_of_stock` · `changed_since` · `already_active` · `still_promotes_out_of_stock` · `cannot_confirm`) read live from the ad platform; `data.pending_sessions[]` — out-of-stock work still waiting for review that would pause this product's ads; `data.recently_closed[]` — with `--product`, each ad whose pause for it was turned back on or let go in the last 30 days, once, with how its latest pause closed (`resolved_reason`) and when (`closed_at`).
 
 **Refusals:** `NO_SHOPIFY_CONNECTION` — no store is connected; `error.fix.action` is `request_connection` (`{ platform: "shopify" }`). `SHOPIFY_NOT_AVAILABLE` — Shopify can't be connected on this Baker yet; `error.fix.action` is `continue_without`. Both exit 1.
 

package/dist/cli.js

@@ -66576,27 +66576,45 @@ function resumeCommand2(hold) {
 }
 var CLOSED_HOW = {
   resumed_by_back_in_stock_run: "turned back on by an earlier back-in-stock run",
-  changed_by_baker: "turned back on or changed in Baker",
-  already_active: "turned back on by someone",
+  changed_by_baker: "turned back on by other work published in Baker",
+  already_active: "found running again, turned back on by someone",
   removed: "removed",
   product_removed: "let go when the product left the store"
 };
-function nothingHeldHint(answer) {
+function nothingHeldHint(answer, asked) {
+  if (!asked.product) return "No ad is still paused because a product ran out: there is nothing to resume.";
+  if (answer.pending_sessions.length > 0) {
+    return "The latest pause for this product is still waiting for review and was never published, so nothing is paused and there is nothing to resume.";
+  }
   const closed = answer.recently_closed;
   if (closed.length > 0) {
-    const how = [...new Set(closed.map((hold) => CLOSED_HOW[hold.resolved_reason]))].join(" or ");
-    return `Baker paused ${closed.map(holdName).join(", ")} when this product ran out, and ${closed.length === 1 ? "it has" : "they have"} since been ${how}: there is nothing left to resume. Tell the user that \u2014 never that nothing was paused.`;
-  }
-  if (answer.pending_sessions.length > 0) {
-    return "No pause for this product has been published yet, so there is nothing to resume.";
+    const each = closed.map((hold) => `Baker paused ${holdName(hold)} for it, and it was later ${CLOSED_HOW[hold.resolved_reason]}`).join("; ");
+    return `Nothing is still paused because this product ran out, so there is nothing to resume: ${each}. Tell the user that, naming only ${closed.length === 1 ? "this ad" : "these ads"} \u2014 never that nothing was paused, and never whether an ad is running now.`;
   }
   if (answer.holds.length > 0) return "None of these is still paused because its product ran out: nothing to resume.";
   return "Baker has no pause on record for this product running out: there is nothing to resume.";
 }
-function stockHoldHints(answer) {
+function leftAloneHint(hold) {
+  const name = holdName(hold);
+  switch (hold.verdict) {
+    case "still_out_of_stock":
+      return `${name} stays paused: \u201C${hold.product.title ?? hold.product.id}\u201D still cannot be bought. Leave it.`;
+    case "changed_since":
+      return `${name} was changed by someone after Baker paused it: leave it, and tell the user.`;
+    case "still_promotes_out_of_stock":
+      return `${name} still sends people to \u201C${hold.verdict_detail ?? "another product"}\u201D, which is out: leave it until that is back.`;
+    case "cannot_confirm":
+      return `${name} could not be confirmed as untouched since Baker paused it: leave it, and tell the user to check it.`;
+    case "already_active":
+      return `${name} is already running again: nothing to do.`;
+    default:
+      return null;
+  }
+}
+function stockHoldHints(answer, asked) {
   const hints2 = [];
   const held = answer.holds.filter((hold) => hold.state === "held");
-  if (held.length === 0) hints2.push(nothingHeldHint(answer));
+  if (held.length === 0) hints2.push(nothingHeldHint(answer, asked));
   const resumable = held.filter((hold) => hold.verdict === "resumable");
   if (resumable.length > 0) {
     hints2.push(
@@ -66604,19 +66622,8 @@ function stockHoldHints(answer) {
     );
   }
   for (const hold of held) {
-    if (hold.verdict === "changed_since") {
-      hints2.push(`${holdName(hold)} was changed by someone after Baker paused it: leave it, and tell the user.`);
-    } else if (hold.verdict === "still_promotes_out_of_stock") {
-      hints2.push(
-        `${holdName(hold)} still sends people to \u201C${hold.verdict_detail ?? "another product"}\u201D, which is out: leave it until that is back.`
-      );
-    } else if (hold.verdict === "cannot_confirm") {
-      hints2.push(
-        `${holdName(hold)} could not be confirmed as untouched since Baker paused it: leave it, and tell the user to check it.`
-      );
-    } else if (hold.verdict === "already_active") {
-      hints2.push(`${holdName(hold)} is already running again: nothing to do.`);
-    }
+    const why = leftAloneHint(hold);
+    if (why) hints2.push(why);
   }
   for (const session of answer.pending_sessions) {
     hints2.push(
@@ -66640,7 +66647,7 @@ registerSchema({
 });
 registerSchema({
   command: "shopify.stock-holds",
-  description: "Start here when a product is back in stock: the ads Baker paused because it ran out, each with a `verdict` \u2014 `resumable` (resume it), `still_out_of_stock`, `changed_since` (someone changed it after Baker paused it: leave it), `already_active`, `still_promotes_out_of_stock` (it also sends people to another product that is still out: `verdict_detail` names it), `cannot_confirm`. Resume only what is resumable. `pending_sessions` lists out-of-stock work still waiting for review that would pause this product's ads: tell the user to discard it. With `--product`, `recently_closed` lists its pauses turned back on or let go in the last 30 days: an empty `holds` never means nothing was paused.",
+  description: "Start here when a product is back in stock: the ads Baker paused because it ran out, each with a `verdict` \u2014 `resumable` (resume it), `still_out_of_stock`, `changed_since` (someone changed it after Baker paused it: leave it), `already_active`, `still_promotes_out_of_stock` (it also sends people to another product that is still out: `verdict_detail` names it), `cannot_confirm`. Resume only what is resumable. `pending_sessions` lists out-of-stock work still waiting for review that would pause this product's ads: tell the user to discard it. With `--product`, `recently_closed` lists each ad whose pause was turned back on or let go in the last 30 days, once, with how its latest pause closed: an empty `holds` never means nothing was paused. Tell the user in plain words, never a verdict code.",
   args: {
     product: { type: "string", description: "Only one product's holds: its id, handle or link", required: false },
     all: { type: "boolean", description: "Resolved holds too (resumed or released)", required: false, default: false },
@@ -66709,7 +66716,10 @@ var stockHoldsCommand = defineCommand210({
         params({ product: args5.product, all: args5.all, full: args5.full })
       );
       const { store, ...data } = answer;
-      emit2(data, { store, count: answer.holds.length }, [...storeStateHints(store), ...stockHoldHints(answer)]);
+      emit2(data, { store, count: answer.holds.length }, [
+        ...storeStateHints(store),
+        ...stockHoldHints(answer, { product: args5.product !== void 0 })
+      ]);
     } catch (err) {
       fail9(err);
     }