@koda-sl/baker-cli 0.345.0 → 0.347.0-dev.043fc924c

package/dist/cli.js

@@ -67,7 +67,7 @@ import {
   validateCanvasDeep,
   withoutCastName,
   ytDlpBlockSignal
-} from "./chunk-FFOURYP5.js";
+} from "./chunk-D5P4COPD.js";
 import {
   csvOrJson,
   daysAgoIso,
@@ -789,6 +789,50 @@ var actionsUpdateRequestSchema = z.object({
 var actionsUpdateResponseSchema = okOnlySchema();
 var ACTION_COMPLETE_NOTE_MIN = 20;
 var actionsCompleteNoteMessage = `A completion note (\u2265${ACTION_COMPLETE_NOTE_MIN} chars) describing what was done is required: what changed, where, and the outcome.`;
+var ACCOUNT_CONTEXT = "(?:account|accounts|cuenta|cuentas|customer|cliente|property|propiedad|meta|facebook|google|ads|linkedin|ga4|analytics|gtm|tag manager|id)";
+var COMPLETION_NOTE_INTERNALS = [
+  // Repo paths: rooted in a workspace directory, or a path or lowercase file name
+  // ending in a source extension (a product name like "Next.js" is not a file).
+  /(?:\.{0,2}\/)?(?:src|public|__tooling__|\.claude)\/[^\s,;:)`'"]*[^\s,;:)`'".]/g,
+  /(?:[\w.-]*\/[\w./-]*|\b[a-z_][\w-]*)\.(?:mdx?|astro|tsx?|jsx?|mjs|json|ya?ml)\b/g,
+  // Meta ad-account ids, Tag Manager containers and GA4 measurement ids.
+  /\bact_\d+\b/g,
+  /\bGTM-[A-Z0-9]{4,}\b/g,
+  /\bG-[A-Z0-9]{6,}\b/g,
+  // Google Ads customer ids (386-508-3115), LinkedIn, GA4 and bare Google Ads ids:
+  // a long number named next to a platform or an account, so a phone number or
+  // a figure elsewhere in the note is not one.
+  new RegExp(
+    String.raw`(?<=\b${ACCOUNT_CONTEXT}\b[^.\n\d]{0,20})(?<![\w-])(?:\d{3}-\d{3}-\d{4}|\d{7,})(?![\w-])`,
+    "gi"
+  ),
+  // Error codes: SCREAMING_SNAKE in the shapes platforms and Baker return them
+  // (NO_GOOGLE_ADS_CONNECTION, PERMISSION_DENIED, INVALID_ACCOUNT_ID).
+  /\b(?:(?:ERR|INVALID|MISSING)(?:_[A-Z0-9]+)+|[A-Z][A-Z0-9]*(?:_[A-Z0-9]+)*_(?:ERROR|CONNECTION|FAILED|NOT_FOUND|DENIED|REQUIRED|INVALID|EXPIRED|UNAVAILABLE|EXCEEDED|UNREACHABLE|UNAUTHORIZED|FORBIDDEN|TIMEOUT|TOKEN)|BAD_REQUEST|NOT_FOUND|RATE_LIMITED)\b/g,
+  // CLI invocations (`baker analytics flow`).
+  /\bbaker [a-z][a-z-]*/g
+];
+function completionNoteInternals(note) {
+  const hits = [];
+  for (const pattern of COMPLETION_NOTE_INTERNALS) {
+    for (const match of note.matchAll(pattern)) {
+      const index = match.index ?? 0;
+      hits.push({ index, end: index + match[0].length, text: match[0] });
+    }
+  }
+  hits.sort((a, b) => a.index - b.index || b.end - a.end);
+  const found = [];
+  let coveredUntil = -1;
+  for (const hit of hits) {
+    if (hit.index < coveredUntil) continue;
+    found.push(hit.text);
+    coveredUntil = hit.end;
+  }
+  return found;
+}
+function completionNoteInternalsMessage(internals) {
+  return `The completion note is read by the client on the Task, and it carries internal details they cannot use: ${internals.join(", ")}. Rewrite it in product terms \u2014 name the page, campaign or Knowledge entry instead of a file, the platform instead of an account id, and say what is missing instead of an error code.`;
+}
 var actionsCompleteRequestSchema = z.object({
   chatId: z.string(),
   actionRef: z.string().min(1, "actionRef is required"),
@@ -796,6 +840,11 @@ var actionsCompleteRequestSchema = z.object({
 }).transform((body) => ({ ...body, note: (body.note ?? "").trim() })).refine((body) => body.note.length >= ACTION_COMPLETE_NOTE_MIN, {
   message: actionsCompleteNoteMessage,
   path: ["note"]
+}).superRefine((body, ctx) => {
+  const internals = completionNoteInternals(body.note);
+  if (internals.length > 0) {
+    ctx.addIssue({ code: "custom", message: completionNoteInternalsMessage(internals), path: ["note"] });
+  }
 });
 var actionsCompleteResponseSchema = okOnlySchema();
 var actionsDiscardRequestSchema = z.object({
@@ -8460,12 +8509,12 @@ var claimCommand = defineCommand({
 import { defineCommand as defineCommand2 } from "citty";
 registerSchema({
   command: "actions.complete",
-  description: "Stage completion of an action (it was DONE). Accepts a real action ID (must be claimed) or a temp ID from the same draft. The action becomes completed when the chat is published. --note is REQUIRED and must describe what you actually did to resolve it (what changed, where, and the outcome) \u2014 it is the client-facing record surfaced by `baker actions log`. Do NOT use this to drop an action you no longer want \u2014 to remove a staged op use `actions draft remove`, to close an unwanted published action use `actions discard`.",
+  description: 'Stage completion of an action (it was DONE). Accepts a real action ID (must be claimed) or a temp ID from the same draft. The action becomes completed when the chat is published. --note is REQUIRED and must describe what you actually did to resolve it (what changed, where, and the outcome) \u2014 it is the client-facing record shown on the Task in Tasks and surfaced by `baker actions log`, so write it for a marketer, in the client\'s language and product terms: a few lines, no file paths, account ids, error codes or `baker` commands ("Weekly review saved in your Knowledge; Google Ads and LinkedIn are not connected yet", not "written to src/content/audits/\u2026md; NO_GOOGLE_ADS_CONNECTION"). A note carrying those is refused. Do NOT use this to drop an action you no longer want \u2014 to remove a staged op use `actions draft remove`, to close an unwanted published action use `actions discard`.',
   args: {
     id: { type: "string", description: "Action ID or temp ID", required: true },
     note: {
       type: "string",
-      description: "REQUIRED. Detailed description of what you did to resolve this: what changed, where, and the outcome. This is the durable, client-facing record shown by `baker actions log`.",
+      description: "REQUIRED. What you did to resolve this \u2014 what changed, where (in product terms: the page, the campaign, Knowledge), and the outcome \u2014 in a few lines. The client reads it on the Task: no file paths, account ids, error codes or `baker` commands.",
       required: true
     }
   }
@@ -8480,7 +8529,7 @@ var completeCommand = defineCommand2({
     "action-id": { type: "string", description: "Action ID or temp ID", required: false },
     note: {
       type: "string",
-      description: "REQUIRED. What you did to resolve this: what changed, where, and the outcome.",
+      description: "REQUIRED. What you did, where (in product terms) and the outcome \u2014 read by the client, so no file paths, account ids or error codes.",
       required: false
     }
   },
@@ -8499,6 +8548,10 @@ var completeCommand = defineCommand2({
           `--note is required and must describe what you did (\u2265${ACTION_COMPLETE_NOTE_MIN} chars): what changed, where, and the outcome. This becomes the client-facing record surfaced by \`baker actions log\`.`
         );
       }
+      const internals = completionNoteInternals(note);
+      if (internals.length > 0) {
+        failValidation(`--note: ${completionNoteInternalsMessage(internals)} Then run the same command again.`);
+      }
       const chatId = requireChatId();
       await apiPost("/api/actions/complete", { chatId, actionRef: id, note });
       writeOk();