@koda-sl/baker-cli 0.330.0 → 0.331.0

package/README.md

@@ -300,7 +300,7 @@ Read it before interpreting any null. Field coverage is folded page by page on t
 }
 ```
 
-Never total or count from a response carrying it — re-run with `--all --limit 10000 --out data.csv` (the API accepts page sizes up to 10,000) and check the re-run came back without the warning. Warnings reach every output format, so no `--output` choice can hide one:
+Never total or count from a response carrying it — re-run with `--all --limit 10000 --out data.csv` (the API accepts page sizes up to 10,000) and check the re-run came back without the warning. A read that returns one row by construction — `FROM customer` with no segment selected, such as `--preset account-summary` — has no page to fill, so it never carries `TRUNCATED_RESULTS`, nor `CONVERSION_MIX`, since one account-wide row has no campaigns to total or compare. Warnings reach every output format, so no `--output` choice can hide one:
 
 | `--output` | Where warnings land |
 |------------|---------------------|

package/dist/cli.js

@@ -11846,160 +11846,6 @@ import { appendFileSync, existsSync as existsSync2, readFileSync as readFileSync
 import { resolve } from "path";
 import { defineCommand as defineCommand28 } from "citty";
 
-// src/commands/ads/google/conversion-mix.ts
-var CONVERSION_METRICS = [
-  "METRICS.CONVERSIONS",
-  "METRICS.ALL_CONVERSIONS",
-  "METRICS.CONVERSIONS_VALUE",
-  "METRICS.ALL_CONVERSIONS_VALUE",
-  "METRICS.COST_PER_CONVERSION",
-  "METRICS.COST_PER_ALL_CONVERSIONS",
-  "METRICS.CONVERSIONS_FROM_INTERACTIONS_RATE",
-  "METRICS.ALL_CONVERSIONS_FROM_INTERACTIONS_RATE",
-  "METRICS.VALUE_PER_CONVERSION",
-  "METRICS.VALUE_PER_ALL_CONVERSIONS"
-];
-var CONVERSION_SEGMENTS = ["SEGMENTS.CONVERSION_ACTION_NAME", "SEGMENTS.CONVERSION_ACTION="];
-var CAMPAIGN_EQUALITY = /\bCAMPAIGN\.(ID|NAME|RESOURCE_NAME)\s*=/;
-function whereClause(upperQuery) {
-  const whereIdx = upperQuery.indexOf(" WHERE ");
-  if (whereIdx === -1) return "";
-  let rest = upperQuery.slice(whereIdx + 7);
-  for (const trailing of [" ORDER BY ", " GROUP BY ", " LIMIT ", " PARAMETERS "]) {
-    const idx = rest.indexOf(trailing);
-    if (idx !== -1) rest = rest.slice(0, idx);
-  }
-  return rest;
-}
-function conversionMixWarnings(finalQuery) {
-  const upper2 = ` ${finalQuery.toUpperCase().replace(/\s+/g, " ")} `;
-  const readsConversions = CONVERSION_METRICS.some((metric) => upper2.includes(metric));
-  if (!readsConversions) return [];
-  if (CONVERSION_SEGMENTS.some((segment) => upper2.includes(segment))) return [];
-  if (CAMPAIGN_EQUALITY.test(whereClause(upper2))) return [];
-  return [
-    {
-      code: "CONVERSION_MIX",
-      message: "MIXED CONVERSION ACTIONS \u2014 this read covers more than one campaign, and a campaign's conversion figures count whatever conversion actions are primary for it. Those differ campaign by campaign (a webinar registration, an info request, a CRM-stage SQL), so a total across these rows adds different events and a conversion rate from one campaign is not comparable with another's. Before totalling or comparing, re-run segmented by segments.conversion_action_name and check the campaigns you are putting side by side count the same action. If they do not, compare only within one action \u2014 and carry that caveat into anything you write for the user, not just the analysis."
-    }
-  ];
-}
-
-// src/commands/ads/google/keyword-serving.ts
-var BELOW_FIRST_PAGE_BID = "AD_GROUP_CRITERION_BELOW_FIRST_PAGE_BID";
-var ACTIONABLE_REASONS = {
-  [BELOW_FIRST_PAGE_BID]: {
-    label: "Below first page bid",
-    advice: "raise the max CPC (keywords update --cpc-bid) to at least the first-page estimate, or move the ad group onto a smart bidding strategy that sets the bid itself"
-  },
-  AD_GROUP_CRITERION_LOW_QUALITY: {
-    label: "Low quality score",
-    advice: "a bid raise does not lift quality \u2014 tighten ad relevance to the keyword and the landing page it points at (ad_group_criterion.quality_info.* breaks the score into its three parts)"
-  },
-  AD_GROUP_CRITERION_RARELY_SERVED: {
-    label: "Rarely served",
-    advice: "too few people search this term \u2014 broaden the match type or drop it, don't bid it up"
-  },
-  AD_GROUP_CRITERION_DISAPPROVED: {
-    label: "Disapproved",
-    advice: "select ad_group_criterion.disapproval_reasons to see which policy blocked it"
-  },
-  AD_GROUP_CRITERION_RESTRICTED: {
-    label: "Restricted",
-    advice: "policy limits where and to whom this keyword may show"
-  },
-  AD_GROUP_CRITERION_UNDER_REVIEW: {
-    label: "Under review",
-    advice: "waiting on Google's review \u2014 nothing to change yet"
-  },
-  AD_GROUP_CRITERION_PENDING_REVIEW: {
-    label: "Pending review",
-    advice: "waiting on Google's review \u2014 nothing to change yet"
-  },
-  AD_GROUP_CRITERION_PAUSED_DUE_TO_LOW_ACTIVITY: {
-    label: "Auto-paused for low activity",
-    advice: "Google paused it after prolonged low serving \u2014 resume it only alongside a change that gives it traffic"
-  }
-};
-var REASON_ORDER = Object.keys(ACTIONABLE_REASONS);
-var MAX_NAMED_KEYWORDS = 5;
-function toMicros2(value) {
-  if (typeof value === "number" && Number.isFinite(value)) return value;
-  if (typeof value === "string" && value.trim() !== "" && Number.isFinite(Number(value))) return Number(value);
-  return null;
-}
-function formatMoney(micros) {
-  return (micros / 1e6).toFixed(2);
-}
-function keywordLabel(row) {
-  const text2 = row["ad_group_criterion.keyword.text"];
-  const id = row["ad_group_criterion.criterion_id"];
-  const name = typeof text2 === "string" && text2 !== "" ? text2 : id == null ? "(unnamed keyword)" : `criterion ${id}`;
-  const adGroup = row["ad_group.name"];
-  return typeof adGroup === "string" && adGroup !== "" ? `${name} (ad group ${adGroup})` : name;
-}
-function keywordKey(row) {
-  const adGroup = row["ad_group.id"] ?? row["ad_group.name"] ?? "";
-  const criterion = row["ad_group_criterion.criterion_id"] ?? row["ad_group_criterion.keyword.text"] ?? "";
-  return `${String(adGroup)}~${String(criterion)}` === "~" ? keywordLabel(row) : `${adGroup}~${criterion}`;
-}
-function reasonsOn(row) {
-  const raw = row["ad_group_criterion.primary_status_reasons"];
-  if (!Array.isArray(raw)) return null;
-  return raw.filter((r) => typeof r === "string");
-}
-function bidShortfall(row) {
-  const bid = toMicros2(row["ad_group_criterion.effective_cpc_bid_micros"] ?? row["ad_group_criterion.cpc_bid_micros"]);
-  const firstPage = toMicros2(row["ad_group_criterion.position_estimates.first_page_cpc_micros"]);
-  if (bid == null || firstPage == null || bid >= firstPage) return null;
-  return `bids ${formatMoney(bid)} against a ${formatMoney(firstPage)} first-page estimate`;
-}
-function limitsOn(row, options) {
-  const reasons = reasonsOn(row);
-  const shortfall = bidShortfall(row);
-  const label = keywordLabel(row);
-  const applicable = reasons ? reasons.filter((reason) => reason in ACTIONABLE_REASONS) : options.statusReasonsSelected || shortfall === null ? [] : [BELOW_FIRST_PAGE_BID];
-  return applicable.map((reason) => ({
-    reason,
-    detail: reason === BELOW_FIRST_PAGE_BID && shortfall ? `"${label}" ${shortfall}` : `"${label}"`
-  }));
-}
-function describeLimit(reason, details) {
-  const named = details.slice(0, MAX_NAMED_KEYWORDS).join("; ");
-  const rest = details.length > MAX_NAMED_KEYWORDS ? ` (+${details.length - MAX_NAMED_KEYWORDS} more)` : "";
-  const { label, advice } = ACTIONABLE_REASONS[reason];
-  return `${label} \u2014 ${details.length}: ${named}${rest}. Fix: ${advice}.`;
-}
-function collectKeywordLimits(rows, options, acc = { detailsByReason: /* @__PURE__ */ new Map(), keywords: /* @__PURE__ */ new Set() }) {
-  for (const row of rows) {
-    const limits = limitsOn(row, options);
-    if (limits.length === 0) continue;
-    acc.keywords.add(keywordKey(row));
-    for (const { reason, detail } of limits) {
-      const bucket = acc.detailsByReason.get(reason);
-      if (bucket) bucket.push(detail);
-      else acc.detailsByReason.set(reason, [detail]);
-    }
-  }
-  return acc;
-}
-function renderKeywordLimits(limits) {
-  if (limits.detailsByReason.size === 0) return [];
-  const sentences = REASON_ORDER.filter((reason) => limits.detailsByReason.has(reason)).map(
-    (reason) => describeLimit(reason, limits.detailsByReason.get(reason) ?? [])
-  );
-  const count2 = limits.keywords.size;
-  return [
-    {
-      code: "KEYWORD_SERVING_LIMITED",
-      message: `${count2} ${count2 === 1 ? "keyword is" : "keywords are"} limited and not getting the traffic they could. ${sentences.join(" ")} Amounts are in the account currency (baker ads google currency).`
-    }
-  ];
-}
-function keywordServingWarnings(rows, options) {
-  return renderKeywordLimits(collectKeywordLimits(rows, options));
-}
-
 // src/commands/ads/google/presets.ts
 var GAQL_DATE_RANGE_RE = /^(?:TODAY|YESTERDAY|LAST_7_DAYS|LAST_14_DAYS|LAST_30_DAYS|LAST_90_DAYS|THIS_MONTH|LAST_MONTH|THIS_QUARTER|LAST_QUARTER|THIS_YEAR|LAST_YEAR|ALL_TIME|BETWEEN\s+'[0-9]{4}-[0-9]{2}-[0-9]{2}'\s+AND\s+'[0-9]{4}-[0-9]{2}-[0-9]{2}')$/i;
 function isValidDateRange(value) {
@@ -12167,7 +12013,7 @@ var RUNG_PIN_FIELDS = {
   "campaign_asset.status": ["campaign_asset.resource_name"],
   "ad_group_asset.status": ["ad_group_asset.resource_name"]
 };
-function whereClause2(query) {
+function whereClause(query) {
   const match = query.match(/\bWHERE\b([\s\S]*)$/i);
   if (!match?.[1]) return "";
   let rest = match[1];
@@ -12187,7 +12033,7 @@ function analyzeServingChain(query) {
   const resource = fromResource(query);
   const chain = resource ? SERVING_CHAINS[resource] : void 0;
   if (!chain) return null;
-  const where = whereClause2(query);
+  const where = whereClause(query);
   if (/ad_group_criterion\.negative\s*=\s*TRUE/i.test(where)) return null;
   const unscoped = chain.filter((rung) => {
     if (mentions(where, rung)) return false;
@@ -12239,7 +12085,7 @@ function fromResource(query) {
 function isSingleRowRead(query) {
   const resource = fromResource(query);
   if (!resource || !SINGLE_ROW_RESOURCES.includes(resource)) return false;
-  return !/\bsegments\./i.test(query);
+  return !/\bsegments\./i.test(selectClause(query));
 }
 var SEGMENTING_ANCESTORS = {
   campaign_budget: ["campaign"],
@@ -12414,6 +12260,161 @@ function validatePreflight(query, customerId, limit) {
   return { valid: true, correctedQuery: annotated.query, warnings };
 }
 
+// src/commands/ads/google/conversion-mix.ts
+var CONVERSION_METRICS = [
+  "METRICS.CONVERSIONS",
+  "METRICS.ALL_CONVERSIONS",
+  "METRICS.CONVERSIONS_VALUE",
+  "METRICS.ALL_CONVERSIONS_VALUE",
+  "METRICS.COST_PER_CONVERSION",
+  "METRICS.COST_PER_ALL_CONVERSIONS",
+  "METRICS.CONVERSIONS_FROM_INTERACTIONS_RATE",
+  "METRICS.ALL_CONVERSIONS_FROM_INTERACTIONS_RATE",
+  "METRICS.VALUE_PER_CONVERSION",
+  "METRICS.VALUE_PER_ALL_CONVERSIONS"
+];
+var CONVERSION_SEGMENTS = ["SEGMENTS.CONVERSION_ACTION_NAME", "SEGMENTS.CONVERSION_ACTION="];
+var CAMPAIGN_EQUALITY = /\bCAMPAIGN\.(ID|NAME|RESOURCE_NAME)\s*=/;
+function whereClause2(upperQuery) {
+  const whereIdx = upperQuery.indexOf(" WHERE ");
+  if (whereIdx === -1) return "";
+  let rest = upperQuery.slice(whereIdx + 7);
+  for (const trailing of [" ORDER BY ", " GROUP BY ", " LIMIT ", " PARAMETERS "]) {
+    const idx = rest.indexOf(trailing);
+    if (idx !== -1) rest = rest.slice(0, idx);
+  }
+  return rest;
+}
+function conversionMixWarnings(finalQuery) {
+  const upper2 = ` ${finalQuery.toUpperCase().replace(/\s+/g, " ")} `;
+  const readsConversions = CONVERSION_METRICS.some((metric) => upper2.includes(metric));
+  if (!readsConversions) return [];
+  if (CONVERSION_SEGMENTS.some((segment) => upper2.includes(segment))) return [];
+  if (CAMPAIGN_EQUALITY.test(whereClause2(upper2))) return [];
+  if (isSingleRowRead(finalQuery)) return [];
+  return [
+    {
+      code: "CONVERSION_MIX",
+      message: "MIXED CONVERSION ACTIONS \u2014 this read covers more than one campaign, and a campaign's conversion figures count whatever conversion actions are primary for it. Those differ campaign by campaign (a webinar registration, an info request, a CRM-stage SQL), so a total across these rows adds different events and a conversion rate from one campaign is not comparable with another's. Before totalling or comparing, re-run segmented by segments.conversion_action_name and check the campaigns you are putting side by side count the same action. If they do not, compare only within one action \u2014 and carry that caveat into anything you write for the user, not just the analysis."
+    }
+  ];
+}
+
+// src/commands/ads/google/keyword-serving.ts
+var BELOW_FIRST_PAGE_BID = "AD_GROUP_CRITERION_BELOW_FIRST_PAGE_BID";
+var ACTIONABLE_REASONS = {
+  [BELOW_FIRST_PAGE_BID]: {
+    label: "Below first page bid",
+    advice: "raise the max CPC (keywords update --cpc-bid) to at least the first-page estimate, or move the ad group onto a smart bidding strategy that sets the bid itself"
+  },
+  AD_GROUP_CRITERION_LOW_QUALITY: {
+    label: "Low quality score",
+    advice: "a bid raise does not lift quality \u2014 tighten ad relevance to the keyword and the landing page it points at (ad_group_criterion.quality_info.* breaks the score into its three parts)"
+  },
+  AD_GROUP_CRITERION_RARELY_SERVED: {
+    label: "Rarely served",
+    advice: "too few people search this term \u2014 broaden the match type or drop it, don't bid it up"
+  },
+  AD_GROUP_CRITERION_DISAPPROVED: {
+    label: "Disapproved",
+    advice: "select ad_group_criterion.disapproval_reasons to see which policy blocked it"
+  },
+  AD_GROUP_CRITERION_RESTRICTED: {
+    label: "Restricted",
+    advice: "policy limits where and to whom this keyword may show"
+  },
+  AD_GROUP_CRITERION_UNDER_REVIEW: {
+    label: "Under review",
+    advice: "waiting on Google's review \u2014 nothing to change yet"
+  },
+  AD_GROUP_CRITERION_PENDING_REVIEW: {
+    label: "Pending review",
+    advice: "waiting on Google's review \u2014 nothing to change yet"
+  },
+  AD_GROUP_CRITERION_PAUSED_DUE_TO_LOW_ACTIVITY: {
+    label: "Auto-paused for low activity",
+    advice: "Google paused it after prolonged low serving \u2014 resume it only alongside a change that gives it traffic"
+  }
+};
+var REASON_ORDER = Object.keys(ACTIONABLE_REASONS);
+var MAX_NAMED_KEYWORDS = 5;
+function toMicros2(value) {
+  if (typeof value === "number" && Number.isFinite(value)) return value;
+  if (typeof value === "string" && value.trim() !== "" && Number.isFinite(Number(value))) return Number(value);
+  return null;
+}
+function formatMoney(micros) {
+  return (micros / 1e6).toFixed(2);
+}
+function keywordLabel(row) {
+  const text2 = row["ad_group_criterion.keyword.text"];
+  const id = row["ad_group_criterion.criterion_id"];
+  const name = typeof text2 === "string" && text2 !== "" ? text2 : id == null ? "(unnamed keyword)" : `criterion ${id}`;
+  const adGroup = row["ad_group.name"];
+  return typeof adGroup === "string" && adGroup !== "" ? `${name} (ad group ${adGroup})` : name;
+}
+function keywordKey(row) {
+  const adGroup = row["ad_group.id"] ?? row["ad_group.name"] ?? "";
+  const criterion = row["ad_group_criterion.criterion_id"] ?? row["ad_group_criterion.keyword.text"] ?? "";
+  return `${String(adGroup)}~${String(criterion)}` === "~" ? keywordLabel(row) : `${adGroup}~${criterion}`;
+}
+function reasonsOn(row) {
+  const raw = row["ad_group_criterion.primary_status_reasons"];
+  if (!Array.isArray(raw)) return null;
+  return raw.filter((r) => typeof r === "string");
+}
+function bidShortfall(row) {
+  const bid = toMicros2(row["ad_group_criterion.effective_cpc_bid_micros"] ?? row["ad_group_criterion.cpc_bid_micros"]);
+  const firstPage = toMicros2(row["ad_group_criterion.position_estimates.first_page_cpc_micros"]);
+  if (bid == null || firstPage == null || bid >= firstPage) return null;
+  return `bids ${formatMoney(bid)} against a ${formatMoney(firstPage)} first-page estimate`;
+}
+function limitsOn(row, options) {
+  const reasons = reasonsOn(row);
+  const shortfall = bidShortfall(row);
+  const label = keywordLabel(row);
+  const applicable = reasons ? reasons.filter((reason) => reason in ACTIONABLE_REASONS) : options.statusReasonsSelected || shortfall === null ? [] : [BELOW_FIRST_PAGE_BID];
+  return applicable.map((reason) => ({
+    reason,
+    detail: reason === BELOW_FIRST_PAGE_BID && shortfall ? `"${label}" ${shortfall}` : `"${label}"`
+  }));
+}
+function describeLimit(reason, details) {
+  const named = details.slice(0, MAX_NAMED_KEYWORDS).join("; ");
+  const rest = details.length > MAX_NAMED_KEYWORDS ? ` (+${details.length - MAX_NAMED_KEYWORDS} more)` : "";
+  const { label, advice } = ACTIONABLE_REASONS[reason];
+  return `${label} \u2014 ${details.length}: ${named}${rest}. Fix: ${advice}.`;
+}
+function collectKeywordLimits(rows, options, acc = { detailsByReason: /* @__PURE__ */ new Map(), keywords: /* @__PURE__ */ new Set() }) {
+  for (const row of rows) {
+    const limits = limitsOn(row, options);
+    if (limits.length === 0) continue;
+    acc.keywords.add(keywordKey(row));
+    for (const { reason, detail } of limits) {
+      const bucket = acc.detailsByReason.get(reason);
+      if (bucket) bucket.push(detail);
+      else acc.detailsByReason.set(reason, [detail]);
+    }
+  }
+  return acc;
+}
+function renderKeywordLimits(limits) {
+  if (limits.detailsByReason.size === 0) return [];
+  const sentences = REASON_ORDER.filter((reason) => limits.detailsByReason.has(reason)).map(
+    (reason) => describeLimit(reason, limits.detailsByReason.get(reason) ?? [])
+  );
+  const count2 = limits.keywords.size;
+  return [
+    {
+      code: "KEYWORD_SERVING_LIMITED",
+      message: `${count2} ${count2 === 1 ? "keyword is" : "keywords are"} limited and not getting the traffic they could. ${sentences.join(" ")} Amounts are in the account currency (baker ads google currency).`
+    }
+  ];
+}
+function keywordServingWarnings(rows, options) {
+  return renderKeywordLimits(collectKeywordLimits(rows, options));
+}
+
 // src/commands/ads/google/query.ts
 registerSchema({
   command: "ads.google.query",
@@ -12518,6 +12519,7 @@ function writeRowsToFile(filePath, rows, fields, append) {
   }
 }
 function effectiveRowLimit(finalQuery, limit, all = false) {
+  if (isSingleRowRead(finalQuery)) return void 0;
   const match = finalQuery.match(/\bLIMIT\s+(\d+)/i);
   const statementLimit = match?.[1] ? Number(match[1]) : void 0;
   if (all) return statementLimit;