@koda-sl/baker-cli 0.271.0-dev.1f1c09c80 → 0.272.1-dev.1f1c09c80

package/README.md

@@ -3669,6 +3669,9 @@ paid for by the time it runs — and the findings come back as `review` and `hin
 - **Across the reel:** whether the cast stays the same people, whether a brand mark is
   visible anywhere, and whether the last frames close the ad or simply stop.
 
+Each per-frame finding names the **scene file** that produced that second, so a defect is
+an edit rather than a hunt — and re-running re-renders only the scenes you changed.
+
 It needs `GEMINI_API_KEY` (the Runtime receives it automatically). Without one the run
 says the video was **not** reviewed rather than reporting it clean, and a frame that
 could not be read is reported as unchecked for the same reason.

package/dist/cli.js

@@ -30100,6 +30100,9 @@ async function syncSceneNodeParams(canvas, canvasPath, log) {
   try {
     rebuildRaw = await readFile7(path9.join(creativeDir, REBUILD_FILE), "utf8");
   } catch {
+    log(
+      `[scenes] this creative has scene files but no ${REBUILD_FILE}, so edits to scenes/*.json are NOT reaching the render \u2014 the prompts inlined in the canvas are what renders. Re-scaffold the creative to restore the link, or edit the canvas node prompts directly.`
+    );
     return "not_applicable";
   }
   const { elements, opts } = JSON.parse(rebuildRaw);
@@ -30531,10 +30534,10 @@ function runDirsToPrune(entries, keep, currentRunId) {
   return runs.slice(0, Math.max(0, runs.length - keep));
 }
 async function pruneOldRuns(outputsDir, keep, currentRunId, log) {
-  const { readdir: readdir11 } = await import("fs/promises");
+  const { readdir: readdir12 } = await import("fs/promises");
   let entries;
   try {
-    entries = await readdir11(outputsDir);
+    entries = await readdir12(outputsDir);
   } catch {
     return;
   }
@@ -30827,7 +30830,7 @@ async function restoreRunSnapshot(manifest, targetDir, opts = {}) {
 
 // src/engine/nodes/local/lib/render-review.ts
 import { execFile as execFile2 } from "child_process";
-import { mkdtemp, readFile as readFile11, rm as rm5 } from "fs/promises";
+import { mkdtemp, readdir as readdir6, readFile as readFile11, rm as rm5 } from "fs/promises";
 import { tmpdir } from "os";
 import path15 from "path";
 import { promisify as promisify2 } from "util";
@@ -30835,6 +30838,9 @@ import { z as z28 } from "zod";
 var RENDER_REVIEW_MODEL = "gemini-pro-latest";
 var RENDER_REVIEW_FRAMES = 12;
 var RENDER_REVIEW_WIDTH = 1024;
+function sceneAt(windows, atS) {
+  return windows.find((w) => atS >= w.startS && atS < w.endS)?.file;
+}
 function reviewFrameTimes(durationS, frames) {
   const n = Math.max(2, frames);
   const last = Math.max(0, durationS - 0.15);
@@ -30937,19 +30943,23 @@ function collapseRepeats(frames) {
   }
   return [...seen.values()];
 }
-function classifyFrameFindings(frames) {
+function classifyFrameFindings(frames, windows = []) {
   const seen = collapseRepeats(frames);
   const anatomy = seen.filter((f) => ANATOMY.test(f.what));
   const rest = seen.filter((f) => !ANATOMY.test(f.what));
-  const findings = rest.map((f) => ({
-    severity: "blocking",
-    what: `At ${f.at.map((s) => `${s}s`).join(", ")}: ${f.what}`
-  }));
+  const findings = rest.map((f) => {
+    const scene = sceneAt(windows, f.at[0]);
+    return {
+      severity: "blocking",
+      what: `At ${f.at.map((s) => `${s}s`).join(", ")}${scene ? ` (${scene})` : ""}: ${f.what}`,
+      ...scene ? { scene } : {}
+    };
+  });
   if (anatomy.length > 0) {
     const at = [...new Set(anatomy.flatMap((f) => f.at))].sort((a, b) => a - b);
     findings.push({
       severity: "blocking",
-      what: `Malformed hands or limbs in ${at.length} of ${frames.length} sampled frames (${at.map((s) => `${s}s`).join(", ")}): ${anatomy.map((f) => f.what).join(" ")} Re-render those beats \u2014 keep hands out of frame, or away from the object being held.`
+      what: `Malformed hands or limbs in ${at.length} of ${frames.length} sampled frames (${at.map((s) => `${s}s${sceneAt(windows, s) ? ` \u2192 ${sceneAt(windows, s)}` : ""}`).join(", ")}): ${anatomy.map((f) => f.what).join(" ")} Re-render those beats \u2014 keep hands out of frame, or away from the object being held.`
     });
   }
   return findings;
@@ -31074,7 +31084,7 @@ async function reviewRenderedVideo(opts) {
     }));
     const unread = perFrame.filter((f) => f.json === null).length;
     if (unread === perFrame.length && reel === null) return null;
-    const findings = [...classifyFrameFindings(perFrame), ...classifyReelFindings(reel)];
+    const findings = [...classifyFrameFindings(perFrame, opts.windows ?? []), ...classifyReelFindings(reel)];
     if (unread > 0) {
       findings.push({
         severity: "warning",
@@ -31086,6 +31096,24 @@ async function reviewRenderedVideo(opts) {
     await rm5(dir, { recursive: true, force: true });
   }
 }
+async function sceneWindowsBeside(canvasPath) {
+  const dir = path15.join(path15.dirname(canvasPath), "scenes");
+  const files = await readdir6(dir).catch(() => null);
+  if (!files) return [];
+  const windows = [];
+  for (const name of files.filter((f) => f.endsWith(".json")).sort()) {
+    const raw = await readFile11(path15.join(dir, name), "utf-8").catch(() => null);
+    if (!raw) continue;
+    try {
+      const scene = JSON.parse(raw);
+      if (typeof scene.start_s === "number" && typeof scene.end_s === "number") {
+        windows.push({ file: `scenes/${name}`, startS: scene.start_s, endS: scene.end_s });
+      }
+    } catch {
+    }
+  }
+  return windows;
+}
 
 // src/commands/canvas/run.ts
 var runCommand = defineCommand100({
@@ -31373,10 +31401,13 @@ ${describeRewrites(healed.rewrites)}
 `));
     }
     const reviewable = videoPathFromOutput(result.output);
-    const review = reviewable ? await reviewRenderedVideo({ video: reviewable }) : null;
+    const review = reviewable ? await reviewRenderedVideo({ video: reviewable, windows: await sceneWindowsBeside(filePath) }) : null;
     const hints = reviewable ? review === null ? [RENDER_REVIEW_UNAVAILABLE] : review.length === 0 ? ["Reviewed the finished video frame by frame \u2014 nothing to report."] : [
       `Reviewed the finished video and found ${review.length} thing${review.length === 1 ? "" : "s"} to fix. Show the user what is wrong before you show them the ad.`,
-      ...review.map((f) => `${f.severity === "blocking" ? "MUST FIX" : "SHOULD FIX"} \u2014 ${f.what}`)
+      ...review.map((f) => `${f.severity === "blocking" ? "MUST FIX" : "SHOULD FIX"} \u2014 ${f.what}`),
+      ...review.some((f) => f.scene) ? [
+        `Fix them, then re-run: edit the \`show\` of the scene files named above \u2014 a shot with a person handling equipment is where limbs and objects go wrong, so widen it, move the hands out of frame, or drop the person from that beat. Re-running re-renders ONLY the scenes you edited; everything else comes from the cache (this run: ${result.stats?.cached_nodes ?? 0} of ${result.stats?.total_nodes ?? 0} nodes were cached).`
+      ] : []
     ] : [];
     process.stdout.write(
       `${JSON.stringify(
@@ -31921,7 +31952,7 @@ function isValidScaffoldSlug(slug) {
 }
 
 // src/commands/canvas/sync-definition.ts
-import { readdir as readdir6, readFile as readFile13, stat as stat3 } from "fs/promises";
+import { readdir as readdir7, readFile as readFile13, stat as stat3 } from "fs/promises";
 import path20 from "path";
 import { defineCommand as defineCommand102 } from "citty";
 
@@ -32027,7 +32058,7 @@ async function resolveCanvasPath(inputPath) {
   }
   let entries;
   try {
-    entries = await readdir6(dir);
+    entries = await readdir7(dir);
   } catch {
     return null;
   }
@@ -32692,7 +32723,7 @@ function adSpecToBlueprint(spec) {
   const market = marketFor(spec);
   const place = market ? ` Set in ${market}: the architecture, streets and styling are ${market}'s.` : "";
   const currency = market ? CURRENCY_BY_MARKET[market.toLowerCase()] : void 0;
-  const physics = " Everything obeys real-world physics: paper, card and screens are OPAQUE with nothing showing through from behind, every object is at believable real-world scale next to the people handling it, and every object has its real-world form and construction \u2014 a phone has ONE screen and it is on the front. NO readable text or numbers anywhere in frame \u2014 phone screens, documents and signage stay illegible or out of focus, because any figure the model invents will contradict the script." + (currency ? ` If a currency is unavoidably visible it is ${currency}.` : "");
+  const physics = " Everything obeys real-world physics: paper, card and screens are OPAQUE with nothing showing through from behind, every object is at believable real-world scale next to the people handling it, and every object has its real-world form and construction \u2014 a phone has ONE screen and it is on the front. NO readable text or numbers anywhere in frame \u2014 phone screens, documents and signage stay illegible or out of focus, because any figure the model invents will contradict the script. Hands are kept simple: no close-up of fingers manipulating small parts, no hand gripping the edge of an object, and each person has exactly TWO arms and TWO legs, all attached and all visible or all out of frame. Anyone working does so the way the trade actually does it: nobody stands or kneels on the equipment being installed, nothing is fitted overhanging an edge or floating unsupported, and every part rests on the structure that would really carry it." + (currency ? ` If a currency is unavoidably visible it is ${currency}.` : "");
   const closesOnCard = endCardWanted(spec);
   let clock = 0;
   const scenes = spec.beats.map((beat, i) => {
@@ -32877,7 +32908,7 @@ function injectAdBrandOverlay(indexHtml, overlayHtml) {
 }
 
 // src/engine/scaffold/ad-brand-source.ts
-import { readdir as readdir7, readFile as readFile15 } from "fs/promises";
+import { readdir as readdir8, readFile as readFile15 } from "fs/promises";
 import path22 from "path";
 var BRAND_DIR = "src/brand";
 function paletteFromBrandDoc(markdown) {
@@ -32917,7 +32948,7 @@ async function readBrandFromWorkspace(root = ".") {
     if (palette.length > 0) found.palette = palette;
   }
   const dir = path22.join(root, BRAND_DIR, "logos");
-  const files = await readdir7(dir).catch(() => null);
+  const files = await readdir8(dir).catch(() => null);
   if (files) {
     const mark = pickBrandMark(files);
     if (mark) found.logo = path22.join(BRAND_DIR, "logos", mark);
@@ -33111,6 +33142,12 @@ var scaffoldAdCommand = defineCommand104({
       const html = await readFile16(indexPath, "utf-8");
       await writeFile9(indexPath, injectAdBrandOverlay(html, overlayHtml), "utf-8");
     }
+    await writeFile9(
+      path24.join(outDir, REBUILD_FILE),
+      `${JSON.stringify({ elements: adSpecCastElements(spec.data, avatar), opts }, null, 2)}
+`,
+      "utf8"
+    );
     await writeFile9(outPath, `${JSON.stringify(canvas, null, 2)}
 `, "utf-8");
     writeJson({
@@ -33199,7 +33236,7 @@ function routeVideoModel(input) {
 
 // src/engine/nodes/local/lib/sceneDetect.ts
 import { execFile as execFile3 } from "child_process";
-import { mkdtemp as mkdtemp2, readdir as readdir8, readFile as readFile17, rm as rm6 } from "fs/promises";
+import { mkdtemp as mkdtemp2, readdir as readdir9, readFile as readFile17, rm as rm6 } from "fs/promises";
 import { tmpdir as tmpdir2 } from "os";
 import { join as join2 } from "path";
 import { promisify as promisify3 } from "util";
@@ -33273,7 +33310,7 @@ async function runSceneDetectOnce(filePath, threshold, minSceneLenS, timeoutMs)
       ],
       { encoding: "utf-8", maxBuffer: 32 * 1024 * 1024, timeout: timeoutMs }
     );
-    const csvName = (await readdir8(outDir)).find((f) => f.toLowerCase().endsWith(".csv"));
+    const csvName = (await readdir9(outDir)).find((f) => f.toLowerCase().endsWith(".csv"));
     if (!csvName) return [];
     return parsePySceneDetectCsvCuts(await readFile17(join2(outDir, csvName), "utf-8"));
   } finally {
@@ -42332,7 +42369,7 @@ Full guide: __tooling__/docs/tools/baker/images.md`
 import { defineCommand as defineCommand167 } from "citty";
 
 // src/commands/landing/critique.ts
-import { readdir as readdir10, stat as stat6 } from "fs/promises";
+import { readdir as readdir11, stat as stat6 } from "fs/promises";
 import path31 from "path";
 import { defineCommand as defineCommand157 } from "citty";
 
@@ -43319,7 +43356,7 @@ async function writeCritiqueSnapshot(projectRoot, snapshot) {
 }
 
 // src/commands/landing/source-version.ts
-import { readdir as readdir9, readFile as readFile24, stat as stat5 } from "fs/promises";
+import { readdir as readdir10, readFile as readFile24, stat as stat5 } from "fs/promises";
 import path30 from "path";
 async function landingSourceRelPaths(landingDir) {
   const rel = [];
@@ -43360,7 +43397,7 @@ async function isFile(p) {
 async function walkAstro(dir) {
   let entries;
   try {
-    entries = await readdir9(dir, { withFileTypes: true });
+    entries = await readdir10(dir, { withFileTypes: true });
   } catch {
     return [];
   }
@@ -43486,7 +43523,7 @@ async function critiqueOne(projectRoot, slug, brand) {
 }
 async function listLandingSlugs(projectRoot) {
   try {
-    const entries = await readdir10(path31.join(projectRoot, "src", "pages"), { withFileTypes: true });
+    const entries = await readdir11(path31.join(projectRoot, "src", "pages"), { withFileTypes: true });
     return entries.filter((e) => e.isDirectory() && !e.name.startsWith("_") && !e.name.startsWith(".")).map((e) => e.name).sort();
   } catch {
     return [];