@koa/router 13.0.1 → 13.1.0

package/HISTORY.md

@@ -0,0 +1,187 @@
+# History
+
+**[History has moved to the Releases tab of GitHub](https://github.com/koajs/router/releases).**
+
+
+## Log
+
+
+## 9.0.0 / 2020-04-09
+
+* Update `path-to-regexp`. Migration path: change usage of `'*'` in routes to `(.*)` or `:splat*`.
+  * Example: `router.get('*', ....)` becomes `router.get('(.*)') ....)`
+
+
+## 8.0.0 / 2019-06-16
+
+**others**
+
+* [b5dd5e8](http://github.com/koajs/koa-router/commit/b5dd5e8f00e841b7061a62ab6228cbe96a999470)] - chore: rename to @koa/router (dead-horse)
+
+---
+
+Changelogs inherit from koa-router.
+
+
+## 7.4.0
+
+* Fix router.url() for multiple nested routers [#407](https://github.com/alexmingoia/koa-router/pull/407)
+* `layer.name` added to `ctx` at `ctx.routerName` during routing [#412](https://github.com/alexmingoia/koa-router/pull/412)
+* Router.use() was erroneously settings `(.*)` as a prefix to all routers nested with .use that did not pass an explicit prefix string as the first argument. This resulted in routes being matched that should not have been, included the running of multiple route handlers in error. [#369](https://github.com/alexmingoia/koa-router/issues/369) and [#410](https://github.com/alexmingoia/koa-router/issues/410) include information on this issue.
+
+
+## 7.3.0
+
+* Router#url() now accepts query parameters to add to generated urls [#396](https://github.com/alexmingoia/koa-router/pull/396)
+
+
+## 7.2.1
+
+* Respond to CORS preflights with 200, 0 length body [#359](https://github.com/alexmingoia/koa-router/issues/359)
+
+
+## 7.2.0
+
+* Fix a bug in Router#url and append Router object to ctx. [#350](https://github.com/alexmingoia/koa-router/pull/350)
+* Adds `_matchedRouteName` to context [#337](https://github.com/alexmingoia/koa-router/pull/337)
+* Respond to CORS preflights with 200, 0 length body [#359](https://github.com/alexmingoia/koa-router/issues/359)
+
+
+## 7.1.1
+
+* Fix bug where param handlers were run out of order [#282](https://github.com/alexmingoia/koa-router/pull/282)
+
+
+## 7.1.0
+
+* Backports: merge 5.4 work into the 7.x upstream. See 5.4.0 updates for more details.
+
+
+## 7.0.1
+
+* Fix: allowedMethods should be ctx.method not this.method [#215](https://github.com/alexmingoia/koa-router/pull/215)
+
+
+## 7.0.0
+
+* The API has changed to match the new promise-based middleware
+  signature of koa 2. See the
+  [koa 2.x readme](https://github.com/koajs/koa/tree/2.0.0-alpha.3) for more
+  information.
+* Middleware is now always run in the order declared by `.use()` (or `.get()`,
+  etc.), which matches Express 4 API.
+
+
+## 5.4.0
+
+* Expose matched route at `ctx._matchedRoute`.
+
+
+## 5.3.0
+
+* Register multiple routes with array of paths [#203](https://github.com/alexmingoia/koa-router/issue/143).
+* Improved router.url() [#143](https://github.com/alexmingoia/koa-router/pull/143)
+* Adds support for named routes and regular expressions
+  [#152](https://github.com/alexmingoia/koa-router/pull/152)
+* Add support for custom throw functions for 405 and 501 responses [#206](https://github.com/alexmingoia/koa-router/pull/206)
+
+
+## 5.2.3
+
+* Fix for middleware running twice when nesting routes [#184](https://github.com/alexmingoia/koa-router/issues/184)
+
+
+## 5.2.2
+
+* Register routes without params before those with params [#183](https://github.com/alexmingoia/koa-router/pull/183)
+* Fix for allowed methods [#182](https://github.com/alexmingoia/koa-router/issues/182)
+
+
+## 5.2.0
+
+* Add support for async/await. Resolves [#130](https://github.com/alexmingoia/koa-router/issues/130).
+* Add support for array of paths by Router#use(). Resolves [#175](https://github.com/alexmingoia/koa-router/issues/175).
+* Inherit param middleware when nesting routers. Fixes [#170](https://github.com/alexmingoia/koa-router/issues/170).
+* Default router middleware without path to root. Fixes [#161](https://github.com/alexmingoia/koa-router/issues/161), [#155](https://github.com/alexmingoia/koa-router/issues/155), [#156](https://github.com/alexmingoia/koa-router/issues/156).
+* Run nested router middleware after parent's. Fixes [#156](https://github.com/alexmingoia/koa-router/issues/156).
+* Remove dependency on koa-compose.
+
+
+## 5.1.1
+
+* Match routes in order they were defined. Fixes #131.
+
+
+## 5.1.0
+
+* Support mounting router middleware at a given path.
+
+
+## 5.0.1
+
+* Fix bug with missing parameters when nesting routers.
+
+
+## 5.0.0
+
+* Remove confusing API for extending koa app with router methods. Router#use()
+  does not have the same behavior as app#use().
+* Add support for nesting routes.
+* Remove support for regular expression routes to achieve nestable routers and
+  enable future trie-based routing optimizations.
+
+
+## 4.3.2
+
+* Do not send 405 if route matched but status is 404. Fixes #112, closes #114.
+
+
+## 4.3.1
+
+* Do not run middleware if not yielded to by previous middleware. Fixes #115.
+
+
+## 4.3.0
+
+* Add support for router prefixes.
+* Add MIT license.
+
+
+## 4.2.0
+
+* Fixed issue with router middleware being applied even if no route was
+  matched.
+* Router.url - new static method to generate url from url pattern and data
+
+
+## 4.1.0
+
+Private API changed to separate context parameter decoration from route
+matching. `Router#match` and `Route#match` are now pure functions that return
+an array of routes that match the URL path.
+
+For modules using this private API that need to determine if a method and path
+match a route, `route.methods` must be checked against the routes returned from
+`router.match()`:
+
+```javascript
+var matchedRoute = router.match(path).filter(function (route) {
+  return ~route.methods.indexOf(method);
+}).shift();
+```
+
+
+## 4.0.0
+
+405, 501, and OPTIONS response handling was moved into separate middleware
+`router.allowedMethods()`. This resolves incorrect 501 or 405 responses when
+using multiple routers.
+
+### Breaking changes
+
+4.x is mostly backwards compatible with 3.x, except for the following:
+
+* Instantiating a router with `new` and `app` returns the router instance,
+  whereas 3.x returns the router middleware. When creating a router in 4.x, the
+  only time router middleware is returned is when creating using the
+  `Router(app)` signature (with `app` and without `new`).

package/lib/layer.js

@@ -1,6 +1,6 @@
 const { parse: parseUrl, format: formatUrl } = require('node:url');
 
-const { pathToRegexp, compile, parse, stringify } = require('path-to-regexp');
+const { pathToRegexp, compile, parse } = require('path-to-regexp');
 
 module.exports = class Layer {
   /**
@@ -13,7 +13,6 @@ module.exports = class Layer {
    * @param {String=} opts.name route name
    * @param {String=} opts.sensitive case sensitive (default: false)
    * @param {String=} opts.strict require the trailing slash (default: false)
-   * @param {Boolean=} opts.pathIsRegexp if true, treat `path` as a regular expression
    * @returns {Layer}
    * @private
    */
@@ -42,19 +41,7 @@ module.exports = class Layer {
     }
 
     this.path = path;
-
-    if (this.opts.pathIsRegexp === true) {
-      this.regexp = new RegExp(path);
-    } else if (this.path) {
-      if (this.opts.strict === true) {
-        // path-to-regexp renamed strict to trailing in v8.1.0
-        this.opts.trailing = false;
-      }
-
-      const { regexp: regex, keys } = pathToRegexp(this.path, this.opts);
-      this.regexp = regex;
-      this.paramNames = keys;
-    }
+    this.regexp = pathToRegexp(path, this.paramNames, this.opts);
   }
 
   /**
@@ -129,14 +116,13 @@ module.exports = class Layer {
 
     const toPath = compile(url, { encode: encodeURIComponent, ...options });
     let replaced;
-    const { tokens } = parse(url);
+
+    const tokens = parse(url);
     let replace = {};
 
     if (Array.isArray(args)) {
       for (let len = tokens.length, i = 0, j = 0; i < len; i++) {
-        if (tokens[i].name) {
-          replace[tokens[i].name] = args[j++];
-        }
+        if (tokens[i].name) replace[tokens[i].name] = args[j++];
       }
     } else if (tokens.some((token) => token.name)) {
       replace = params;
@@ -144,10 +130,6 @@ module.exports = class Layer {
       options = params;
     }
 
-    for (const [key, value] of Object.entries(replace)) {
-      replace[key] = String(value);
-    }
-
     replaced = toPath(replace);
 
     if (options && options.query) {
@@ -230,13 +212,8 @@ module.exports = class Layer {
         this.path !== '/' || this.opts.strict === true
           ? `${prefix}${this.path}`
           : prefix;
-      if (this.opts.pathIsRegexp === true || prefix instanceof RegExp) {
-        this.regexp = new RegExp(this.path);
-      } else if (this.path) {
-        const { regexp: regex, keys } = pathToRegexp(this.path, this.opts);
-        this.regexp = regex;
-        this.paramNames = keys;
-      }
+      this.paramNames = [];
+      this.regexp = pathToRegexp(this.path, this.paramNames, this.opts);
     }
 
     return this;

package/lib/router.js

@@ -165,14 +165,14 @@ class Router {
           }
         }
       } else {
-        const { keys } = pathToRegexp(router.opts.prefix || '', router.opts);
+        const keys = [];
+        pathToRegexp(router.opts.prefix || '', keys);
         const routerPrefixHasParam = Boolean(
           router.opts.prefix && keys.length > 0
         );
         router.register(path || '([^/]*)', [], m, {
           end: false,
-          ignoreCaptures: !hasPath && !routerPrefixHasParam,
-          pathIsRegexp: true
+          ignoreCaptures: !hasPath && !routerPrefixHasParam
         });
       }
     }
@@ -380,7 +380,7 @@ class Router {
    * @returns {Router}
    */
   all(name, path, middleware) {
-    if (typeof path === 'string' || path instanceof RegExp) {
+    if (typeof path === 'string') {
       middleware = Array.prototype.slice.call(arguments, 2);
     } else {
       middleware = Array.prototype.slice.call(arguments, 1);
@@ -396,12 +396,7 @@ class Router {
     )
       throw new Error('You have to provide a path when adding an all handler');
 
-    const opts = {
-      name,
-      pathIsRegexp: path instanceof RegExp
-    };
-
-    this.register(path, methods, middleware, { ...this.opts, ...opts });
+    this.register(path, methods, middleware, { name });
 
     return this;
   }
@@ -460,10 +455,10 @@ class Router {
    * @returns {Layer}
    * @private
    */
-  register(path, methods, middleware, newOpts = {}) {
+  register(path, methods, middleware, opts = {}) {
     const router = this;
     const { stack } = this;
-    const opts = { ...this.opts, ...newOpts };
+
     // support array of paths
     if (Array.isArray(path)) {
       for (const curPath of path) {
@@ -477,14 +472,12 @@ class Router {
     const route = new Layer(path, methods, middleware, {
       end: opts.end === false ? opts.end : true,
       name: opts.name,
-      sensitive: opts.sensitive || false,
-      strict: opts.strict || false,
-      prefix: opts.prefix || '',
-      ignoreCaptures: opts.ignoreCaptures,
-      pathIsRegexp: opts.pathIsRegexp
+      sensitive: opts.sensitive || this.opts.sensitive || false,
+      strict: opts.strict || this.opts.strict || false,
+      prefix: opts.prefix || this.opts.prefix || '',
+      ignoreCaptures: opts.ignoreCaptures
     });
 
-    // if parent prefix exists, add prefix to new route
     if (this.opts.prefix) {
       route.setPrefix(this.opts.prefix);
     }
@@ -819,13 +812,8 @@ for (const method of methods) {
         `You have to provide a path when adding a ${method} handler`
       );
 
-    const opts = {
-      name,
-      pathIsRegexp: path instanceof RegExp
-    };
+    this.register(path, [method], middleware, { name });
 
-    // pass opts to register call on verb methods
-    this.register(path, [method], middleware, { ...this.opts, ...opts });
     return this;
   };
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@koa/router",
   "description": "Router middleware for koa. Maintained by Forward Email and Lad.",
-  "version": "13.0.1",
+  "version": "13.1.0",
   "author": "Alex Mingoia <talk@alexmingoia.com>",
   "bugs": {
     "url": "https://github.com/koajs/router/issues",
@@ -23,7 +23,7 @@
   "dependencies": {
     "http-errors": "^2.0.0",
     "koa-compose": "^4.1.0",
-    "path-to-regexp": "^8.1.0"
+    "path-to-regexp": "^6.3.0"
   },
   "devDependencies": {
     "@commitlint/cli": "^17.7.2",
@@ -68,7 +68,7 @@
     "docs": "NODE_ENV=test jsdoc2md -t ./lib/API_tpl.hbs --src ./lib/*.js  >| API.md",
     "lint": "xo --fix && remark . -qfo && fixpack",
     "prepare": "husky install",
-    "pretest": "npm run lint",
+    "prextest": "npm run lint",
     "test": "mocha test/**/*.js",
     "test:watch": "mocha test/**/*.js --watch"
   }