@knime/utils 1.4.3 → 1.5.0

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @knime/utils
 
+## 1.5.0
+
+### Minor Changes
+
+- 493c9f0: TS improvements
+
+  - removed namespaces: UploadManagerNS
+  - replaced any with fitting type or unknown/never
+
+## 1.4.4
+
+### Patch Changes
+
+- Updated dependencies [8e21558]
+  - @knime/styles@1.7.0
+
 ## 1.4.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@knime/utils",
-  "version": "1.4.3",
+  "version": "1.5.0",
   "description": "Internal utility functions and constants shared across @knime packages.",
   "homepage": "https://knime.github.io/webapps-common/",
   "license": "GPL 3 and Additional Permissions according to Sec. 7 (SEE the file LICENSE)",
@@ -9,7 +9,7 @@
   "dependencies": {
     "date-fns": "2.30.0",
     "date-fns-tz": "2.0.0",
-    "@knime/styles": "1.6.0"
+    "@knime/styles": "1.7.0"
   },
   "peerDependencies": {
     "consola": "3.x"

package/src/filters.ts

@@ -110,5 +110,5 @@ const modeDefinitions = [
 // convert [{id: "key1", text: "asdf"}, ...] to {"key1": {id:"key1", text: "asdf"} ... }
 export const filters: Record<
   string,
-  FilterDefinition<any, any, any>
+  FilterDefinition<unknown, unknown, unknown>
 > = Object.assign({}, ...modeDefinitions.map((obj) => ({ [obj.id]: obj })));

package/src/formatHotkeys.ts

@@ -73,8 +73,8 @@ export const formatHotkey = (hotkey: Hotkey): string => {
    * Pipe function implementation. Receives a list of functions to execute in order
    * and will pipe the parameter passed at the end to each function returning the final output
    */
-  const pipe = <T extends () => any>(
-    ...fns: Array<(...args: any[]) => ReturnType<T>>
+  const pipe = <T extends () => string>(
+    ...fns: Array<(...args: Hotkey[]) => ReturnType<T>>
   ) => fns.reduce((f, g) => (arg) => g(f(arg)));
 
   const macKeyFormatter = pipe(

package/src/index.ts

@@ -37,15 +37,11 @@ import * as uploadManager from "./uploadManager";
 
 const hotkeys = { formatHotkeys, formatHotkey, getDefaultSeparator };
 
-export namespace HotkeysNS {
-  export type Hotkey = _Hotkey;
-  export type KnownHotkey = _KnownHotkey;
-}
+export type Hotkey = _Hotkey;
+export type KnownHotkey = _KnownHotkey;
 
-export namespace UploadManagerNS {
-  export type UploaderConfig = _UploadManagerConfig;
-  export type UploadStateName = _UploadStateName;
-}
+export type UploaderConfig = _UploadManagerConfig;
+export type UploadStateName = _UploadStateName;
 
 export * from "./fileExtensions";
 export * from "./hotkeys";

package/src/promise/retryPromise.ts

@@ -1,4 +1,3 @@
-/* eslint-disable func-style */
 import sleep from "../sleep";
 
 export const DEFAULT_RETRY_DELAY_MS = 0;

package/src/uploadManager/index.ts

@@ -312,7 +312,7 @@ export const createUploadManager = (config: UploaderManagerConfig) => {
 
         setFailed(
           uploadId,
-          error instanceof Error ? error : new Error(error as any),
+          error instanceof Error ? error : new Error(error as string),
         );
         return;
       }
@@ -333,7 +333,7 @@ export const createUploadManager = (config: UploaderManagerConfig) => {
   };
 
   const uploadFiles = (files: Array<{ uploadId: string; file: File }>) => {
-    const result: Array<Promise<any>> = [];
+    const result: Array<Promise<unknown>> = [];
 
     for (const { uploadId, file } of files) {
       result.push(uploadFileFromChunkIndex(uploadId, file));

package/test-utils/muteConsole.ts

@@ -8,8 +8,7 @@ const methods: ConsoleMethod[] = ["log", "warn", "error", "info"];
  * @param f The function to run. Can be async.
  * @returns The original function's return value
  */
-// TODO: replace Function with fitting top type (...args: never[]) => unknown has unknown return type which makes problems in line 41
-export default (f: Function) => {
+export default (f: (...args: never[]) => Promise<unknown>) => {
   const originals = methods.map((method) => console[method]);
   methods.forEach((method) => {
     console[method] = () => {};
@@ -38,7 +37,10 @@ export default (f: Function) => {
 
   if (f.constructor.name === "AsyncFunction") {
     // async
-    return f().finally(restoreOriginals);
+    const result = f();
+    if (result instanceof Promise) {
+      return result.finally(restoreOriginals);
+    }
   } else {
     // sync
     try {