@knime/hub-features 1.22.3 → 1.23.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @knime/hub-features
 
+## 1.23.0
+
+### Minor Changes
+
+- 368d638: Fix error when fetching versions if user that created the version is no longer available
+
+## 1.22.4
+
+### Patch Changes
+
+- 12e9b4a: Auto-expand RFC error toast when details list is empty
+
 ## 1.22.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@knime/hub-features",
-  "version": "1.22.3",
+  "version": "1.23.0",
   "description": "Vue components & composables for shared hub features",
   "repository": {
     "type": "git",

package/src/components/versions/composables/useVersionsApi.ts

@@ -70,18 +70,28 @@ export const useVersionsApi = ({
     }>;
   };
 
-  const fetchResourceLabels = ({
+  const fetchResourceLabels = async ({
     resourceType,
     resourceId,
   }: {
     resourceType: "savepoint";
     resourceId: string;
-  }) => {
-    return doHubRequest(
-      `/validation/validation/resources/${resourceType}/${resourceId}/labels`,
-    ).catch(() => ({ assignedLabels: [] })) as Promise<{
-      assignedLabels: Array<AssignedLabel>;
-    }>;
+  }): Promise<{
+    assignedLabels: Array<AssignedLabel>;
+  }> => {
+    try {
+      return await doHubRequest(
+        `/validation/validation/resources/${resourceType}/${resourceId}/labels`,
+      );
+    } catch (error) {
+      consola.error("useVersionsApi::Failed to fetch resource labels", {
+        resourceId,
+        resourceType,
+        error,
+      });
+
+      return { assignedLabels: [] };
+    }
   };
 
   const deleteVersion = ({
@@ -140,36 +150,50 @@ export const useVersionsApi = ({
   }: {
     accountName: string;
   }): Promise<HubAvatarData> => {
-    const accountInfo = await doHubRequest(`/accounts/name/${accountName}`, {
-      headers: {
-        Prefer: "representation=minimal",
-      },
-    });
+    try {
+      const accountInfo = await doHubRequest(`/accounts/name/${accountName}`, {
+        headers: {
+          Prefer: "representation=minimal",
+        },
+      });
 
-    return {
-      kind: accountInfo.type === "TEAM" ? "group" : "account",
-      name: accountInfo.name,
-      image: {
-        url: accountInfo.avatarUrl,
-        altText: `${accountInfo.realName ?? accountInfo.name} profile image`,
-      },
-    };
+      return {
+        kind: accountInfo.type === "TEAM" ? "group" : "account",
+        name: accountInfo.name,
+        image: {
+          url: accountInfo.avatarUrl,
+          altText: `${accountInfo.realName ?? accountInfo.name} profile image`,
+        },
+      };
+    } catch (error) {
+      consola.error("useVersionsApi::Failed to fetch user avatar", {
+        accountName,
+        error,
+      });
+
+      return {
+        kind: "account",
+        name: "?",
+        tooltip: "unknown",
+      };
+    }
   };
 
   const loadSavepointMetadata = async (
     savepoint: ItemSavepoint,
   ): Promise<WithAvatar & WithLabels> => {
-    return {
-      avatar: await getAvatar({
-        accountName: savepoint.version?.author ?? savepoint.author,
-      }),
-      labels: savepoint.itemVersionId
-        ? await fetchResourceLabels({
-            resourceType: "savepoint",
-            resourceId: savepoint.itemVersionId,
-          }).then((response) => response.assignedLabels)
-        : [],
-    };
+    const avatar = await getAvatar({
+      accountName: savepoint.version?.author ?? savepoint.author,
+    });
+
+    const labels = savepoint.itemVersionId
+      ? await fetchResourceLabels({
+          resourceType: "savepoint",
+          resourceId: savepoint.itemVersionId,
+        }).then((response) => response.assignedLabels)
+      : [];
+
+    return { avatar, labels };
   };
 
   const fetchItemSavepoints = ({

package/src/rfcErrors/RFCErrorToastTemplate.vue

@@ -35,7 +35,14 @@ const { copy, copied } = useClipboard({
   copiedDuring: 3000,
 });
 
-const showDetails = ref(false);
+const hasDetails =
+  props.details?.length ||
+  props.status !== undefined ||
+  props.date !== undefined ||
+  props.requestId !== undefined ||
+  props.errorId !== undefined;
+// don't show 'Show details' button if there are no details to show
+const showDetails = ref(!hasDetails);
 
 const formatDate = (date: Date): string =>
   date ? formatDateTimeString(date.getTime()) : "";