@knime/hub-features 1.21.2 → 1.22.1

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @knime/hub-features
 
+## 1.22.1
+
+### Patch Changes
+
+- d0c7524: KDS-659: avoid instanceof; it fails with mulitple ofetch versions
+
+## 1.22.0
+
+### Minor Changes
+
+- 395300b: allow embedding failure to be sent after initialization step
+
 ## 1.21.2
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@knime/hub-features",
-  "version": "1.21.2",
+  "version": "1.22.1",
   "description": "Vue components & composables for shared hub features",
   "repository": {
     "type": "git",
@@ -36,9 +36,9 @@
     "lodash-es": "4.17.23",
     "ofetch": "^1.4.1",
     "typescript": "^5.9.3",
-    "@knime/components": "1.45.7",
+    "@knime/styles": "1.15.0",
     "@knime/utils": "1.10.0",
-    "@knime/styles": "1.15.0"
+    "@knime/components": "1.45.7"
   },
   "peerDependencies": {
     "consola": "3.x",

package/src/embeddingSDK/host.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-use-before-define */
 import { MESSAGES } from "./messages";
 import {
   type EmbeddingContext,
@@ -20,9 +19,7 @@ export const init = (callbacks: {
   onReady: () => void;
   onError: (error: Error) => void;
 }) => {
-  function teardown() {
-    window.removeEventListener("message", onMessage);
-  }
+  let _initDone = false;
 
   function onMessage(event: MessageEvent) {
     if (!messageValidators.isInitializationMessage(event)) {
@@ -30,9 +27,13 @@ export const init = (callbacks: {
     }
 
     if (event.data?.type === MESSAGES.AWAITING_EMBEDDING_CONTEXT) {
+      if (_initDone) {
+        return;
+      }
+
       logger().info("Got confirmation to send embedding context");
       callbacks.onReady();
-      teardown();
+      _initDone = true;
     }
 
     if (event.data?.type === MESSAGES.EMBEDDING_FAILED) {
@@ -40,7 +41,6 @@ export const init = (callbacks: {
         event: event.data,
       });
       callbacks.onError(event.data.error);
-      teardown();
     }
   }
 

package/src/rfcErrors/index.ts

@@ -41,12 +41,22 @@ const toToast = ({
   };
 };
 
+const isFetchError = (error: unknown): error is FetchError => {
+  return (
+    error !== null &&
+    typeof error === "object" &&
+    "response" in error &&
+    "statusCode" in error &&
+    "data" in error
+  );
+};
+
 /**
  * Parse an ofetch's `FetchError` to an `RFCError`.
  * When parsing is not possible it returns undefined.
  */
 const tryParse = (error: unknown): RFCError | undefined => {
-  if (!(error instanceof FetchError)) {
+  if (!isFetchError(error)) {
     return undefined;
   }