@knime/hub-features 1.19.0 → 1.20.1

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @knime/hub-features
 
+## 1.20.1
+
+### Patch Changes
+
+- c877d5a: NXT-4373: improve upload api
+- Updated dependencies [c877d5a]
+  - @knime/components@1.45.6
+
+## 1.20.0
+
+### Minor Changes
+
+- 63ed737: adjust analytics event structure
+
 ## 1.19.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@knime/hub-features",
-  "version": "1.19.0",
+  "version": "1.20.1",
   "description": "Vue components & composables for shared hub features",
   "repository": {
     "type": "git",
@@ -36,7 +36,7 @@
     "lodash-es": "4.17.23",
     "ofetch": "^1.4.1",
     "typescript": "^5.8.3",
-    "@knime/components": "1.45.5",
+    "@knime/components": "1.45.6",
     "@knime/styles": "1.15.0",
     "@knime/utils": "1.10.0"
   },

package/src/embeddingSDK/types.ts

@@ -65,8 +65,7 @@ type HostNavigationRequestEvent = {
 type AnalyticsEvent = {
   kind: "analytics";
   payload: {
-    category: string;
-    name: string;
+    id: string;
     data: unknown;
   };
 };

package/src/useFileUpload/useFileUpload.ts

@@ -34,6 +34,7 @@ type UseFileUploadOptions = {
     uploadId: string;
     filePartIds: Record<number, string>;
     parentId: string;
+    name: string;
   }) => void;
   onFileUploadFailed?: (payload: {
     uploadId: string;
@@ -193,8 +194,7 @@ export const useFileUpload = (options: UseFileUploadOptions = {}) => {
 
   // contains upload ids for files that have a processing step which was not finished yet
   const unprocessedUploads = reactive<Set<string>>(new Set());
-  const isFileWithProcessing = (file: File) =>
-    knimeFileFormats.KNWF.matches(file);
+  const isKNWFFile = (file: File) => knimeFileFormats.KNWF.matches(file);
 
   let useUploadManagerResult: ReturnType<typeof useUploadManager> | null = null;
 
@@ -219,11 +219,16 @@ export const useFileUpload = (options: UseFileUploadOptions = {}) => {
   useUploadManagerResult = useUploadManager({
     resolveFilePartUploadURL,
 
-    onFileUploadComplete: ({ uploadId, filePartIds, parentId }) => {
+    onFileUploadComplete: ({ uploadId, filePartIds, parentId, name }) => {
       promise
         .retryPromise({ fn: () => completeUpload(uploadId, filePartIds) })
         .then(() => {
-          options.onFileUploadComplete?.({ uploadId, filePartIds, parentId });
+          options.onFileUploadComplete?.({
+            uploadId,
+            filePartIds,
+            parentId,
+            name,
+          });
         })
         .catch((error) => {
           consola.error("Error attempting to complete upload", { error });
@@ -274,7 +279,12 @@ export const useFileUpload = (options: UseFileUploadOptions = {}) => {
     isPreparingUpload: computed(() => prepareQueueSize.value > 0),
     totalFilesBeingPrepared: computed(() => prepareQueueSize.value),
 
-    start: async (parentId: string, files: File[]) => {
+    start: async (
+      parentId: string,
+      files: File[],
+      options: { isFileWithProcessing?: typeof isKNWFFile } = {},
+    ) => {
+      const { isFileWithProcessing = isKNWFFile } = options;
       const enqueableFiles = getEnqueueableFiles(files);
       const uploadSizeLimitBytes = getUploadSizeLimitBytes();
       const oversizedFiles = enqueableFiles.filter(
@@ -294,7 +304,7 @@ export const useFileUpload = (options: UseFileUploadOptions = {}) => {
 
       try {
         if (enqueableFiles.length === 0) {
-          return;
+          return [];
         }
 
         prepareQueueSize.value += enqueableFiles.length;
@@ -313,9 +323,13 @@ export const useFileUpload = (options: UseFileUploadOptions = {}) => {
           }
         });
 
+        const uploadIds = uploadPayload.map((upload) => upload.uploadId);
+
         // accept floating promise, errors are handled inside the function
         // eslint-disable-next-line @typescript-eslint/no-floating-promises
         useUploadManagerResult.start(parentId, uploadPayload);
+
+        return uploadIds;
       } catch (error) {
         throw rfcErrors.tryParse(error) ?? error;
       } finally {