@knime/hub-features 1.15.3 → 1.15.5

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @knime/hub-features
 
+## 1.15.5
+
+### Patch Changes
+
+- 301cfc2: Fix inconsistent error toast text when stack trace is provided but copying to clipboard is not allowed
+
+## 1.15.4
+
+### Patch Changes
+
+- e44c108: fix rfcErrors parser and return undefined on error
+- Updated dependencies [e44c108]
+  - @knime/components@1.41.8
+
 ## 1.15.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@knime/hub-features",
-  "version": "1.15.3",
+  "version": "1.15.5",
   "description": "Vue components & composables for shared hub features",
   "repository": {
     "type": "git",
@@ -36,9 +36,9 @@
     "lodash-es": "4.17.21",
     "ofetch": "^1.4.1",
     "typescript": "^5.8.3",
-    "@knime/components": "1.41.7",
     "@knime/styles": "1.14.3",
-    "@knime/utils": "1.7.1"
+    "@knime/utils": "1.7.1",
+    "@knime/components": "1.41.8"
   },
   "peerDependencies": {
     "consola": "3.x",

package/src/components/versions/composables/useVersionsApi.ts

@@ -1,4 +1,4 @@
-import { FetchError, type FetchOptions } from "ofetch";
+import { type FetchOptions } from "ofetch";
 
 import { type HubAvatarData, rfcErrors } from "@knime/hub-features";
 import { VERSION_DEFAULT_LIMIT } from "@knime/hub-features/versions";
@@ -37,11 +37,7 @@ export const useVersionsApi = ({
 
       return await $ofetch(path, { ...defaults, ...fetchOptions });
     } catch (error) {
-      if (error instanceof FetchError) {
-        throw rfcErrors.tryParse(error);
-      }
-
-      throw error;
+      throw rfcErrors.tryParse(error) ?? error;
     }
   };
 

package/src/rfcErrors/RFCErrorToastTemplate.vue

@@ -102,7 +102,12 @@ const onShowDetailsClicked = () => {
     <div class="title">
       {{ props.title }}
     </div>
-    <button v-if="!showDetails" class="show-more" @click="onShowDetailsClicked">
+    <button
+      v-if="!showDetails"
+      data-test-id="show-details"
+      class="show-more"
+      @click="onShowDetailsClicked"
+    >
       Show details
     </button>
     <div v-if="showDetails" class="additional-info">
@@ -124,11 +129,11 @@ const onShowDetailsClicked = () => {
       <div v-if="date"><strong>Date: </strong>{{ formattedDate }}</div>
       <div v-if="requestId"><strong>Request id: </strong>{{ requestId }}</div>
       <div v-if="errorId"><strong>Error id: </strong>{{ errorId }}</div>
-      <div v-if="stacktrace">
+      <div v-if="stacktrace && canCopyToClipboard">
         <strong>Stacktrace: </strong>Part of clipboard text
       </div>
       <div v-if="canCopyToClipboard" class="copy-button-wrapper">
-        <Button @click="copyToClipboard">
+        <Button data-test-id="copy-to-clipboard" @click="copyToClipboard">
           <template v-if="copied">
             <CheckIcon class="copy-icon" />Error was copied
           </template>

package/src/rfcErrors/index.ts

@@ -35,21 +35,28 @@ const toToast = ({
 };
 
 /**
- * Try to parse an ofetch's `FetchError` to an `RFCError`. When parsing is not possible
- * it returns the same `FetchError` given unchanged.
+ * Parse an ofetch's `FetchError` to an `RFCError`.
+ * When parsing is not possible it returns undefined.
  */
-const tryParse = (error: FetchError): RFCError | FetchError => {
+const tryParse = (error: unknown): RFCError | undefined => {
+  if (!(error instanceof FetchError)) {
+    return undefined;
+  }
+
   if (!error.response) {
-    return error;
+    return undefined;
   }
 
   const responseDate = error.response.headers.get("date")
     ? new Date(error.response.headers.get("date")!)
     : undefined;
 
+  const title =
+    typeof error.data === "string" ? error.data : error.data?.title ?? "";
+
   const rfcErrorData: RFCErrorData = {
-    title: error.data.title as string,
-    details: error.data.details as string[] | undefined,
+    title: title as string,
+    details: error.data?.details as string[] | undefined,
     status: error.statusCode as number,
     date: responseDate,
     requestId: error.response.headers.get("x-request-id") ?? undefined,

package/src/useDownloadArtifact/useDownloadArtifact.ts

@@ -284,10 +284,7 @@ export const useDownloadArtifact = (
     } catch (error: unknown) {
       // here only errors thrown by the initial requests are caught;
       // errors occurring while polling will be handled in pollDownloadItem
-      if (error instanceof FetchError) {
-        throw rfcErrors.tryParse(error);
-      }
-      throw error;
+      throw rfcErrors.tryParse(error) ?? error;
     }
   };
 

package/src/useFileUpload/useFileUpload.ts

@@ -287,11 +287,7 @@ export const useFileUpload = (options: UseFileUploadOptions = {}) => {
 
         useUploadManagerResult.start(parentId, uploadPayload);
       } catch (error) {
-        if (error instanceof FetchError) {
-          throw rfcErrors.tryParse(error);
-        }
-
-        throw error;
+        throw rfcErrors.tryParse(error) ?? error;
       } finally {
         // errors can only be thrown in the prepareUpload call, useUploadManagerResult.start does its own error handling
         prepareQueueSize.value -= enqueableFiles.length;