@kmugalkhod/lightcode 0.6.0 → 0.7.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kmugalkhod/lightcode",
-  "version": "0.6.0",
+  "version": "0.7.0",
   "description": "Lightcode — a personal AI coding agent with a terminal UI and local session storage.",
   "type": "module",
   "license": "MIT",

package/server.js

@@ -147,7 +147,7 @@ var init_src = __esm(() => {
 });
 
 // packages/ai/src/constants.ts
-var MAX_TOOL_TEXT_OUTPUT_CHARS = 12000, DEFAULT_TOOL_TEXT_OUTPUT_CHARS = 6000, MAX_TOOL_LIST_ENTRIES = 200, MAX_TOOL_SEARCH_RESULTS = 200, ANTHROPIC_TOOL_OPTIONAL_PARAMETER_BUDGET = 24;
+var MAX_TOOL_TEXT_OUTPUT_CHARS = 12000, DEFAULT_TOOL_TEXT_OUTPUT_CHARS = 6000, MAX_TOOL_LIST_ENTRIES = 200, MAX_TOOL_SEARCH_RESULTS = 200, ANTHROPIC_TOOL_OPTIONAL_PARAMETER_BUDGET = 24, TODO_CONTENT_MAX_CHARS = 200, TODO_ACTIVE_FORM_MAX_CHARS = 80, PROGRESS_NOTE_PRUNE_MIN_CHARS = 200;
 
 // packages/ai/src/coding-agent-modes.ts
 import { z } from "zod";
@@ -1045,20 +1045,22 @@ var init_schema10 = __esm(() => {
   todoPrioritySchema = z14.enum(["low", "medium", "high"]);
   todoItemSchema = z14.object({
     id: z14.string().min(1).max(120).optional(),
-    content: z14.string().min(1).max(500),
+    content: z14.string().min(1).max(TODO_CONTENT_MAX_CHARS),
     status: todoStatusSchema,
     priority: todoPrioritySchema.optional().default("medium"),
-    notes: z14.string().max(1000).optional()
+    notes: z14.string().max(1000).optional(),
+    activeForm: z14.string().min(1).max(TODO_ACTIVE_FORM_MAX_CHARS).optional()
   });
   todoItemProviderSchema = z14.object({
-    content: z14.string().min(1).max(500),
-    status: todoStatusSchema
+    content: z14.string().min(1).max(TODO_CONTENT_MAX_CHARS),
+    status: todoStatusSchema,
+    activeForm: z14.string().min(1).max(TODO_ACTIVE_FORM_MAX_CHARS).optional().describe(`Short present-tense active label for this task, e.g. "Adding tests" or "Editing schema". Set it primarily for the in_progress item so the UI can show what's actively happening; the UI falls back to content when omitted.`)
   });
   todoWriteInputSchema = z14.object({
     todos: z14.array(todoItemSchema).max(50)
   });
   todoWriteProviderInputSchema = z14.object({
-    todos: z14.array(todoItemProviderSchema)
+    todos: z14.array(todoItemProviderSchema).max(20)
   });
   todoWriteOutputSchema = z14.object({
     sessionId: z14.string(),
@@ -1070,7 +1072,8 @@ var init_schema10 = __esm(() => {
       inProgress: z14.number().int().nonnegative(),
       completed: z14.number().int().nonnegative(),
       canceled: z14.number().int().nonnegative()
-    })
+    }),
+    warnings: z14.array(z14.string()).optional()
   });
 });
 
@@ -1904,14 +1907,139 @@ ${environmentContext.trim()}` : "");
 var cwdPromptPlaceholder = "{cwd}", defaultCodingAgentSystemPrompt, toolCallingDisciplineAddendum;
 var init_coding_agent_prompt = __esm(() => {
   init_coding_agent_modes();
-  defaultCodingAgentSystemPrompt = "You are a coding agent working inside the user's project at this working directory: {cwd}. " + 'You can already see the project \u2014 proactively read it. When the user asks you to review, explain, or work on "my code"/"this", inspect the working directory yourself with list_files, glob_search, grep, and read_file; NEVER ask the user to paste or share code that lives in this directory \u2014 open it. ' + "Use tools for filesystem and codebase tasks instead of guessing, and only interact with files under the working directory. " + "Prefer dedicated tools \u2014 glob_search for paths, grep for text search, structured git tools for repository inspection \u2014 and bash only when those are not enough. " + `Use todo_write to keep multi-step work visible and current, inspect context before risky operations, and emit a brief, natural progress note before major tool actions and after important findings.
+  defaultCodingAgentSystemPrompt = "You are a coding agent working inside the user's project at this working directory: {cwd}. " + 'You can already see the project \u2014 proactively read it. When the user asks you to review, explain, or work on "my code"/"this", inspect the working directory yourself with list_files, glob_search, grep, and read_file; NEVER ask the user to paste or share code that lives in this directory \u2014 open it. ' + "Use tools for filesystem and codebase tasks instead of guessing, and only interact with files under the working directory. " + "Prefer dedicated tools \u2014 glob_search for paths, grep for text search, structured git tools for repository inspection \u2014 and bash only when those are not enough. " + `Inspect context before risky operations. Progress notes: before a major tool action you may emit ONE short note (one sentence, ~15 words) saying what you are about to do. After a tool returns, mention a finding only if it changes your plan, and state it as fact grounded in what the tool actually returned \u2014 cite the file/line/symbol. NEVER claim you found, changed, or fixed something before a tool result confirms it. Skip notes for routine reads, and do not restate the todo list in prose.
+
+` + `Task list discipline \u2014 use the todo_write tool to keep a visible, evolving checklist:
+` + `- Create the list FIRST. For any task with roughly three or more distinct steps, or any multi-file or multi-stage work, call todo_write as your very first action \u2014 before reading or editing \u2014 with every step listed and all of them set to pending.
+` + `- Keep exactly ONE item in_progress at a time. Mark an item in_progress immediately before you start it; never have two items in_progress at once.
+` + `- Mark an item completed only after a tool result confirms it is actually done (test passed, file written, build clean) \u2014 not on intent. Do this the MOMENT it is confirmed; do not batch completions or wait until the end of the turn.
+` + `- Completions are monotonic: once a task is completed, do not silently move it back to pending or in_progress. Reopen it only if it genuinely regressed.
+` + `- Every todo_write call is a FULL REWRITE of the list: always send every task with its current status (re-state the completed and pending ones too \u2014 never send only the changed item). Keep each item terse (a short label, not a paragraph).
+` + `- Skip the list for trivial, single-step, or purely conversational requests \u2014 a checklist there is just noise.
 
 ` + `You are an agent \u2014 keep working until the request is fully resolved. Never stop with a partial answer; if you say you will do something, do it in the same turn by calling a tool. Do not finish while any todo is pending or in_progress \u2014 end your turn only when the task is complete or you are blocked on input that only the user can provide.
 
+` + `When the task is complete, end with a short summary (a few lines) grounded in the todos you actually completed and the real file diffs \u2014 name the files you edited, do not list steps you did not verify, and do not repeat the todo card verbatim. If anything is incomplete or you are blocked, say so plainly.
+
 ` + "Long-running processes (dev servers, watchers): never run them as plain foreground bash \u2014 the bash tool enforces a timeout and will kill them. Start them detached with output redirected to a log " + '(Windows: start /B cmd /c "npm run dev > dev.log 2>&1"; Unix: nohup npm run dev > dev.log 2>&1 &), then read the log to confirm startup and the actual port (do not assume the default). ' + "Never kill processes or free ports you did not open yourself.";
   toolCallingDisciplineAddendum = "Invoke tools only through the function-calling interface. " + "Never write tool calls as XML or plain text such as <tool_call>, <function_call>, <invoke>, or bare JSON in your message. " + "Tool arguments must be valid JSON matching the tool's schema. " + "Call one tool at a time and wait for its result before deciding the next step.";
 });
 
+// packages/ai/src/common/coerce-tool-input.ts
+function coercePrimitive(current, expected) {
+  if (current === undefined || current === null) {
+    return NO_CHANGE;
+  }
+  switch (expected) {
+    case "number": {
+      if (typeof current === "string") {
+        const trimmed = current.trim();
+        if (trimmed !== "" && Number.isFinite(Number(trimmed))) {
+          return Number(trimmed);
+        }
+      }
+      return NO_CHANGE;
+    }
+    case "boolean": {
+      if (typeof current === "string") {
+        const lowered = current.trim().toLowerCase();
+        if (lowered === "true" || lowered === "1" || lowered === "yes") {
+          return true;
+        }
+        if (lowered === "false" || lowered === "0" || lowered === "no") {
+          return false;
+        }
+      }
+      if (current === 1)
+        return true;
+      if (current === 0)
+        return false;
+      return NO_CHANGE;
+    }
+    case "string": {
+      if (typeof current === "number" || typeof current === "boolean") {
+        return String(current);
+      }
+      return NO_CHANGE;
+    }
+    case "object":
+    case "array": {
+      if (typeof current === "string") {
+        try {
+          const parsed = JSON.parse(current);
+          const isArray = Array.isArray(parsed);
+          const matches = expected === "array" ? isArray : parsed !== null && typeof parsed === "object" && !isArray;
+          if (matches) {
+            return parsed;
+          }
+        } catch {}
+      }
+      return NO_CHANGE;
+    }
+    default:
+      return NO_CHANGE;
+  }
+}
+function coerceAtPath(root, path3, expected) {
+  if (path3.length === 0 || root === null || typeof root !== "object") {
+    return false;
+  }
+  let parent = root;
+  for (let index = 0;index < path3.length - 1; index += 1) {
+    const next = parent[path3[index]];
+    if (next === null || typeof next !== "object") {
+      return false;
+    }
+    parent = next;
+  }
+  const key = path3[path3.length - 1];
+  const coerced = coercePrimitive(parent[key], expected);
+  if (coerced === NO_CHANGE) {
+    return false;
+  }
+  parent[key] = coerced;
+  return true;
+}
+function coerceToolInputToSchema(value, schema) {
+  if (value === null || typeof value !== "object") {
+    return null;
+  }
+  let current;
+  try {
+    current = structuredClone(value);
+  } catch {
+    current = value;
+  }
+  for (let pass = 0;pass < MAX_PASSES; pass += 1) {
+    const result = schema.safeParse(current);
+    if (result.success) {
+      return result.data;
+    }
+    let changed = false;
+    for (const issue of result.error.issues) {
+      if (issue.code !== "invalid_type") {
+        continue;
+      }
+      const expected = issue.expected;
+      if (typeof expected !== "string") {
+        continue;
+      }
+      if (coerceAtPath(current, issue.path, expected)) {
+        changed = true;
+      }
+    }
+    if (!changed) {
+      break;
+    }
+  }
+  const final = schema.safeParse(current);
+  return final.success ? final.data : null;
+}
+var NO_CHANGE, MAX_PASSES = 4;
+var init_coerce_tool_input = __esm(() => {
+  NO_CHANGE = Symbol("no-change");
+});
+
 // packages/ai/src/providers/tool-call-json-repair.ts
 import { parsePartialJson } from "ai";
 async function repairToolJson(raw) {
@@ -2106,15 +2234,19 @@ async function repairCodingAgentToolCall({
     if (!repairedInput || typeof repairedInput !== "object") {
       return null;
     }
+    const schema = codingToolProviderInputSchemas[toolCall.toolName];
+    const coerced = schema ? coerceToolInputToSchema(repairedInput, schema) : null;
     return {
       ...toolCall,
-      input: JSON.stringify(repairedInput)
+      input: JSON.stringify(coerced ?? repairedInput)
     };
   }
   return null;
 }
 var toolNameAliases;
 var init_coding_agent_tool_repair = __esm(() => {
+  init_agent_tools();
+  init_coerce_tool_input();
   init_tool_call_json_repair();
   toolNameAliases = {
     read: "read_file",
@@ -2203,19 +2335,6 @@ function getLastUserText(messages, prompt) {
   }
   return collectTextFromUnknown(prompt).trim();
 }
-function pushUniqueTool(tools, toolName) {
-  if (!tools.includes(toolName)) {
-    tools.push(toolName);
-  }
-}
-function includesAny(text, tokens) {
-  return tokens.some((token) => {
-    if (token.includes("://") || token.includes(" ")) {
-      return text.includes(token);
-    }
-    return new RegExp(`(^|[^a-z0-9])${token.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}([^a-z0-9]|$)`).test(text);
-  });
-}
 function selectCodingAgentIntentTools({
   mode,
   prompt,
@@ -2226,75 +2345,7 @@ function selectCodingAgentIntentTools({
   if (!normalizedText || casualPromptPattern.test(normalizedText)) {
     return [];
   }
-  const situational = [];
-  const hasGitIntent = includesAny(normalizedText, [
-    "git",
-    "diff",
-    "status",
-    "commit",
-    "log",
-    "show",
-    "revision",
-    "changes"
-  ]);
-  if (hasGitIntent) {
-    if (includesAny(normalizedText, ["status", "state", "dirty", "working tree"]) || !includesAny(normalizedText, ["diff", "log", "show", "history", "commit"])) {
-      pushUniqueTool(situational, "git_status");
-    }
-    if (includesAny(normalizedText, ["diff", "changes", "patch"])) {
-      pushUniqueTool(situational, "git_diff");
-    }
-    if (includesAny(normalizedText, ["log", "history", "commits"])) {
-      pushUniqueTool(situational, "git_log");
-    }
-    if (includesAny(normalizedText, ["show", "revision", "commit"])) {
-      pushUniqueTool(situational, "git_show");
-    }
-  }
-  if (mode === "build" && includesAny(normalizedText, ["todo", "tasks", "checklist", "steps", "epic", "ticket"])) {
-    pushUniqueTool(situational, "todo_write");
-  }
-  if (includesAny(normalizedText, ["tool_search", "tool search", "find tool", "available tool"])) {
-    pushUniqueTool(situational, "tool_search");
-  }
-  if (includesAny(normalizedText, ["skill", "skills", "load skill"])) {
-    pushUniqueTool(situational, "skill");
-  }
-  if (includesAny(normalizedText, ["mcp", "resource", "resources", "mcp tool", "mcp server"])) {
-    pushUniqueTool(situational, "list_mcp_resources");
-    if (includesAny(normalizedText, ["read", "resource", "resources"])) {
-      pushUniqueTool(situational, "read_mcp_resource");
-    }
-    if (mode === "build" && includesAny(normalizedText, ["call", "execute", "run"])) {
-      pushUniqueTool(situational, "call_mcp_tool");
-    }
-  }
-  if (includesAny(normalizedText, [
-    "http://",
-    "https://",
-    "url",
-    "fetch",
-    "website",
-    "web",
-    "online",
-    "search internet",
-    "latest"
-  ])) {
-    pushUniqueTool(situational, "web_fetch");
-    pushUniqueTool(situational, "web_search");
-  }
-  if (mode === "plan" && includesAny(normalizedText, ["question", "ask", "clarify"])) {
-    pushUniqueTool(situational, "request_user_input");
-  }
-  const ordered = [...baseReadTools, ...situational];
-  if (mode === "build") {
-    ordered.push("write_file", "edit_file", "bash");
-  }
-  const selected = [];
-  for (const toolName of ordered) {
-    pushUniqueTool(selected, toolName);
-  }
-  return selected.slice(0, maxProviderActiveTools);
+  return [...getCodingAgentModeDefinition(mode).activeTools];
 }
 function limitProviderActiveTools(tools, maxTools = maxProviderActiveTools) {
   if (tools.length <= maxTools) {
@@ -2303,15 +2354,10 @@ function limitProviderActiveTools(tools, maxTools = maxProviderActiveTools) {
   const toolSet = new Set(tools);
   return providerToolPriority.filter((toolName) => toolSet.has(toolName)).slice(0, maxTools);
 }
-var casualPromptPattern, baseReadTools, maxProviderActiveTools = 7, providerToolPriority;
+var casualPromptPattern, maxProviderActiveTools = 24, providerToolPriority;
 var init_intent_tool_selection = __esm(() => {
+  init_coding_agent_modes();
   casualPromptPattern = /^(hi|hello|hey|how are you|how r you|what'?s up|whats up|sup|thanks|thank you|ok|okay|yes|no|nice|cool|great)[\s?!.,]*$/i;
-  baseReadTools = [
-    "list_files",
-    "glob_search",
-    "read_file",
-    "grep"
-  ];
   providerToolPriority = [
     "list_files",
     "glob_search",
@@ -2984,6 +3030,16 @@ function getPartState(part) {
   const state = isRecord3(part) ? Reflect.get(part, "state") : undefined;
   return typeof state === "string" ? state : null;
 }
+function getPlainTextPartContent(part) {
+  if (!isRecord3(part) || Reflect.get(part, "type") !== "text") {
+    return null;
+  }
+  const text = Reflect.get(part, "text");
+  return typeof text === "string" ? text : null;
+}
+function messageHasToolPart(message) {
+  return message.parts.some((part) => getToolNameFromPart(part) !== null);
+}
 function computePruneCutoffIndex(messages, preserveRecentMessages, quantizeUserTurns = DEFAULT_PRUNE_QUANTIZE_USER_TURNS) {
   const candidate = messages.length - preserveRecentMessages;
   if (candidate <= 0) {
@@ -3033,15 +3089,29 @@ function pruneToolOutputs(messages, options) {
   });
   let elidedToolOutputs = 0;
   let dedupedFileReads = 0;
+  let elidedProgressNotes = 0;
   let savedChars = 0;
   const prunedMessages = messages.map((message, messageIndex) => {
     if (messageIndex >= cutoff) {
       return message;
     }
+    const noteCandidate = message.role === "assistant" && messageHasToolPart(message);
     let changed = false;
     const parts = message.parts.map((part, partIndex) => {
       const toolName = getToolNameFromPart(part);
       if (!toolName || getPartState(part) !== "output-available") {
+        if (noteCandidate && toolName === null) {
+          const text = getPlainTextPartContent(part);
+          if (text !== null && text !== PROGRESS_NOTE_ELISION_STUB && text.length > PROGRESS_NOTE_PRUNE_MIN_CHARS) {
+            elidedProgressNotes += 1;
+            savedChars += Math.max(0, text.length - PROGRESS_NOTE_ELISION_STUB.length);
+            changed = true;
+            return {
+              ...part,
+              text: PROGRESS_NOTE_ELISION_STUB
+            };
+          }
+        }
         return part;
       }
       const output = isRecord3(part) ? Reflect.get(part, "output") : undefined;
@@ -3058,7 +3128,7 @@ function pruneToolOutputs(messages, options) {
       }
       const stub = {
         lightcodeElided: true,
-        note: isStaleRead ? "Earlier read of this file elided; a later read in this conversation has the current content. Re-run read_file if needed." : "Large tool output elided to preserve context budget. Re-run the tool if this output is needed again.",
+        note: isStaleRead ? "Earlier read of this file elided; its current content is already shown later in this conversation \u2014 do not read it again." : "Large tool output elided to preserve context budget. Re-run the tool only if this output is needed again.",
         originalChars: serializedOutput.length
       };
       if (isStaleRead) {
@@ -3076,10 +3146,11 @@ function pruneToolOutputs(messages, options) {
     messages: prunedMessages,
     elidedToolOutputs,
     dedupedFileReads,
+    elidedProgressNotes,
     savedChars
   };
 }
-var DEFAULT_PRUNE_MIN_OUTPUT_CHARS = 2000, DEFAULT_PRUNE_QUANTIZE_USER_TURNS = 4;
+var DEFAULT_PRUNE_MIN_OUTPUT_CHARS = 2000, PROGRESS_NOTE_ELISION_STUB = "[progress note elided]", DEFAULT_PRUNE_QUANTIZE_USER_TURNS = 4;
 var init_tier1_prune = __esm(() => {
   init_estimate();
   init_message_parts();
@@ -6104,6 +6175,22 @@ function mergeFinishedMessagesIntoFullHistory({
   return [...fullMessages, ...appendedMessages];
 }
 
+// packages/ai/src/tool-call-repeat-guard.ts
+var guardedTools, lastCallByTurn;
+var init_tool_call_repeat_guard = __esm(() => {
+  guardedTools = new Set([
+    "read_file",
+    "list_files",
+    "glob_search",
+    "grep",
+    "git_status",
+    "git_diff",
+    "git_log",
+    "git_show"
+  ]);
+  lastCallByTurn = new Map;
+});
+
 // packages/ai/src/common/resolve-within-workspace.ts
 import path8 from "path";
 import {
@@ -6483,6 +6570,8 @@ var init_runtime16 = __esm(() => {
 // packages/ai/src/runtime-registry.ts
 var init_runtime_registry = __esm(() => {
   init_agent_tools();
+  init_coerce_tool_input();
+  init_tool_call_repeat_guard();
   init_runtime4();
   init_runtime6();
   init_runtime7();
@@ -7418,6 +7507,26 @@ var init_session_auto_title = __esm(() => {
 import { readFile as readFile2, readdir } from "fs/promises";
 import { platform as platform3 } from "os";
 import path11 from "path";
+function formatAvailableSkills(skills) {
+  if (skills.length === 0) {
+    return "";
+  }
+  const shown = skills.slice(0, maxListedSkills);
+  const lines = shown.map((skill) => `- ${skill.name}${skill.description ? `: ${skill.description}` : ""}`);
+  const more = skills.length > shown.length ? `
+\u2026 and ${skills.length - shown.length} more` : "";
+  return `Available skills (load by name with the skill tool):
+${lines.join(`
+`)}${more}`;
+}
+function buildAvailableSkills(cwd) {
+  try {
+    return formatAvailableSkills(listSkills({ cwd }));
+  } catch (error) {
+    logger7.warn("workspace_skills_failed", { cwd, error: getErrorMessage(error) });
+    return "";
+  }
+}
 function describePlatform() {
   const map = {
     darwin: "macOS",
@@ -7493,6 +7602,7 @@ async function buildWorkspaceContext({
     buildGitSummary(cwd),
     buildProjectDocs(cwd)
   ]);
+  const skills = buildAvailableSkills(cwd);
   const today = new Date().toISOString().slice(0, 10);
   const parts = [
     "<environment>",
@@ -7508,6 +7618,8 @@ async function buildWorkspaceContext({
     docs ? `
 Project instructions:
 ${docs}` : "",
+    skills ? `
+${skills}` : "",
     "</environment>"
   ];
   const block = parts.join(`
@@ -7516,7 +7628,7 @@ ${docs}` : "",
 \u2026 (environment truncated)
 </environment>` : block;
 }
-var logger7, projectDocNames, maxListedEntries = 40, maxDocChars = 1500, maxBlockChars = 8000;
+var logger7, projectDocNames, maxListedEntries = 40, maxListedSkills = 20, maxDocChars = 1500, maxBlockChars = 8000;
 var init_workspace_context = __esm(() => {
   init_runtime17();
   init_src();
@@ -7555,7 +7667,8 @@ function messagesHaveToolActivity(messages) {
 function shouldUseFastChatPath({
   messages,
   mode,
-  allowedTools
+  allowedTools,
+  availableSkillNames = []
 }) {
   if (allowedTools && allowedTools.length > 0) {
     return false;
@@ -7566,7 +7679,8 @@ function shouldUseFastChatPath({
   return selectCodingAgentIntentTools({
     mode,
     prompt: "",
-    messages
+    messages,
+    availableSkillNames
   }).length === 0;
 }
 async function countPendingChatInteractions(sessionId) {
@@ -7884,11 +7998,13 @@ async function streamSessionChat(c, sessionIdentifier, messagesPayload, cwd, mod
     };
   };
   const environmentContext = await buildWorkspaceContext({ cwd });
+  const availableSkillNames = listSkills({ cwd }).map((skill) => skill.name);
   try {
     if (shouldUseFastChatPath({
       messages: providerMessages,
       mode,
-      allowedTools
+      allowedTools,
+      availableSkillNames
     })) {
       logger8.info("chat_fast_path", {
         sessionId,