@kmiyh/pi-skills-menu 1.0.5 → 1.1.0

package/README.md

@@ -59,10 +59,22 @@ Press:
 
 Press:
 
-- `Enter` — select a skill and insert it into the editor
+- `Enter` — select an enabled skill and insert it into the editor
 
 After that, the skill is inserted into the editor so it will be used by Pi when the message is sent.
 
+### Enable or disable a skill
+
+Press:
+
+- `x` — toggle the selected skill between enabled and disabled
+
+This also works for skills that come from installed libraries/packages.
+
+Disabled skills stay visible in the list and are marked with:
+
+- `[disabled]`
+
 ### Create a new skill
 
 The list also contains a dedicated entry for creating a new skill.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kmiyh/pi-skills-menu",
-  "version": "1.0.5",
+  "version": "1.1.0",
   "description": "Pi extension that moves skills into a dedicated /skills menu with browsing, preview, editing, and AI-assisted creation.",
   "type": "module",
   "keywords": [

package/src/create-skill.ts

@@ -1014,6 +1014,7 @@ export async function createSkillFromAnswers(
 		origin: "top-level",
 		source: "auto",
 		baseDir: targetDir,
+		enabled: true,
 	};
 }
 

package/src/index.ts

@@ -5,12 +5,14 @@ import { detectExtensionInstallScope } from "./extension-scope.js";
 import { expandSkillMarkers, hasSkillMarker, insertSkillMarker, removeIncompleteSkillMarkerLines } from "./markers.js";
 import { loadSkillRegistry } from "./skill-registry.js";
 import { ensureSkillCommandsHidden } from "./settings-toggle.js";
+import { setSkillEnabled } from "./skill-enabled-toggle.js";
 import type { ExtensionInstallScope, SkillRegistry } from "./types.js";
 import { showSkillPreview } from "./ui/skill-preview.js";
 import { showSkillsSelector } from "./ui/skills-selector.js";
 
 const EMPTY_REGISTRY: SkillRegistry = {
 	skills: [],
+	allSkills: [],
 	byName: new Map(),
 };
 
@@ -131,12 +133,29 @@ export default function skillsMenuExtension(pi: ExtensionAPI) {
 						continue;
 					}
 					await refreshRegistry(ctx.cwd);
-					const createdSkillIndex = registry.skills.findIndex((skill) => skill.path === createdSkill.path);
+					const createdSkillIndex = registry.allSkills.findIndex((skill) => skill.path === createdSkill.path);
 					selectorIndex = createdSkillIndex >= 0 ? createdSkillIndex + 1 : 0;
 					selectorQuery = "";
 					continue;
 				}
 
+				if (selection.type === "toggle") {
+					try {
+						await setSkillEnabled(ctx.cwd, selection.skill, !selection.skill.enabled);
+						await refreshRegistry(ctx.cwd);
+						ctx.ui.notify(
+							selection.skill.enabled
+								? `Disabled ${selection.skill.name}. Run /reload to fully apply the change.`
+								: `Enabled ${selection.skill.name}. Run /reload to fully apply the change.`,
+							"info",
+						);
+					} catch (error) {
+						console.error("skills-menu: failed to toggle skill", error);
+						ctx.ui.notify(error instanceof Error ? error.message : "Failed to update skill visibility", "error");
+					}
+					continue;
+				}
+
 				if (selection.type === "preview") {
 					await showSkillPreview(ctx, selection.skill);
 					continue;

package/src/skill-enabled-toggle.ts

@@ -0,0 +1,69 @@
+import { dirname, join, relative } from "node:path";
+import { getAgentDir, SettingsManager, type PackageSource } from "@mariozechner/pi-coding-agent";
+import type { SkillEntry } from "./types.js";
+
+function updatePatterns(current: string[], pattern: string, enabled: boolean): string[] {
+	const updated = current.filter((entry) => {
+		const stripped = entry.startsWith("!") || entry.startsWith("+") || entry.startsWith("-") ? entry.slice(1) : entry;
+		return stripped !== pattern;
+	});
+	updated.push(`${enabled ? "+" : "-"}${pattern}`);
+	return updated;
+}
+
+function getTopLevelPattern(skill: SkillEntry, cwd: string): string {
+	const baseDir = skill.scope === "project" ? join(cwd, ".pi") : getAgentDir();
+	return relative(baseDir, skill.path);
+}
+
+function getPackagePattern(skill: SkillEntry): string {
+	const baseDir = skill.baseDir ?? dirname(skill.path);
+	return relative(baseDir, skill.path);
+}
+
+function hasPackageFilters(pkg: Exclude<PackageSource, string>): boolean {
+	return pkg.extensions !== undefined || pkg.skills !== undefined || pkg.prompts !== undefined || pkg.themes !== undefined;
+}
+
+export async function setSkillEnabled(cwd: string, skill: SkillEntry, enabled: boolean): Promise<void> {
+	if (skill.scope === "temporary") {
+		throw new Error("Temporary skills cannot be toggled.");
+	}
+
+	const settingsManager = SettingsManager.create(cwd, getAgentDir());
+
+	if (skill.origin === "top-level") {
+		const settings = skill.scope === "project" ? settingsManager.getProjectSettings() : settingsManager.getGlobalSettings();
+		const current = [...(settings.skills ?? [])];
+		const updated = updatePatterns(current, getTopLevelPattern(skill, cwd), enabled);
+
+		if (skill.scope === "project") {
+			settingsManager.setProjectSkillPaths(updated);
+		} else {
+			settingsManager.setSkillPaths(updated);
+		}
+		await settingsManager.flush();
+		return;
+	}
+
+	const settings = skill.scope === "project" ? settingsManager.getProjectSettings() : settingsManager.getGlobalSettings();
+	const packages = [...(settings.packages ?? [])];
+	const packageIndex = packages.findIndex((pkg) => (typeof pkg === "string" ? pkg : pkg.source) === skill.source);
+	if (packageIndex === -1) {
+		throw new Error("Could not find the package settings entry for this skill.");
+	}
+
+	const packageEntry = packages[packageIndex];
+	const packageConfig = typeof packageEntry === "string" ? { source: packageEntry } : { ...packageEntry };
+	const current = [...(packageConfig.skills ?? [])];
+	const updated = updatePatterns(current, getPackagePattern(skill), enabled);
+	packageConfig.skills = updated.length > 0 ? updated : undefined;
+	packages[packageIndex] = hasPackageFilters(packageConfig) ? packageConfig : packageConfig.source;
+
+	if (skill.scope === "project") {
+		settingsManager.setProjectPackages(packages);
+	} else {
+		settingsManager.setPackages(packages);
+	}
+	await settingsManager.flush();
+}

package/src/skill-registry.ts

@@ -3,6 +3,10 @@ import { parseSkillFile } from "./skill-parser.js";
 import type { SkillEntry, SkillRegistry } from "./types.js";
 
 function compareSkills(a: SkillEntry, b: SkillEntry): number {
+	if (a.enabled !== b.enabled) {
+		return a.enabled ? -1 : 1;
+	}
+
 	const scopeRank = (scope: SkillEntry["scope"]) => {
 		switch (scope) {
 			case "project":
@@ -25,8 +29,6 @@ function compareSkills(a: SkillEntry, b: SkillEntry): number {
 }
 
 function toSkillEntry(resource: ResolvedResource): SkillEntry | null {
-	if (!resource.enabled) return null;
-
 	const parsed = parseSkillFile(resource.path);
 	if (!parsed) return null;
 
@@ -40,9 +42,21 @@ function toSkillEntry(resource: ResolvedResource): SkillEntry | null {
 		origin: resource.metadata.origin,
 		source: resource.metadata.source,
 		baseDir: resource.metadata.baseDir,
+		enabled: resource.enabled,
 	};
 }
 
+function dedupeByPath(skills: SkillEntry[]): SkillEntry[] {
+	const seen = new Set<string>();
+	const deduped: SkillEntry[] = [];
+	for (const skill of skills) {
+		if (seen.has(skill.path)) continue;
+		seen.add(skill.path);
+		deduped.push(skill);
+	}
+	return deduped;
+}
+
 export async function loadSkillRegistry(cwd: string): Promise<SkillRegistry> {
 	const settingsManager = SettingsManager.create(cwd, getAgentDir());
 	const packageManager = new DefaultPackageManager({
@@ -52,10 +66,10 @@ export async function loadSkillRegistry(cwd: string): Promise<SkillRegistry> {
 	});
 	const resolved = await packageManager.resolve();
 
+	const allSkills = dedupeByPath(resolved.skills.map(toSkillEntry).filter((entry): entry is SkillEntry => entry !== null)).sort(compareSkills);
 	const byName = new Map<string, SkillEntry>();
-	for (const resource of resolved.skills) {
-		const entry = toSkillEntry(resource);
-		if (!entry) continue;
+	for (const entry of allSkills) {
+		if (!entry.enabled) continue;
 		if (!byName.has(entry.name)) {
 			byName.set(entry.name, entry);
 		}
@@ -64,6 +78,7 @@ export async function loadSkillRegistry(cwd: string): Promise<SkillRegistry> {
 	const skills = Array.from(byName.values()).sort(compareSkills);
 	return {
 		skills,
+		allSkills,
 		byName: new Map(skills.map((skill) => [skill.name, skill])),
 	};
 }

package/src/types.ts

@@ -10,9 +10,11 @@ export interface SkillEntry {
 	origin: "package" | "top-level";
 	source: string;
 	baseDir?: string;
+	enabled: boolean;
 }
 
 export interface SkillRegistry {
 	skills: SkillEntry[];
+	allSkills: SkillEntry[];
 	byName: Map<string, SkillEntry>;
 }

package/src/ui/skills-selector.ts

@@ -22,6 +22,7 @@ export type SkillsMenuSelection =
 	| { type: "create"; answers: SkillCreationAnswers; selectedIndex: number; query: string }
 	| { type: "preview"; skill: SkillEntry; selectedIndex: number; query: string }
 	| { type: "delete"; skill: SkillEntry; selectedIndex: number; query: string }
+	| { type: "toggle"; skill: SkillEntry; selectedIndex: number; query: string }
 	| null;
 
 type CreateTextStepId = "name" | "description";
@@ -179,8 +180,8 @@ class SkillsSelectorComponent extends Container implements Focusable {
 	}
 
 	private orderBrowseSkills(skills: SkillEntry[]): SkillEntry[] {
-		const ownSkills = skills.filter((skill) => isDeletableSkill(skill));
-		const otherSkills = skills.filter((skill) => !isDeletableSkill(skill));
+		const ownSkills = skills.filter((skill) => isDeletableSkill(skill)).sort((a, b) => Number(b.enabled) - Number(a.enabled));
+		const otherSkills = skills.filter((skill) => !isDeletableSkill(skill)).sort((a, b) => Number(b.enabled) - Number(a.enabled));
 		return [...ownSkills, ...otherSkills];
 	}
 
@@ -361,10 +362,20 @@ class SkillsSelectorComponent extends Container implements Focusable {
 		this.filteredSkills = this.orderBrowseSkills(this.filterSkills(this.browseQuery));
 		this.selectedIndex = Math.min(this.selectedIndex, Math.max(0, this.getSelectableCount() - 1));
 		const selectedSkill = this.getSelectedSkill();
-		const footer = !this.browseQuery && selectedSkill && isDeletableSkill(selectedSkill)
-			? "type to search • enter insert • tab preview • backspace delete • esc close"
-			: "type to search • enter insert • tab preview • esc close";
-		this.footerText.setText(this.theme.fg("dim", footer));
+		const actions = ["type to search"];
+		if (!selectedSkill) {
+			actions.push("enter create", "esc close");
+		} else {
+			if (selectedSkill.enabled) {
+				actions.push("enter insert");
+			}
+			actions.push("tab preview", "x enable/disable");
+			if (!this.browseQuery && isDeletableSkill(selectedSkill)) {
+				actions.push("backspace delete");
+			}
+			actions.push("esc close");
+		}
+		this.footerText.setText(this.theme.fg("dim", actions.join(" • ")));
 		this.renderBrowseList();
 	}
 
@@ -406,13 +417,14 @@ class SkillsSelectorComponent extends Container implements Focusable {
 				} else {
 					const skill = entry.skill;
 					const prefix = isSelected ? this.theme.fg("accent", "→ ") : "  ";
-					const name = isSelected ? this.theme.fg("accent", skill.name) : skill.name;
+					const name = isSelected ? this.theme.fg("accent", skill.name) : skill.enabled ? skill.name : this.theme.fg("muted", skill.name);
+					const status = skill.enabled ? "" : this.theme.fg("warning", " [disabled]");
 					const scope = this.theme.fg("muted", ` [${getScopeLabel(skill)}]`);
 					const packageLabel = getPackageLabel(skill);
 					const source = packageLabel ? this.theme.fg("muted", ` - [${packageLabel}]`) : "";
 					const descriptionPrefix = packageLabel ? " " : " - ";
 					const description = this.theme.fg("dim", `${descriptionPrefix}${skill.description}`);
-					this.listContainer.addChild(new SingleLineText(`${prefix}${name}${scope}${source}${description}`, descriptionEllipsis));
+					this.listContainer.addChild(new SingleLineText(`${prefix}${name}${status}${scope}${source}${description}`, descriptionEllipsis));
 				}
 			}
 			if (isSelectable) {
@@ -503,7 +515,7 @@ class SkillsSelectorComponent extends Container implements Focusable {
 				return;
 			}
 			const skill = this.getSelectedSkill();
-			if (skill) {
+			if (skill?.enabled) {
 				this.done({ type: "skill", skill, selectedIndex: this.selectedIndex, query: this.browseQuery });
 			}
 			return;
@@ -515,6 +527,13 @@ class SkillsSelectorComponent extends Container implements Focusable {
 			}
 			return;
 		}
+		if (data === "x" || data === "X") {
+			const skill = this.getSelectedSkill();
+			if (skill) {
+				this.done({ type: "toggle", skill, selectedIndex: this.selectedIndex, query: this.browseQuery });
+			}
+			return;
+		}
 		if (matchesKey(data, Key.backspace) && !this.input.getValue()) {
 			const skill = this.getSelectedSkill();
 			if (skill && isDeletableSkill(skill)) {
@@ -593,7 +612,7 @@ export async function showSkillsSelector(
 ): Promise<SkillsMenuSelection> {
 	return await ctx.ui.custom<SkillsMenuSelection>((tui, _theme, _kb, done) => {
 		const component = new SkillsSelectorComponent(
-			registry.skills,
+			registry.allSkills,
 			ctx.ui.theme,
 			done,
 			tui,