@klippa/ngx-enhancy-forms 14.22.6 → 14.22.8

package/fesm2020/klippa-ngx-enhancy-forms.mjs

@@ -668,10 +668,11 @@ class FormElementComponent {
         return this.getErrorToShow() === error && !this.customErrorHandlers.some((e) => e.error === error);
     }
     getScrollableParent(node) {
-        if (node == null) {
-            return null;
+        if (node === window.document.documentElement) {
+            return window.document.documentElement;
         }
-        if (node.scrollHeight > node.clientHeight) {
+        const overflowY = getComputedStyle(node).overflowY;
+        if (node.clientHeight < node.scrollHeight && (overflowY === 'auto' || overflowY === 'scroll')) {
             return node;
         }
         else {
@@ -679,9 +680,17 @@ class FormElementComponent {
         }
     }
     scrollTo() {
-        this.internalComponentRef.nativeElement.scrollIntoView(true);
-        // to give some breathing room, we scroll 100px more to the top
-        this.getScrollableParent(this.internalComponentRef.nativeElement)?.scrollBy(0, -100);
+        const parent = this.getScrollableParent(this.internalComponentRef.nativeElement);
+        const parentTop = parent === window.document.documentElement ? 0 : parent.getBoundingClientRect().top;
+        const elementTop = this.internalComponentRef.nativeElement.getBoundingClientRect().top;
+        const parentScrollTop = parent.scrollTop;
+        const answer = elementTop - parentTop + parentScrollTop;
+        console.log('answer', parentTop, elementTop, parentScrollTop, answer);
+        console.log(parent, this.internalComponentRef.nativeElement);
+        parent.scrollTo({
+            top: answer - 30,
+            behavior: 'smooth'
+        });
     }
     isRequired() {
         if (isValueSet(this.input)) {