@kiva/kv-components 3.89.1 → 3.90.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [3.90.0](https://github.com/kiva/kv-ui-elements/compare/@kiva/kv-components@3.89.1...@kiva/kv-components@3.90.0) (2024-07-26)
+
+
+### Bug Fixes
+
+* revert new loan card ([84ee01e](https://github.com/kiva/kv-ui-elements/commit/84ee01e11c23d45f41389c003acaba843b50d103))
+
+
+### Features
+
+* remove clickable tags exp ([afba87d](https://github.com/kiva/kv-ui-elements/commit/afba87dd24a9123607ccf6d8a83e81efab2a2a34))
+
+
+
+
+
 ## [3.89.1](https://github.com/kiva/kv-ui-elements/compare/@kiva/kv-components@3.89.0...@kiva/kv-components@3.89.1) (2024-07-24)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kiva/kv-components",
-  "version": "3.89.1",
+  "version": "3.90.0",
   "type": "module",
   "publishConfig": {
     "access": "public"
@@ -82,5 +82,5 @@
       "optional": true
     }
   },
-  "gitHead": "ffe94e4d7bb773db757012754b5a753dd32ecf51"
+  "gitHead": "b1468cd0b28b722c0088ad4941c604d12cd60735"
 }

package/tests/unit/specs/components/KvClassicLoanCard.spec.js

@@ -1,5 +1,4 @@
 import { render } from '@testing-library/vue';
-import userEvent from '@testing-library/user-event';
 import { axe } from 'jest-axe';
 import KvClassicLoanCard from '../../../../vue/KvClassicLoanCard.vue';
 
@@ -199,22 +198,4 @@ describe('KvClassicLoanCard', () => {
 		expect(activityText).toBeDefined();
 		expect(activityBtn).toBeDefined();
 	});
-
-	it('should emit clicked tag data', async () => {
-		const { getByText, emitted } = render(KvClassicLoanCard,
-			{
-				props: {
-					loanId: loan.id,
-					loan,
-					kvTrackFunction,
-					photoPath,
-					enableClickableTags: true,
-				},
-			});
-		const tagSpan = getByText('Agriculture');
-
-		await userEvent.click(tagSpan);
-
-		expect(emitted()['jump-filter-page']).toEqual([[{ id: 1, label: 'Agriculture', type: 'sector' }]]);
-	});
 });

package/vue/KvClassicLoanCard.vue

@@ -97,7 +97,6 @@
 					<kv-loan-tag
 						v-if="showTags && !isLoading"
 						:loan="loan"
-						:kv-track-function="kvTrackFunction"
 					/>
 				</component>
 
@@ -151,7 +150,6 @@
 			<kv-loan-callouts
 				v-else
 				:callouts="loanCallouts"
-				:enable-clickable="enableClickableTags"
 				class="tw-mt-1.5"
 				:class="{ 'tw-px-1': largeCard }"
 				@click="$emit('jump-filter-page', $event)"
@@ -407,10 +405,6 @@ export default {
 			type: Boolean,
 			default: false,
 		},
-		enableClickableTags: {
-			type: Boolean,
-			default: false,
-		},
 		primaryButtonText: {
 			type: String,
 			default: 'Lend',

package/vue/KvLoanCallouts.vue

@@ -27,8 +27,6 @@
 					tw-mb-0.5
 					tw-text-small
 				"
-				:class="{ 'tw-cursor-pointer hover:tw-underline': isClickable(tag) }"
-				@click="clickCallout(tag)"
 			>
 				{{ tag.label }}
 			</span>
@@ -37,8 +35,6 @@
 </template>
 
 <script>
-import { toRefs } from 'vue-demi';
-
 export default {
 	name: 'KvLoanCallouts',
 	props: {
@@ -46,36 +42,6 @@ export default {
 			type: Array,
 			required: true,
 		},
-		enableClickable: {
-			type: Boolean,
-			default: false,
-		},
-	},
-	emits: [
-		'click',
-	],
-	setup(props, { emit }) {
-		const {
-			enableClickable,
-		} = toRefs(props);
-
-		const isClickable = (tag) => {
-			const clickableTypes = ['sector', 'tag', 'attribute', 'activity'];
-			const isClickableType = clickableTypes.includes(tag.type);
-
-			return enableClickable.value && isClickableType && !!tag.id;
-		};
-
-		const clickCallout = (tag) => {
-			if (isClickable(tag)) {
-				emit('click', tag);
-			}
-		};
-
-		return {
-			isClickable,
-			clickCallout,
-		};
 	},
 };
 </script>

package/vue/KvLoanTag.vue

@@ -29,10 +29,6 @@ export default {
 			type: Object,
 			required: true,
 		},
-		kvTrackFunction: {
-			type: Function,
-			required: true,
-		},
 	},
 	data() {
 		return {

package/vue/KvWideLoanCard.vue

@@ -106,7 +106,6 @@
 				<kv-loan-tag
 					v-if="showTags && !isLoading"
 					:loan="loan"
-					:kv-track-function="kvTrackFunction"
 				/>
 			</component>
 

package/vue/stories/KvClassicLoanCard.stories.js

@@ -33,7 +33,6 @@ const story = (args) => {
 					:combined-activities="combinedActivities"
 					:showContributors="showContributors"
 					:enable-huge-amount="enableHugeAmount"
-					:enable-clickable-tags="enableClickableTags"
 					:primary-button-text="primaryButtonText"
 					:secondary-button-text="secondaryButtonText"
 					:secondary-button-handler="secondaryButtonHandler"
@@ -400,14 +399,6 @@ export const HugeLentAmount = story({
 	enableHugeAmount: true,
 });
 
-export const ClickableTags = story({
-	loanId: loan.id,
-	loan,
-	kvTrackFunction,
-	photoPath,
-	enableClickableTags: true,
-});
-
 export const SupportButton = story({
 	loanId: loan.id,
 	loan,

package/vue/stories/KvLoanCallouts.stories.js

@@ -12,7 +12,6 @@ const story = (args) => {
 		template: `
 			<kv-loan-callouts
 				:callouts="callouts"
-				:enableClickable="enableClickable"
 			/>
 		`,
 	});
@@ -21,14 +20,3 @@ const story = (args) => {
 };
 
 export const Default = story({ callouts: [{ label: 'callout 1' }, { label: 'callout 2' }, { label: 'callout 3' }] });
-
-export const Clickable = story({
-	callouts: [
-		{ label: 'callout 1' },
-		{ id: 33, label: 'callout 2', type: 'sector' },
-		{ id: null, label: 'callout 3', type: 'tag' },
-		{ id: 12, label: 'callout 4', type: 'attribute' },
-		{ id: 9, label: 'callout 5', type: 'activity' },
-	],
-	enableClickable: true,
-});

package/vue/stories/KvLoanTag.stories.js

@@ -16,7 +16,6 @@ const story = (args) => {
 		template: `
 			<kv-loan-tag
 				:loan="loan"
-				:kv-track-function="kvTrackFunction"
 			/>
 		`,
 	});
@@ -30,9 +29,7 @@ tomorrow.setDate(tomorrow.getDate() + 1);
 const nextWeek = new Date();
 nextWeek.setDate(new Date().getDate() + 7);
 
-const kvTrackFunction = () => { };
-
-export const EndingSoon = story({ loan: { plannedExpirationDate: tomorrow.toISOString() }, kvTrackFunction });
+export const EndingSoon = story({ loan: { plannedExpirationDate: tomorrow.toISOString() } });
 
 export const AlmostFunded = story({
 	loan: {
@@ -40,7 +37,6 @@ export const AlmostFunded = story({
 		plannedExpirationDate: nextWeek.toISOString(),
 		loanFundraisingInfo: { fundedAmount: 50, reservedAmount: 50 },
 	},
-	kvTrackFunction,
 });
 
 export const Matched = story({
@@ -51,7 +47,6 @@ export const Matched = story({
 		loanAmount: 199,
 		loanFundraisingInfo: { fundedAmount: 0, reservedAmount: 0 },
 	},
-	kvTrackFunction,
 });
 
 export const LseLoan = story({
@@ -63,5 +58,4 @@ export const LseLoan = story({
 		loanFundraisingInfo: { fundedAmount: 0, reservedAmount: 0 },
 		partnerName: 'N/A, direct to Novulis',
 	},
-	kvTrackFunction,
 });