@kiva/kv-components 3.82.0 → 3.82.1

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [3.82.1](https://github.com/kiva/kv-ui-elements/compare/@kiva/kv-components@3.82.0...@kiva/kv-components@3.82.1) (2024-06-03)
+
+
+### Bug Fixes
+
+* loan card button secondary action and destination ([#411](https://github.com/kiva/kv-ui-elements/issues/411)) ([9cf20db](https://github.com/kiva/kv-ui-elements/commit/9cf20dbd9865a685ae19a5a4d553bb3345c680b8))
+
+
+
+
+
 # [3.82.0](https://github.com/kiva/kv-ui-elements/compare/@kiva/kv-components@3.81.0...@kiva/kv-components@3.82.0) (2024-06-03)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kiva/kv-components",
-  "version": "3.82.0",
+  "version": "3.82.1",
   "type": "module",
   "publishConfig": {
     "access": "public"
@@ -75,5 +75,5 @@
       "optional": true
     }
   },
-  "gitHead": "013324187e1f8cf1639a3cc6d3e29495d26e69fe"
+  "gitHead": "cde8d379527232294da84dde985729ec92479c65"
 }

package/vue/KvLendCta.vue

@@ -6,9 +6,9 @@
 			variant="secondary"
 			class="tw-inline-flex tw-flex-1"
 			data-testid="bp-lend-cta-checkout-button"
-			:to="!externalLinks || secondaryButtonHandler ? '/basket' : undefined"
-			:href="externalLinks || secondaryButtonHandler ? '/basket' : undefined"
-			@click.native="clickSecondaryButton"
+			:to="!externalLinks ? '/basket' : undefined"
+			:href="externalLinks ? '/basket' : undefined"
+			@click.native="clickSecondaryButton($event)"
 		>
 			{{ loanInBasketButtonText }}
 		</kv-ui-button>
@@ -407,8 +407,10 @@ export default {
 		clickDropdown() {
 			this.kvTrackFunction('Lending', 'click-Modify loan amount', 'open dialog', this.loanId, this.loanId);
 		},
-		clickSecondaryButton() {
+		clickSecondaryButton(event) {
 			if (this.secondaryButtonHandler) {
+				event.preventDefault();
+				event.stopPropagation();
 				// Custom secondary button behavior
 				this.secondaryButtonHandler();
 			} else {

package/vue/stories/KvLendCta.stories.js

@@ -23,6 +23,8 @@ const story = (args) => {
 					:custom-loan-details="customLoanDetails"
 					:enable-huge-amount="enableHugeAmount"
 					:is-visitor="isVisitor"
+					:secondary-button-handler="secondaryButtonHandler"
+					:external-links="externalLinks"
 				/>
 			</div>
 		`,
@@ -33,6 +35,8 @@ const story = (args) => {
 
 const kvTrackFunction = () => { };
 
+const secondaryButtonHandler = () => { console.log('secondary button handler'); };
+
 export const Loading = story({ isLoading: true, kvTrackFunction });
 
 export const Adding = story({ isLoading: false, isAdding: true, kvTrackFunction });
@@ -49,6 +53,20 @@ export const Basketed = story({
 	kvTrackFunction,
 });
 
+export const BasketedWithSecondaryAction = story({
+	isLoading: false,
+	loan: { id: 1 },
+	basketItems: [
+		{
+			__typename: 'LoanReservation',
+			id: 1,
+		},
+	],
+	externalLinks: true,
+	kvTrackFunction,
+	secondaryButtonHandler,
+});
+
 export const Funded = story({
 	isLoading: false,
 	loan: { status: 'funded' },