@kiva/kv-components 3.29.0 → 3.30.0

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [3.30.0](https://github.com/kiva/kv-ui-elements/compare/@kiva/kv-components@3.29.0...@kiva/kv-components@3.30.0) (2023-07-17)
+
+
+### Features
+
+* cover the expired edge case ([4e97abf](https://github.com/kiva/kv-ui-elements/commit/4e97abfab4019f08632666f34a931d8a2f89e6d2))
+
+
+
+
+
 # [3.29.0](https://github.com/kiva/kv-ui-elements/compare/@kiva/kv-components@3.28.0...@kiva/kv-components@3.29.0) (2023-07-14)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kiva/kv-components",
-  "version": "3.29.0",
+  "version": "3.30.0",
   "type": "module",
   "publishConfig": {
     "access": "public"
@@ -75,5 +75,5 @@
       "optional": true
     }
   },
-  "gitHead": "c6cb925341942eed7b7e89a469e1b6bd0878af27"
+  "gitHead": "d54d59bf1bedf3e18841138aac0b4dc7f58679be"
 }

package/vue/KvCountdownTimer.vue

@@ -29,19 +29,23 @@ export default {
 		onMounted(() => {
 			timeLeft.value = moment.duration(msLeft.value > 0 ? msLeft.value : 0, 'milliseconds');
 
-			const countdownInterval = 1000;
+			if (timeLeft.value > 0) {
+				const countdownInterval = 1000;
 
-			interval.value = setInterval(() => {
-				timeLeft.value = moment.duration(timeLeft.value - countdownInterval, 'milliseconds');
+				interval.value = setInterval(() => {
+					timeLeft.value = moment.duration(timeLeft.value - countdownInterval, 'milliseconds');
 
-				if (timeLeft.value <= 0) {
-					clearInterval(interval.value);
-				}
-			}, countdownInterval);
+					if (timeLeft.value <= 0) {
+						clearInterval(interval.value);
+					}
+				}, countdownInterval);
+			}
 		});
 
 		onBeforeUnmount(() => {
-			clearInterval(interval.value);
+			if (interval.value) {
+				clearInterval(interval.value);
+			}
 		});
 
 		return { timeLeft };

package/vue/stories/KvCountdownTimer.stories.js

@@ -25,3 +25,5 @@ export const Seconds = story({ msLeft: 1000 * 10 });
 
 // One second less than 24 hours (since we don't show days in timer)
 export const Tomorrow = story({ msLeft: 1000 * 60 * 60 * 24 - 1000 });
+
+export const Expired = story({ msLeft: 0 });