@kitware/vtk.js 34.15.2 → 34.15.3

package/CONTRIBUTING.md

@@ -33,7 +33,7 @@ Please follow the coding style:
     $ git checkout -b new_feature
     ```
 
-4. Start hacking. Additional information on how to create class/test/example can be found
+6. Start hacking. Additional information on how to create class/test/example can be found
    [here](https://kitware.github.io/vtk-js/docs/) in the __Development__ section.
 
     ```sh
@@ -41,19 +41,26 @@ Please follow the coding style:
     $ git add file1 file2 file3
     ```
 
-5. Use Commitizen to create commits
+7. Verify you have correctly formatted code, and that all tests pass:
+
+    ```sh
+    $ npm run reformat
+    $ npm run test
+    ```
+
+8. Use Commitizen to create commits
 
     ```sh
     $ npm run commit
     ```
 
-6. Push commits in your feature branch to your fork in GitHub:
+9. Push commits in your feature branch to your fork in GitHub:
 
     ```sh
     $ git push origin new_feature
     ```
 
-7. Visit your fork in Github, browse to the "**Pull Requests**" link on the left, and use the 
+10. Visit your fork in Github, browse to the "**Pull Requests**" link on the left, and use the 
    "**New Pull Request**" button in the upper right to create a Pull Request.
 
     For more information see: 
@@ -62,7 +69,7 @@ Please follow the coding style:
 If committing changes to `vtk.js@next` or `vtk.js@next-major`, then set your base branch to be `next`
 or `next-major`, respectively. For more info see the section on release channels below.
 
-8. vtk.js uses GitHub for code review and Github Actions to validate proposed patches before they are merged.
+11. vtk.js uses GitHub for code review and Github Actions to validate proposed patches before they are merged.
 
 ## Release Channels
 

package/IO/Geometry/IFCImporter.js

@@ -40,13 +40,13 @@ function vtkIFCImporter(publicAPI, model) {
     const cells = vtkCellArray.newInstance();
     const pointValues = new Float32Array(vertices.length / 2);
     const normalsArray = new Float32Array(vertices.length / 2);
-    for (let i = 0; i < vertices.length; i += 6) {
-      pointValues[i / 2] = vertices[i];
-      pointValues[i / 2 + 1] = vertices[i + 1];
-      pointValues[i / 2 + 2] = vertices[i + 2];
-      normalsArray[i / 2] = vertices[i + 3];
-      normalsArray[i / 2 + 1] = vertices[i + 4];
-      normalsArray[i / 2 + 2] = vertices[i + 5];
+    for (let i = 0, p = 0; i < vertices.length; p += 3) {
+      pointValues[p] = vertices[i++];
+      pointValues[p + 1] = vertices[i++];
+      pointValues[p + 2] = vertices[i++];
+      normalsArray[p] = vertices[i++];
+      normalsArray[p + 1] = vertices[i++];
+      normalsArray[p + 2] = vertices[i++];
     }
     const nCells = indices.length;
     cells.resize(3 * nCells / 3);
@@ -82,36 +82,30 @@ function vtkIFCImporter(publicAPI, model) {
     const normalsArray = new Float32Array(vertices.length / 2);
     const colorArray = new Float32Array(vertices.length / 2);
     if (userMatrix) {
-      const transformMatrix = vtkMatrixBuilder.buildFromRadian().setMatrix(userMatrix);
-      const normalMatrix = vtkMatrixBuilder.buildFromRadian().multiply3x3(mat3.fromMat4(mat3.create(), userMatrix));
-      for (let i = 0; i < vertices.length; i += 6) {
-        const point = [vertices[i], vertices[i + 1], vertices[i + 2]];
-        const normal = [vertices[i + 3], vertices[i + 4], vertices[i + 5]];
-        transformMatrix.apply(point);
-        normalMatrix.apply(normal);
-        pointValues[i / 2] = point[0];
-        pointValues[i / 2 + 1] = point[1];
-        pointValues[i / 2 + 2] = point[2];
-        normalsArray[i / 2] = normal[0];
-        normalsArray[i / 2 + 1] = normal[1];
-        normalsArray[i / 2 + 2] = normal[2];
-        const colorIndex = i / 2;
-        colorArray[colorIndex] = color.x;
-        colorArray[colorIndex + 1] = color.y;
-        colorArray[colorIndex + 2] = color.z;
+      for (let i = 0, p = 0; i < vertices.length; p += 3) {
+        pointValues[p] = vertices[i++];
+        pointValues[p + 1] = vertices[i++];
+        pointValues[p + 2] = vertices[i++];
+        normalsArray[p] = vertices[i++];
+        normalsArray[p + 1] = vertices[i++];
+        normalsArray[p + 2] = vertices[i++];
+        colorArray[p] = color.x;
+        colorArray[p + 1] = color.y;
+        colorArray[p + 2] = color.z;
       }
+      vtkMatrixBuilder.buildFromRadian().setMatrix(userMatrix).apply(pointValues);
+      vtkMatrixBuilder.buildFromRadian().multiply3x3(mat3.fromMat4(mat3.create(), userMatrix)).apply(normalsArray);
     } else {
-      for (let i = 0; i < vertices.length; i += 6) {
-        pointValues[i / 2] = vertices[i];
-        pointValues[i / 2 + 1] = vertices[i + 1];
-        pointValues[i / 2 + 2] = vertices[i + 2];
-        normalsArray[i / 2] = vertices[i + 3];
-        normalsArray[i / 2 + 1] = vertices[i + 4];
-        normalsArray[i / 2 + 2] = vertices[i + 5];
-        const colorIndex = i / 2;
-        colorArray[colorIndex] = color.x;
-        colorArray[colorIndex + 1] = color.y;
-        colorArray[colorIndex + 2] = color.z;
+      for (let i = 0, p = 0; i < vertices.length; p += 3) {
+        pointValues[p] = vertices[i++];
+        pointValues[p + 1] = vertices[i++];
+        pointValues[p + 2] = vertices[i++];
+        normalsArray[p] = vertices[i++];
+        normalsArray[p + 1] = vertices[i++];
+        normalsArray[p + 2] = vertices[i++];
+        colorArray[p] = color.x;
+        colorArray[p + 1] = color.y;
+        colorArray[p + 2] = color.z;
       }
     }
     const nCells = indices.length;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kitware/vtk.js",
-  "version": "34.15.2",
+  "version": "34.15.3",
   "description": "Visualization Toolkit for the Web",
   "keywords": [
     "3d",