@kitware/vtk.js 24.16.5 → 24.17.0

package/Filters/General/OBBTree.js

@@ -132,11 +132,7 @@ function vtkOBBTree(publicAPI, model) {
 
     for (var _i2 = 0; _i2 < 3; _i2++) {
       for (var _j2 = 0; _j2 < 3; _j2++) {
-        a[_i2][_j2] = a[_i2][_j2] / totMass - mean[_i2] * mean[_j2]; // send to zero if close to zero
-
-        if (Math.abs(a[_i2][_j2]) < 1e-12) {
-          a[_i2][_j2] = 0;
-        }
+        a[_i2][_j2] = a[_i2][_j2] / totMass - mean[_i2] * mean[_j2];
       }
     } //
     // Extract axes (i.e., eigenvectors) from covariance matrix.

package/Interaction/Manipulators/MouseRangeManipulator.js

@@ -199,7 +199,10 @@ function vtkMouseRangeManipulator(publicAPI, model) {
     // and the last `onMouseMove` event, we must make sure the pointer
     // is still locked before we run this logic otherwise we may
     // get a `onMouseMove` call after the pointer has been unlocked.
-    if (!interactor.isPointerLocked()) return;
+    if (!interactor.isPointerLocked()) return; // previousPosition could be undefined if for some reason the
+    // `startPointerLockEvent` method is called before the `onButtonDown` one.
+
+    if (model.previousPosition == null) return;
     model.previousPosition.x += event.movementX;
     model.previousPosition.y += event.movementY;
     publicAPI.onMouseMove(interactor, renderer, model.previousPosition);

package/Rendering/Core/RenderWindowInteractor.d.ts

@@ -57,6 +57,8 @@ export interface IRenderWindowInteractorInitialValues {
 	lastFrameTime?: number;
 	wheelTimeoutID?: number;
 	moveTimeoutID?: number;
+	preventDefaultOnPointerDown?: boolean;
+	preventDefaultOnPointerUp?: boolean;
 }
 
 interface IPosition {
@@ -151,6 +153,16 @@ export interface vtkRenderWindowInteractor extends vtkObject {
 	 */
 	getStillUpdateRate(): number;
 
+	/**
+	 * @default false
+	 */
+	getPreventDefaultOnPointerDown(): boolean;
+
+	/**
+	 * @default false
+	 */
+	getPreventDefaultOnPointerUp(): boolean;
+
 	/**
 	 * 
 	 * @param {IRenderWindowInteractorEvent} callData 
@@ -821,6 +833,22 @@ export interface vtkRenderWindowInteractor extends vtkObject {
 	setPicker(picker: any): boolean;
 
 	/**
+	 * Set whether preventDefault is called on pointer down.
+	 * @param {Boolean} preventDefault
+	 */
+	setPreventDefaultOnPointerDown(preventDefault: boolean): boolean;
+
+	/**
+	 * Set whether preventDefault is called on pointer up.
+	 *
+	 * If pointerup occurs without a preceeding pointerdown, then
+	 * this does nothing.
+	 *
+	 * @param {Boolean} preventDefault
+	 */
+	setPreventDefaultOnPointerUp(preventDefault: boolean): boolean;
+
+   /**
 	 *
 	 * @param recognizeGestures
 	 */

package/Rendering/Core/RenderWindowInteractor.js

@@ -24,11 +24,8 @@ var handledEvents = ['StartAnimation', 'Animation', 'EndAnimation', 'PointerEnte
 
 function preventDefault(event) {
   if (event.cancelable) {
-    event.stopPropagation();
     event.preventDefault();
   }
-
-  return false;
 }
 
 function pointerCacheToPositions(cache) {
@@ -173,8 +170,7 @@ function vtkRenderWindowInteractor(publicAPI, model) {
 
   publicAPI.bindEvents = function (container) {
     model.container = container;
-    container.addEventListener('contextmenu', preventDefault); // container.addEventListener('click', preventDefault); // Avoid stopping event propagation
-
+    container.addEventListener('contextmenu', preventDefault);
     container.addEventListener('wheel', publicAPI.handleWheel);
     container.addEventListener('DOMMouseScroll', publicAPI.handleWheel);
     container.addEventListener('pointerenter', publicAPI.handlePointerEnter);
@@ -201,8 +197,7 @@ function vtkRenderWindowInteractor(publicAPI, model) {
 
   publicAPI.unbindEvents = function () {
     var container = model.container;
-    container.removeEventListener('contextmenu', preventDefault); // model.container.removeEventListener('click', preventDefault); // Avoid stopping event propagation
-
+    container.removeEventListener('contextmenu', preventDefault);
     container.removeEventListener('wheel', publicAPI.handleWheel);
     container.removeEventListener('DOMMouseScroll', publicAPI.handleWheel);
     container.removeEventListener('pointerenter', publicAPI.handlePointerEnter);
@@ -270,7 +265,9 @@ function vtkRenderWindowInteractor(publicAPI, model) {
       return;
     }
 
-    preventDefault(event);
+    if (model.preventDefaultOnPointerDown) {
+      preventDefault(event);
+    }
 
     if (event.target.hasPointerCapture(event.pointerId)) {
       event.target.releasePointerCapture(event.pointerId);
@@ -302,7 +299,10 @@ function vtkRenderWindowInteractor(publicAPI, model) {
 
   publicAPI.handlePointerUp = function (event) {
     if (pointerCache.has(event.pointerId)) {
-      preventDefault(event);
+      if (model.preventDefaultOnPointerUp) {
+        preventDefault(event);
+      }
+
       pointerCache.delete(event.pointerId);
       model.container.releasePointerCapture(event.pointerId);
 
@@ -384,8 +384,9 @@ function vtkRenderWindowInteractor(publicAPI, model) {
 
 
   publicAPI.requestPointerLock = function () {
-    var canvas = publicAPI.getView().getCanvas();
-    canvas.requestPointerLock();
+    if (model.container) {
+      model.container.requestPointerLock();
+    }
   }; //----------------------------------------------------------------------
 
 
@@ -395,7 +396,7 @@ function vtkRenderWindowInteractor(publicAPI, model) {
 
 
   publicAPI.isPointerLocked = function () {
-    return !!document.pointerLockElement;
+    return !!model.container && document.pointerLockElement === model.container;
   }; //----------------------------------------------------------------------
 
 
@@ -1075,7 +1076,9 @@ var DEFAULT_VALUES = {
   recentAnimationFrameRate: 10.0,
   wheelTimeoutID: 0,
   moveTimeoutID: 0,
-  lastGamepadValues: {}
+  lastGamepadValues: {},
+  preventDefaultOnPointerDown: false,
+  preventDefaultOnPointerUp: false
 }; // ----------------------------------------------------------------------------
 
 function extend(publicAPI, model) {
@@ -1092,7 +1095,7 @@ function extend(publicAPI, model) {
 
   macro.get(publicAPI, model, ['initialized', 'container', 'interactorStyle', 'lastFrameTime', 'recentAnimationFrameRate', '_view']); // Create get-set macros
 
-  macro.setGet(publicAPI, model, ['lightFollowCamera', 'enabled', 'enableRender', 'recognizeGestures', 'desiredUpdateRate', 'stillUpdateRate', 'picker']);
+  macro.setGet(publicAPI, model, ['lightFollowCamera', 'enabled', 'enableRender', 'recognizeGestures', 'desiredUpdateRate', 'stillUpdateRate', 'picker', 'preventDefaultOnPointerDown', 'preventDefaultOnPointerUp']);
   macro.moveToProtected(publicAPI, model, ['view']); // For more macro methods, see "Sources/macros.js"
   // Object specific methods
 

package/Rendering/OpenGL/Texture.js

@@ -567,13 +567,8 @@ function vtkOpenGLTexture(publicAPI, model) {
     if (dataType !== VtkDataTypes.FLOAT && model.openGLDataType === model.context.FLOAT) {
       for (var idx = 0; idx < data.length; idx++) {
         if (data[idx]) {
-          var newArray = new Float32Array(pixCount);
-
-          for (var i = 0; i < pixCount; i++) {
-            newArray[i] = data[idx][i];
-          }
-
-          pixData.push(newArray);
+          var dataArrayToCopy = data[idx].length > pixCount ? data[idx].subarray(0, pixCount) : data[idx];
+          pixData.push(new Float32Array(dataArrayToCopy));
         } else {
           pixData.push(null);
         }
@@ -585,13 +580,9 @@ function vtkOpenGLTexture(publicAPI, model) {
     if (dataType !== VtkDataTypes.UNSIGNED_CHAR && model.openGLDataType === model.context.UNSIGNED_BYTE) {
       for (var _idx = 0; _idx < data.length; _idx++) {
         if (data[_idx]) {
-          var _newArray = new Uint8Array(pixCount);
+          var _dataArrayToCopy = data[_idx].length > pixCount ? data[_idx].subarray(0, pixCount) : data[_idx];
 
-          for (var _i = 0; _i < pixCount; _i++) {
-            _newArray[_i] = data[_idx][_i];
-          }
-
-          pixData.push(_newArray);
+          pixData.push(new Uint8Array(_dataArrayToCopy));
         } else {
           pixData.push(null);
         }
@@ -606,13 +597,13 @@ function vtkOpenGLTexture(publicAPI, model) {
     if (halfFloat) {
       for (var _idx2 = 0; _idx2 < data.length; _idx2++) {
         if (data[_idx2]) {
-          var _newArray2 = new Uint16Array(pixCount);
+          var newArray = new Uint16Array(pixCount);
 
-          for (var _i2 = 0; _i2 < pixCount; _i2++) {
-            _newArray2[_i2] = HalfFloat.toHalf(data[_idx2][_i2]);
+          for (var i = 0; i < pixCount; i++) {
+            newArray[i] = HalfFloat.toHalf(data[_idx2][i]);
           }
 
-          pixData.push(_newArray2);
+          pixData.push(newArray);
         } else {
           pixData.push(null);
         }
@@ -621,8 +612,8 @@ function vtkOpenGLTexture(publicAPI, model) {
 
 
     if (pixData.length === 0) {
-      for (var _i3 = 0; _i3 < data.length; _i3++) {
-        pixData.push(data[_i3]);
+      for (var _i = 0; _i < data.length; _i++) {
+        pixData.push(data[_i]);
       }
     }
 
@@ -714,8 +705,8 @@ function vtkOpenGLTexture(publicAPI, model) {
 
 
     if (pixData.length === 0) {
-      for (var _i4 = 0; _i4 < data.length; _i4++) {
-        pixData.push(data[_i4]);
+      for (var _i2 = 0; _i2 < data.length; _i2++) {
+        pixData.push(data[_i2]);
       }
     }
 
@@ -819,7 +810,7 @@ function vtkOpenGLTexture(publicAPI, model) {
 
     model.context.pixelStorei(model.context.UNPACK_ALIGNMENT, 1); // We get the 6 images
 
-    for (var _i5 = 0; _i5 < 6; _i5++) {
+    for (var _i3 = 0; _i3 < 6; _i3++) {
       // For each mipmap level
       var j = 0;
       var w = model.width;
@@ -832,10 +823,10 @@ function vtkOpenGLTexture(publicAPI, model) {
         var tempData = null;
 
         if (j <= model.maxLevel) {
-          tempData = invertedData[6 * j + _i5];
+          tempData = invertedData[6 * j + _i3];
         }
 
-        model.context.texImage2D(model.context.TEXTURE_CUBE_MAP_POSITIVE_X + _i5, j, model.internalFormat, w, h, 0, model.format, model.openGLDataType, tempData);
+        model.context.texImage2D(model.context.TEXTURE_CUBE_MAP_POSITIVE_X + _i3, j, model.internalFormat, w, h, 0, model.format, model.openGLDataType, tempData);
         j++;
         w /= 2;
         h /= 2;
@@ -1111,7 +1102,7 @@ function vtkOpenGLTexture(publicAPI, model) {
       } // otherwise convert to float
 
 
-      var _newArray3 = new Float32Array(numPixelsIn * numComps); // compute min and max values
+      var _newArray = new Float32Array(numPixelsIn * numComps); // compute min and max values
 
 
       model.volumeInfo.offset = computedOffset;
@@ -1123,12 +1114,12 @@ function vtkOpenGLTexture(publicAPI, model) {
 
       for (var i = 0; i < numPixelsIn; i++) {
         for (var nc = 0; nc < numComps; nc++) {
-          _newArray3[count] = (data[count] - computedOffset[nc]) * scaleInverse[nc];
+          _newArray[count] = (data[count] - computedOffset[nc]) * scaleInverse[nc];
           count++;
         }
       }
 
-      return publicAPI.create3DFromRaw(width, height, depth, numComps, VtkDataTypes.FLOAT, _newArray3);
+      return publicAPI.create3DFromRaw(width, height, depth, numComps, VtkDataTypes.FLOAT, _newArray);
     } // not webgl2, deal with webgl1, no 3d textures
     // and maybe no float textures
     // compute min and max values

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kitware/vtk.js",
-  "version": "24.16.5",
+  "version": "24.17.0",
   "description": "Visualization Toolkit for the Web",
   "keywords": [
     "3d",