@kitlangton/ghui 0.2.0 → 0.3.0

package/README.md

@@ -44,15 +44,12 @@ bun run dev
 
 ## Configuration
 
-- `GHUI_AUTHOR`: author passed to `gh search prs`, defaults to `@me`
-- `GHUI_REPO`: optional `owner/name` repository queue for browsing all open PRs in a repo
 - `GHUI_PR_FETCH_LIMIT`: max PRs fetched, defaults to `200`
 
 Example:
 
 ```bash
-GHUI_AUTHOR=@me ghui
-GHUI_REPO=basecamp/omarchy ghui
+GHUI_PR_FETCH_LIMIT=100 ghui
 ```
 
 You can also copy `.env.example` to `.env` and edit the values locally.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@kitlangton/ghui",
-	"version": "0.2.0",
+	"version": "0.3.0",
 	"description": "Terminal UI for GitHub pull requests",
 	"type": "module",
 	"license": "MIT",

package/src/App.tsx

@@ -8,12 +8,12 @@ import { Cause, Effect, Layer, Schedule } from "effect"
 import * as AsyncResult from "effect/unstable/reactivity/AsyncResult"
 import * as Atom from "effect/unstable/reactivity/Atom"
 import * as AtomRegistry from "effect/unstable/reactivity/AtomRegistry"
-import { useContext, useEffect, useMemo, useRef, useState } from "react"
+import { useCallback, useContext, useEffect, useLayoutEffect, useMemo, useRef, useState } from "react"
 import { buildAppCommands } from "./appCommands.js"
 import type { AppCommand } from "./commands.js"
 import { clampCommandIndex, commandEnabled, defineCommand, filterCommands, sortCommandsByScope } from "./commands.js"
 import { config } from "./config.js"
-import { type CreatePullRequestCommentInput, type DiffCommentSide, type ListPullRequestPageInput, type LoadStatus, type PullRequestConversationItem, type PullRequestItem, type PullRequestLabel, type PullRequestMergeAction, type PullRequestReviewComment } from "./domain.js"
+import { type CreatePullRequestCommentInput, type DiffCommentSide, type ListPullRequestPageInput, type LoadStatus, type PullRequestConversationItem, type PullRequestItem, type PullRequestLabel, type PullRequestMergeAction, type PullRequestReviewComment, type SubmitPullRequestReviewInput } from "./domain.js"
 import { formatShortDate, formatTimestamp } from "./date.js"
 import { errorMessage } from "./errors.js"
 import { availableMergeActions, mergeInfoFromPullRequest } from "./mergeActions.js"
@@ -33,7 +33,7 @@ import { FooterHints, initialRetryProgress, RetryProgress } from "./ui/FooterHin
 import { LoadingLogoPane } from "./ui/LoadingLogo.js"
 import { Divider, fitCell, PlainLine, SeparatorColumn } from "./ui/primitives.js"
 import { CommandPalette } from "./ui/CommandPalette.js"
-import { CloseModal, CommentModal, CommentThreadModal, filterLabels, initialCloseModalState, initialCommandPaletteState, initialCommentModalState, initialCommentThreadModalState, initialLabelModalState, initialMergeModalState, initialModal, initialOpenRepositoryModalState, initialThemeModalState, LabelModal, MergeModal, Modal, OpenRepositoryModal, ThemeModal, type CloseModalState, type CommandPaletteState, type CommentModalState, type CommentThreadModalState, type LabelModalState, type MergeModalState, type ModalState, type ModalTag, type OpenRepositoryModalState, type ThemeModalState } from "./ui/modals.js"
+import { ChangedFilesModal, CloseModal, CommentModal, CommentThreadModal, filterChangedFiles, filterLabels, initialChangedFilesModalState, initialCloseModalState, initialCommandPaletteState, initialCommentModalState, initialCommentThreadModalState, initialLabelModalState, initialMergeModalState, initialModal, initialOpenRepositoryModalState, initialSubmitReviewModalState, initialThemeModalState, LabelModal, MergeModal, Modal, OpenRepositoryModal, submitReviewOptions, SubmitReviewModal, ThemeModal, type ChangedFilesModalState, type CloseModalState, type CommandPaletteState, type CommentModalState, type CommentThreadModalState, type LabelModalState, type MergeModalState, type ModalState, type ModalTag, type OpenRepositoryModalState, type SubmitReviewModalState, type ThemeModalState } from "./ui/modals.js"
 import { groupBy, reviewLabel } from "./ui/pullRequests.js"
 import { PullRequestDiffPane } from "./ui/PullRequestDiffPane.js"
 import { buildPullRequestListRows, pullRequestListRowIndex, PullRequestList } from "./ui/PullRequestList.js"
@@ -132,7 +132,7 @@ const appendPullRequestPage = (existing: readonly PullRequestItem[], incoming: r
 }
 
 const retryProgressAtom = Atom.make<RetryProgress>(initialRetryProgress).pipe(Atom.keepAlive)
-const activeViewAtom = Atom.make<PullRequestView>(initialPullRequestView(config.repository)).pipe(Atom.keepAlive)
+const activeViewAtom = Atom.make<PullRequestView>(initialPullRequestView()).pipe(Atom.keepAlive)
 const queueLoadCacheAtom = Atom.make<Partial<Record<string, PullRequestLoad>>>({}).pipe(Atom.keepAlive)
 const queueSelectionAtom = Atom.make<Partial<Record<string, number>>>({}).pipe(Atom.keepAlive)
 const trimQueueLoadCache = (cache: Partial<Record<string, PullRequestLoad>>) => {
@@ -212,9 +212,7 @@ const labelCacheAtom = Atom.make<Record<string, readonly PullRequestLabel[]>>({}
 const pullRequestOverridesAtom = Atom.make<Record<string, PullRequestItem>>({}).pipe(Atom.keepAlive)
 const recentlyCompletedPullRequestsAtom = Atom.make<Record<string, PullRequestItem>>({}).pipe(Atom.keepAlive)
 const usernameAtom = githubRuntime.atom(
-	config.author === "@me"
-		? GitHubService.use((github) => github.getAuthenticatedUser())
-		: Effect.succeed(config.author.replace(/^@/, "")),
+	GitHubService.use((github) => github.getAuthenticatedUser()),
 ).pipe(Atom.keepAlive)
 
 const pullRequestLoadAtom = Atom.make((get) => {
@@ -350,6 +348,7 @@ const closePullRequestAtom = githubRuntime.fn<{ readonly repository: string; rea
 	GitHubService.use((github) => github.closePullRequest(input.repository, input.number))
 )
 const createPullRequestCommentAtom = githubRuntime.fn<CreatePullRequestCommentInput>()((input) => GitHubService.use((github) => github.createPullRequestComment(input)))
+const submitPullRequestReviewAtom = githubRuntime.fn<SubmitPullRequestReviewInput>()((input) => GitHubService.use((github) => github.submitPullRequestReview(input)))
 const copyToClipboardAtom = githubRuntime.fn<string>()((text) => Clipboard.use((clipboard) => clipboard.copy(text)))
 const openInBrowserAtom = githubRuntime.fn<PullRequestItem>()((pullRequest) => BrowserOpener.use((browser) => browser.openPullRequest(pullRequest)))
 
@@ -418,6 +417,12 @@ const groupDiffCommentThreads = (pullRequest: PullRequestItem, comments: readonl
 
 const isLocalDiffComment = (comment: PullRequestReviewComment) => comment.id.startsWith("local:")
 
+const reviewStatusAfterSubmit = {
+	COMMENT: null,
+	APPROVE: "approved",
+	REQUEST_CHANGES: "changes",
+} satisfies Record<SubmitPullRequestReviewInput["event"], PullRequestItem["reviewStatus"] | null>
+
 const originalDiffLineColor = (anchor: DiffCommentAnchor): DiffLineColorConfig => {
 	if (anchor.kind === "addition") {
 		return { gutter: colors.diff.addedLineNumberBg, content: colors.diff.addedBg }
@@ -559,6 +564,8 @@ export const App = () => {
 	const mergeModalActive = Modal.$is("Merge")(activeModal)
 	const commentModalActive = Modal.$is("Comment")(activeModal)
 	const commentThreadModalActive = Modal.$is("CommentThread")(activeModal)
+	const changedFilesModalActive = Modal.$is("ChangedFiles")(activeModal)
+	const submitReviewModalActive = Modal.$is("SubmitReview")(activeModal)
 	const themeModalActive = Modal.$is("Theme")(activeModal)
 	const commandPaletteActive = Modal.$is("CommandPalette")(activeModal)
 	const openRepositoryModalActive = Modal.$is("OpenRepository")(activeModal)
@@ -567,6 +574,8 @@ export const App = () => {
 	const mergeModal: MergeModalState = mergeModalActive ? activeModal : initialMergeModalState
 	const commentModal: CommentModalState = commentModalActive ? activeModal : initialCommentModalState
 	const commentThreadModal: CommentThreadModalState = commentThreadModalActive ? activeModal : initialCommentThreadModalState
+	const changedFilesModal: ChangedFilesModalState = changedFilesModalActive ? activeModal : initialChangedFilesModalState
+	const submitReviewModal: SubmitReviewModalState = submitReviewModalActive ? activeModal : initialSubmitReviewModalState
 	const themeModal: ThemeModalState = themeModalActive ? activeModal : initialThemeModalState
 	const commandPalette: CommandPaletteState = commandPaletteActive ? activeModal : initialCommandPaletteState
 	const openRepositoryModal: OpenRepositoryModalState = openRepositoryModalActive ? activeModal : initialOpenRepositoryModalState
@@ -585,6 +594,8 @@ export const App = () => {
 	const setMergeModal = makeModalSetter("Merge")
 	const setCommentModal = makeModalSetter("Comment")
 	const setCommentThreadModal = makeModalSetter("CommentThread")
+	const setChangedFilesModal = makeModalSetter("ChangedFiles")
+	const setSubmitReviewModal = makeModalSetter("SubmitReview")
 	const setThemeModal = makeModalSetter("Theme")
 	const setCommandPalette = makeModalSetter("CommandPalette")
 	const setOpenRepositoryModal = makeModalSetter("OpenRepository")
@@ -603,6 +614,7 @@ export const App = () => {
 	const [terminalFocused, setTerminalFocused] = useState(true)
 	const [startupLoadComplete, setStartupLoadComplete] = useState(false)
 	const [loadingMoreKey, setLoadingMoreKey] = useState<string | null>(null)
+	const [detailPreviewScrollTop, setDetailPreviewScrollTop] = useState(0)
 	const usernameResult = useAtomValue(usernameAtom)
 	const loadRepoLabels = useAtomSet(listRepoLabelsAtom, { mode: "promise" })
 	const loadPullRequestPage = useAtomSet(listOpenPullRequestPageAtom, { mode: "promise" })
@@ -615,6 +627,7 @@ export const App = () => {
 	const mergePullRequest = useAtomSet(mergePullRequestAtom, { mode: "promise" })
 	const closePullRequest = useAtomSet(closePullRequestAtom, { mode: "promise" })
 	const createPullRequestComment = useAtomSet(createPullRequestCommentAtom, { mode: "promise" })
+	const submitPullRequestReview = useAtomSet(submitPullRequestReviewAtom, { mode: "promise" })
 	const copyToClipboard = useAtomSet(copyToClipboardAtom, { mode: "promise" })
 	const openInBrowser = useAtomSet(openInBrowserAtom, { mode: "promise" })
 	const terminalWidth = width ?? 100
@@ -644,6 +657,7 @@ export const App = () => {
 	const maybeRefreshPullRequestsRef = useRef<(minimumAgeMs: number) => void>(() => {})
 	const detailScrollRef = useRef<ScrollBoxRenderable | null>(null)
 	const detailPreviewScrollRef = useRef<ScrollBoxRenderable | null>(null)
+	const detailPreviewScrollTopRef = useRef(0)
 	const diffScrollRef = useRef<ScrollBoxRenderable | null>(null)
 	const prListScrollRef = useRef<ScrollBoxRenderable | null>(null)
 	const diffRenderableRefs = useRef(new Map<number, DiffRenderable>())
@@ -722,6 +736,10 @@ export const App = () => {
 			: [],
 		[selectedDiffState, diffWhitespaceMode],
 	)
+	const changedFileResults = useMemo(
+		() => changedFilesModalActive ? filterChangedFiles(readyDiffFiles, changedFilesModal.query) : [],
+		[changedFilesModalActive, readyDiffFiles, changedFilesModal.query],
+	)
 	const displayedDiffState = useMemo(
 		() => selectedDiffState?._tag === "Ready"
 			? PullRequestDiffState.Ready({ patch: readyDiffFiles.map((file) => file.patch).join("\n"), files: readyDiffFiles })
@@ -1071,6 +1089,10 @@ export const App = () => {
 		setDiffPreferredSide(null)
 		setDiffCommentRangeStartIndex(null)
 		detailPreviewScrollRef.current?.scrollTo({ x: 0, y: 0 })
+		if (detailPreviewScrollTopRef.current !== 0) {
+			detailPreviewScrollTopRef.current = 0
+			setDetailPreviewScrollTop(0)
+		}
 	}, [selectedIndex])
 
 	useEffect(() => {
@@ -1148,7 +1170,7 @@ export const App = () => {
 	}, [diffFullView])
 	const isHydratingPullRequestDetails = pullRequestStatus === "ready" && selectedPullRequest?.state === "open" && !selectedPullRequest.detailLoaded
 	const isRefreshingPullRequests = pullRequestResult.waiting && pullRequestLoad !== null
-	const hasActiveLoadingIndicator = pullRequestResult.waiting || isHydratingPullRequestDetails || isLoadingMorePullRequests || labelModal.loading || closeModal.running || mergeModal.loading || mergeModal.running || selectedDiffState?._tag === "Loading"
+	const hasActiveLoadingIndicator = pullRequestResult.waiting || isHydratingPullRequestDetails || isLoadingMorePullRequests || labelModal.loading || closeModal.running || mergeModal.loading || mergeModal.running || submitReviewModal.running || selectedDiffState?._tag === "Loading"
 	const loadingIndicator = SPINNER_FRAMES[loadingFrame % SPINNER_FRAMES.length]!
 
 	useEffect(() => {
@@ -1211,8 +1233,6 @@ export const App = () => {
 		title: `${loadingIndicator} Loading pull request details`,
 		hint: `${selectedPullRequest.repository} #${selectedPullRequest.number}`,
 	} : detailPlaceholderContent
-	const detailJunctions = isSelectedPullRequestDetailLoading ? [] : getDetailJunctionRows(selectedPullRequest, rightPaneWidth, true, rightContentWidth, selectedConversationItems, selectedConversationStatus)
-
 	const halfPage = Math.max(1, Math.floor(wideBodyHeight / 2))
 
 	const loadPullRequestComments = (pullRequest: PullRequestItem, force = false) => {
@@ -1334,8 +1354,23 @@ export const App = () => {
 		setDiffFileIndex((current) => current === nextIndex ? current : nextIndex)
 	}
 
-	const scrollDetailPreviewBy = (y: number) => detailPreviewScrollRef.current?.scrollBy({ x: 0, y })
-	const scrollDetailPreviewTo = (y: number) => detailPreviewScrollRef.current?.scrollTo({ x: 0, y })
+	const syncDetailPreviewScrollState = useCallback(() => {
+		const scrollTop = detailPreviewScrollRef.current?.scrollTop
+		if (scrollTop === undefined) return
+		const nextTop = Math.max(0, Math.floor(scrollTop))
+		if (detailPreviewScrollTopRef.current === nextTop) return
+		detailPreviewScrollTopRef.current = nextTop
+		setDetailPreviewScrollTop(nextTop)
+	}, [])
+
+	const scrollDetailPreviewBy = (y: number) => {
+		detailPreviewScrollRef.current?.scrollBy({ x: 0, y })
+		syncDetailPreviewScrollState()
+	}
+	const scrollDetailPreviewTo = (y: number) => {
+		detailPreviewScrollRef.current?.scrollTo({ x: 0, y })
+		syncDetailPreviewScrollState()
+	}
 
 	const ensureDiffLineVisible = (line: number) => {
 		const scroll = diffScrollRef.current
@@ -1354,9 +1389,19 @@ export const App = () => {
 		return () => globalThis.clearInterval(interval)
 	}, [diffFullView, stackedDiffFiles])
 
-	const jumpDiffFile = (delta: 1 | -1) => {
+	useLayoutEffect(() => {
+		if (!isWideLayout || detailFullView || diffFullView) return
+		const scroll = detailPreviewScrollRef.current
+		if (!scroll) return
+		const sync = () => { syncDetailPreviewScrollState() }
+		scroll.verticalScrollBar.on("change", sync)
+		syncDetailPreviewScrollState()
+		return () => { scroll.verticalScrollBar.off("change", sync) }
+	}, [isWideLayout, detailFullView, diffFullView, syncDetailPreviewScrollState])
+
+	const selectDiffFile = (index: number) => {
 		if (readyDiffFiles.length === 0) return
-		const nextIndex = safeDiffFileIndex(readyDiffFiles, diffFileIndex + delta)
+		const nextIndex = safeDiffFileIndex(readyDiffFiles, index)
 		setDiffFileIndex(nextIndex)
 		setDiffCommentRangeStartIndex(null)
 		const targetSide = diffPreferredSide ?? selectedDiffCommentAnchor?.side
@@ -1366,6 +1411,26 @@ export const App = () => {
 		scrollToDiffFile(nextIndex)
 	}
 
+	const jumpDiffFile = (delta: 1 | -1) => {
+		selectDiffFile(diffFileIndex + delta)
+	}
+
+	const openChangedFilesModal = () => {
+		if (readyDiffFiles.length === 0) return
+		setChangedFilesModal({
+			query: "",
+			selectedIndex: safeDiffFileIndex(readyDiffFiles, diffFileIndex),
+		})
+	}
+
+	const selectChangedFile = () => {
+		const selectedIndex = changedFileResults.length === 0 ? 0 : Math.max(0, Math.min(changedFilesModal.selectedIndex, changedFileResults.length - 1))
+		const entry = changedFileResults[selectedIndex]
+		if (!entry) return
+		closeActiveModal()
+		selectDiffFile(entry.index)
+	}
+
 	const navigableDiffCommentAnchors = () => diffCommentRangeStartAnchor
 		? diffCommentAnchors.filter((anchor) => sameDiffCommentTarget(anchor, diffCommentRangeStartAnchor))
 		: diffCommentAnchors
@@ -1445,6 +1510,27 @@ export const App = () => {
 		})
 	}
 
+	const editSubmitReview = (transform: (state: CommentEditorValue) => CommentEditorValue) => {
+		setSubmitReviewModal((current) => {
+			const next = transform({ body: current.body, cursor: current.cursor })
+			if (next.body === current.body && next.cursor === current.cursor && current.error === null) return current
+			return { ...current, body: next.body, cursor: next.cursor, error: null }
+		})
+	}
+
+	const openSubmitReviewModal = () => {
+		if (!selectedPullRequest || selectedPullRequest.state !== "open") return
+		setSubmitReviewModal({
+			repository: selectedPullRequest.repository,
+			number: selectedPullRequest.number,
+			selectedIndex: 0,
+			body: "",
+			cursor: 0,
+			running: false,
+			error: null,
+		})
+	}
+
 	const openDiffCommentModal = () => {
 		if (!selectedDiffCommentAnchor || !selectedPullRequest) return
 		setCommentModal(initialCommentModalState)
@@ -1554,6 +1640,31 @@ export const App = () => {
 		})
 	}
 
+	const confirmSubmitReview = () => {
+		if (!submitReviewModal.repository || submitReviewModal.number === null || submitReviewModal.running) return
+		const option = submitReviewOptions[submitReviewModal.selectedIndex]
+		if (!option) return
+		const repository = submitReviewModal.repository
+		const number = submitReviewModal.number
+		const body = submitReviewModal.body.trim()
+		const targetPullRequest = pullRequests.find((pullRequest) => pullRequest.repository === repository && pullRequest.number === number) ?? null
+		const nextReviewStatus = reviewStatusAfterSubmit[option.event]
+
+		setSubmitReviewModal((current) => ({ ...current, running: true, error: null }))
+		void submitPullRequestReview({ repository, number, event: option.event, body })
+			.then(() => {
+				if (targetPullRequest && nextReviewStatus) {
+					updatePullRequest(targetPullRequest.url, (pullRequest) => ({ ...pullRequest, reviewStatus: nextReviewStatus }))
+				}
+				closeActiveModal()
+				flashNotice(`Submitted ${option.title.toLowerCase()} review for #${number}`)
+			})
+			.catch((error) => {
+				setSubmitReviewModal((current) => ({ ...current, running: false, error: errorMessage(error) }))
+				flashNotice(errorMessage(error))
+			})
+	}
+
 	const openSelectedPullRequestInBrowser = (pullRequest: PullRequestItem) => {
 		void openInBrowser(pullRequest)
 			.then(() => flashNotice(`Opened #${pullRequest.number} in browser`))
@@ -1831,10 +1942,18 @@ export const App = () => {
 			editComment((state) => insertText(state, text.replace(/\r\n?/g, "\n")))
 			return true
 		}
+		if (submitReviewModalActive) {
+			editSubmitReview((state) => insertText(state, text.replace(/\r\n?/g, "\n")))
+			return true
+		}
 		if (labelModalActive) {
 			setLabelModal((current) => ({ ...current, query: current.query + singleLineText(text), selectedIndex: 0 }))
 			return true
 		}
+		if (changedFilesModalActive) {
+			setChangedFilesModal((current) => ({ ...current, query: current.query + singleLineText(text), selectedIndex: 0 }))
+			return true
+		}
 		if (filterMode) {
 			setFilterDraft((current) => current + singleLineText(text))
 			return true
@@ -1854,7 +1973,7 @@ export const App = () => {
 		return () => {
 			keyInput.off("paste", handlePaste)
 		}
-	}, [renderer, commandPaletteActive, openRepositoryModalActive, themeModalActive, themeModal.filterMode, commentModalActive, labelModalActive, filterMode])
+	}, [renderer, commandPaletteActive, openRepositoryModalActive, themeModalActive, themeModal.filterMode, commentModalActive, submitReviewModalActive, labelModalActive, changedFilesModalActive, filterMode])
 
 	const appCommands: readonly AppCommand[] = buildAppCommands({
 		pullRequestStatus,
@@ -1916,11 +2035,13 @@ export const App = () => {
 			toggleDiffRenderView: () => setDiffRenderView((current) => current === "unified" ? "split" : "unified"),
 			toggleDiffWrapMode: () => setDiffWrapMode((current) => current === "none" ? "word" : "none"),
 			toggleDiffWhitespaceMode,
+			openChangedFilesModal,
 			jumpDiffFile,
 			openSelectedDiffComment,
 			toggleDiffCommentRange,
 			moveDiffCommentThread,
 			openDiffCommentModal,
+			openSubmitReviewModal,
 			togglePullRequestDraftStatus: toggleSelectedPullRequestDraftStatus,
 			openLabelModal,
 			openMergeModal,
@@ -1986,6 +2107,15 @@ export const App = () => {
 		const max = Math.max(0, filterLabels(labelModal.availableLabels, labelModal.query).length - 1)
 		return { ...current, selectedIndex: Math.max(0, Math.min(max, current.selectedIndex + delta)) }
 	})
+	const moveChangedFileSelection = (delta: -1 | 1) => setChangedFilesModal((current) => {
+		const max = Math.max(0, changedFileResults.length - 1)
+		const selectedIndex = Math.max(0, Math.min(max, current.selectedIndex + delta))
+		return selectedIndex === current.selectedIndex ? current : { ...current, selectedIndex }
+	})
+	const moveSubmitReviewActionSelection = (delta: -1 | 1) => setSubmitReviewModal((current) => {
+		const max = Math.max(0, submitReviewOptions.length - 1)
+		return { ...current, selectedIndex: Math.max(0, Math.min(max, current.selectedIndex + delta)), error: null }
+	})
 	const moveCommandPaletteSelection = (delta: -1 | 1) => setCommandPalette((current) => {
 		const selectedIndex = clampCommandIndex(current.selectedIndex + delta, commandPaletteCommands)
 		return selectedIndex === current.selectedIndex ? current : { ...current, selectedIndex }
@@ -2060,6 +2190,8 @@ export const App = () => {
 		closeModalActive,
 		mergeModalActive,
 		commentThreadModalActive,
+		changedFilesModalActive,
+		submitReviewModalActive,
 		labelModalActive,
 		themeModalActive,
 		openRepositoryModalActive,
@@ -2071,6 +2203,8 @@ export const App = () => {
 		textInputActive: commentModalActive
 			|| commandPaletteActive
 			|| openRepositoryModalActive
+			|| changedFilesModalActive
+			|| submitReviewModalActive
 			|| labelModalActive
 			|| filterMode
 			|| (themeModalActive && themeModal.filterMode),
@@ -2090,6 +2224,32 @@ export const App = () => {
 			openInlineComment: openDiffCommentModal,
 			scrollBy: scrollCommentThread,
 		},
+		changedFilesModal: {
+			hasResults: changedFileResults.length > 0,
+			closeModal: closeActiveModal,
+			selectFile: selectChangedFile,
+			moveSelection: moveChangedFileSelection,
+		},
+		submitReviewModal: {
+			closeModal: closeActiveModal,
+			submit: confirmSubmitReview,
+			insertNewline: () => editSubmitReview((state) => insertText(state, "\n")),
+			moveActionSelection: moveSubmitReviewActionSelection,
+			moveLeft: () => editSubmitReview(editorMoveLeft),
+			moveRight: () => editSubmitReview(editorMoveRight),
+			moveUp: () => editSubmitReview((state) => moveVertically(state, -1)),
+			moveDown: () => editSubmitReview((state) => moveVertically(state, 1)),
+			moveLineStart: () => editSubmitReview(moveLineStart),
+			moveLineEnd: () => editSubmitReview(moveLineEnd),
+			moveWordBackward: () => editSubmitReview(moveWordBackward),
+			moveWordForward: () => editSubmitReview(moveWordForward),
+			backspace: () => editSubmitReview(editorBackspace),
+			deleteForward: () => editSubmitReview(editorDeleteForward),
+			deleteWordBackward: () => editSubmitReview(deleteWordBackward),
+			deleteWordForward: () => editSubmitReview(deleteWordForward),
+			deleteToLineStart: () => editSubmitReview(deleteToLineStart),
+			deleteToLineEnd: () => editSubmitReview(deleteToLineEnd),
+		},
 		labelModal: {
 			closeModal: closeActiveModal,
 			toggleSelected: toggleLabelAtIndex,
@@ -2151,7 +2311,6 @@ export const App = () => {
 				else runCommandById("diff.close")
 			},
 			openSelectedComment: openSelectedDiffComment,
-			addComment: () => runCommandById("diff.add-comment"),
 			toggleRange: () => runCommandById("diff.toggle-range"),
 			toggleView: () => runCommandById("diff.toggle-view"),
 			toggleWrap: () => runCommandById("diff.toggle-wrap"),
@@ -2162,6 +2321,8 @@ export const App = () => {
 			moveAnchorToBoundary: moveDiffCommentToBoundary,
 			alignAnchor: alignSelectedDiffCommentAnchor,
 			selectSide: selectDiffCommentSide,
+			openChangedFiles: () => runCommandById("diff.changed-files"),
+			openSubmitReview: () => runCommandById("diff.submit-review"),
 			nextFile: () => runCommandById("diff.next-file"),
 			previousFile: () => runCommandById("diff.previous-file"),
 			openInBrowser: () => runCommandById("pull.open-browser"),
@@ -2245,9 +2406,21 @@ export const App = () => {
 			return
 		}
 
+		if (submitReviewModalActive) {
+			const text = printableKeyText(key)
+			if (text) editSubmitReview((state) => insertText(state, text))
+			return
+		}
 
-
-
+		if (changedFilesModalActive) {
+			if (isSingleLineInputKey(key)) {
+				setChangedFilesModal((current) => {
+					const query = editSingleLineInput(current.query, key) ?? current.query
+					return query === current.query ? current : { ...current, query, selectedIndex: 0 }
+				})
+			}
+			return
+		}
 		if (labelModalActive) {
 			if (isSingleLineInputKey(key)) {
 				setLabelModal((current) => ({
@@ -2284,6 +2457,16 @@ export const App = () => {
 	const wideDetailBodyViewportHeight = Math.max(1, wideBodyHeight - wideDetailHeaderHeight)
 	const wideDetailBodyHeight = getScrollableDetailBodyHeight(selectedPullRequest, rightContentWidth, selectedConversationItems, selectedConversationStatus)
 	const wideDetailBodyScrollable = wideDetailBodyHeight > wideDetailBodyViewportHeight
+	const detailJunctions = isSelectedPullRequestDetailLoading ? [] : getDetailJunctionRows({
+		pullRequest: selectedPullRequest,
+		paneWidth: rightPaneWidth,
+		showChecks: true,
+		contentWidth: rightContentWidth,
+		conversationItems: selectedConversationItems,
+		conversationStatus: selectedConversationStatus,
+		bodyScrollTop: detailPreviewScrollTop,
+		bodyViewportHeight: wideDetailBodyViewportHeight,
+	})
 
 	const prListProps = {
 		groups: visibleGroups,
@@ -2305,6 +2488,11 @@ export const App = () => {
 	const labelModalHeight = Math.min(20, terminalHeight - 4)
 	const labelModalLeft = centeredOffset(contentWidth, labelModalWidth)
 	const labelModalTop = centeredOffset(terminalHeight, labelModalHeight)
+	const longestDiffFileName = changedFilesModalActive ? readyDiffFiles.reduce((max, file) => Math.max(max, file.name.length), 0) : 0
+	const changedFilesModalWidth = changedFilesModalActive ? Math.min(Math.max(46, longestDiffFileName + 16), 88, contentWidth - 4) : 46
+	const changedFilesModalHeight = Math.min(22, terminalHeight - 4)
+	const changedFilesModalLeft = centeredOffset(contentWidth, changedFilesModalWidth)
+	const changedFilesModalTop = centeredOffset(terminalHeight, changedFilesModalHeight)
 	const sizedModal = (minW: number, maxW: number, padX: number, maxH: number) => {
 		const w = Math.min(maxW, Math.max(minW, contentWidth - padX))
 		const h = Math.min(maxH, terminalHeight - 4)
@@ -2325,6 +2513,11 @@ export const App = () => {
 	const commentThreadModalHeight = commentThreadLayout.height
 	const commentThreadModalLeft = commentThreadLayout.left
 	const commentThreadModalTop = commentThreadLayout.top
+	const submitReviewLayout = sizedModal(54, 84, 8, 18)
+	const submitReviewModalWidth = submitReviewLayout.width
+	const submitReviewModalHeight = submitReviewLayout.height
+	const submitReviewModalLeft = submitReviewLayout.left
+	const submitReviewModalTop = submitReviewLayout.top
 	const commentAnchorLabel = selectedDiffCommentAnchor && selectedDiffCommentLabel
 		? `${selectedDiffCommentAnchor.path} ${selectedDiffCommentLabel}`
 		: "No diff line selected"
@@ -2470,7 +2663,7 @@ export const App = () => {
 						hasSelection={selectedPullRequest !== null}
 						canCloseSelection={selectedPullRequest?.state === "open"}
 						hasError={pullRequestStatus === "error"}
-						isLoading={pullRequestStatus === "loading" || isRefreshingPullRequests || isHydratingPullRequestDetails || closeModal.running || mergeModal.running}
+						isLoading={pullRequestStatus === "loading" || isRefreshingPullRequests || isHydratingPullRequestDetails || closeModal.running || mergeModal.running || submitReviewModal.running}
 						loadingIndicator={loadingIndicator}
 						retryProgress={retryProgress}
 					/>
@@ -2518,6 +2711,27 @@ export const App = () => {
 					offsetTop={commentThreadModalTop}
 				/>
 			) : null}
+			{changedFilesModalActive ? (
+				<ChangedFilesModal
+					state={changedFilesModal}
+					results={changedFileResults}
+					totalCount={readyDiffFiles.length}
+					modalWidth={changedFilesModalWidth}
+					modalHeight={changedFilesModalHeight}
+					offsetLeft={changedFilesModalLeft}
+					offsetTop={changedFilesModalTop}
+				/>
+			) : null}
+			{submitReviewModalActive ? (
+				<SubmitReviewModal
+					state={submitReviewModal}
+					modalWidth={submitReviewModalWidth}
+					modalHeight={submitReviewModalHeight}
+					offsetLeft={submitReviewModalLeft}
+					offsetTop={submitReviewModalTop}
+					loadingIndicator={loadingIndicator}
+				/>
+			) : null}
 			{mergeModalActive ? (
 				<MergeModal
 					state={mergeModal}

package/src/appCommands.ts

@@ -21,11 +21,13 @@ interface AppCommandActions {
 	readonly toggleDiffRenderView: () => void
 	readonly toggleDiffWrapMode: () => void
 	readonly toggleDiffWhitespaceMode: () => void
+	readonly openChangedFilesModal: () => void
 	readonly jumpDiffFile: (delta: 1 | -1) => void
 	readonly openSelectedDiffComment: () => void
 	readonly toggleDiffCommentRange: () => void
 	readonly moveDiffCommentThread: (delta: 1 | -1) => void
 	readonly openDiffCommentModal: () => void
+	readonly openSubmitReviewModal: () => void
 	readonly togglePullRequestDraftStatus: () => void
 	readonly openLabelModal: () => void
 	readonly openMergeModal: () => void
@@ -99,6 +101,10 @@ export const buildAppCommands = ({
 	const diffThreadReason = diffFullView && diffReady
 		? hasDiffCommentThreads ? null : "No diff comments loaded."
 		: diffOpenReadyReason
+	const changedFilesReason = diffFullView && diffReady
+		? readyDiffFileCount > 0 ? null : "No changed files loaded."
+		: diffOpenReadyReason
+	const submitReviewReason = diffFullView && diffReady ? noOpenPullRequestReason : diffOpenReadyReason
 	const loadMoreDisabledReason = isLoadingMorePullRequests
 		? "Already loading more pull requests."
 		: hasMorePullRequests ? null : "No more pull requests loaded by this view."
@@ -256,13 +262,23 @@ export const buildAppCommands = ({
 			keywords: ["whitespace", "spacing", "ignore", "show"],
 			run: actions.toggleDiffWhitespaceMode,
 		}),
+		defineCommand({
+			id: "diff.changed-files",
+			title: "Open changed files navigator",
+			scope: "Diff",
+			subtitle: readyDiffFileCount > 0 ? `${readyDiffFileCount} changed files` : "No diff files loaded",
+			shortcut: "f",
+			disabledReason: changedFilesReason,
+			keywords: ["files", "navigator", "search"],
+			run: actions.openChangedFilesModal,
+		}),
 		defineCommand({
 			id: "diff.next-file",
 			title: "Next diff file",
 			scope: "Diff",
 			subtitle: readyDiffFileCount > 0 ? `${diffFileIndex + 1}/${readyDiffFileCount}` : "No diff files loaded",
 			shortcut: "]",
-			disabledReason: diffFullView && readyDiffFileCount > 0 ? null : diffOpenReadyReason,
+			disabledReason: changedFilesReason,
 			run: () => actions.jumpDiffFile(1),
 		}),
 		defineCommand({
@@ -271,7 +287,7 @@ export const buildAppCommands = ({
 			scope: "Diff",
 			subtitle: readyDiffFileCount > 0 ? `${diffFileIndex + 1}/${readyDiffFileCount}` : "No diff files loaded",
 			shortcut: "[",
-			disabledReason: diffFullView && readyDiffFileCount > 0 ? null : diffOpenReadyReason,
+			disabledReason: changedFilesReason,
 			run: () => actions.jumpDiffFile(-1),
 		}),
 		defineCommand({
@@ -319,11 +335,20 @@ export const buildAppCommands = ({
 			title: "Add comment on selected diff line",
 			scope: "Diff",
 			subtitle: selectedDiffCommentAnchorLabel ?? "No diff line selected",
-			shortcut: "a",
 			disabledReason: selectedDiffLineReason,
 			keywords: ["review", "reply"],
 			run: actions.openDiffCommentModal,
 		}),
+		defineCommand({
+			id: "diff.submit-review",
+			title: "Submit pull request review",
+			scope: "Diff",
+			subtitle: selectedPullRequestLabel,
+			shortcut: "R",
+			disabledReason: submitReviewReason,
+			keywords: ["review", "approve", "request changes"],
+			run: actions.openSubmitReviewModal,
+		}),
 		forSelected({
 			id: "pull.toggle-draft",
 			title: selectedPullRequest?.reviewStatus === "draft" ? "Mark ready for review" : "Mark as draft",

package/src/config.ts

@@ -5,10 +5,6 @@ const positiveIntOr = (fallback: number) => (value: number) => Number.isFinite(v
 const pageSizeOr = (fallback: number) => (value: number) => Math.min(100, positiveIntOr(fallback)(value))
 
 const appConfig = Config.all({
-	author: Config.string("GHUI_AUTHOR").pipe(
-		Config.withDefault("@me"),
-		Config.map((value) => value.trim() || "@me"),
-	),
 	prFetchLimit: Config.int("GHUI_PR_FETCH_LIMIT").pipe(
 		Config.withDefault(200),
 		Config.map(positiveIntOr(200)),
@@ -17,10 +13,6 @@ const appConfig = Config.all({
 		Config.withDefault(50),
 		Config.map(pageSizeOr(50)),
 	),
-	repository: Config.string("GHUI_REPO").pipe(
-		Config.withDefault(""),
-		Config.map((value) => value.trim() || null),
-	),
 })
 
 export const config = Effect.runSync(Effect.gen(function*() {