@kinora/reporter 0.2.0 → 0.4.0

package/README.md

@@ -1,8 +1,8 @@
 # @kinora/reporter
 
-Playwright reporter that uploads your test results to a [kinora](https://github.com/joris-gallot/kinora) server: pass rates, trends, flaky tests, and the full Playwright trace for failures, across projects and over time.
+Playwright reporter that uploads your test results to a [kinora](https://github.com/kinora-dev/kinora) server: pass rates, trends, flaky tests, and the full Playwright trace for failures, across projects and over time.
 
-It runs on `onEnd`, posts the normalized run, then uploads the trace.zip for each failed/flaky test that has one. Upload never fails your test run.
+It runs on `onEnd`, posts the normalized run, then uploads the trace.zip for each test that produced one (videos and screenshots too, see below). Upload never fails your test run.
 
 ## Install
 
@@ -33,68 +33,28 @@ The token comes from the environment (keep it out of the config file); the serve
 KINORA_TOKEN=<token> npx playwright test
 ```
 
-Create an API token in the kinora dashboard (Settings → Workspace). Self-hosting? Point at your server with `KINORA_URL` - see [selfhost/README.md](https://github.com/joris-gallot/kinora/blob/main/selfhost/README.md).
+Create an API token in the kinora dashboard (Settings → Workspace). Self-hosting? Point at your server with `KINORA_URL`.
 
-## Options
+## Videos and screenshots without tracing
 
-```ts
-[
-  '@kinora/reporter',
-  {
-    project: { slug: 'web-app', name: 'Web App' },
-  },
-]
-```
-
-| Option    | Type                                 | Default                      | Description                                |
-| --------- | ------------------------------------ | ---------------------------- | ------------------------------------------ |
-| `project` | `{ slug: string, name?: string }`    | required                     | Target project. `name` defaults to `slug`. |
-| `url`     | `string`                             | env `KINORA_URL`, then cloud | kinora server base URL. Set for self-host. |
-| `token`   | `string`                             | env `KINORA_TOKEN`           | Project API token. Prefer the env var.     |
-| `git`     | `{ sha?, branch?, baseBranch?, repoUrl? }` | auto on GitHub Actions | Git metadata. `repoUrl` links a sha to its commit; `baseBranch` powers "regression vs base" in the PR comment. |
-| `ci`      | `{ provider?, runUrl?, runNumber? }` | auto on GitHub Actions       | CI metadata for the run.                   |
-| `prComment` | `boolean \| { label?, policy? }`   | off                          | Post/update a summary comment on the GitHub PR (see below). |
-
-On GitHub Actions, `git` and `ci` are filled from the standard `GITHUB_*` env vars (including the repo URL, so shas link to their commit in the dashboard). Pass them explicitly on other CI providers.
-
-## GitHub PR comment
-
-On a `pull_request` run, the reporter can post (and keep updating) a summary comment on the PR: pass/fail counts, tests newly failing vs the base branch, and a link to the run. It uses the job's ambient `GITHUB_TOKEN`, so no credentials are stored in kinora.
+Traces are uploaded by default, and Playwright already embeds a test's screenshots and video
+inside its trace.zip. If you run without tracing, upload them on their own:
 
 ```ts
-reporter: [['@kinora/reporter', { project: { slug: 'web-app' }, prComment: true }]]
+reporter: [['@kinora/reporter', {
+  project: { slug: 'web-app' },
+  uploadAttachments: ['trace', 'video', 'screenshot'],
+}]]
 ```
 
-The workflow must grant write access to PRs:
+Kinora uploads whatever Playwright attached, so `screenshot: 'only-on-failure'` and
+`video: 'retain-on-failure'` keep deciding what exists in the first place.
 
-```yaml
-# in your workflow job:
-permissions:
-  pull-requests: write # required for the PR comment
-steps:
-  - run: npx playwright test
-    env:
-      KINORA_TOKEN: ${{ secrets.KINORA_TOKEN }}
-```
-
-- Same-repo PRs only: `GITHUB_TOKEN` is read-only on fork PRs, so the comment is skipped there.
-- Shard your run with `merge-reports` (blob report) so one merged run posts one comment; per-shard runs are skipped.
-- Matrix builds sharing a PR: set `prComment: { label: 'node20' }` so each leg keeps its own comment.
-- `policy: 'on-failure'` skips the comment on green runs (default posts always).
-
-## CI example (GitHub Actions)
-
-```yaml
-- run: npx playwright test
-  env:
-    KINORA_TOKEN: ${{ secrets.KINORA_TOKEN }}
-```
+## Documentation
 
-## Notes
+Full reporter options, GitHub PR comments, CI examples, and self-hosting are in the docs:
 
-- If `KINORA_TOKEN` is missing, the reporter logs a warning and skips the upload, so local runs aren't affected. `KINORA_URL` is optional (defaults to the hosted cloud).
-- Traces are uploaded only for tests that produced one, so enable `trace` in your Playwright config (`on-first-retry`, `retain-on-failure`, etc.).
-- Cross-run test identity is the file + title path + Playwright project name, so history stays stable as long as those don't change.
+**https://docs.kinora.dev/guides/reporter/**
 
 ## License
 

package/dist/index.d.mts

@@ -1,6 +1,5 @@
-import { CiMeta, GitMeta } from "@kinora/core";
+import { AttachmentKind, CiMeta, GitMeta } from "@kinora/core";
 import { FullConfig, FullResult, Reporter, Suite } from "@playwright/test/reporter";
-
 //#region src/index.d.ts
 interface KinoraReporterOptions {
   /** kinora server base URL. Defaults to env KINORA_URL, then the hosted cloud. Set for self-host. */
@@ -22,6 +21,12 @@ interface KinoraReporterOptions {
     label?: string;
     policy?: 'always' | 'on-failure';
   };
+  /**
+   * Which attachment kinds to upload. Defaults to `['trace']`. Add `'video'` / `'screenshot'`
+   * to host them on their own, which is what you want when `trace` is off (with tracing on,
+   * Playwright already embeds them in the trace.zip).
+   */
+  uploadAttachments?: AttachmentKind[];
 }
 declare class KinoraReporter implements Reporter {
   private readonly options;

package/dist/index.mjs

@@ -1,7 +1,7 @@
 import { readFileSync } from "node:fs";
 import { readFile } from "node:fs/promises";
 import process from "node:process";
-import { DEFAULT_KINORA_URL, IngestError, createIngestClient, effectiveAttachments, isTraceAttachment, makeTestKey, postPrComment, resolvePrContext } from "@kinora/core";
+import { DEFAULT_KINORA_URL, DEFAULT_UPLOAD_ATTACHMENTS, IngestError, createIngestClient, detectCiEnv, effectiveAttachments, isUploadableAttachment, makeTestKey, postPrComment, resolvePrContext } from "@kinora/core";
 //#region src/index.ts
 function identity(test) {
 	let file = "";
@@ -68,29 +68,6 @@ function countsOf(tests) {
 	for (const t of tests) counts[t.status]++;
 	return counts;
 }
-function detectGit() {
-	const sha = process.env.GITHUB_SHA;
-	const branch = process.env.GITHUB_REF_NAME;
-	const baseBranch = process.env.GITHUB_BASE_REF || void 0;
-	const { GITHUB_SERVER_URL, GITHUB_REPOSITORY } = process.env;
-	const repoUrl = GITHUB_SERVER_URL && GITHUB_REPOSITORY ? `${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}` : void 0;
-	if (!sha && !branch && !repoUrl) return void 0;
-	return {
-		sha,
-		branch,
-		baseBranch,
-		repoUrl
-	};
-}
-function detectCi() {
-	if (!process.env.GITHUB_ACTIONS) return void 0;
-	const { GITHUB_SERVER_URL, GITHUB_REPOSITORY, GITHUB_RUN_ID, GITHUB_RUN_NUMBER } = process.env;
-	return {
-		provider: "github",
-		runUrl: GITHUB_SERVER_URL && GITHUB_REPOSITORY && GITHUB_RUN_ID ? `${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}` : void 0,
-		runNumber: GITHUB_RUN_NUMBER
-	};
-}
 var KinoraReporter = class {
 	options;
 	suite;
@@ -110,6 +87,7 @@ var KinoraReporter = class {
 			return;
 		}
 		const tests = (this.suite?.allTests() ?? []).map(toNormTest);
+		const detected = detectCiEnv(process.env);
 		const payload = {
 			project: {
 				slug: this.options.project.slug,
@@ -120,8 +98,8 @@ var KinoraReporter = class {
 				duration: result.duration,
 				counts: countsOf(tests),
 				playwrightVersion: this.config?.version,
-				git: this.options.git ?? detectGit(),
-				ci: this.options.ci ?? detectCi()
+				git: this.options.git ?? detected.git,
+				ci: this.options.ci ?? detected.ci
 			},
 			tests
 		};
@@ -132,9 +110,10 @@ var KinoraReporter = class {
 				regression: !!this.options.prComment
 			});
 			const res = await client.uploadRun(payload);
-			let traces = 0;
+			const kinds = this.options.uploadAttachments ?? DEFAULT_UPLOAD_ATTACHMENTS;
+			let artifacts = 0;
 			for (const t of tests) for (const a of t.attachments) {
-				if (!a.path || !isTraceAttachment(a)) continue;
+				if (!a.path || !isUploadableAttachment(a, kinds)) continue;
 				try {
 					await client.uploadArtifact({
 						runId: res.runId,
@@ -143,12 +122,12 @@ var KinoraReporter = class {
 						contentType: a.contentType,
 						body: await readFile(a.path)
 					});
-					traces++;
+					artifacts++;
 				} catch (err) {
-					console.warn(`[kinora] trace upload failed for ${t.testKey}:`, err instanceof Error ? err.message : err);
+					console.warn(`[kinora] ${a.name} upload failed for ${t.testKey}:`, err instanceof Error ? err.message : err);
 				}
 			}
-			console.log(`[kinora] uploaded ${res.tests} tests + ${traces} traces (run ${res.runId})`);
+			console.log(`[kinora] uploaded ${res.tests} tests + ${artifacts} artifacts (run ${res.runId})`);
 			await this.maybePostPrComment(payload, res);
 		} catch (err) {
 			if (err instanceof IngestError && err.status === 402) console.warn(`[kinora] ${err.message}`);
@@ -161,10 +140,11 @@ var KinoraReporter = class {
 		const label = typeof opt === "object" ? opt.label : void 0;
 		const policy = typeof opt === "object" ? opt.policy : void 0;
 		try {
-			const ctx = resolvePrContext(this.config?.shard ? {
+			const env = this.config?.shard ? {
 				...process.env,
 				__KINORA_IS_SHARD: "1"
-			} : process.env, (p) => {
+			} : process.env;
+			const ctx = resolvePrContext(env, (p) => {
 				try {
 					return readFileSync(p, "utf8");
 				} catch {

package/package.json

@@ -1,17 +1,17 @@
 {
   "name": "@kinora/reporter",
   "type": "module",
-  "version": "0.2.0",
+  "version": "0.4.0",
   "description": "Playwright reporter that uploads test results to a kinora server",
   "author": "Joris Gallot",
   "license": "MIT",
-  "homepage": "https://github.com/joris-gallot/kinora#readme",
+  "homepage": "https://github.com/kinora-dev/kinora#readme",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/joris-gallot/kinora.git",
+    "url": "git+https://github.com/kinora-dev/kinora.git",
     "directory": "packages/reporter"
   },
-  "bugs": "https://github.com/joris-gallot/kinora/issues",
+  "bugs": "https://github.com/kinora-dev/kinora/issues",
   "keywords": [
     "playwright",
     "reporter",
@@ -36,15 +36,15 @@
     "@playwright/test": ">=1.40.0"
   },
   "dependencies": {
-    "@kinora/core": "0.2.0"
+    "@kinora/core": "0.4.0"
   },
   "devDependencies": {
-    "@playwright/test": "^1.61.0",
-    "@types/node": "^26.0.0",
-    "@vitest/coverage-v8": "^4.1.9",
-    "tsdown": "^0.22.3",
+    "@playwright/test": "^1.63.0",
+    "@types/node": "^26.5.1",
+    "@vitest/coverage-v8": "^4.1.11",
+    "tsdown": "^0.22.14",
     "typescript": "~6.0.3",
-    "vitest": "^4.1.9"
+    "vitest": "^4.1.11"
   },
   "scripts": {
     "build": "tsdown",