@kici-dev/compiler 0.1.27 → 0.3.0

package/dist/validation/typecheck.js

@@ -0,0 +1,110 @@
+import "../rolldown-runtime-ClRpJifh.js";
+import { compilerError } from "../errors/formatter.js";
+import "../errors/index.js";
+import path from "node:path";
+import { existsSync } from "node:fs";
+import { $ } from "zx";
+import { initZx } from "@kici-dev/core";
+//#region src/validation/typecheck.ts
+initZx();
+/** `path(line,col): error TSxxxx: message` — a located tsc diagnostic. */
+const TSC_LOCATED_RE = /^(.+?)\((\d+),(\d+)\): error (TS\d+): (.+)$/;
+/** `error TSxxxx: message` — a global tsc diagnostic (config errors, etc.). */
+const TSC_GLOBAL_RE = /^error (TS\d+): (.+)$/;
+/**
+* Turn `tsc --noEmit --pretty false` output into located `E120` compiler errors.
+* Handles both located diagnostics (`file(line,col): error TS…`) and global
+* ones (`error TS…`, e.g. a bad tsconfig). Non-diagnostic noise lines are
+* ignored. Paths are left as tsc emits them (kiciDir-relative), readable in the
+* GNU error format.
+*/
+function parseTscOutput(stdout) {
+	const errors = [];
+	for (const raw of stdout.split("\n")) {
+		const line = raw.trim();
+		const located = TSC_LOCATED_RE.exec(line);
+		if (located) {
+			const [, file, lineStr, colStr, tsCode, message] = located;
+			const location = {
+				file,
+				line: parseInt(lineStr, 10),
+				column: parseInt(colStr, 10)
+			};
+			errors.push(compilerError("E120", `${tsCode}: ${message}`, {
+				location,
+				suggestion: "Fix the type error in your workflow source."
+			}));
+			continue;
+		}
+		const global = TSC_GLOBAL_RE.exec(line);
+		if (global) {
+			const [, tsCode, message] = global;
+			errors.push(compilerError("E120", `${tsCode}: ${message}`, { suggestion: "Fix the type error in your workflow source." }));
+		}
+	}
+	return errors;
+}
+/** The E121 "compiler could not be resolved" error. */
+function typecheckUnavailable() {
+	return compilerError("E121", "Type-check unavailable: could not resolve the TypeScript compiler", { suggestion: "Add \"typescript\" to your .kici/package.json devDependencies (kici init scaffolds it), then reinstall." });
+}
+/**
+* Run an opt-in `tsc --noEmit` type-check over the workflow sources in
+* `kiciDir`. Skips (returns `ran: false`) when there is no `tsconfig.json`.
+* Prefers the workspace-local `tsc` binary, falling back to `npx typescript`;
+* returns a single `E121` when the compiler cannot be resolved.
+*/
+async function runTypecheck(kiciDir) {
+	const tsconfigPath = path.join(kiciDir, "tsconfig.json");
+	if (!existsSync(tsconfigPath)) return {
+		ran: false,
+		errors: []
+	};
+	const localBin = path.join(kiciDir, "node_modules", ".bin", "tsc");
+	const usedLocal = existsSync(localBin);
+	const invocation = usedLocal ? [localBin] : [
+		"npx",
+		"--yes",
+		"-p",
+		"typescript",
+		"tsc"
+	];
+	const tscArgs = [
+		"--noEmit",
+		"--pretty",
+		"false",
+		"-p",
+		tsconfigPath
+	];
+	let out;
+	try {
+		out = await $({
+			cwd: kiciDir,
+			nothrow: true
+		})`${invocation} ${tscArgs}`;
+	} catch {
+		return {
+			ran: true,
+			errors: [typecheckUnavailable()]
+		};
+	}
+	const errors = parseTscOutput(out.stdout);
+	if (out.exitCode !== 0 && errors.length === 0) {
+		if (!usedLocal) return {
+			ran: true,
+			errors: [typecheckUnavailable()]
+		};
+		return {
+			ran: true,
+			errors: [compilerError("E120", `type-check failed: ${(out.stderr || out.stdout).trim()}`, { suggestion: "Fix the type error in your workflow source." })]
+		};
+	}
+	return {
+		ran: true,
+		errors
+	};
+}
+//#endregion
+export { parseTscOutput, runTypecheck };
+
+//# sourceMappingURL=typecheck.js.map

package/dist/validation/validator.d.ts

@@ -1,5 +1,5 @@
-import type { Workflow } from '@kici-dev/sdk';
 import { type CompilerError } from '../errors/index.js';
+import type { WorkflowWithSource } from '../types.js';
 /**
  * Validation result - either success or list of errors.
  */
@@ -18,9 +18,14 @@ export type ValidationResult = {
  * 3. Job dependencies are valid (exist, no cycles, no self-refs)
  * 4. Static matrix expansions stay under 256 job limit
  *
- * @param workflows - Array of workflows from config
- * @param configPath - Path for error location reporting
+ * Each error carries the most precise `file:line:column` the data allows: a
+ * job-scoped error anchors to the offending job's first step location (real
+ * file + real line), falling back to the workflow's source file at line 1 when
+ * no step exists; a workflow-scoped error uses the workflow source file (line 1,
+ * since `workflow()` captures no call-site).
+ *
+ * @param workflows - Source-carrying workflows from discovery
  * @returns Validation result with errors if any
  */
-export declare function validateConfig(workflows: Workflow[], configPath: string): ValidationResult;
+export declare function validateConfig(workflows: WorkflowWithSource[]): ValidationResult;
 //# sourceMappingURL=validator.d.ts.map

package/dist/validation/validator.js

@@ -1,5 +1,6 @@
 import "../rolldown-runtime-ClRpJifh.js";
 import { compilerError } from "../errors/formatter.js";
+import { locationForJob, locationForWorkflow } from "../errors/source-location.js";
 import "../errors/index.js";
 import { getDynamicJobGroup, isDynamicGroupRef, isDynamicJobFn, isStaticArray, isStaticObject, validateDag } from "@kici-dev/sdk";
 //#region src/validation/validator.ts
@@ -14,28 +15,26 @@ const MAX_STATIC_MATRIX_JOBS = 256;
 * 3. Job dependencies are valid (exist, no cycles, no self-refs)
 * 4. Static matrix expansions stay under 256 job limit
 *
-* @param workflows - Array of workflows from config
-* @param configPath - Path for error location reporting
+* Each error carries the most precise `file:line:column` the data allows: a
+* job-scoped error anchors to the offending job's first step location (real
+* file + real line), falling back to the workflow's source file at line 1 when
+* no step exists; a workflow-scoped error uses the workflow source file (line 1,
+* since `workflow()` captures no call-site).
+*
+* @param workflows - Source-carrying workflows from discovery
 * @returns Validation result with errors if any
 */
-function validateConfig(workflows, configPath) {
+function validateConfig(workflows) {
 	const errors = [];
 	const workflowNames = /* @__PURE__ */ new Set();
-	for (const workflow of workflows) {
+	for (const { workflow, source } of workflows) {
 		if (workflowNames.has(workflow.name)) errors.push(compilerError("E107", `Duplicate workflow name: "${workflow.name}"`, {
-			location: {
-				file: configPath,
-				line: 1,
-				column: 1
-			},
+			location: locationForWorkflow(source.file),
 			suggestion: "Each workflow must have a unique name"
 		}));
 		workflowNames.add(workflow.name);
 	}
-	for (const workflow of workflows) {
-		const workflowErrors = validateWorkflow(workflow, configPath);
-		errors.push(...workflowErrors);
-	}
+	for (const { workflow, source } of workflows) errors.push(...validateWorkflow(workflow, source.file));
 	if (errors.length > 0) return {
 		valid: false,
 		errors
@@ -45,18 +44,22 @@ function validateConfig(workflows, configPath) {
 /**
 * Validate a single workflow.
 */
-function validateWorkflow(workflow, configPath) {
+function validateWorkflow(workflow, workflowFile) {
 	const errors = [];
 	const staticJobs = [];
 	for (const jobOrFactory of workflow.jobs) if (!isDynamicJobFn(jobOrFactory)) staticJobs.push(jobOrFactory);
+	const jobLoc = (name) => {
+		const j = staticJobs.find((s) => s.name === name);
+		return j ? locationForJob(j, workflowFile) : {
+			file: workflowFile,
+			line: 1,
+			column: 1
+		};
+	};
 	const jobNames = /* @__PURE__ */ new Set();
 	for (const job of staticJobs) {
 		if (jobNames.has(job.name)) errors.push(compilerError("E106", `Duplicate job name "${job.name}" in workflow "${workflow.name}"`, {
-			location: {
-				file: configPath,
-				line: 1,
-				column: 1
-			},
+			location: locationForJob(job, workflowFile),
 			suggestion: "Each job in a workflow must have a unique name"
 		}));
 		jobNames.add(job.name);
@@ -66,19 +69,26 @@ function validateWorkflow(workflow, configPath) {
 		const groupName = getDynamicJobGroup(jobOrFactory);
 		if (groupName) dynamicGroupNames.add(groupName);
 	}
-	const dagErrors = validateJobDag(staticJobs, workflow.name, configPath, dynamicGroupNames);
+	const dagErrors = validateJobDag(staticJobs, workflow.name, jobLoc, dynamicGroupNames);
 	errors.push(...dagErrors);
 	for (const job of staticJobs) {
-		const matrixErrors = validateStaticMatrix(job, workflow.name, configPath);
+		const matrixErrors = validateStaticMatrix(job, workflow.name, workflowFile);
 		errors.push(...matrixErrors);
 	}
 	return errors;
 }
 /**
+* Best location for a DAG node id: strip the synthetic `__group:` prefix (which
+* has no backing Job) and resolve via the job-location lookup.
+*/
+function dagNodeLocation(nodeId, jobLoc) {
+	return jobLoc(nodeId.startsWith("__group:") ? nodeId.slice(8) : nodeId);
+}
+/**
 * Validate job dependency DAG.
 * Includes synthetic __group: nodes for tagged dynamic job functions ( Layer 1).
 */
-function validateJobDag(jobs, workflowName, configPath, dynamicGroupNames) {
+function validateJobDag(jobs, workflowName, jobLoc, dynamicGroupNames) {
 	const errors = [];
 	const dagNodes = jobs.map((job) => ({
 		id: job.name,
@@ -91,32 +101,20 @@ function validateJobDag(jobs, workflowName, configPath, dynamicGroupNames) {
 	const result = validateDag(dagNodes);
 	if (!result.valid) switch (result.error) {
 		case "cycle":
-			errors.push(compilerError("E102", `Circular dependency in workflow "${workflowName}": ${result.nodesInCycle.join(" -> ")}`, {
-				location: {
-					file: configPath,
-					line: 1,
-					column: 1
-				},
+			errors.push(compilerError("E102", `Circular dependency in workflow "${workflowName}": ${result.nodesInCycle.join(", ")}`, {
+				location: dagNodeLocation(result.nodesInCycle[0] ?? "", jobLoc),
 				suggestion: "Break the cycle by removing one of the dependencies"
 			}));
 			break;
 		case "self-reference":
 			errors.push(compilerError("E103", `Job "${result.nodeId}" in workflow "${workflowName}" depends on itself`, {
-				location: {
-					file: configPath,
-					line: 1,
-					column: 1
-				},
+				location: dagNodeLocation(result.nodeId, jobLoc),
 				suggestion: "Remove the self-dependency"
 			}));
 			break;
 		case "missing-dependency":
 			errors.push(compilerError("E101", `Job "${result.nodeId}" in workflow "${workflowName}" depends on non-existent job "${result.missingDep}"`, {
-				location: {
-					file: configPath,
-					line: 1,
-					column: 1
-				},
+				location: dagNodeLocation(result.nodeId, jobLoc),
 				suggestion: `Create a job named "${result.missingDep}" or fix the dependency name`
 			}));
 			break;
@@ -140,7 +138,7 @@ function resolveNeeds(needs) {
 /**
 * Validate static matrix doesn't exceed job limit.
 */
-function validateStaticMatrix(job, workflowName, configPath) {
+function validateStaticMatrix(job, workflowName, workflowFile) {
 	const errors = [];
 	if (!job.matrix) return errors;
 	if (typeof job.matrix === "function") return errors;
@@ -149,11 +147,7 @@ function validateStaticMatrix(job, workflowName, configPath) {
 	else if (isStaticObject(job.matrix)) expansionCount = Object.values(job.matrix).reduce((acc, dimension) => acc * dimension.length, 1);
 	if (job.include) expansionCount += job.include.length;
 	if (expansionCount > MAX_STATIC_MATRIX_JOBS) errors.push(compilerError("E104", `Static matrix for job "${job.name}" in workflow "${workflowName}" would generate ${expansionCount} jobs (max: ${MAX_STATIC_MATRIX_JOBS})`, {
-		location: {
-			file: configPath,
-			line: 1,
-			column: 1
-		},
+		location: locationForJob(job, workflowFile),
 		suggestion: "Reduce matrix dimensions or use exclude patterns to limit combinations"
 	}));
 	return errors;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kici-dev/compiler",
-  "version": "0.1.27",
+  "version": "0.3.0",
   "description": "Compiler and CLI for KiCI workflows. Compiles `.kici/workflows/*.ts` to a `kici.lock.json` file consumed by the orchestrator and agents, and runs workflows locally or against a remote orchestrator.",
   "keywords": [
     "ci",
@@ -53,29 +53,26 @@
     "fast-glob": "^3.3.3",
     "open": "^11.0.0",
     "picocolors": "^1.1.1",
-    "picomatch": "^4.0.4",
-    "proper-lockfile": "^4.1.2",
-    "tar": "^7.5.16",
+    "picomatch": "^4.0.5",
+    "tar": "^7.5.20",
     "typescript": "^6.0.3",
-    "ws": "^8.21.0",
+    "ws": "^8.21.1",
+    "wsl-utils": "^0.3.0",
     "yaml": "^2.9.0",
     "zod": "^4.4.3",
     "zx": "^8.8.5",
-    "@kici-dev/orchestrator": "0.1.27",
-    "@kici-dev/core": "0.1.27",
-    "@kici-dev/agent": "0.1.27",
-    "@kici-dev/engine": "0.1.27"
+    "@kici-dev/agent": "0.3.0",
+    "@kici-dev/engine": "0.3.0",
+    "@kici-dev/orchestrator": "0.3.0",
+    "@kici-dev/core": "0.3.0"
   },
   "peerDependencies": {
-    "@kici-dev/sdk": "0.1.27"
-  },
-  "devDependencies": {
-    "@types/proper-lockfile": "^4.1.4"
+    "@kici-dev/sdk": "0.3.0"
   },
   "scripts": {
-    "build": "node ../../scripts/build-ts.mjs && tsc --emitDeclarationOnly",
+    "build": "node ../../scripts/build-ts.mjs && tsgo --emitDeclarationOnly",
     "postbuild": "zx hack/postbuild.mjs",
-    "typecheck": "tsc --noEmit",
+    "typecheck": "tsgo --noEmit",
     "test": "vitest run",
     "test:watch": "vitest",
     "postinstall": "node hack/postinstall.mjs"