@khoavu882/doflow 0.0.0-stage → 2.0.0-beta.3

package/core/shared/skills/do-code-review/expected_outputs/sample_c_smells_quality.json

@@ -0,0 +1,169 @@
+{
+  "file": "assets/sample_c_smells.c",
+  "language": "c",
+  "metrics": {
+    "lines": {
+      "total": 67,
+      "code": 37,
+      "blank": 17,
+      "comment": 13
+    },
+    "functions": 4,
+    "classes": 0,
+    "avg_complexity": 2.0
+  },
+  "quality_score": 4,
+  "grade": "F",
+  "smells": [
+    {
+      "type": "long_function",
+      "severity": "medium",
+      "message": "Function 'unsafe_input' has 53 lines (max: 50)",
+      "location": "unsafe_input"
+    },
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 242 should be a named constant",
+      "location": "line 17"
+    },
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 100 should be a named constant",
+      "location": "line 27"
+    },
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 134 should be a named constant",
+      "location": "line 31"
+    },
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 120 should be a named constant",
+      "location": "line 35"
+    },
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 690 should be a named constant",
+      "location": "line 41"
+    },
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 416 should be a named constant",
+      "location": "line 47"
+    },
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 100 should be a named constant",
+      "location": "line 62"
+    },
+    {
+      "type": "c_banned_gets",
+      "severity": "high",
+      "message": "'gets()' is unsafe: no bounds check, removed from C11 (CWE-242)",
+      "location": "offset 117"
+    },
+    {
+      "type": "c_banned_strcpy",
+      "severity": "high",
+      "message": "'strcpy()' is unsafe: no bounds check \u2014 prefer strncpy or strlcpy",
+      "location": "offset 157"
+    },
+    {
+      "type": "c_banned_strcpy",
+      "severity": "high",
+      "message": "'strcpy()' is unsafe: no bounds check \u2014 prefer strncpy or strlcpy",
+      "location": "offset 447"
+    },
+    {
+      "type": "c_banned_strcat",
+      "severity": "high",
+      "message": "'strcat()' is unsafe: no bounds check \u2014 prefer strncat or strlcat",
+      "location": "offset 186"
+    },
+    {
+      "type": "c_banned_sprintf",
+      "severity": "high",
+      "message": "'sprintf()' is unsafe: no bounds check \u2014 prefer snprintf",
+      "location": "offset 238"
+    },
+    {
+      "type": "c_format_string",
+      "severity": "high",
+      "message": "'printf(buf)' uses a non-literal format string \u2014 CWE-134 format string vulnerability",
+      "location": "offset 284"
+    },
+    {
+      "type": "c_unbounded_scanf",
+      "severity": "high",
+      "message": "scanf '%s' without a width specifier \u2014 unbounded read can overflow the destination buffer",
+      "location": "offset 326"
+    },
+    {
+      "type": "c_malloc_unchecked",
+      "severity": "medium",
+      "message": "'buf' from malloc/calloc/realloc is not NULL-checked within 5 lines \u2014 dereferencing NULL is UB (CWE-690)",
+      "location": "line 36"
+    },
+    {
+      "type": "c_free_without_null",
+      "severity": "low",
+      "message": "'free(buf)' not followed by 'buf = NULL;' \u2014 dangling pointer can be reused (CWE-416)",
+      "location": "line 42"
+    },
+    {
+      "type": "c_system_non_literal",
+      "severity": "high",
+      "message": "'system(cmd_from_user)' with a non-literal argument \u2014 command injection (CWE-78); use execve with validated args",
+      "location": "offset 571"
+    }
+  ],
+  "solid_violations": [],
+  "function_details": [
+    {
+      "name": "unsafe_input",
+      "parameters": 1,
+      "lines": 53,
+      "complexity": 2
+    },
+    {
+      "name": "leaky_alloc",
+      "parameters": 1,
+      "lines": 27,
+      "complexity": 2
+    },
+    {
+      "name": "run_user_cmd",
+      "parameters": 1,
+      "lines": 14,
+      "complexity": 2
+    },
+    {
+      "name": "main",
+      "parameters": 2,
+      "lines": 8,
+      "complexity": 2
+    }
+  ],
+  "class_details": [],
+  "policy": {
+    "tiers": [
+      "built-in",
+      "review-policy.json"
+    ],
+    "thresholds": {
+      "long_function_lines": 50,
+      "too_many_parameters": 5,
+      "high_complexity": 10,
+      "god_class_methods": 20,
+      "max_imports": 15,
+      "max_declarative_depth": 8
+    }
+  }
+}

package/core/shared/skills/do-code-review/expected_outputs/sample_cpp_shift_quality.json

@@ -0,0 +1,49 @@
+{
+  "file": "assets/sample_cpp_shift.cpp",
+  "language": "cpp",
+  "metrics": {
+    "lines": {
+      "total": 20,
+      "code": 13,
+      "blank": 2,
+      "comment": 5
+    },
+    "functions": 1,
+    "classes": 0,
+    "avg_complexity": 7.0
+  },
+  "quality_score": 100,
+  "grade": "A",
+  "smells": [
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 100 should be a named constant",
+      "location": "line 9"
+    }
+  ],
+  "solid_violations": [],
+  "function_details": [
+    {
+      "name": "report",
+      "parameters": 1,
+      "lines": 13,
+      "complexity": 7
+    }
+  ],
+  "class_details": [],
+  "policy": {
+    "tiers": [
+      "built-in",
+      "review-policy.json"
+    ],
+    "thresholds": {
+      "long_function_lines": 50,
+      "too_many_parameters": 5,
+      "high_complexity": 10,
+      "god_class_methods": 20,
+      "max_imports": 15,
+      "max_declarative_depth": 8
+    }
+  }
+}

package/core/shared/skills/do-code-review/expected_outputs/sample_csharp_clean_quality.json

@@ -0,0 +1,149 @@
+{
+  "file": "assets/sample_csharp_clean.cs",
+  "language": "csharp",
+  "metrics": {
+    "lines": {
+      "total": 101,
+      "code": 67,
+      "blank": 14,
+      "comment": 20
+    },
+    "functions": 13,
+    "classes": 3,
+    "avg_complexity": 1.2
+  },
+  "quality_score": 98,
+  "grade": "A",
+  "smells": [
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System;' appears unused",
+      "location": "System"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System.Net.Http;' appears unused",
+      "location": "System.Net.Http"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System.Threading.Tasks;' appears unused",
+      "location": "System.Threading.Tasks"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System.Data.SqlClient;' appears unused",
+      "location": "System.Data.SqlClient"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using Microsoft.Extensions.Logging;' appears unused",
+      "location": "Microsoft.Extensions.Logging"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using Microsoft.Extensions.Options;' appears unused",
+      "location": "Microsoft.Extensions.Options"
+    }
+  ],
+  "solid_violations": [],
+  "function_details": [
+    {
+      "name": "HttpClient",
+      "parameters": 0,
+      "lines": 1,
+      "complexity": 1
+    },
+    {
+      "name": "UserService",
+      "parameters": 3,
+      "lines": 6,
+      "complexity": 1
+    },
+    {
+      "name": "Task",
+      "parameters": 1,
+      "lines": 1,
+      "complexity": 2
+    },
+    {
+      "name": "HandleClickAsync",
+      "parameters": 0,
+      "lines": 6,
+      "complexity": 1
+    },
+    {
+      "name": "FetchAsync",
+      "parameters": 0,
+      "lines": 12,
+      "complexity": 2
+    },
+    {
+      "name": "InvalidOperationException",
+      "parameters": 1,
+      "lines": 18,
+      "complexity": 2
+    },
+    {
+      "name": "FirstValue",
+      "parameters": 1,
+      "lines": 1,
+      "complexity": 1
+    },
+    {
+      "name": "GetName",
+      "parameters": 1,
+      "lines": 4,
+      "complexity": 1
+    },
+    {
+      "name": "SqlConnection",
+      "parameters": 1,
+      "lines": 3,
+      "complexity": 1
+    },
+    {
+      "name": "SqlCommand",
+      "parameters": 2,
+      "lines": 5,
+      "complexity": 1
+    }
+  ],
+  "class_details": [
+    {
+      "name": "DbOptions",
+      "methods": 0,
+      "lines": 7
+    },
+    {
+      "name": "UserService",
+      "methods": 8,
+      "lines": 75
+    },
+    {
+      "name": "User",
+      "methods": 0,
+      "lines": 3
+    }
+  ],
+  "policy": {
+    "tiers": [
+      "built-in",
+      "review-policy.json"
+    ],
+    "thresholds": {
+      "long_function_lines": 50,
+      "too_many_parameters": 5,
+      "high_complexity": 10,
+      "god_class_methods": 20,
+      "max_imports": 15,
+      "max_declarative_depth": 8
+    }
+  }
+}

package/core/shared/skills/do-code-review/expected_outputs/sample_csharp_smells_quality.json

@@ -0,0 +1,157 @@
+{
+  "file": "assets/sample_csharp_smells.cs",
+  "language": "csharp",
+  "metrics": {
+    "lines": {
+      "total": 79,
+      "code": 43,
+      "blank": 11,
+      "comment": 25
+    },
+    "functions": 7,
+    "classes": 1,
+    "avg_complexity": 1.1
+  },
+  "quality_score": 45,
+  "grade": "F",
+  "smells": [
+    {
+      "type": "csharp_async_void",
+      "severity": "high",
+      "message": "'async void HandleClick' \u2014 only safe for event handlers; prefer 'async Task'",
+      "location": "HandleClick"
+    },
+    {
+      "type": "csharp_blocking_async",
+      "severity": "high",
+      "message": "Blocking call on async operation ('.Result' / '.Wait()' / '.GetAwaiter().GetResult()') \u2014 can deadlock in ASP.NET contexts",
+      "location": "offset 430"
+    },
+    {
+      "type": "csharp_swallowed_exception",
+      "severity": "high",
+      "message": "Empty catch block swallows exceptions silently",
+      "location": "offset 853"
+    },
+    {
+      "type": "csharp_undisposed_idisposable",
+      "severity": "medium",
+      "message": "'HttpClient' looks like IDisposable but is not wrapped in 'using' / 'using var'",
+      "location": "offset 555"
+    },
+    {
+      "type": "csharp_undisposed_idisposable",
+      "severity": "medium",
+      "message": "'SqlCommand' looks like IDisposable but is not wrapped in 'using' / 'using var'",
+      "location": "offset 1289"
+    },
+    {
+      "type": "csharp_new_httpclient",
+      "severity": "medium",
+      "message": "'new HttpClient()' \u2014 prefer IHttpClientFactory or a long-lived static instance to avoid socket exhaustion",
+      "location": "offset 606"
+    },
+    {
+      "type": "csharp_missing_await",
+      "severity": "medium",
+      "message": "Async method called without 'await' \u2014 Task is discarded",
+      "location": "line 42"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System;' appears unused",
+      "location": "System"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System.Net.Http;' appears unused",
+      "location": "System.Net.Http"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System.Threading.Tasks;' appears unused",
+      "location": "System.Threading.Tasks"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System.Data.SqlClient;' appears unused",
+      "location": "System.Data.SqlClient"
+    },
+    {
+      "type": "csharp_unused_using",
+      "severity": "low",
+      "message": "'using System.Diagnostics.CodeAnalysis;' appears unused",
+      "location": "System.Diagnostics.CodeAnalysis"
+    }
+  ],
+  "solid_violations": [],
+  "function_details": [
+    {
+      "name": "HandleClick",
+      "parameters": 2,
+      "lines": 7,
+      "complexity": 1
+    },
+    {
+      "name": "FetchAsync",
+      "parameters": 0,
+      "lines": 2,
+      "complexity": 1
+    },
+    {
+      "name": "HttpClient",
+      "parameters": 0,
+      "lines": 3,
+      "complexity": 1
+    },
+    {
+      "name": "HttpClient",
+      "parameters": 0,
+      "lines": 21,
+      "complexity": 2
+    },
+    {
+      "name": "Pointers",
+      "parameters": 0,
+      "lines": 10,
+      "complexity": 1
+    },
+    {
+      "name": "GetName",
+      "parameters": 2,
+      "lines": 5,
+      "complexity": 1
+    },
+    {
+      "name": "SqlCommand",
+      "parameters": 2,
+      "lines": 5,
+      "complexity": 1
+    }
+  ],
+  "class_details": [
+    {
+      "name": "UserService",
+      "methods": 4,
+      "lines": 61
+    }
+  ],
+  "policy": {
+    "tiers": [
+      "built-in",
+      "review-policy.json"
+    ],
+    "thresholds": {
+      "long_function_lines": 50,
+      "too_many_parameters": 5,
+      "high_complexity": 10,
+      "god_class_methods": 20,
+      "max_imports": 15,
+      "max_declarative_depth": 8
+    }
+  }
+}

package/core/shared/skills/do-code-review/expected_outputs/sample_java_clean_quality.json

@@ -0,0 +1,67 @@
+{
+  "file": "assets/sample_java_clean.java",
+  "language": "java",
+  "metrics": {
+    "lines": {
+      "total": 56,
+      "code": 33,
+      "blank": 9,
+      "comment": 14
+    },
+    "functions": 3,
+    "classes": 1,
+    "avg_complexity": 1.7
+  },
+  "quality_score": 100,
+  "grade": "A",
+  "smells": [
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 1000 should be a named constant",
+      "location": "line 49"
+    }
+  ],
+  "solid_violations": [],
+  "function_details": [
+    {
+      "name": "UserService",
+      "parameters": 1,
+      "lines": 3,
+      "complexity": 1
+    },
+    {
+      "name": "getName",
+      "parameters": 2,
+      "lines": 15,
+      "complexity": 2
+    },
+    {
+      "name": "process",
+      "parameters": 0,
+      "lines": 9,
+      "complexity": 2
+    }
+  ],
+  "class_details": [
+    {
+      "name": "UserService",
+      "methods": 3,
+      "lines": 38
+    }
+  ],
+  "policy": {
+    "tiers": [
+      "built-in",
+      "review-policy.json"
+    ],
+    "thresholds": {
+      "long_function_lines": 50,
+      "too_many_parameters": 5,
+      "high_complexity": 10,
+      "god_class_methods": 20,
+      "max_imports": 15,
+      "max_declarative_depth": 8
+    }
+  }
+}

package/core/shared/skills/do-code-review/expected_outputs/sample_java_smells_quality.json

@@ -0,0 +1,97 @@
+{
+  "file": "assets/sample_java_smells.java",
+  "language": "java",
+  "metrics": {
+    "lines": {
+      "total": 57,
+      "code": 29,
+      "blank": 10,
+      "comment": 18
+    },
+    "functions": 3,
+    "classes": 1,
+    "avg_complexity": 1.7
+  },
+  "quality_score": 68,
+  "grade": "D",
+  "smells": [
+    {
+      "type": "magic_number",
+      "severity": "low",
+      "message": "Magic number 1000 should be a named constant",
+      "location": "line 44"
+    },
+    {
+      "type": "java_empty_catch",
+      "severity": "high",
+      "message": "Empty catch block swallows exceptions silently",
+      "location": "offset 684"
+    },
+    {
+      "type": "java_print_stack_trace",
+      "severity": "medium",
+      "message": "'printStackTrace()' is not real error handling \u2014 log via a proper logger or rethrow with context",
+      "location": "offset 913"
+    },
+    {
+      "type": "java_swallowed_interrupt",
+      "severity": "high",
+      "message": "InterruptedException caught without 'Thread.currentThread().interrupt()' \u2014 breaks cooperative cancellation",
+      "location": "offset 841"
+    },
+    {
+      "type": "java_unclosed_resource",
+      "severity": "medium",
+      "message": "'FileInputStream' looks like an AutoCloseable but is not in a try-with-resources statement",
+      "location": "offset 366"
+    },
+    {
+      "type": "java_per_use_heavy_object",
+      "severity": "medium",
+      "message": "'new ObjectMapper()' is expensive \u2014 share a singleton instance instead of constructing per call",
+      "location": "offset 451"
+    }
+  ],
+  "solid_violations": [],
+  "function_details": [
+    {
+      "name": "getName",
+      "parameters": 2,
+      "lines": 16,
+      "complexity": 2
+    },
+    {
+      "name": "process",
+      "parameters": 0,
+      "lines": 9,
+      "complexity": 2
+    },
+    {
+      "name": "log",
+      "parameters": 1,
+      "lines": 5,
+      "complexity": 1
+    }
+  ],
+  "class_details": [
+    {
+      "name": "UserService",
+      "methods": 3,
+      "lines": 40
+    }
+  ],
+  "policy": {
+    "tiers": [
+      "built-in",
+      "review-policy.json"
+    ],
+    "thresholds": {
+      "long_function_lines": 50,
+      "too_many_parameters": 5,
+      "high_complexity": 10,
+      "god_class_methods": 20,
+      "max_imports": 15,
+      "max_declarative_depth": 8
+    }
+  }
+}