@khanacademy/wonder-blocks-icon-button 3.4.14 → 3.4.15

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @khanacademy/wonder-blocks-icon-button
 
+## 3.4.15
+
+### Patch Changes
+
+-   ceb111df: ClickableBehavior no longer has tabIndex 0 by default. It must be passed in.
+-   Updated dependencies [ceb111df]
+    -   @khanacademy/wonder-blocks-clickable@2.4.0
+
 ## 3.4.14
 
 ### Patch Changes

package/dist/es/index.js

@@ -154,8 +154,7 @@ const _generateStyles = (color, kind, light) => {
   return styles[buttonType];
 };
 
-const _excluded = ["onClick", "href", "skipClientNav", "tabIndex", "target"],
-      _excluded2 = ["tabIndex"];
+const _excluded = ["onClick", "href", "skipClientNav", "tabIndex", "target"];
 class IconButton extends React.Component {
   renderClickableBehavior(router) {
     const _this$props = this.props,
@@ -176,16 +175,13 @@ class IconButton extends React.Component {
       role: "button",
       target: target
     }, (state, _ref) => {
-      let {
-        tabIndex: clickableTabIndex
-      } = _ref,
-          childrenProps = _objectWithoutPropertiesLoose(_ref, _excluded2);
+      let childrenProps = _extends({}, _ref);
 
       return React.createElement(IconButtonCore, _extends({}, sharedProps, state, childrenProps, {
         skipClientNav: skipClientNav,
         href: href,
         target: target,
-        tabIndex: tabIndex || clickableTabIndex
+        tabIndex: tabIndex
       }));
     });
   }

package/dist/index.js

@@ -219,18 +219,13 @@ class IconButton extends react__WEBPACK_IMPORTED_MODULE_1__["Component"] {
       onClick: onClick,
       role: "button",
       target: target
-    }, (state, {
-      tabIndex: clickableTabIndex,
-      ...childrenProps
+    }, (state, { ...childrenProps
     }) => {
       return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1__["createElement"](_icon_button_core_js__WEBPACK_IMPORTED_MODULE_4__[/* default */ "a"], _babel_runtime_helpers_extends__WEBPACK_IMPORTED_MODULE_0___default()({}, sharedProps, state, childrenProps, {
         skipClientNav: skipClientNav,
         href: href,
-        target: target // If tabIndex is provide to the component we allow
-        // it to override the tabIndex provide to use by
-        // ClickableBehavior.
-        ,
-        tabIndex: tabIndex || clickableTabIndex
+        target: target,
+        tabIndex: tabIndex
       }));
     });
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@khanacademy/wonder-blocks-icon-button",
-  "version": "3.4.14",
+  "version": "3.4.15",
   "design": "v1",
   "publishConfig": {
     "access": "public"
@@ -16,7 +16,7 @@
   "license": "MIT",
   "dependencies": {
     "@babel/runtime": "^7.18.6",
-    "@khanacademy/wonder-blocks-clickable": "^2.3.3",
+    "@khanacademy/wonder-blocks-clickable": "^2.4.0",
     "@khanacademy/wonder-blocks-color": "^1.2.0",
     "@khanacademy/wonder-blocks-core": "^4.5.0",
     "@khanacademy/wonder-blocks-icon": "^1.2.32"

package/src/components/icon-button.js

@@ -197,7 +197,7 @@ export default class IconButton extends React.Component<SharedProps> {
                 role="button"
                 target={target}
             >
-                {(state, {tabIndex: clickableTabIndex, ...childrenProps}) => {
+                {(state, {...childrenProps}) => {
                     return (
                         <IconButtonCore
                             {...sharedProps}
@@ -206,10 +206,7 @@ export default class IconButton extends React.Component<SharedProps> {
                             skipClientNav={skipClientNav}
                             href={href}
                             target={target}
-                            // If tabIndex is provide to the component we allow
-                            // it to override the tabIndex provide to use by
-                            // ClickableBehavior.
-                            tabIndex={tabIndex || clickableTabIndex}
+                            tabIndex={tabIndex}
                         />
                     );
                 }}