@khanacademy/wonder-blocks-button 3.0.5 → 3.0.7

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @khanacademy/wonder-blocks-button
 
+## 3.0.7
+
+### Patch Changes
+
+-   ceb111df: ClickableBehavior no longer has tabIndex 0 by default. It must be passed in.
+-   Updated dependencies [ceb111df]
+    -   @khanacademy/wonder-blocks-clickable@2.4.0
+
+## 3.0.6
+
+### Patch Changes
+
+-   Updated dependencies [175a2dd2]
+    -   @khanacademy/wonder-blocks-core@4.5.0
+    -   @khanacademy/wonder-blocks-clickable@2.3.3
+    -   @khanacademy/wonder-blocks-icon@1.2.32
+    -   @khanacademy/wonder-blocks-progress-spinner@1.1.36
+    -   @khanacademy/wonder-blocks-typography@1.1.34
+
 ## 3.0.5
 
 ### Patch Changes

package/dist/es/index.js

@@ -292,8 +292,7 @@ const _generateStyles = (color, kind, light, iconWidth, size) => {
   return styles[buttonType];
 };
 
-const _excluded = ["href", "type", "children", "skipClientNav", "spinner", "disabled", "onClick", "beforeNav", "safeWithNav", "tabIndex", "target", "rel"],
-      _excluded2 = ["tabIndex"];
+const _excluded = ["href", "type", "children", "skipClientNav", "spinner", "disabled", "onClick", "beforeNav", "safeWithNav", "tabIndex", "target", "rel"];
 class Button extends React.Component {
   renderClickableBehavior(router) {
     const _this$props = this.props,
@@ -316,10 +315,7 @@ class Button extends React.Component {
     const ClickableBehavior = getClickableBehavior(href, skipClientNav, router);
 
     const renderProp = (state, _ref) => {
-      let {
-        tabIndex: clickableTabIndex
-      } = _ref,
-          restChildProps = _objectWithoutPropertiesLoose(_ref, _excluded2);
+      let restChildProps = _extends({}, _ref);
 
       return React.createElement(ButtonCore, _extends({}, sharedButtonCoreProps, state, restChildProps, {
         disabled: disabled,
@@ -328,7 +324,7 @@ class Button extends React.Component {
         href: href,
         target: target,
         type: type,
-        tabIndex: tabIndex || clickableTabIndex
+        tabIndex: tabIndex
       }), children);
     };
 

package/dist/index.js

@@ -216,9 +216,7 @@ class Button extends react__WEBPACK_IMPORTED_MODULE_1__["Component"] {
     } = this.props;
     const ClickableBehavior = Object(_khanacademy_wonder_blocks_clickable__WEBPACK_IMPORTED_MODULE_3__["getClickableBehavior"])(href, skipClientNav, router);
 
-    const renderProp = (state, {
-      tabIndex: clickableTabIndex,
-      ...restChildProps
+    const renderProp = (state, { ...restChildProps
     }) => {
       return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1__["createElement"](_button_core_js__WEBPACK_IMPORTED_MODULE_4__[/* default */ "a"], _babel_runtime_helpers_extends__WEBPACK_IMPORTED_MODULE_0___default()({}, sharedButtonCoreProps, state, restChildProps, {
         disabled: disabled,
@@ -226,11 +224,8 @@ class Button extends react__WEBPACK_IMPORTED_MODULE_1__["Component"] {
         skipClientNav: skipClientNav,
         href: href,
         target: target,
-        type: type // If tabIndex is provide to the component we allow
-        // it to override the tabIndex provide to use by
-        // ClickableBehavior.
-        ,
-        tabIndex: tabIndex || clickableTabIndex
+        type: type,
+        tabIndex: tabIndex
       }), children);
     };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@khanacademy/wonder-blocks-button",
-  "version": "3.0.5",
+  "version": "3.0.7",
   "design": "v1",
   "publishConfig": {
     "access": "public"
@@ -16,13 +16,13 @@
   "license": "MIT",
   "dependencies": {
     "@babel/runtime": "^7.18.6",
-    "@khanacademy/wonder-blocks-clickable": "^2.3.2",
+    "@khanacademy/wonder-blocks-clickable": "^2.4.0",
     "@khanacademy/wonder-blocks-color": "^1.2.0",
-    "@khanacademy/wonder-blocks-core": "^4.4.0",
-    "@khanacademy/wonder-blocks-icon": "^1.2.31",
-    "@khanacademy/wonder-blocks-progress-spinner": "^1.1.35",
+    "@khanacademy/wonder-blocks-core": "^4.5.0",
+    "@khanacademy/wonder-blocks-icon": "^1.2.32",
+    "@khanacademy/wonder-blocks-progress-spinner": "^1.1.36",
     "@khanacademy/wonder-blocks-spacing": "^3.0.5",
-    "@khanacademy/wonder-blocks-typography": "^1.1.33"
+    "@khanacademy/wonder-blocks-typography": "^1.1.34"
   },
   "peerDependencies": {
     "aphrodite": "^1.2.5",

package/src/components/button.js

@@ -285,10 +285,7 @@ export default class Button extends React.Component<Props> {
             router,
         );
 
-        const renderProp = (
-            state,
-            {tabIndex: clickableTabIndex, ...restChildProps},
-        ) => {
+        const renderProp = (state, {...restChildProps}) => {
             return (
                 <ButtonCore
                     {...sharedButtonCoreProps}
@@ -300,10 +297,7 @@ export default class Button extends React.Component<Props> {
                     href={href}
                     target={target}
                     type={type}
-                    // If tabIndex is provide to the component we allow
-                    // it to override the tabIndex provide to use by
-                    // ClickableBehavior.
-                    tabIndex={tabIndex || clickableTabIndex}
+                    tabIndex={tabIndex}
                 >
                     {children}
                 </ButtonCore>