@khanacademy/perseus 7.2.1 → 8.0.0

package/src/widgets/unit.tsx

@@ -108,7 +108,7 @@ export class OldUnitInput extends React.Component<Props> {
         const sigfigs = rubric.sigfigs;
         const sigfigsCorrect = countSigfigs(guess.coefficient) === sigfigs;
         if (!sigfigsCorrect) {
-            // @ts-expect-error [FEI-5003] - TS2322 - Type 'string' is not assignable to type 'null'.
+            // @ts-expect-error - TS2322 - Type 'string' is not assignable to type 'null'.
             message = i18n._("Check your significant figures.");
         }
 
@@ -136,7 +136,7 @@ export class OldUnitInput extends React.Component<Props> {
         }
 
         if (!numericallyCorrect) {
-            // @ts-expect-error [FEI-5003] - TS2322 - Type 'string' is not assignable to type 'null'.
+            // @ts-expect-error - TS2322 - Type 'string' is not assignable to type 'null'.
             message = i18n._("That answer is numerically incorrect.");
         }
 
@@ -163,7 +163,7 @@ export class OldUnitInput extends React.Component<Props> {
             });
         }
         if (!kasCorrect) {
-            // @ts-expect-error [FEI-5003] - TS2322 - Type 'string' is not assignable to type 'null'.
+            // @ts-expect-error - TS2322 - Type 'string' is not assignable to type 'null'.
             message = i18n._("Check your units.");
         }
 
@@ -180,14 +180,14 @@ export class OldUnitInput extends React.Component<Props> {
     componentDidUpdate() {
         // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
         // eslint-disable-next-line no-restricted-syntax
-        // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+        // @ts-expect-error - TS2769 - No overload matches this call.
         clearTimeout(this._errorTimeout);
         if (KAS.unitParse(this.props.value).parsed) {
             this._hideError();
         } else {
             // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
             // eslint-disable-next-line no-restricted-syntax
-            // @ts-expect-error [FEI-5003] - TS2322 - Type 'Timeout' is not assignable to type 'number'.
+            // @ts-expect-error - TS2322 - Type 'Timeout' is not assignable to type 'number'.
             this._errorTimeout = setTimeout(this._showError, 2000);
         }
     }
@@ -195,7 +195,7 @@ export class OldUnitInput extends React.Component<Props> {
     componentWillUnmount() {
         // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
         // eslint-disable-next-line no-restricted-syntax
-        // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+        // @ts-expect-error - TS2769 - No overload matches this call.
         clearTimeout(this._errorTimeout);
     }
 
@@ -205,12 +205,12 @@ export class OldUnitInput extends React.Component<Props> {
         }
 
         // eslint-disable-next-line react/no-string-refs
-        // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+        // @ts-expect-error - TS2769 - No overload matches this call.
         const $error = $(ReactDOM.findDOMNode(this.refs.error));
-        // @ts-expect-error [FEI-5003] - TS2339 - Property 'is' does not exist on type 'JQueryStatic'.
+        // @ts-expect-error - TS2339 - Property 'is' does not exist on type 'JQueryStatic'.
         if (!$error.is(":visible")) {
             $error
-                // @ts-expect-error [FEI-5003] - TS2554 - Expected 2 arguments, but got 1.
+                // @ts-expect-error - TS2554 - Expected 2 arguments, but got 1.
                 .css({top: 50, opacity: 0.1})
                 .show()
                 .animate({top: 0, opacity: 1.0}, 300);
@@ -219,14 +219,14 @@ export class OldUnitInput extends React.Component<Props> {
 
     _hideError: () => void = () => {
         // eslint-disable-next-line react/no-string-refs
-        // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+        // @ts-expect-error - TS2769 - No overload matches this call.
         const $error = $(ReactDOM.findDOMNode(this.refs.error));
-        // @ts-expect-error [FEI-5003] - TS2339 - Property 'is' does not exist on type 'JQueryStatic'.
+        // @ts-expect-error - TS2339 - Property 'is' does not exist on type 'JQueryStatic'.
         if ($error.is(":visible")) {
-            // @ts-expect-error [FEI-5003] - TS2339 - Property 'animate' does not exist on type 'JQueryStatic'.
+            // @ts-expect-error - TS2339 - Property 'animate' does not exist on type 'JQueryStatic'.
             $error.animate({top: 50, opacity: 0.1}, 300, function () {
                 // eslint-disable-next-line @babel/no-invalid-this
-                // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+                // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
                 // eslint-disable-next-line @babel/no-invalid-this
                 $(this).hide();
             });
@@ -236,7 +236,7 @@ export class OldUnitInput extends React.Component<Props> {
     change: (...args: ReadonlyArray<any>) => any | null | undefined = (
         ...args
     ) => {
-        // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'readonly any[]' is not assignable to parameter of type 'any[]'.
+        // @ts-expect-error - TS2345 - Argument of type 'readonly any[]' is not assignable to parameter of type 'any[]'.
         return Changeable.change.apply(this, args);
     };
 
@@ -244,7 +244,7 @@ export class OldUnitInput extends React.Component<Props> {
         this.props.onBlur([]);
         // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
         // eslint-disable-next-line no-restricted-syntax
-        // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+        // @ts-expect-error - TS2769 - No overload matches this call.
         clearTimeout(this._errorTimeout);
         if (!KAS.unitParse(this.props.value).parsed) {
             this._showError();
@@ -287,7 +287,7 @@ export class OldUnitInput extends React.Component<Props> {
              * Change to using a ref callback so that focus() can be
              * accessed.
              */
-            // @ts-expect-error [FEI-5003] - TS2339 - Property 'focus' does not exist on type 'Element | Text'.
+            // @ts-expect-error - TS2339 - Property 'focus' does not exist on type 'Element | Text'.
             input.focus();
         }
     };
@@ -305,7 +305,7 @@ export class OldUnitInput extends React.Component<Props> {
              * Change to using a ref callback so that focus() can be
              * accessed.
              */
-            // @ts-expect-error [FEI-5003] - TS2339 - Property 'blur' does not exist on type 'Element | Text'.
+            // @ts-expect-error - TS2339 - Property 'blur' does not exist on type 'Element | Text'.
             input.blur();
         }
     };

package/src/widgets/video-transcript-link.test.tsx

@@ -138,7 +138,7 @@ describe("VideoTranscriptLink", () => {
         // Arrange
         jest.spyOn(Dependencies, "getDependencies").mockReturnValue({
             ...testDependencies,
-            // @ts-expect-error [FEI-5003] - TS2322 - Type '(videoId: string, kind: VideoKind) => { status: "success"; data: {}; }' is not assignable to type '(id: string, kind: VideoKind) => Result<{ video: VideoData | null | undefined; }>'.
+            // @ts-expect-error - TS2322 - Type '(videoId: string, kind: VideoKind) => { status: "success"; data: {}; }' is not assignable to type '(id: string, kind: VideoKind) => Result<{ video: VideoData | null | undefined; }>'.
             useVideo: (videoId, kind) => {
                 return {status: "success", data: {}};
             },
@@ -169,7 +169,7 @@ describe("VideoTranscriptLink", () => {
         // Arrange
         jest.spyOn(Dependencies, "getDependencies").mockReturnValue({
             ...testDependencies,
-            // @ts-expect-error [FEI-5003] - TS2322 - Type '(videoId: string, kind: VideoKind) => { status: "success"; data: {}; }' is not assignable to type '(id: string, kind: VideoKind) => Result<{ video: VideoData | null | undefined; }>'.
+            // @ts-expect-error - TS2322 - Type '(videoId: string, kind: VideoKind) => { status: "success"; data: {}; }' is not assignable to type '(id: string, kind: VideoKind) => Result<{ video: VideoData | null | undefined; }>'.
             useVideo: (videoId, kind) => {
                 return {status: "success", data: {}};
             },
@@ -186,7 +186,7 @@ describe("VideoTranscriptLink", () => {
         // Arrange
         jest.spyOn(Dependencies, "getDependencies").mockReturnValue({
             ...testDependencies,
-            // @ts-expect-error [FEI-5003] - TS2322 - Type '(videoId: string, kind: VideoKind) => { status: "error"; }' is not assignable to type '(id: string, kind: VideoKind) => Result<{ video: VideoData | null | undefined; }>'.
+            // @ts-expect-error - TS2322 - Type '(videoId: string, kind: VideoKind) => { status: "error"; }' is not assignable to type '(id: string, kind: VideoKind) => Result<{ video: VideoData | null | undefined; }>'.
             useVideo: (videoId, kind) => {
                 return {status: "error"};
             },

package/src/widgets/video-transcript-link.tsx

@@ -39,7 +39,7 @@ const VideoTranscriptLink = (props: Props): React.ReactElement => {
         : [location, "READABLE_ID"];
     // The result value conforms to the wonder-blocks-data `Result` type
     // which is used by our GraphQL framework.
-    // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'string' is not assignable to parameter of type 'VideoKind'.
+    // @ts-expect-error - TS2345 - Argument of type 'string' is not assignable to parameter of type 'VideoKind'.
     const result = useVideo(id, kind);
 
     switch (result.status) {

package/src/widgets/video.tsx

@@ -59,7 +59,7 @@ class Video extends React.Component<Props> {
     };
 
     change: (...args: ReadonlyArray<unknown>) => any = (...args) => {
-        // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'readonly unknown[]' is not assignable to parameter of type 'any[]'.
+        // @ts-expect-error - TS2345 - Argument of type 'readonly unknown[]' is not assignable to parameter of type 'any[]'.
         return Changeable.change.apply(this, args);
     };
 

package/src/widgets.ts

@@ -1,4 +1,3 @@
-import * as React from "react";
 import _ from "underscore";
 
 import {Errors, Log} from "./logging/log";
@@ -12,6 +11,7 @@ import type {
     WidgetInfo,
     WidgetTransform,
 } from "./types";
+import type * as React from "react";
 
 const DEFAULT_ALIGNMENT = "block";
 // NOTE(kevinb): "default" is not one in `validAlignments`.
@@ -66,7 +66,7 @@ export const getWidget = (
 
     // Allow widgets to specify a widget directly or via a function
     if (widgets[name].getWidget) {
-        // @ts-expect-error [FEI-5003] - TS2722 - Cannot invoke an object which is possibly 'undefined'.
+        // @ts-expect-error - TS2722 - Cannot invoke an object which is possibly 'undefined'.
         return widgets[name].getWidget();
     }
     return widgets[name].widget;
@@ -102,10 +102,10 @@ export const getVersionVector = (): {
 
 export const getPublicWidgets = (): ReadonlyArray<WidgetExports> => {
     // TODO(alex): Update underscore.js so that _.pick can take a function.
-    // @ts-expect-error [FEI-5003] - TS2740 - Type 'Pick<{ [key: string]: Readonly<{ name: string; displayName: string; getWidget?: (() => ComponentType<any>) | undefined; accessible?: boolean | ((props: any) => boolean) | undefined; hidden?: boolean | undefined; ... 10 more ...; widget: ComponentType<...>; }>; }, string>' is missing the following properties from type 'readonly Readonly<{ name: string; displayName: string; getWidget?: (() => ComponentType<any>) | undefined; accessible?: boolean | ((props: any) => boolean) | undefined; hidden?: boolean | undefined; ... 10 more ...; widget: ComponentType<...>; }>[]': length, concat, join, slice, and 18 more.
+    // @ts-expect-error - TS2740 - Type 'Pick<{ [key: string]: Readonly<{ name: string; displayName: string; getWidget?: (() => ComponentType<any>) | undefined; accessible?: boolean | ((props: any) => boolean) | undefined; hidden?: boolean | undefined; ... 10 more ...; widget: ComponentType<...>; }>; }, string>' is missing the following properties from type 'readonly Readonly<{ name: string; displayName: string; getWidget?: (() => ComponentType<any>) | undefined; accessible?: boolean | ((props: any) => boolean) | undefined; hidden?: boolean | undefined; ... 10 more ...; widget: ComponentType<...>; }>[]': length, concat, join, slice, and 18 more.
     return _.pick(
         widgets,
-        // @ts-expect-error [FEI-5003] - TS2345 - Argument of type '(name: string) => boolean | undefined' is not assignable to parameter of type 'Iteratee<string[], boolean, string>'.
+        // @ts-expect-error - TS2345 - Argument of type '(name: string) => boolean | undefined' is not assignable to parameter of type 'Iteratee<string[], boolean, string>'.
         _.reject(_.keys(widgets), function (name) {
             return widgets[name].hidden;
         }),
@@ -318,7 +318,7 @@ export const getSupportedAlignments = (
     type: string,
 ): ReadonlyArray<Alignment> => {
     const widgetExport = widgets[type];
-    // @ts-expect-error [FEI-5003] - TS2322 - Type 'string[] | readonly Alignment[]' is not assignable to type 'readonly Alignment[]'.
+    // @ts-expect-error - TS2322 - Type 'string[] | readonly Alignment[]' is not assignable to type 'readonly Alignment[]'.
     return (
         (widgetExport && widgetExport.supportedAlignments) ||
         DEFAULT_SUPPORTED_ALIGNMENTS

package/src/zoom.ts

@@ -45,7 +45,7 @@ function transitionEnd() {
 }
 
 // http://blog.alexmaccaw.com/css-transitions
-// @ts-expect-error [FEI-5003] - TS2339 - Property 'emulateTransitionEnd' does not exist on type 'JQuery<HTMLElement>'.
+// @ts-expect-error - TS2339 - Property 'emulateTransitionEnd' does not exist on type 'JQuery<HTMLElement>'.
 $.fn.emulateTransitionEnd = function (duration: any) {
     let called = false;
     const $el = this;
@@ -75,9 +75,9 @@ $(function () {
         bindType: $.support.transition.end,
         delegateType: $.support.transition.end,
         handle: function (e) {
-            // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+            // @ts-expect-error - TS2769 - No overload matches this call.
             if ($(e.target).is(this)) {
-                // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'IArguments' is not assignable to parameter of type '[t: TriggeredEvent<EventTarget, any, any, any>, ...args: any[]]'.
+                // @ts-expect-error - TS2345 - Argument of type 'IArguments' is not assignable to parameter of type '[t: TriggeredEvent<EventTarget, any, any, any>, ...args: any[]]'.
                 // eslint-disable-next-line prefer-rest-params
                 return e.handleObj.handler.apply(this, arguments);
             }
@@ -107,14 +107,14 @@ function changeViewportTag(
 
     // Hacky way to get the page to take the changes
     // From http://stackoverflow.com/a/36894653
-    // @ts-expect-error [FEI-5003] - TS2322 - Type 'number' is not assignable to type 'string'.
+    // @ts-expect-error - TS2322 - Type 'number' is not assignable to type 'string'.
     document.body.style.opacity = 0.9999;
 
     // ... and undo the temporary change.
     // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
     // eslint-disable-next-line no-restricted-syntax
     setTimeout(() => {
-        // @ts-expect-error [FEI-5003] - TS2322 - Type 'number' is not assignable to type 'string'.
+        // @ts-expect-error - TS2322 - Type 'number' is not assignable to type 'string'.
         document.body.style.opacity = 1;
 
         // ... which involves restoring the scroll position, which may have
@@ -175,7 +175,7 @@ ZoomServiceClass.prototype.handleZoomClick = function (
 
     if (
         !enableMobilePinch &&
-        // @ts-expect-error [FEI-5003] - TS2554 - Expected 1 arguments, but got 0.
+        // @ts-expect-error - TS2554 - Expected 1 arguments, but got 0.
         target.width >= window.innerWidth - Zoom.getOffset()
     ) {
         return;
@@ -298,15 +298,15 @@ ZoomServiceClass.prototype._touchMove = function (e) {
  * The zoom object
  */
 function Zoom(img: any, enableMobilePinch: any) {
-    // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+    // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
     this._fullHeight = this._fullWidth = this._overlay = null;
 
-    // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+    // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
     this._targetImage = img;
-    // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+    // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
     this._enableMobilePinch = enableMobilePinch;
 
-    // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+    // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
     this._$body = $(document.body);
 }
 
@@ -330,13 +330,13 @@ Zoom.prototype.zoomImage = function () {
     img.onload = function () {
         // Load the image without specifying height and width so that we can find
         // the true height and width.
-        // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+        // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
         this._fullHeight = Number(img.height);
-        // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+        // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
         this._fullWidth = Number(img.width);
 
         // Set up our image to mirror the current image on the document.
-        // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+        // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
         const imageOffset = (this._imageOffset = $(this._targetImage).offset());
 
         // Position the image using viewport-fixed coordinates so that it is
@@ -345,21 +345,21 @@ Zoom.prototype.zoomImage = function () {
         // Said another way ... get the coordinates of the image relative to
         // the viewport, and use those to position our new image (which is
         // absolutely positioned within a full-bleed fixed-position container).
-        // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2532 - Object is possibly 'undefined'. | TS2532 - Object is possibly 'undefined'.
+        // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2532 - Object is possibly 'undefined'. | TS2532 - Object is possibly 'undefined'.
         const left = (this._left = imageOffset.left - $(window).scrollLeft());
-        // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2532 - Object is possibly 'undefined'. | TS2532 - Object is possibly 'undefined'.
+        // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation. | TS2532 - Object is possibly 'undefined'. | TS2532 - Object is possibly 'undefined'.
         const top = (this._top = imageOffset.top - $(window).scrollTop());
 
         $zoomedImage.css({
             left: left,
             top: top,
-            // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+            // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
             width: this._targetImage.width,
-            // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+            // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
             height: this._targetImage.height,
         });
 
-        // @ts-expect-error [FEI-5003] - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
+        // @ts-expect-error - TS2683 - 'this' implicitly has type 'any' because it does not have a type annotation.
         this._zoomOriginal();
     }.bind(this);
 
@@ -413,9 +413,9 @@ Zoom.prototype._calculateZoom = function () {
 };
 
 Zoom.prototype._triggerAnimation = function () {
-    // @ts-expect-error [FEI-5003] - TS2532 - Object is possibly 'undefined'.
+    // @ts-expect-error - TS2532 - Object is possibly 'undefined'.
     const viewportY = $(window).scrollTop() + window.innerHeight / 2;
-    // @ts-expect-error [FEI-5003] - TS2532 - Object is possibly 'undefined'.
+    // @ts-expect-error - TS2532 - Object is possibly 'undefined'.
     const viewportX = $(window).scrollLeft() + window.innerWidth / 2;
 
     const scaleFactor = this._imgScaleFactor;
@@ -464,7 +464,7 @@ Zoom.prototype._onZoomInFinish = function () {
     // Horizontally center the image within the viewport, either by positioning
     // with CSS or scrolling the viewport.
     if (width < window.innerWidth) {
-        // @ts-expect-error [FEI-5003] - TS2322 - Type 'string' is not assignable to type 'number'.
+        // @ts-expect-error - TS2322 - Type 'string' is not assignable to type 'number'.
         left = "50%";
         marginLeft = -width / 2;
     } else {
@@ -473,7 +473,7 @@ Zoom.prototype._onZoomInFinish = function () {
 
     // ... and similarly, vertically center the image within the viewport.
     if (height < window.innerHeight) {
-        // @ts-expect-error [FEI-5003] - TS2322 - Type 'string' is not assignable to type 'number'.
+        // @ts-expect-error - TS2322 - Type 'string' is not assignable to type 'number'.
         top = "50%";
         marginTop = -height / 2;
     } else {