@khanacademy/perseus 4.0.2 → 6.0.0

package/src/components/tooltip.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable react/no-unsafe */
 /**
  * A generic tooltip library for React.js
  *
@@ -7,9 +8,9 @@
  * import Tooltip from "./tooltip";
  * <Tooltip
  *     className="class-for-tooltip-contents"
- *     horizontalPosition="left" // one of "left", "right"
- *     horizontalAlign="left" // one of "left", "right"
- *     verticalPosition="bottom" // one of "top", "bottom"
+ *     horizontalPosition={HoriziontalDirection.Left}
+ *     horizontalAlign={HoriziontalDirection.Left}
+ *     verticalPosition={VerticalDirection.Top}
  *     arrowSize={10} // arrow size in pixels
  *     borderColor="#ccc" // color of the border for the tooltip
  *     show={true} // whether the tooltip should currently be visible
@@ -40,136 +41,142 @@
 // TODO(joel/aria) fix z-index issues https://s3.amazonaws.com/uploads.hipchat.com/6574/29028/yOApjwmgiMhEZYJ/Screen%20Shot%202014-05-30%20at%203.34.18%20PM.png
 // z-index: 3 on perseus-formats-tooltip seemed to work
 
-import createReactClass from "create-react-class";
-import PropTypes from "prop-types";
 import * as React from "react";
 import ReactDOM from "react-dom";
 
-const zIndex = 10;
-
-const Triangle = createReactClass({
-    propTypes: {
-        color: PropTypes.string.isRequired,
-        left: PropTypes.number.isRequired,
-        top: PropTypes.number.isRequired,
-        width: PropTypes.number.isRequired,
-        height: PropTypes.number.isRequired,
-        horizontalDirection: PropTypes.oneOf(["left", "right"]).isRequired,
-        verticalDirection: PropTypes.oneOf(["top", "bottom"]).isRequired,
-    },
-
-    render: function () {
-        let borderLeft;
-        let borderRight;
-        let borderTop;
-        let borderBottom;
-
-        const hBorder = `${this.props.width}px solid transparent`;
-        if (this.props.horizontalDirection === "right") {
-            borderLeft = hBorder;
-        } else {
-            borderRight = hBorder;
-        }
-
-        const vBorder = `${this.props.height}px solid ${this.props.color}`;
-        if (this.props.verticalDirection === "top") {
-            borderTop = vBorder;
-        } else {
-            borderBottom = vBorder;
-        }
-
-        return (
-            <div
-                style={{
-                    display: "block",
-                    height: 0,
-                    width: 0,
-                    position: "absolute",
-                    left: this.props.left,
-                    top: this.props["top"],
-                    borderLeft: borderLeft,
-                    borderRight: borderRight,
-                    borderTop: borderTop,
-                    borderBottom: borderBottom,
-                }}
-            />
-        );
-    },
-});
-
-const TooltipArrow = createReactClass({
-    propTypes: {
-        position: PropTypes.string,
-        visibility: PropTypes.string,
-        left: PropTypes.number,
-        top: PropTypes.number,
-        color: PropTypes.string.isRequired, // a css color
-        border: PropTypes.string.isRequired, // a css color
-        width: PropTypes.number.isRequired,
-        height: PropTypes.number.isRequired,
-        horizontalDirection: PropTypes.oneOf(["left", "right"]).isRequired,
-        verticalDirection: PropTypes.oneOf(["top", "bottom"]).isRequired,
-    },
+import type {Property} from "csstype";
 
-    getDefaultProps: function () {
-        return {
-            position: "relative",
-            visibility: "visible",
-            left: 0,
-            top: 0,
-        };
-    },
+const zIndex = 10;
 
+export enum HorizontalDirection {
+    Left = "left",
+    Right = "right",
+}
+
+export enum VerticalDirection {
+    Top = "top",
+    Bottom = "bottom",
+}
+
+type TriangleProps = {
+    color: string;
+    left: number;
+    top: number;
+    width: number;
+    height: number;
+    horizontalDirection: HorizontalDirection;
+    verticalDirection: VerticalDirection;
+};
+
+const Triangle = (props: TriangleProps) => {
+    let borderLeft;
+    let borderRight;
+    let borderTop;
+    let borderBottom;
+
+    const hBorder = `${props.width}px solid transparent`;
+    if (props.horizontalDirection === "right") {
+        borderLeft = hBorder;
+    } else {
+        borderRight = hBorder;
+    }
+
+    const vBorder = `${props.height}px solid ${props.color}`;
+    if (props.verticalDirection === "top") {
+        borderTop = vBorder;
+    } else {
+        borderBottom = vBorder;
+    }
+
+    return (
+        <div
+            style={{
+                display: "block",
+                height: 0,
+                width: 0,
+                position: "absolute",
+                left: props.left,
+                top: props["top"],
+                borderLeft: borderLeft,
+                borderRight: borderRight,
+                borderTop: borderTop,
+                borderBottom: borderBottom,
+            }}
+        />
+    );
+};
+
+type TooltipArrowProps = {
+    position: Property.Position;
+    visibility: Property.Visibility;
+    left: number;
+    top: number;
+    color: string; // a css color
+    border: string; // a css color
+    width: number;
+    height: number;
+    horizontalDirection: HorizontalDirection;
+    verticalDirection: VerticalDirection;
+    zIndex?: number;
+};
+
+const TooltipArrow = (props: TooltipArrowProps) => {
     // TODO(aria): Think about adding a box-shadow to the triangle here
     // See http://css-tricks.com/triangle-with-shadow/
-    render: function () {
-        //const isRight = (this.props.horizontalDirection === "right");
-        const isTop = this.props.verticalDirection === "top";
-
-        const frontTopOffset = isTop ? 0 : 1;
-        const borderTopOffset = isTop ? 0 : -1;
 
-        return (
-            <div
-                style={{
-                    display: "block",
-                    position: this.props.position,
-                    visibility: this.props.visibility,
-                    left: this.props.left,
-                    top: this.props["top"],
-                    width: this.props.width + 2,
-                    height: this.props.height + 1,
-                    marginTop: -1,
-                    marginBottom: -2,
-                    zIndex: zIndex,
-                }}
-            >
-                {/* The background triangle used to create the effect of a
+    //const isRight = (this.props.horizontalDirection === "right");
+    const isTop = props.verticalDirection === "top";
+
+    const frontTopOffset = isTop ? 0 : 1;
+    const borderTopOffset = isTop ? 0 : -1;
+
+    return (
+        <div
+            style={{
+                display: "block",
+                position: props.position,
+                visibility: props.visibility,
+                left: props.left,
+                top: props["top"],
+                width: props.width + 2,
+                height: props.height + 1,
+                marginTop: -1,
+                marginBottom: -2,
+                zIndex: zIndex,
+            }}
+        >
+            {/* The background triangle used to create the effect of a
                 border around the foreground triangle*/}
-                <Triangle
-                    horizontalDirection={this.props.horizontalDirection}
-                    verticalDirection={this.props.verticalDirection}
-                    color={this.props.border}
-                    left={0}
-                    top={borderTopOffset}
-                    width={this.props.width + 2} // one extra for the diagonal
-                    height={this.props.height + 2}
-                />
-                {/* The foreground triangle covers all but the left/right edges
+            <Triangle
+                horizontalDirection={props.horizontalDirection}
+                verticalDirection={props.verticalDirection}
+                color={props.border}
+                left={0}
+                top={borderTopOffset}
+                width={props.width + 2} // one extra for the diagonal
+                height={props.height + 2}
+            />
+            {/* The foreground triangle covers all but the left/right edges
                 of the background triangle */}
-                <Triangle
-                    horizontalDirection={this.props.horizontalDirection}
-                    verticalDirection={this.props.verticalDirection}
-                    color={this.props.color}
-                    left={1}
-                    top={frontTopOffset}
-                    width={this.props.width}
-                    height={this.props.height}
-                />
-            </div>
-        );
-    },
-});
+            <Triangle
+                horizontalDirection={props.horizontalDirection}
+                verticalDirection={props.verticalDirection}
+                color={props.color}
+                left={1}
+                top={frontTopOffset}
+                width={props.width}
+                height={props.height}
+            />
+        </div>
+    );
+};
+
+TooltipArrow.defaultProps = {
+    position: "relative",
+    visibility: "visible",
+    left: 0,
+    top: 0,
+};
 
 const VERTICAL_CORNERS = {
     top: {
@@ -201,52 +208,61 @@ const HORIZONTAL_ALIGNMNENTS = {
     },
 } as const;
 
-// eslint-disable-next-line react/no-unsafe
-const Tooltip = createReactClass({
-    propTypes: {
-        show: PropTypes.bool.isRequired,
-        className: PropTypes.string,
-        arrowSize: PropTypes.number,
-        borderColor: PropTypes.string,
-        verticalPosition: PropTypes.oneOf(Object.keys(VERTICAL_CORNERS)),
-        horizontalPosition: PropTypes.oneOf(Object.keys(HORIZONTAL_CORNERS)),
-        horizontalAlign: PropTypes.oneOf(Object.keys(HORIZONTAL_ALIGNMNENTS)),
-        children: PropTypes.arrayOf(PropTypes.element).isRequired,
-        targetContainerStyle: PropTypes.any, // style object
-    },
-
-    getDefaultProps: function () {
-        return {
-            className: "",
-            arrowSize: 10,
-            borderColor: "#ccc",
-            verticalPosition: "bottom",
-            horizontalPosition: "left",
-            horizontalAlign: "left",
-            targetContainerStyle: {},
-        };
-    },
-
-    getInitialState: function () {
-        return {
-            height: null, // used for offsetting "top" positioned tooltips
-        };
-    },
-
-    componentDidMount: function () {
+type Props = {
+    show: boolean;
+    className: string;
+    arrowSize: number;
+    borderColor: string;
+    verticalPosition: VerticalDirection;
+    horizontalPosition: HorizontalDirection;
+    horizontalAlign: HorizontalDirection.Left;
+    children: React.ReactNode;
+    targetContainerStyle: any; // style object
+};
+
+type DefaultProps = {
+    className: Props["className"];
+    arrowSize: Props["arrowSize"];
+    borderColor: Props["borderColor"];
+    verticalPosition: Props["verticalPosition"];
+    horizontalPosition: Props["horizontalPosition"];
+    horizontalAlign: Props["horizontalAlign"];
+    targetContainerStyle: Props["targetContainerStyle"];
+};
+
+type State = {
+    height: number | null;
+};
+
+class Tooltip extends React.Component<Props, State> {
+    static defaultProps: DefaultProps = {
+        className: "",
+        arrowSize: 10,
+        borderColor: "#ccc",
+        verticalPosition: VerticalDirection.Bottom,
+        horizontalPosition: HorizontalDirection.Left,
+        horizontalAlign: HorizontalDirection.Left,
+        targetContainerStyle: {},
+    };
+
+    state: State = {
+        height: null, // used for offsetting "top" positioned tooltips
+    };
+
+    componentDidMount() {
         this._updateHeight();
-    },
+    }
 
-    UNSAFE_componentWillReceiveProps: function () {
+    UNSAFE_componentWillReceiveProps() {
         // If the contents have changed, reset our measure of the height
         this.setState({height: null});
-    },
+    }
 
-    componentDidUpdate: function () {
+    componentDidUpdate() {
         this._updateHeight();
-    },
+    }
 
-    _renderToolTipDiv: function (isTooltipAbove) {
+    _renderToolTipDiv(isTooltipAbove?: boolean) {
         const settings = Object.assign(
             {},
             HORIZONTAL_CORNERS[this.props.horizontalPosition],
@@ -261,7 +277,7 @@ const Tooltip = createReactClass({
             // We put an absolutely positioned arrow in the correct place
             arrowAbove = (
                 <TooltipArrow
-                    verticalDirection="top"
+                    verticalDirection={VerticalDirection.Top}
                     horizontalDirection={this.props.horizontalAlign}
                     position="absolute"
                     color="white"
@@ -278,7 +294,7 @@ const Tooltip = createReactClass({
             // content by the correct amount
             arrowBelow = (
                 <TooltipArrow
-                    verticalDirection="top"
+                    verticalDirection={VerticalDirection.Top}
                     horizontalDirection={this.props.horizontalAlign}
                     visibility="hidden"
                     color="white"
@@ -293,7 +309,7 @@ const Tooltip = createReactClass({
         } else {
             arrowAbove = (
                 <TooltipArrow
-                    verticalDirection="bottom"
+                    verticalDirection={VerticalDirection.Bottom}
                     horizontalDirection={this.props.horizontalAlign}
                     color="white"
                     border={this.props.borderColor}
@@ -348,6 +364,7 @@ const Tooltip = createReactClass({
                             zIndex: zIndex - 1,
                         }}
                     >
+                        {/* @ts-expect-error TS2533 - First child is target, rest is tooltip content */}
                         {this.props.children.slice(1)}
                     </div>
 
@@ -355,9 +372,9 @@ const Tooltip = createReactClass({
                 </div>
             </div>
         );
-    },
+    }
 
-    _updateHeight: function () {
+    _updateHeight() {
         const tooltipContainer = ReactDOM.findDOMNode(
             // eslint-disable-next-line react/no-string-refs
             this.refs.tooltipContainer,
@@ -366,9 +383,9 @@ const Tooltip = createReactClass({
         if (height !== this.state.height) {
             this.setState({height});
         }
-    },
+    }
 
-    render: function () {
+    render() {
         const isTooltipAbove = this.props.verticalPosition === "top";
 
         /* We wrap the entire output in a span so that it displays inline */
@@ -379,14 +396,15 @@ const Tooltip = createReactClass({
                 {/* We wrap our input in a div so that we can put the tooltip in a
                 div above/below it */}
                 <div style={this.props.targetContainerStyle}>
+                    {/* @ts-expect-error TS2533 - First child is target, rest is tooltip content */}
                     {this.props.children[0]}
                 </div>
 
                 {!isTooltipAbove && this._renderToolTipDiv()}
             </span>
         );
-    },
-});
+    }
+}
 
 // Sorry.  // Apology-Oriented-Programming
 export default Tooltip;

package/src/components/visibility-observer/__stories__/visibility-observer.stories.tsx

@@ -136,8 +136,6 @@ class VisibilityTest extends React.Component<Props, State> {
     }
 }
 
-export const AlertWhenNotVisible: React.FC<StoryArgs> = (
-    args,
-): React.ReactElement => {
+export const AlertWhenNotVisible = (args: StoryArgs): React.ReactElement => {
     return <VisibilityTest />;
 };

package/src/error-boundary.tsx

@@ -2,18 +2,15 @@ import * as React from "react";
 
 import {Errors, Log} from "./logging/log";
 
-type ErrorBoundaryProps = {
+type Props = {
     children: React.ReactNode;
 };
-type ErrorBoundaryState = {
+type State = {
     error: string;
 };
 
-class ErrorBoundary extends React.Component<
-    ErrorBoundaryProps,
-    ErrorBoundaryState
-> {
-    constructor(props: ErrorBoundaryProps) {
+class ErrorBoundary extends React.Component<Props, State> {
+    constructor(props: Props) {
         super(props);
         this.state = {error: ""};
     }

package/src/interactive2/types.ts

@@ -1,2 +1,2 @@
-export type Coord = [number, number];
-export type Line = [Coord, Coord];
+export type Coord = [number, number]; // x, y
+export type Line = [Coord, Coord]; // start, end

package/src/multi-items/__stories__/multi-renderer.stories.tsx

@@ -13,7 +13,7 @@ type Story = {
     title: string;
 };
 
-export const SingleItem: React.FC<StoryArgs> = (args): React.ReactElement => {
+export const SingleItem = (args: StoryArgs): React.ReactElement => {
     const item = {
         _multi: {
             ...question1._multi,