@khanacademy/perseus 2.1.0 → 4.0.0

package/src/widgets/numeric-input.tsx

@@ -0,0 +1,563 @@
+/* eslint-disable react/prop-types */
+import {linterContextDefault} from "@khanacademy/perseus-linter";
+import * as i18n from "@khanacademy/wonder-blocks-i18n";
+import {StyleSheet} from "aphrodite";
+import * as React from "react";
+import _ from "underscore";
+
+import InputWithExamples from "../components/input-with-examples";
+import SimpleKeypadInput from "../components/simple-keypad-input";
+import {ApiOptions} from "../perseus-api";
+import TexWrangler from "../tex-wrangler";
+import KhanAnswerTypes from "../util/answer-types";
+import KhanMath from "../util/math";
+
+import type {
+    PerseusNumericInputAnswer,
+    PerseusNumericInputWidgetOptions,
+    PerseusNumericInputAnswerForm,
+} from "../perseus-types";
+import type {
+    FocusPath,
+    PerseusScore,
+    WidgetExports,
+    WidgetProps,
+} from "../types";
+
+const ParseTex = TexWrangler.parseTex;
+
+const answerFormButtons = [
+    {title: "Integers", value: "integer", content: "6"},
+    {title: "Decimals", value: "decimal", content: "0.75"},
+    {title: "Proper fractions", value: "proper", content: "\u2157"},
+    {
+        title: "Improper fractions",
+        value: "improper",
+        content: "\u2077\u2044\u2084",
+    },
+    {title: "Mixed numbers", value: "mixed", content: "1\u00BE"},
+    {title: "Numbers with \u03C0", value: "pi", content: "\u03C0"},
+];
+
+const formExamples: {
+    [key: string]: (arg1: PerseusNumericInputAnswerForm) => string;
+} = {
+    integer: () => i18n._("an integer, like $6$"),
+    proper: (form) =>
+        form.simplify === "optional"
+            ? i18n._("a *proper* fraction, like $1/2$ or $6/10$")
+            : i18n._("a *simplified proper* fraction, like $3/5$"),
+    improper: (form) =>
+        form.simplify === "optional"
+            ? i18n._("an *improper* fraction, like $10/7$ or $14/8$")
+            : i18n._("a *simplified improper* fraction, like $7/4$"),
+    mixed: () => i18n._("a mixed number, like $1\\ 3/4$"),
+    decimal: () => i18n._("an *exact* decimal, like $0.75$"),
+    pi: () =>
+        i18n._(
+            "a multiple of pi, like $12\\ \\text{pi}$ or " +
+                "$2/3\\ \\text{pi}$",
+        ),
+};
+
+type UserInput = {
+    currentValue: string;
+};
+
+export type Rubric = PerseusNumericInputWidgetOptions;
+
+type ExternalProps = WidgetProps<PerseusNumericInputWidgetOptions, Rubric>;
+
+type Props = ExternalProps & {
+    size: NonNullable<ExternalProps["size"]>;
+    rightAlign: NonNullable<ExternalProps["rightAlign"]>;
+    apiOptions: NonNullable<ExternalProps["apiOptions"]>;
+    coefficient: NonNullable<ExternalProps["coefficient"]>;
+    answerForms: NonNullable<ExternalProps["answerForms"]>;
+    labelText: NonNullable<ExternalProps["labelText"]>;
+    linterContext: NonNullable<ExternalProps["linterContext"]>;
+    multipleNumberInput: NonNullable<ExternalProps["multipleNumberInput"]>;
+    currentValue: string;
+};
+
+type DefaultProps = {
+    currentValue: Props["currentValue"];
+    size: Props["size"];
+    rightAlign: Props["rightAlign"];
+    apiOptions: Props["apiOptions"];
+    coefficient: Props["coefficient"];
+    answerForms: Props["answerForms"];
+    labelText: Props["labelText"];
+    linterContext: Props["linterContext"];
+    multipleNumberInput: Props["multipleNumberInput"];
+};
+
+type State = {
+    // keeps track of the other set of values when switching
+    // between 0 and finite solutions
+    previousValues: ReadonlyArray<string>;
+};
+
+export class NumericInput extends React.Component<Props, State> {
+    inputRef: SimpleKeypadInput | InputWithExamples | null | undefined;
+
+    static defaultProps: DefaultProps = {
+        currentValue: "",
+        size: "normal",
+        rightAlign: false,
+        apiOptions: ApiOptions.defaults,
+        coefficient: false,
+        answerForms: [],
+        labelText: "",
+        linterContext: linterContextDefault,
+        multipleNumberInput: false,
+    };
+
+    static getUserInputFromProps(props: Props): UserInput {
+        return {
+            currentValue: props.currentValue,
+        };
+    }
+
+    static getOneCorrectAnswerFromRubric(
+        rubric: Rubric,
+    ): string | null | undefined {
+        const correctAnswers = rubric.answers.filter(
+            (answer) => answer.status === "correct",
+        );
+        const answerStrings = correctAnswers.map((answer) => {
+            // Figure out how this answer is supposed to be
+            // displayed
+            let format = "decimal";
+            if (answer.answerForms && answer.answerForms[0]) {
+                // NOTE(johnsullivan): This isn't exactly ideal, but
+                // it does behave well for all the currently known
+                // problems. See D14742 for some discussion on
+                // alternate strategies.
+                format = answer.answerForms[0];
+            }
+
+            // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'string' is not assignable to parameter of type 'MathFormat | undefined'.
+            let answerString = KhanMath.toNumericString(answer.value, format);
+            if (answer.maxError) {
+                answerString +=
+                    " \u00B1 " +
+                    // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'string' is not assignable to parameter of type 'MathFormat | undefined'.
+                    KhanMath.toNumericString(answer.maxError, format);
+            }
+            return answerString;
+        });
+        if (answerStrings.length === 0) {
+            return;
+        }
+        return answerStrings[0];
+    }
+
+    static validate(useInput: UserInput, rubric: Rubric): PerseusScore {
+        const allAnswerForms = answerFormButtons.map((e) => e["value"]);
+
+        const createValidator = (answer: PerseusNumericInputAnswer) => {
+            const stringAnswer = `${answer.value}`;
+            return KhanAnswerTypes.number.createValidatorFunctional(
+                stringAnswer,
+                {
+                    message: answer.message,
+                    simplify:
+                        answer.status === "correct"
+                            ? answer.simplify
+                            : "optional",
+                    inexact: true, // TODO(merlob) backfill / delete
+                    maxError: answer.maxError,
+                    forms:
+                        answer.strict &&
+                        answer.answerForms &&
+                        answer.answerForms.length !== 0
+                            ? answer.answerForms
+                            : allAnswerForms,
+                },
+            );
+        };
+
+        // We may have received TeX; try to parse it before grading.
+        // If `currentValue` is not TeX, this should be a no-op.
+        const currentValue = ParseTex(useInput.currentValue);
+        const correctAnswers = rubric.answers.filter(
+            (answer) => answer.status === "correct",
+        );
+
+        const normalizedAnswerExpected = correctAnswers.every(
+            (answer) => Math.abs(answer.value) <= 1,
+        );
+
+        // Look through all correct answers for one that matches either
+        // precisely or approximately and return the appropriate message:
+        // - if precise, return the message that the answer came with
+        // - if it needs to be simplified, etc., show that message
+        let result = correctAnswers
+            .map((answer) => {
+                // The coefficient is an attribute of the widget
+                let localValue = currentValue;
+                if (rubric.coefficient) {
+                    if (!localValue) {
+                        // @ts-expect-error [FEI-5003] - TS2322 - Type 'number' is not assignable to type 'string'.
+                        localValue = 1;
+                    } else if (localValue === "-") {
+                        // @ts-expect-error [FEI-5003] - TS2322 - Type 'number' is not assignable to type 'string'.
+                        localValue = -1;
+                    }
+                }
+                const validate = createValidator(answer);
+                return validate(
+                    maybeParsePercentInput(
+                        localValue,
+                        normalizedAnswerExpected,
+                    ),
+                );
+            })
+            .find((match) => match.correct || match.empty);
+
+        if (!result) {
+            // Otherwise, if the guess is not correct
+            const otherAnswers = [].concat(
+                // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+                rubric.answers.filter((answer) => answer.status === "ungraded"),
+                rubric.answers.filter((answer) => answer.status === "wrong"),
+            );
+
+            // Look through all other answers and if one matches either
+            // precisely or approximately return the answer's message
+            const match = otherAnswers.find((answer) => {
+                const validate = createValidator(answer);
+                return validate(
+                    maybeParsePercentInput(
+                        currentValue,
+                        normalizedAnswerExpected,
+                    ),
+                ).correct;
+            });
+            result = {
+                // @ts-expect-error [FEI-5003] - TS2339 - Property 'status' does not exist on type 'never'.
+                empty: match ? match.status === "ungraded" : false,
+                // @ts-expect-error [FEI-5003] - TS2339 - Property 'status' does not exist on type 'never'.
+                correct: match ? match.status === "correct" : false,
+                // @ts-expect-error [FEI-5003] - TS2339 - Property 'message' does not exist on type 'never'.
+                message: match ? match.message : null,
+                guess: currentValue,
+            };
+        }
+
+        // TODO(eater): Seems silly to translate result to this
+        // invalid/points thing and immediately translate it
+        // back in ItemRenderer.scoreInput()
+        if (result.empty) {
+            return {
+                type: "invalid",
+                message: result.message,
+            };
+        }
+        return {
+            type: "points",
+            earned: result.correct ? 1 : 0,
+            total: 1,
+            message: result.message,
+        };
+    }
+
+    state: State = {
+        // keeps track of the other set of values when switching
+        // between 0 and finite solutions
+        previousValues: [""],
+    };
+
+    // TODO(Nicole, Jeremy): This is maybe never used and should be removed
+    examples: () => ReadonlyArray<string> = () => {
+        // if the set of specified forms are empty, allow all forms
+        const forms =
+            this.props.answerForms?.length !== 0
+                ? this.props.answerForms
+                : Object.keys(formExamples).map((name) => {
+                      return {
+                          name: name,
+                          simplify: "required",
+                      };
+                  });
+
+        let examples = _.map(forms, (form) => {
+            // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'PerseusNumericInputAnswerForm | { name: string; simplify: string; }' is not assignable to parameter of type 'PerseusNumericInputAnswerForm'.
+            return formExamples[form.name](form);
+        });
+        // Ensure no duplicate tooltip text from simplified and unsimplified
+        // versions of the same format
+        examples = _.uniq(examples);
+
+        return [i18n._("**Your answer should be** ")].concat(examples);
+    };
+
+    shouldShowExamples: () => boolean = () => {
+        const noFormsAccepted = this.props.answerForms?.length === 0;
+        // To check if all answer forms are accepted, we must first
+        // find the *names* of all accepted forms, and see if they are
+        // all present, ignoring duplicates
+        const answerFormNames: ReadonlyArray<string> = _.uniq(
+            this.props.answerForms?.map((form) => form.name),
+        );
+        const allFormsAccepted =
+            answerFormNames.length >= Object.keys(formExamples).length;
+        return !noFormsAccepted && !allFormsAccepted;
+    };
+
+    simpleValidate: (arg1: Rubric) => PerseusScore = (rubric) => {
+        return NumericInput.validate(this.getUserInput(), rubric);
+    };
+
+    focus: () => boolean = () => {
+        this.inputRef?.focus();
+        return true;
+    };
+
+    focusInputPath: () => void = () => {
+        this.inputRef?.focus();
+    };
+
+    blurInputPath: () => void = () => {
+        this.inputRef?.blur();
+    };
+
+    getInputPaths: () => ReadonlyArray<ReadonlyArray<string>> = () => {
+        // The widget itself is an input, so we return a single empty list to
+        // indicate this.
+        /* c8 ignore next */
+        return [[]];
+    };
+
+    getGrammarTypeForPath: (arg1: FocusPath) => string = (inputPath) => {
+        /* c8 ignore next */
+        return "number";
+    };
+
+    setInputValue: (
+        arg1: FocusPath,
+        arg2: string,
+        arg3?: () => unknown | null | undefined,
+    ) => void = (path, newValue, cb) => {
+        /* c8 ignore next */
+        this.props.onChange(
+            {
+                currentValue: newValue,
+            },
+            cb,
+        );
+    };
+
+    getUserInput: () => UserInput = () => {
+        return NumericInput.getUserInputFromProps(this.props);
+    };
+
+    handleChange: (
+        arg1: string,
+        arg2?: () => unknown | null | undefined,
+    ) => void = (newValue, cb) => {
+        this.props.onChange({currentValue: newValue}, cb);
+        this.props.trackInteraction();
+    };
+
+    _handleFocus: () => void = () => {
+        this.props.onFocus([]);
+        // HACK(kevinb): We want to dismiss the feedback popover that webapp
+        // displays as soon as a user clicks in in the input field so we call
+        // interactionCallback directly.
+        const {interactionCallback} = this.props.apiOptions;
+        if (interactionCallback) {
+            interactionCallback();
+        }
+    };
+
+    _handleBlur: () => void = () => {
+        this.props.onBlur([]);
+    };
+
+    render(): React.ReactNode {
+        let labelText = this.props.labelText;
+        if (labelText == null || labelText === "") {
+            labelText = i18n._("Your answer:");
+        }
+
+        // To right align a custom keypad we need to wrap it.
+        const maybeRightAlignKeypadInput = (
+            keypadInput: React.ReactElement<
+                React.ComponentProps<typeof SimpleKeypadInput>
+            >,
+        ) => {
+            return this.props.rightAlign ? (
+                <div className="perseus-input-right-align">{keypadInput}</div>
+            ) : (
+                keypadInput
+            );
+        };
+
+        if (this.props.apiOptions.customKeypad) {
+            // TODO(charlie): Support "Review Mode".
+            return maybeRightAlignKeypadInput(
+                <SimpleKeypadInput
+                    ref={(ref) => (this.inputRef = ref)}
+                    value={this.props.currentValue}
+                    keypadElement={this.props.keypadElement}
+                    onChange={this.handleChange}
+                    onFocus={this._handleFocus}
+                    onBlur={this._handleBlur}
+                />,
+            );
+        }
+
+        // Note: This is _very_ similar to what `input-number.jsx` does. If
+        // you modify this, double-check if you also need to modify that
+        // component.
+        const styles = StyleSheet.create({
+            input: {
+                textAlign: this.props.rightAlign ? "right" : "left",
+                width: this.props.size === "small" ? 40 : 80,
+                padding: 0,
+                height: "auto",
+            },
+        });
+
+        return (
+            <div>
+                <InputWithExamples
+                    ref={(ref) => (this.inputRef = ref)}
+                    value={this.props.currentValue}
+                    onChange={this.handleChange}
+                    labelText={labelText}
+                    type="text"
+                    examples={this.examples()}
+                    shouldShowExamples={this.shouldShowExamples()}
+                    onFocus={this._handleFocus}
+                    onBlur={this._handleBlur}
+                    id={this.props.widgetId}
+                    disabled={this.props.apiOptions.readOnly}
+                    style={styles.input}
+                />
+            </div>
+        );
+    }
+}
+
+// TODO(thomas): Currently we receive a list of lists of acceptable answer types
+// and union them down into a single set. It's worth considering whether it
+// wouldn't make more sense to have a single set of acceptable answer types for
+// a given *problem* rather than for each possible [correct/wrong] *answer*.
+// When should two answers to a problem take different answer types?
+// See D27790 for more discussion.
+export const unionAnswerForms: (
+    arg1: ReadonlyArray<ReadonlyArray<PerseusNumericInputAnswerForm>>,
+) => ReadonlyArray<PerseusNumericInputAnswerForm> = function (answerFormsList) {
+    // Takes a list of lists of answer forms, and returns a list of the forms
+    // in each of these lists in the same order that they're listed in the
+    // `formExamples` forms from above.
+
+    // uniqueBy takes a list of elements and a function which compares whether
+    // two elements are equal, and returns a list of unique elements. This is
+    // just a helper function here, but works generally.
+    const uniqueBy = function (list, iteratee: any) {
+        // @ts-expect-error [FEI-5003] - TS2347 - Untyped function calls may not accept type arguments.
+        return list.reduce<Array<any>>((uniqueList, element) => {
+            // For each element, decide whether it's already in the list of
+            // unique items.
+            const inList = _.find(uniqueList, iteratee.bind(null, element));
+            if (inList) {
+                return uniqueList;
+            }
+            return uniqueList.concat([element]);
+        }, []);
+    };
+
+    // Pull out all of the forms from the different lists.
+    const allForms = answerFormsList.flat();
+    // Pull out the unique forms using uniqueBy.
+    const uniqueForms = uniqueBy(allForms, _.isEqual);
+    // Sort them by the order they appear in the `formExamples` list.
+    const formExampleKeys = Object.keys(formExamples);
+    return _.sortBy(uniqueForms, (form) => {
+        return formExampleKeys.indexOf(form.name);
+    });
+};
+
+type RenderProps = {
+    answerForms: ReadonlyArray<{
+        simplify: "required" | "correct" | "enforced" | null | undefined;
+        name: "integer" | "decimal" | "proper" | "improper" | "mixed" | "pi";
+    }>;
+    labelText: string;
+    size: "normal" | "small";
+    coefficient: boolean;
+    rightAlign?: boolean;
+    static: boolean;
+};
+
+// This function checks if the user inputted a percent value, parsing
+// it as a number (and maybe scaling) so that it can be graded.
+// NOTE(michaelpolyak): Unlike `KhanAnswerTypes.number.percent()` which
+// can accept several input forms with or without "%", the decision
+// to parse based on the presence of "%" in the input, is so that we
+// don't accidently scale the user typed value before grading, CP-930.
+export function maybeParsePercentInput(
+    inputValue: string | number,
+    normalizedAnswerExpected: boolean,
+): string | number {
+    // If the input value is not a string ending with "%", then there's
+    // nothing more to do. The value will be graded as inputted by user.
+    if (!(typeof inputValue === "string" && inputValue.endsWith("%"))) {
+        return inputValue;
+    }
+
+    const value = parseFloat(inputValue.slice(0, -1));
+    // If the input value stripped of the "%" cannot be parsed as a
+    // number (the slice is not really necessary for parseFloat to work
+    // if the string starts with a number) then return the original
+    // input for grading.
+    if (isNaN(value)) {
+        return inputValue;
+    }
+
+    // Next, if all correct answers are in the range of |0,1| then we
+    // scale the user typed value. We assume this is the correct thing
+    // to do since the input value ends with "%".
+    if (normalizedAnswerExpected) {
+        return value / 100;
+    }
+
+    // Otherwise, we return input valuåe (number) stripped of the "%".
+    return value;
+}
+
+const propsTransform = function (
+    widgetOptions: PerseusNumericInputWidgetOptions,
+): RenderProps {
+    const rendererProps = _.extend(_.omit(widgetOptions, "answers"), {
+        answerForms: unionAnswerForms(
+            // Pull out the name of each form and whether that form has
+            // required simplification.
+            widgetOptions.answers.map((answer) => {
+                // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'readonly MathFormat[] | undefined' is not assignable to parameter of type 'Collection<any>'.
+                return _.map(answer.answerForms, (form) => {
+                    return {
+                        simplify: answer.simplify,
+                        name: form,
+                    };
+                });
+            }),
+        ),
+    });
+
+    return rendererProps;
+};
+
+export default {
+    name: "numeric-input",
+    displayName: "Number text box",
+    defaultAlignment: "inline-block",
+    accessible: true,
+    widget: NumericInput,
+    transform: propsTransform,
+    isLintable: true,
+} as WidgetExports<typeof NumericInput>;