@khanacademy/perseus 2.0.1 → 3.0.0

package/src/widgets/unit.jsx

@@ -1,5 +1,4 @@
 // @flow
-/* eslint-disable react/sort-comp */
 // TODO(joel): teach KAS how to accept an answer only if it's expressed in
 // terms of a certain type.
 // TODO(joel): Allow sigfigs within a range rather than an exact expected
@@ -13,7 +12,6 @@ import * as React from "react";
 import ReactDOM from "react-dom";
 import _ from "underscore";
 
-import MathOutput from "../components/math-output.jsx";
 import * as Changeable from "../mixins/changeable.jsx";
 import {ClassNames as ApiClassNames, ApiOptions} from "../perseus-api.jsx";
 import {SignificantFigures, displaySigFigs} from "../sigfigs.jsx";
@@ -177,37 +175,23 @@ export class OldUnitInput extends React.Component<Props> {
         };
     }
 
-    // TODO(joel) think about showing the error buddy
-    render(): React.Node {
-        const input = this.props.apiOptions.staticRender ? (
-            <MathOutput
-                onChange={this.handleChange}
-                ref="input" // eslint-disable-line react/no-string-refs
-                className={ApiClassNames.INTERACTIVE}
-                value={this.props.value}
-                onFocus={this.handleFocus}
-                onBlur={this.handleBlur}
-            />
-        ) : (
-            <input
-                onChange={this.handleChange}
-                ref="input" // eslint-disable-line react/no-string-refs
-                className={ApiClassNames.INTERACTIVE}
-                value={this.props.value}
-                onFocus={this.handleFocus}
-                onBlur={this.handleBlur}
-            />
-        );
+    componentDidUpdate() {
+        // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
+        // eslint-disable-next-line no-restricted-syntax
+        clearTimeout(this._errorTimeout);
+        if (KAS.unitParse(this.props.value).parsed) {
+            this._hideError();
+        } else {
+            // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
+            // eslint-disable-next-line no-restricted-syntax
+            this._errorTimeout = setTimeout(this._showError, 2000);
+        }
+    }
 
-        return (
-            <div className="old-unit-input">
-                {input}
-                {/* eslint-disable-next-line react/no-string-refs */}
-                <div ref="error" className="error" style={{display: "none"}}>
-                    {i18n._("I don't understand that")}
-                </div>
-            </div>
-        );
+    componentWillUnmount() {
+        // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
+        // eslint-disable-next-line no-restricted-syntax
+        clearTimeout(this._errorTimeout);
     }
 
     _showError: () => void = () => {
@@ -240,25 +224,6 @@ export class OldUnitInput extends React.Component<Props> {
         return Changeable.change.apply(this, args);
     };
 
-    componentDidUpdate() {
-        // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
-        // eslint-disable-next-line no-restricted-syntax
-        clearTimeout(this._errorTimeout);
-        if (KAS.unitParse(this.props.value).parsed) {
-            this._hideError();
-        } else {
-            // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
-            // eslint-disable-next-line no-restricted-syntax
-            this._errorTimeout = setTimeout(this._showError, 2000);
-        }
-    }
-
-    componentWillUnmount() {
-        // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
-        // eslint-disable-next-line no-restricted-syntax
-        clearTimeout(this._errorTimeout);
-    }
-
     handleBlur: () => void = () => {
         this.props.onBlur([]);
         // TODO(jeff, CP-3128): Use Wonder Blocks Timing API.
@@ -353,6 +318,26 @@ export class OldUnitInput extends React.Component<Props> {
     };
 
     // end mobile stuff
+
+    // TODO(joel) think about showing the error buddy
+    render(): React.Node {
+        return (
+            <div className="old-unit-input">
+                <input
+                    onChange={this.handleChange}
+                    ref="input" // eslint-disable-line react/no-string-refs
+                    className={ApiClassNames.INTERACTIVE}
+                    value={this.props.value}
+                    onFocus={this.handleFocus}
+                    onBlur={this.handleBlur}
+                />
+                {/* eslint-disable-next-line react/no-string-refs */}
+                <div ref="error" className="error" style={{display: "none"}}>
+                    {i18n._("I don't understand that")}
+                </div>
+            </div>
+        );
+    }
 }
 
 // Extract the primitive units from a unit expression. This first simplifies

package/src/widgets/__tests__/__snapshots__/expression_test.jsx.snap

@@ -1,38 +0,0 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
-
-exports[`rendering static renders: static render 1`] = `
-<div>
-  <span
-    class="mock-KatexProvider"
-  >
-    <div
-      class="perseus-renderer perseus-renderer-responsive"
-    >
-      <div
-        class="paragraph"
-        data-perseus-paragraph-index="0"
-      >
-        <div
-          class="paragraph"
-        >
-          <div
-            class="perseus-widget-container widget-nohighlight widget-inline-block"
-          >
-            <span
-              class="math-output perseus-input perseus-interactive"
-            >
-              <div
-                style="text-align: center;"
-              >
-                <span
-                  class="mock-TeX"
-                />
-              </div>
-            </span>
-          </div>
-        </div>
-      </div>
-    </div>
-  </span>
-</div>
-`;