@khanacademy/perseus 19.1.2 → 19.1.4

package/src/util/graphie.ts

@@ -121,13 +121,15 @@ export class Graphie {
     }
 
     init(options: {
-        range?: [Interval, Interval];
+        range: [Interval, Interval];
         scale?: number | Coord;
         isMobile?: boolean;
     }) {
         let scale = options.scale || [40, 40];
         scale = typeof scale === "number" ? [scale, scale] : scale;
 
+        // TODO(jeremy): This can be removed once we're confident that callers
+        // obey the Typescript types.
         if (options.range == null) {
             throw new PerseusError(
                 "range should be specified in graph init",

package/src/widgets/__tests__/__snapshots__/input-number.test.ts.snap

@@ -182,7 +182,7 @@ exports[`rendering supports mobile rendering: mobile render 1`] = `
                   class="mq-textarea"
                 >
                   <span
-                    aria-label="Math Input:"
+                    aria-label="Math input box:"
                   />
                 </span>
                 <span

package/src/widgets/__tests__/__snapshots__/numeric-input.test.ts.snap

@@ -44,7 +44,7 @@ exports[`Numeric input widget styles differently on mobile: mobile render 1`] =
                   class="mq-textarea"
                 >
                   <span
-                    aria-label="Math Input:"
+                    aria-label="Math input box:"
                   />
                 </span>
                 <span

package/src/widgets/label-image/marker.tsx

@@ -7,6 +7,7 @@
 
 import Color from "@khanacademy/wonder-blocks-color";
 import {View, type StyleType} from "@khanacademy/wonder-blocks-core";
+import * as i18n from "@khanacademy/wonder-blocks-i18n";
 import {StyleSheet} from "aphrodite";
 import * as React from "react";
 
@@ -127,6 +128,7 @@ export default class Marker extends React.Component<Props> {
             answerStyles,
             hovered,
             focused,
+            label,
         } = this.props;
 
         // We cannot make dropdown openers untabbable, so we isolate tabbing
@@ -141,6 +143,8 @@ export default class Marker extends React.Component<Props> {
                         styles.marker,
                         active && !markerDisabled && styles.markerActive,
                     ]}
+                    // already translated in: /widgets/graded-group.tsx
+                    aria-label={markerDisabled ? i18n._("Correct!") : label}
                 >
                     {this.renderIcon()}
                 </View>

package/src/widgets/label-image.tsx

@@ -598,16 +598,11 @@ export class LabelImage extends React.Component<
                         }
                         // cannot change answer choices once question is answered
                         disabled={disabled}
-                        opener={({opened, text}) => (
+                        opener={({opened}) => (
                             <Clickable
                                 role="button"
+                                aria-expanded={opened}
                                 key={`marker-${marker.x}.${marker.y}`}
-                                aria-label={
-                                    // already translated in: /widgets/graded-group.tsx
-                                    showCorrectness === "correct"
-                                        ? i18n._("Correct!")
-                                        : marker.label
-                                }
                             >
                                 {({hovered, focused, pressed}) => (
                                     <Marker

package/src/widgets.ts

@@ -170,7 +170,10 @@ export const upgradeWidgetInfoToLatestVersion = (
     oldWidgetInfo: PerseusWidget,
 ): PerseusWidget => {
     const type = oldWidgetInfo.type;
-    // TODO(LP-10707): Remove unnecessary type checking (`type` is a string)
+    // NOTE(jeremy): This looks like it could be replaced by fixing types so
+    // that `type` is non-optional. But we're seeing this in Sentry today so I
+    // suspect we have legacy data (potentially unpublished) and we should
+    // figure that out before depending solely on types.
     if (!_.isString(type)) {
         throw new PerseusError(
             "widget type must be a string, but was: " + type,